Skip to contentSkip to conversation

mm-show_mem-dump-the-status-of-the-mem-alloc-profiling-before-printing.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Sep 21, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/show_mem: dump the status of the mem alloc profiling before printing
has been removed from the -mm tree. Its filename was
mm-show_mem-dump-the-status-of-the-mem-alloc-profiling-before-printing.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Yueyang Pan <[email protected]>
Subject: mm/show_mem: dump the status of the mem alloc profiling before printing
Date: Wed, 3 Sep 2025 04:16:13 -0700

This patchset fixes two issues we saw in production rollout.

The first issue is that we saw all zero output of memory allocation profiling information from show_mem() if CONFIG_MEM_ALLOC_PROFILING is set and sysctl.vm.mem_profiling=0. This cause ambiguity as we don't know what 0B actually means in the output. It can mean either memory allocation profiling is temporary disabled or the allocation at that position is actually 0. Such ambiguity will make further parsing harder as we cannot differentiate between two case.

The second issue is that multiple entities can call show_mem() which messed up the allocation info in dmesg. We saw outputs like this:

    327 MiB    83635 mm/compaction.c:1880 func:compaction_alloc
   48.4 GiB 12684937 mm/memory.c:1061 func:folio_prealloc
   7.48 GiB    10899 mm/huge_memory.c:1159 func:vma_alloc_anon_folio_pmd
    298 MiB    95216 kernel/fork.c:318 func:alloc_thread_stack_node
    250 MiB    63901 mm/zsmalloc.c:987 func:alloc_zspage
    1.42 GiB   372527 mm/memory.c:1063 func:folio_prealloc
    1.17 GiB    95693 mm/slub.c:2424 func:alloc_slab_page
     651 MiB   166732 mm/readahead.c:270 func:page_cache_ra_unbounded
     419 MiB   107261 net/core/page_pool.c:572 func:__page_pool_alloc_pages_slow
     404 MiB   103425 arch/x86/mm/pgtable.c:25 func:pte_alloc_one

The above example is because one kthread invokes show_mem() from __alloc_pages_slowpath while kernel itself calls oom_kill_process()

This patch (of 2):

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

---

 mm/show_mem.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/show_mem.c renamed from mm/show_mem.c~mm-show_mem-dump-the-status-of-the-mem-alloc-profiling-before-printing +2 -1
@@ -431,7 +431,8 @@ void __show_mem(unsigned int filter, nod
 
 		nr = alloc_tag_top_users(tags, ARRAY_SIZE(tags), false);
 		if (nr) {
-			pr_notice("Memory allocations:\n");
+			pr_notice("Memory allocations (profiling is currently turned %s):\n",
+				mem_alloc_profiling_enabled() ? "on" : "off");
 			for (i = 0; i < nr; i++) {
 				struct codetag *ct = tags[i].ct;
 				struct alloc_tag *tag = ct_to_alloc_tag(ct);

_

Patches currently in -mm which might be from [email protected] are