mm/show_mem: Bug fix for print mem alloc info
Subsystems (2)
v3 cover mm/show_mem: Bug fix for print mem alloc info
This patch set fixes two issues we saw in production rollout.
The first issue is that we saw all zero output of memory allocation profiling information from show_mem() if CONFIG_MEM_ALLOC_PROFILING is set and sysctl.vm.mem_profiling=0. This cause ambiguity as we don't know what 0B actually means in the output. It can mean either memory allocation profiling is temporary disabled or the allocation at that position is actually 0. Such ambiguity will make further parsing harder as we cannot differentiate between two case.
The second issue is that multiple entities can call show_mem() which messed up the allocation info in dmesg. We saw outputs like this:
```
327 MiB 83635 mm/compaction.c:1880 func:compaction_alloc
48.4 GiB 12684937 mm/memory.c:1061 func:folio_prealloc
7.48 GiB 10899 mm/huge_memory.c:1159 func:vma_alloc_anon_folio_pmd
298 MiB 95216 kernel/fork.c:318 func:alloc_thread_stack_node
250 MiB 63901 mm/zsmalloc.c:987 func:alloc_zspage
1.42 GiB 372527 mm/memory.c:1063 func:folio_prealloc
1.17 GiB 95693 mm/slub.c:2424 func:alloc_slab_page
651 MiB 166732 mm/readahead.c:270 func:page_cache_ra_unbounded
419 MiB 107261 net/core/page_pool.c:572 func:__page_pool_alloc_pages_slow
404 MiB 103425 arch/x86/mm/pgtable.c:25 func:pte_alloc_one
```The above example is because one kthread invokes show_mem() from __alloc_pages_slowpath while kernel itself calls oom_kill_process()
Revision History
=================
Changes from v2 [2]
- Merge status dump with "Memory allocations:" starting line
- Move the definition of spinlock within ifdef
Changes from v1 [1]
- Dump status of memory allocation profiling instead of disabling the output following Vishal's advise.
- Move lock from file scope to within __show_mem() and replace mutex with spinlock following Andrew, Vlastimil and Shakeel's advice.
[1] https://lore.kernel.org/linux-mm/[email protected]/
[2] https://lore.kernel.org/linux-mm/[email protected]/
Yueyang Pan (2):
mm/show_mem: Dump the status of the mem alloc profiling before
printing
mm/show_mem: Add trylock while printing alloc info
mm/show_mem.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Signature · 1 line
2.47.3
PATCH v3 1/2 mm/show_mem: Dump the status of the mem alloc profiling before printing
This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.
--- mm/show_mem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
mm/show_mem.c +2 -1
@@ -427,7 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) nr =alloc_tag_top_users (tags,ARRAY_SIZE (tags), false);if (nr) { -pr_notice ("Memory allocations:\n" ); +pr_notice ("Memory allocations (profiling is currently turned %s):\n" , +mem_alloc_profiling_enabled () ?"on" :"off" );for (i =0 ; i < nr; i++) {struct codetag *ct = tags[i].ct;struct alloc_tag *tag =ct_to_alloc_tag (ct);
Signature · 1 line
2.47.3
Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing
Quoted 7 lines · Yueyang Pan
This patch prints the status of the memory allocation profiling before
__show_memactually prints the detailed allocation info. This way will let us know the0Bwe saw in allocation info is because the profiling is disabled or the allocation is actually 0B.Signed-off-by Yueyang Pan <[email protected]>
Quoted 18 lines
--- mm/show_mem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)mm/show_mem.c +2
-1@@ -427,7 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) nr =alloc_tag_top_users (tags,ARRAY_SIZE (tags), false);if (nr) { -pr_notice ("Memory allocations:\n" ); +pr_notice ("Memory allocations (profiling is currently turned %s):\n" , +mem_alloc_profiling_enabled () ?"on" :"off" );for (i =0 ; i < nr; i++) {struct codetag *ct = tags[i].ct;struct alloc_tag *tag =ct_to_alloc_tag (ct);
Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing
In reply to Yueyang PanQuoted 7 lines · Yueyang Pan
This patch prints the status of the memory allocation profiling before
__show_memactually prints the detailed allocation info. This way will let us know the0Bwe saw in allocation info is because the profiling is disabled or the allocation is actually 0B.Signed-off-by Yueyang Pan <[email protected]>
Quoted 18 lines
--- mm/show_mem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)mm/show_mem.c +2
-1@@ -427,7 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) nr =alloc_tag_top_users (tags,ARRAY_SIZE (tags), false);if (nr) { -pr_notice ("Memory allocations:\n" ); +pr_notice ("Memory allocations (profiling is currently turned %s):\n" , +mem_alloc_profiling_enabled () ?"on" :"off" );for (i =0 ; i < nr; i++) {struct codetag *ct = tags[i].ct;struct alloc_tag *tag =ct_to_alloc_tag (ct);
Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing
In reply to Yueyang PanQuoted 11 lines · Yueyang Pan
This patch prints the status of the memory allocation profiling before
__show_memactually prints the detailed allocation info. This way will let us know the0Bwe saw in allocation info is because the profiling is disabled or the allocation is actually 0B.Signed-off-by Yueyang Pan <[email protected]>--- mm/show_mem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Best Regards,
Yan, Zi
Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing
Quoted 9 lines · Zi Yan
Quoted 6 lines · Yueyang Pan
This patch prints the status of the memory allocation profiling before
__show_memactually prints the detailed allocation info. This way will let us know the0Bwe saw in allocation info is because the profiling is disabled or the allocation is actually 0B.
Quoted 6 lines
Quoted 5 lines
Signed-off-by Yueyang Pan <[email protected]>--- mm/show_mem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Acked-by Zi Yan <[email protected]>
Quoted 3 lines
Best Regards,
Yan, Zi
Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing
In reply to Yueyang PanQuoted 7 lines · Yueyang Pan
This patch prints the status of the memory allocation profiling before
__show_memactually prints the detailed allocation info. This way will let us know the0Bwe saw in allocation info is because the profiling is disabled or the allocation is actually 0B.Signed-off-by Yueyang Pan <[email protected]>
Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing
In reply to Yueyang PanQuoted 7 lines · Yueyang Pan
This patch prints the status of the memory allocation profiling before
__show_memactually prints the detailed allocation info. This way will let us know the0Bwe saw in allocation info is because the profiling is disabled or the allocation is actually 0B.Signed-off-by Yueyang Pan <[email protected]>
PATCH v3 2/2 mm/show_mem: Add trylock while printing alloc info
In reply to Yueyang PanIn production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.
--- mm/show_mem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
mm/show_mem.c +4 -1
@@ -421,7 +421,9 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)printk ("%lu pages hwpoisoned\n" ,atomic_long_read (&num_poisoned_pages));#endif #ifdef CONFIG_MEM_ALLOC_PROFILING - { +static DEFINE_SPINLOCK (mem_alloc_profiling_spinlock); + +if (spin_trylock (&mem_alloc_profiling_spinlock)) {struct codetag_bytes tags[10 ];size_t i, nr;
@@ -448,6 +450,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) ct->lineno, ct->function); } } +spin_unlock (&mem_alloc_profiling_spinlock); }#endif }
Signature · 1 line
2.47.3
Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info
Quoted 8 lines · Yueyang Pan
In production,
show_mem()can be called concurrently from two different entities, for example one fromoom_kill_process()another from__alloc_pages_slowpathfrom another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info inshow_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.Signed-off-by Yueyang Pan <[email protected]>
Quoted 27 lines
--- mm/show_mem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)mm/show_mem.c +4
-1@@ -421,7 +421,9 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)printk ("%lu pages hwpoisoned\n" ,atomic_long_read (&num_poisoned_pages));#endif #ifdef CONFIG_MEM_ALLOC_PROFILING - { +static DEFINE_SPINLOCK (mem_alloc_profiling_spinlock); + +if (spin_trylock (&mem_alloc_profiling_spinlock)) {struct codetag_bytes tags[10 ];size_t i, nr;@@ -448,6 +450,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) ct->lineno, ct->function); } } +spin_unlock (&mem_alloc_profiling_spinlock); }#endif }
Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info
In reply to Yueyang PanQuoted 8 lines · Yueyang Pan
In production,
show_mem()can be called concurrently from two different entities, for example one fromoom_kill_process()another from__alloc_pages_slowpathfrom another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info inshow_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.Signed-off-by Yueyang Pan <[email protected]>
Quoted 27 lines
--- mm/show_mem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)mm/show_mem.c +4
-1@@ -421,7 +421,9 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)printk ("%lu pages hwpoisoned\n" ,atomic_long_read (&num_poisoned_pages));#endif #ifdef CONFIG_MEM_ALLOC_PROFILING - { +static DEFINE_SPINLOCK (mem_alloc_profiling_spinlock); + +if (spin_trylock (&mem_alloc_profiling_spinlock)) {struct codetag_bytes tags[10 ];size_t i, nr;@@ -448,6 +450,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) ct->lineno, ct->function); } } +spin_unlock (&mem_alloc_profiling_spinlock); }#endif }
Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info
In reply to Yueyang PanQuoted 7 lines · Yueyang Pan
In production,
show_mem()can be called concurrently from two different entities, for example one fromoom_kill_process()another from__alloc_pages_slowpathfrom another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info inshow_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.
Quoted 5 lines
Signed-off-by Yueyang Pan <[email protected]>--- mm/show_mem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Best Regards,
Yan, Zi
Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info
Quoted 10 lines · Zi Yan
Quoted 7 lines · Yueyang Pan
In production,
show_mem()can be called concurrently from two different entities, for example one fromoom_kill_process()another from__alloc_pages_slowpathfrom another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info inshow_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Yueyang Pan <[email protected]>--- mm/show_mem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Acked-by Zi Yan <[email protected]>
Quoted 3 lines
Best Regards,
Yan, Zi
Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info
In reply to Yueyang PanQuoted 8 lines · Yueyang Pan
In production,
show_mem()can be called concurrently from two different entities, for example one fromoom_kill_process()another from__alloc_pages_slowpathfrom another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info inshow_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.Signed-off-by Yueyang Pan <[email protected]>