Skip to contentSkip to conversation

mm/show_mem: Bug fix for print mem alloc info

PATCH Applied Yueyang Pan 7 participants 14 messages Sep 3, 2025 – Sep 4, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover mm/show_mem: Bug fix for print mem alloc info

This patch set fixes two issues we saw in production rollout.

The first issue is that we saw all zero output of memory allocation profiling information from show_mem() if CONFIG_MEM_ALLOC_PROFILING is set and sysctl.vm.mem_profiling=0. This cause ambiguity as we don't know what 0B actually means in the output. It can mean either memory allocation profiling is temporary disabled or the allocation at that position is actually 0. Such ambiguity will make further parsing harder as we cannot differentiate between two case.

The second issue is that multiple entities can call show_mem() which messed up the allocation info in dmesg. We saw outputs like this:

```
    327 MiB    83635 mm/compaction.c:1880 func:compaction_alloc
   48.4 GiB 12684937 mm/memory.c:1061 func:folio_prealloc
   7.48 GiB    10899 mm/huge_memory.c:1159 func:vma_alloc_anon_folio_pmd
    298 MiB    95216 kernel/fork.c:318 func:alloc_thread_stack_node
    250 MiB    63901 mm/zsmalloc.c:987 func:alloc_zspage
    1.42 GiB   372527 mm/memory.c:1063 func:folio_prealloc
    1.17 GiB    95693 mm/slub.c:2424 func:alloc_slab_page
     651 MiB   166732 mm/readahead.c:270 func:page_cache_ra_unbounded
     419 MiB   107261 net/core/page_pool.c:572 func:__page_pool_alloc_pages_slow
     404 MiB   103425 arch/x86/mm/pgtable.c:25 func:pte_alloc_one
```

The above example is because one kthread invokes show_mem() from __alloc_pages_slowpath while kernel itself calls oom_kill_process()

Revision History
=================
Changes from v2 [2]
- Merge status dump with "Memory allocations:" starting line
- Move the definition of spinlock within ifdef

Changes from v1 [1]
- Dump status of memory allocation profiling instead of disabling the output following Vishal's advise.
- Move lock from file scope to within __show_mem() and replace mutex with spinlock following Andrew, Vlastimil and Shakeel's advice.

[1] https://lore.kernel.org/linux-mm/[email protected]/
[2] https://lore.kernel.org/linux-mm/[email protected]/

Yueyang Pan (2):
mm/show_mem: Dump the status of the mem alloc profiling before
printing
mm/show_mem: Add trylock while printing alloc info

 mm/show_mem.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Signature · 1 line
2.47.3
#1 lore raw

PATCH v3 1/2 mm/show_mem: Dump the status of the mem alloc profiling before printing

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

---
 mm/show_mem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/show_mem.c +2 -1
index ecf20a93ea54..fd85a028a926 100644
@@ -427,7 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 
 		nr = alloc_tag_top_users(tags, ARRAY_SIZE(tags), false);
 		if (nr) {
-			pr_notice("Memory allocations:\n");
+			pr_notice("Memory allocations (profiling is currently turned %s):\n",
+				mem_alloc_profiling_enabled() ? "on" : "off");
 			for (i = 0; i < nr; i++) {
 				struct codetag *ct = tags[i].ct;
 				struct alloc_tag *tag = ct_to_alloc_tag(ct);
Signature · 1 line
2.47.3
#8 lore raw

PATCH v3 2/2 mm/show_mem: Add trylock while printing alloc info

In reply to Yueyang Pan

In production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.

---
 mm/show_mem.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
mm/show_mem.c +4 -1
index fd85a028a926..e9701d07549b 100644
@@ -421,7 +421,9 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 	printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages));
 #endif
 #ifdef CONFIG_MEM_ALLOC_PROFILING
-	{
+	static DEFINE_SPINLOCK(mem_alloc_profiling_spinlock);
+
+	if (spin_trylock(&mem_alloc_profiling_spinlock)) {
 		struct codetag_bytes tags[10];
 		size_t i, nr;
 
@@ -448,6 +450,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 						  ct->lineno, ct->function);
 			}
 		}
+		spin_unlock(&mem_alloc_profiling_spinlock);
 	}
 #endif
 }
Signature · 1 line
2.47.3
Acked-by on v3 2/2
#9 lore raw

Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info

Quoted 8 lines · Yueyang Pan

In production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.

Quoted 27 lines
---
 mm/show_mem.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
mm/show_mem.c +4 -1
index fd85a028a926..e9701d07549b 100644
@@ -421,7 +421,9 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 	printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages));
 #endif
 #ifdef CONFIG_MEM_ALLOC_PROFILING
-	{
+	static DEFINE_SPINLOCK(mem_alloc_profiling_spinlock);
+
+	if (spin_trylock(&mem_alloc_profiling_spinlock)) {
 		struct codetag_bytes tags[10];
 		size_t i, nr;
 
@@ -448,6 +450,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 						  ct->lineno, ct->function);
 			}
 		}
+		spin_unlock(&mem_alloc_profiling_spinlock);
 	}
 #endif
 }
Acked-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing

In reply to Yueyang Pan
Quoted 7 lines · Yueyang Pan

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

Quoted 18 lines
---
 mm/show_mem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/show_mem.c +2 -1
index ecf20a93ea54..fd85a028a926 100644
@@ -427,7 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 
 		nr = alloc_tag_top_users(tags, ARRAY_SIZE(tags), false);
 		if (nr) {
-			pr_notice("Memory allocations:\n");
+			pr_notice("Memory allocations (profiling is currently turned %s):\n",
+				mem_alloc_profiling_enabled() ? "on" : "off");
 			for (i = 0; i < nr; i++) {
 				struct codetag *ct = tags[i].ct;
 				struct alloc_tag *tag = ct_to_alloc_tag(ct);
Acked-by on v3 1/2
#3 lore raw

Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing

In reply to Yueyang Pan
Quoted 7 lines · Yueyang Pan

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

Quoted 18 lines
---
 mm/show_mem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/show_mem.c +2 -1
index ecf20a93ea54..fd85a028a926 100644
@@ -427,7 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 
 		nr = alloc_tag_top_users(tags, ARRAY_SIZE(tags), false);
 		if (nr) {
-			pr_notice("Memory allocations:\n");
+			pr_notice("Memory allocations (profiling is currently turned %s):\n",
+				mem_alloc_profiling_enabled() ? "on" : "off");
 			for (i = 0; i < nr; i++) {
 				struct codetag *ct = tags[i].ct;
 				struct alloc_tag *tag = ct_to_alloc_tag(ct);
Acked-by on v3 2/2
#10 lore raw

Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info

In reply to Yueyang Pan
Quoted 8 lines · Yueyang Pan

In production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.

Quoted 27 lines
---
 mm/show_mem.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
mm/show_mem.c +4 -1
index fd85a028a926..e9701d07549b 100644
@@ -421,7 +421,9 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 	printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages));
 #endif
 #ifdef CONFIG_MEM_ALLOC_PROFILING
-	{
+	static DEFINE_SPINLOCK(mem_alloc_profiling_spinlock);
+
+	if (spin_trylock(&mem_alloc_profiling_spinlock)) {
 		struct codetag_bytes tags[10];
 		size_t i, nr;
 
@@ -448,6 +450,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 						  ct->lineno, ct->function);
 			}
 		}
+		spin_unlock(&mem_alloc_profiling_spinlock);
 	}
 #endif
 }
reviewer Acked-by on v3 1/2
#4 lore raw

Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing

In reply to Yueyang Pan
Quoted 11 lines · Yueyang Pan

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

---
 mm/show_mem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Best Regards,
Yan, Zi

reviewer Acked-by on v3 2/2
#11 lore raw

Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info

In reply to Yueyang Pan
Quoted 7 lines · Yueyang Pan

In production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.

Quoted 5 lines
---
 mm/show_mem.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Best Regards,
Yan, Zi

reviewer Acked-by
#5 lore raw

Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing

In reply to Zi Yan
Quoted 9 lines · Zi Yan
Quoted 6 lines · Yueyang Pan

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

Quoted 6 lines
Quoted 5 lines
---
 mm/show_mem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 3 lines

Best Regards,
Yan, Zi

reviewer Acked-by
#12 lore raw

Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info

In reply to Zi Yan
Quoted 10 lines · Zi Yan
Quoted 7 lines · Yueyang Pan

In production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.

Quoted 7 lines
Quoted 5 lines
---
 mm/show_mem.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 3 lines

Best Regards,
Yan, Zi

Reviewed-by on v3 1/2
#6 lore raw

Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing

In reply to Yueyang Pan
Quoted 7 lines · Yueyang Pan

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

Acked-by on v3 1/2
#7 lore raw

Re: [PATCH v3 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing

In reply to Yueyang Pan
Quoted 7 lines · Yueyang Pan

This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the 0B we saw in allocation info is because the profiling is disabled or the allocation is actually 0B.

Acked-by on v3 2/2
#13 lore raw

Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info

In reply to Yueyang Pan
Quoted 8 lines · Yueyang Pan

In production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier.