Skip to contentSkip to conversation

Allow configfs to disable specific GT type(s)

PATCH Superseded Matt Roper 5 participants 42 messages Sep 25, 2025 – Sep 30, 2025

Subsystems (4)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Matt Roper

author
#0 lore raw

v2 cover Allow configfs to disable specific GT type(s)

During various debug or hardware bring-up activities, it is often useful to completely disable one of the GTs to reduce the scope of the debug. Add a configfs attribute to make this easy to do in a standard manner, similar to the existing attribute we have to limit engines.

One of the changes in this series is that we reverse direction on the placement of a few feature flags. Previously we had moved things like number of page table levels, size of the virtual address space, or presence/absence of FlatCCS into the graphics descriptor to tie it to the general architecture (Xe2, Xe3, etc.). But upon further reflection, these kind of flags and values are truly platform-specific characteristics rather than being tied just to the graphics IP. The value of these winds up being platform-wide (as already evidenced by the fact that we copied their values into xe->info rather than gt->info) and all IP blocks in a hardware platform (graphics, media, and display) are going to have a consistent understanding of these characteristics; they're not just "graphics" values, and we need to be able to detect and handle them properly even when "graphics" (in the form of the primary GT) is absent. So this series moves some of those flags back into the platform-level descriptors and tries to keep the graphics descriptor's fields focused on values that are truly tied to the primary GT.

Note that at the moment it's only possible to disable the media GT. Although this series includes a number of patches aimed at reducing the driver's reliance on the primary GT and assumptions that the primary GT will always be present and non-NULL, we're not quite at the point where the driver can actually run with primary GT disabled. The main remaining blocker for that is the reliance on the BCS engines (which reside in the primary GT) for various VRAM and migration operations. Additional work after this series will be required to eliminate those dependencies.

v2:
- About 20 extra patches added to reduce dependencies on an always-present primary GT.
- Kerneldoc and string parsing fixes to the configfs attribute handling (Gustavo)

Cc Gustavo Sousa <[email protected]>

Matt Roper (22):
drm/xe/huc: Adjust HuC check on primary GT
drm/xe: Drop GT parameter to xe_display_irq_postinstall() drm/xe: Move 'va_bits' flag back to platform descriptor drm/xe: Move 'vm_max_level' flag back to platform descriptor drm/xe: Move 'vram_flags' flag back to platform descriptor drm/xe: Move 'has_flatccs' flag back to platform descriptor drm/xe: Move primary GT allocation from xe_tile_init_early to
xe_tile_init
drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled drm/xe/query: Report hwconfig size as 0 if primary GT is disabled drm/xe/pmu: Initialize PMU event types based on first available GT drm/xe: Check for primary GT before looking up Wa_22019338487 drm/xe: Make display part of Wa_22019338487 a device workaround drm/xe/irq: Don't try to lookup engine masks for non-existent primary
GT
drm/xe: Handle Wa_22010954014 and Wa_14022085890 as device workarounds drm/xe/rtp: Pass xe_device parameter to FUNC matches drm/xe: Bypass Wa_14018094691 when primary GT is disabled drm/xe: Correct lineage for Wa_22014953428 and only check with valid
GT
drm/xe: Check that GT is not NULL before testing Wa_16023588340 drm/xe: Don't check BIOS-disabled FlatCCS if primary GT is disabled drm/xe: Break GT setup out of xe_info_init() drm/xe/configfs: Add attribute to disable GT types drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfs

 drivers/gpu/drm/xe/display/intel_fbdev_fb.c   |   4 +-
 drivers/gpu/drm/xe/display/xe_display.c       |   5 +-
 drivers/gpu/drm/xe/display/xe_display.h       |   4 +-
 drivers/gpu/drm/xe/display/xe_display_wa.c    |   3 +-
 drivers/gpu/drm/xe/display/xe_plane_initial.c |   4 +-
 drivers/gpu/drm/xe/tests/xe_rtp_test.c        |   6 +-
 drivers/gpu/drm/xe/xe_configfs.c              | 130 +++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h              |   2 +
 drivers/gpu/drm/xe/xe_device.c                |  11 +-
 drivers/gpu/drm/xe/xe_device_wa_oob.rules     |   3 +
 drivers/gpu/drm/xe/xe_ggtt.c                  |  26 ++-
 drivers/gpu/drm/xe/xe_gsc.c                   |   4 +-
 drivers/gpu/drm/xe/xe_guc_pc.c                |   3 +-
 drivers/gpu/drm/xe/xe_huc.c                   |  10 +-
 drivers/gpu/drm/xe/xe_hw_engine.c             |  10 +-
 drivers/gpu/drm/xe/xe_irq.c                   |  14 +-
 drivers/gpu/drm/xe/xe_pci.c                   | 154 ++++++++++++------
 drivers/gpu/drm/xe/xe_pci_types.h             |   9 +-
 drivers/gpu/drm/xe/xe_platform_types.h        |   1 +
 drivers/gpu/drm/xe/xe_pmu.c                   |  11 +-
 drivers/gpu/drm/xe/xe_query.c                 |   2 +-
 drivers/gpu/drm/xe/xe_reg_whitelist.c         |   3 +-
 drivers/gpu/drm/xe/xe_rtp.c                   |  24 +--
 drivers/gpu/drm/xe/xe_rtp.h                   |  18 +-
 drivers/gpu/drm/xe/xe_rtp_types.h             |   4 +-
 drivers/gpu/drm/xe/xe_sriov.c                 |  19 ++-
 drivers/gpu/drm/xe/xe_sriov.h                 |   2 +-
 drivers/gpu/drm/xe/xe_tile.c                  |   4 -
 drivers/gpu/drm/xe/xe_vm.c                    |   3 +-
 drivers/gpu/drm/xe/xe_wa.c                    |   2 +-
 drivers/gpu/drm/xe/xe_wa_oob.rules            |   8 +-
 include/drm/intel/pciids.h                    |   7 +-
 32 files changed, 386 insertions(+), 124 deletions(-)
Signature · 1 line
2.51.0
author
#1 lore raw

PATCH v2 1/22 drm/xe/huc: Adjust HuC check on primary GT

The HuC initialization code determines whether a platform can have a HuC on the primary GT by checking whether tile->media_gt is NULL; old Xe1 platforms that combined render+media into a single GT will always have a NULL media_gt pointer. However once we allow media to be disabled via configfs, there will also be cases where tile->media_gt is NULL on more modern platforms, causing this condition to behave incorrectly.

To handle cases where media gets disabled via configfs (or theoretical cases where media is truly fused off in hardware), change the condition to consider the graphics version of the primary GT; only the old Xe1 platforms with graphics versions 12.55 or earlier should try to initialize a HuC on the primary GT.

---
 drivers/gpu/drm/xe/xe_huc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_huc.c +7 -3
index 7e43b2dd6a32..0a70c8924582 100644
@@ -66,14 +66,18 @@ static int huc_alloc_gsc_pkt(struct xe_huc *huc)
 int xe_huc_init(struct xe_huc *huc)
 {
 	struct xe_gt *gt = huc_to_gt(huc);
-	struct xe_tile *tile = gt_to_tile(gt);
 	struct xe_device *xe = gt_to_xe(gt);
 	int ret;
 
 	huc->fw.type = XE_UC_FW_TYPE_HUC;
 
-	/* On platforms with a media GT the HuC is only available there */
-	if (tile->media_gt && (gt != tile->media_gt)) {
+	/*
+	 * The HuC is only available on the media GT on most platforms.  The
+	 * exception to that rule are the old Xe1 platforms where there was
+	 * no separate GT for media IP, so the HuC was part of the primary
+	 * GT.  Such platforms have graphics versions 12.55 and earlier.
+	 */
+	if (!xe_gt_is_media_type(gt) && GRAPHICS_VERx100(xe) > 1255) {
 		xe_uc_fw_change_status(&huc->fw, XE_UC_FIRMWARE_NOT_SUPPORTED);
 		return 0;
 	}
Signature · 1 line
2.51.0
author
#2 lore raw

PATCH v2 2/22 drm/xe: Drop GT parameter to xe_display_irq_postinstall()

In reply to Matt Roper

Display interrupt handling has no relation to GT(s) on the platforms supported by the Xe driver. We only call xe_display_irq_postinstall with the first tile's primary GT, so the single condition that uses the GT pointer within the function always evaluates to true. Drop the unnecessary parameter and the condition.

---
 drivers/gpu/drm/xe/display/xe_display.c | 5 ++---
 drivers/gpu/drm/xe/display/xe_display.h | 4 ++--
 drivers/gpu/drm/xe/xe_irq.c             | 2 +-
 3 files changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/display/xe_display.c +2 -3
index 19e691fccf8c..f5101f267c18 100644
@@ -223,15 +223,14 @@ void xe_display_irq_reset(struct xe_device *xe)
 	gen11_display_irq_reset(display);
 }
 
-void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt)
+void xe_display_irq_postinstall(struct xe_device *xe)
 {
 	struct intel_display *display = xe->display;
 
 	if (!xe->info.probe_display)
 		return;
 
-	if (gt->info.id == XE_GT0)
-		gen11_de_irq_postinstall(display);
+	gen11_de_irq_postinstall(display);
 }
 
 static bool suspend_to_idle(void)
drivers/gpu/drm/xe/display/xe_display.h +2 -2
index e533aa4750bc..76db95c25f7e 100644
@@ -26,7 +26,7 @@ void xe_display_unregister(struct xe_device *xe);
 void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl);
 void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir);
 void xe_display_irq_reset(struct xe_device *xe);
-void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt);
+void xe_display_irq_postinstall(struct xe_device *xe);
 
 void xe_display_pm_suspend(struct xe_device *xe);
 void xe_display_pm_shutdown(struct xe_device *xe);
@@ -55,7 +55,7 @@ static inline void xe_display_unregister(struct xe_device *xe) {}
 static inline void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl) {}
 static inline void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir) {}
 static inline void xe_display_irq_reset(struct xe_device *xe) {}
-static inline void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt) {}
+static inline void xe_display_irq_postinstall(struct xe_device *xe) {}
 
 static inline void xe_display_pm_suspend(struct xe_device *xe) {}
 static inline void xe_display_pm_shutdown(struct xe_device *xe) {}
drivers/gpu/drm/xe/xe_irq.c +1 -1
index 870edaf69388..5018a116852f 100644
@@ -656,7 +656,7 @@ static void xe_irq_postinstall(struct xe_device *xe)
 			xe_memirq_postinstall(&tile->memirq);
 	}
 
-	xe_display_irq_postinstall(xe, xe_root_mmio_gt(xe));
+	xe_display_irq_postinstall(xe);
 
 	/*
 	 * ASLE backlight operations are reported via GUnit GSE interrupts
Signature · 1 line
2.51.0
Reviewed-by on v2 2/22
#3 lore raw

Re: [PATCH v2 02/22] drm/xe: Drop GT parameter to xe_display_irq_postinstall()

Quoted 7 lines · Matt Roper

Display interrupt handling has no relation to GT(s) on the platforms supported by the Xe driver. We only call xe_display_irq_postinstall with the first tile's primary GT, so the single condition that uses the GT pointer within the function always evaluates to true. Drop the unnecessary parameter and the condition.

Lucas De Marchi

Quoted 66 lines

---

drivers/gpu/drm/xe/display/xe_display.c | 5 ++---
drivers/gpu/drm/xe/display/xe_display.h | 4 ++--
drivers/gpu/drm/xe/xe_irq.c             | 2 +-
3 files changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/display/xe_display.c +2 -3
index 19e691fccf8c..f5101f267c18 100644
@@ -223,15 +223,14 @@ void xe_display_irq_reset(struct xe_device *xe)
 	gen11_display_irq_reset(display);
 }
 
-void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt)
+void xe_display_irq_postinstall(struct xe_device *xe)
 {
 	struct intel_display *display = xe->display;
 
 	if (!xe->info.probe_display)
 		return;
 
-	if (gt->info.id == XE_GT0)
-		gen11_de_irq_postinstall(display);
+	gen11_de_irq_postinstall(display);
 }
 
 static bool suspend_to_idle(void)
drivers/gpu/drm/xe/display/xe_display.h +2 -2
index e533aa4750bc..76db95c25f7e 100644
@@ -26,7 +26,7 @@ void xe_display_unregister(struct xe_device *xe);
 void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl);
 void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir);
 void xe_display_irq_reset(struct xe_device *xe);
-void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt);
+void xe_display_irq_postinstall(struct xe_device *xe);
 
 void xe_display_pm_suspend(struct xe_device *xe);
 void xe_display_pm_shutdown(struct xe_device *xe);
@@ -55,7 +55,7 @@ static inline void xe_display_unregister(struct xe_device *xe) {}
 static inline void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl) {}
 static inline void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir) {}
 static inline void xe_display_irq_reset(struct xe_device *xe) {}
-static inline void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt) {}
+static inline void xe_display_irq_postinstall(struct xe_device *xe) {}
 
 static inline void xe_display_pm_suspend(struct xe_device *xe) {}
 static inline void xe_display_pm_shutdown(struct xe_device *xe) {}
drivers/gpu/drm/xe/xe_irq.c +1 -1
index 870edaf69388..5018a116852f 100644
@@ -656,7 +656,7 @@ static void xe_irq_postinstall(struct xe_device *xe)
 			xe_memirq_postinstall(&tile->memirq);
 	}
 
-	xe_display_irq_postinstall(xe, xe_root_mmio_gt(xe));
+	xe_display_irq_postinstall(xe);
 
 	/*
 	 * ASLE backlight operations are reported via GUnit GSE interrupts
Signature · 1 line
2.51.0
author
#4 lore raw

PATCH v2 3/22 drm/xe: Move 'va_bits' flag back to platform descriptor

In reply to Matt Roper

The number of virtual address bits is something that should be tracked at the platform level rather than the IP level. Even when mixing and matching various graphics, media, and display IP blocks, the platform as a whole has to have consistent page table handling. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

Since all platforms except PVC use the same value (48 bits), let's make this the default if a platform descriptor doesn't specify the value. If more platforms show up in the future with virtual addresses of 57-bits (or other sizes), we can go back to requiring this to be explicitly specified for every platform at that time.

---
 drivers/gpu/drm/xe/xe_pci.c       | 8 +++-----
 drivers/gpu/drm/xe/xe_pci_types.h | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +3 -5
index 3f42b91efa28..90dae6fa7fc8 100644
@@ -52,13 +52,11 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
 static const struct xe_graphics_desc graphics_xelp = {
 	.hw_engine_mask = BIT(XE_HW_ENGINE_RCS0) | BIT(XE_HW_ENGINE_BCS0),
 
-	.va_bits = 48,
 	.vm_max_level = 3,
 };
 
 #define XE_HP_FEATURES \
 	.has_range_tlb_inval = true, \
-	.va_bits = 48, \
 	.vm_max_level = 3
 
 static const struct xe_graphics_desc graphics_xehpg = {
@@ -84,7 +82,6 @@ static const struct xe_graphics_desc graphics_xehpc = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-	.va_bits = 57,
 	.vm_max_level = 4,
 	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 
@@ -108,7 +105,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
 	.has_range_tlb_inval = 1, \
 	.has_usm = 1, \
 	.has_64bit_timestamp = 1, \
-	.va_bits = 48, \
 	.vm_max_level = 4, \
 	.hw_engine_mask = \
 		BIT(XE_HW_ENGINE_RCS0) | \
@@ -303,6 +299,7 @@ static const __maybe_unused struct xe_device_desc pvc_desc = {
 	.max_gt_per_tile = 1,
 	.max_remote_tiles = 1,
 	.require_force_probe = true,
+	.va_bits = 57,
 	.has_mbx_power_limits = false,
 };
 
@@ -584,6 +581,8 @@ static int xe_info_init_early(struct xe_device *xe,
 		subplatform_desc->subplatform : XE_SUBPLATFORM_NONE;
 
 	xe->info.dma_mask_size = desc->dma_mask_size;
+	xe->info.va_bits = desc->va_bits ?: 48;
+
 	xe->info.is_dgfx = desc->is_dgfx;
 	xe->info.has_fan_control = desc->has_fan_control;
 	xe->info.has_mbx_power_limits = desc->has_mbx_power_limits;
@@ -713,7 +712,6 @@ static int xe_info_init(struct xe_device *xe,
 	}
 
 	xe->info.vram_flags = graphics_desc->vram_flags;
-	xe->info.va_bits = graphics_desc->va_bits;
 	xe->info.vm_max_level = graphics_desc->vm_max_level;
 	xe->info.has_asid = graphics_desc->has_asid;
 	xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
drivers/gpu/drm/xe/xe_pci_types.h +1 -1
index 9b9766a3baa3..095133a1aa44 100644
@@ -30,6 +30,7 @@ struct xe_device_desc {
 	u8 dma_mask_size;
 	u8 max_remote_tiles:2;
 	u8 max_gt_per_tile:2;
+	u8 va_bits;		/* default is 48 bits if not specified */
 
 	u8 require_force_probe:1;
 	u8 is_dgfx:1;
@@ -51,7 +52,6 @@ struct xe_device_desc {
 };
 
 struct xe_graphics_desc {
-	u8 va_bits;
 	u8 vm_max_level;
 	u8 vram_flags;
 
Signature · 1 line
2.51.0
#5 lore raw

Re: [PATCH v2 03/22] drm/xe: Move 'va_bits' flag back to platform descriptor

Quoted 7 lines · Matt Roper

The number of virtual address bits is something that should be tracked at the platform level rather than the IP level. Even when mixing and matching various graphics, media, and display IP blocks, the platform as a whole has to have consistent page table handling. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

Quoted 5 lines

Since all platforms except PVC use the same value (48 bits), let's make this the default if a platform descriptor doesn't specify the value. If more platforms show up in the future with virtual addresses of 57-bits (or other sizes), we can go back to requiring this to be explicitly specified for every platform at that time.

but does it make sense to introduce exception in device_desc by relying that some unset values will have extra runtime code that sets defaults?

all device_desc'riptors are static const so there should be no extra cost (beyond LOC) to store there 48 instead of 0

Quoted 50 lines
---
 drivers/gpu/drm/xe/xe_pci.c       | 8 +++-----
 drivers/gpu/drm/xe/xe_pci_types.h | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +1 -4
index 3f42b91efa28..90dae6fa7fc8 100644
@@ -52,13 +52,11 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
 static const struct xe_graphics_desc graphics_xelp = {
 	.hw_engine_mask = BIT(XE_HW_ENGINE_RCS0) | BIT(XE_HW_ENGINE_BCS0),
 
-	.va_bits = 48,
 	.vm_max_level = 3,
 };
 
 #define XE_HP_FEATURES \
 	.has_range_tlb_inval = true, \
-	.va_bits = 48, \
 	.vm_max_level = 3
 
 static const struct xe_graphics_desc graphics_xehpg = {
@@ -84,7 +82,6 @@ static const struct xe_graphics_desc graphics_xehpc = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-	.va_bits = 57,
 	.vm_max_level = 4,
 	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 
@@ -108,7 +105,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
 	.has_range_tlb_inval = 1, \
 	.has_usm = 1, \
 	.has_64bit_timestamp = 1, \
-	.va_bits = 48, \
 	.vm_max_level = 4, \
 	.hw_engine_mask = \
 		BIT(XE_HW_ENGINE_RCS0) | \
@@ -303,6 +299,7 @@ static const __maybe_unused struct xe_device_desc pvc_desc = {
 	.max_gt_per_tile = 1,
 	.max_remote_tiles = 1,
 	.require_force_probe = true,
+	.va_bits = 57,
 	.has_mbx_power_limits = false,
 };
 

drivers/gpu/drm/xe/xe_pci.c static int xe_info_init_early(struct xe_device *xe, · line 584

Quoted 4 lines
drivers/gpu/drm/xe/xe_pci.c +1 -0
@@ -584,6 +581,8 @@ static int xe_info_init_early(struct xe_device *xe,
 		subplatform_desc->subplatform : XE_SUBPLATFORM_NONE;
 
 	xe->info.dma_mask_size = desc->dma_mask_size;
+	xe->info.va_bits = desc->va_bits ?: 48;

all other fields are just simple copy
this one requires (hard to spot) logic

Quoted 32 lines
drivers/gpu/drm/xe/xe_pci.c +1 -1
+
 	xe->info.is_dgfx = desc->is_dgfx;
 	xe->info.has_fan_control = desc->has_fan_control;
 	xe->info.has_mbx_power_limits = desc->has_mbx_power_limits;
@@ -713,7 +712,6 @@ static int xe_info_init(struct xe_device *xe,
 	}
 
 	xe->info.vram_flags = graphics_desc->vram_flags;
-	xe->info.va_bits = graphics_desc->va_bits;
 	xe->info.vm_max_level = graphics_desc->vm_max_level;
 	xe->info.has_asid = graphics_desc->has_asid;
 	xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
drivers/gpu/drm/xe/xe_pci_types.h +1 -1
index 9b9766a3baa3..095133a1aa44 100644
@@ -30,6 +30,7 @@ struct xe_device_desc {
 	u8 dma_mask_size;
 	u8 max_remote_tiles:2;
 	u8 max_gt_per_tile:2;
+	u8 va_bits;		/* default is 48 bits if not specified */
 
 	u8 require_force_probe:1;
 	u8 is_dgfx:1;
@@ -51,7 +52,6 @@ struct xe_device_desc {
 };
 
 struct xe_graphics_desc {
-	u8 va_bits;
 	u8 vm_max_level;
 	u8 vram_flags;
 
#6 lore raw

Re: [PATCH v2 03/22] drm/xe: Move 'va_bits' flag back to platform descriptor

Quoted 16 lines · Michal Wajdeczko
Quoted 7 lines · Matt Roper

The number of virtual address bits is something that should be tracked at the platform level rather than the IP level. Even when mixing and matching various graphics, media, and display IP blocks, the platform as a whole has to have consistent page table handling. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

Quoted 5 lines

Since all platforms except PVC use the same value (48 bits), let's make this the default if a platform descriptor doesn't specify the value. If more platforms show up in the future with virtual addresses of 57-bits (or other sizes), we can go back to requiring this to be explicitly specified for every platform at that time.

Quoted 5 lines

but does it make sense to introduce exception in device_desc by relying that some unset values will have extra runtime code that sets defaults?

all device_desc'riptors are static const so there should be no extra cost (beyond LOC) to store there 48 instead of 0

agreed... only downside I can see is having to be explicit, which we already are for e.g. dma_mask_size. So, just adding it next to dma_mask_size would also help translating the spec to the device descriptor as they are closely located

The move from graphics_desc to device_desk makes sense though.

Lucas De Marchi

Quoted 92 lines
Quoted 51 lines
---
 drivers/gpu/drm/xe/xe_pci.c       | 8 +++-----
 drivers/gpu/drm/xe/xe_pci_types.h | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +1 -4
index 3f42b91efa28..90dae6fa7fc8 100644
@@ -52,13 +52,11 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
 static const struct xe_graphics_desc graphics_xelp = {
 	.hw_engine_mask = BIT(XE_HW_ENGINE_RCS0) | BIT(XE_HW_ENGINE_BCS0),
 
-	.va_bits = 48,
 	.vm_max_level = 3,
 };
 
 #define XE_HP_FEATURES \
 	.has_range_tlb_inval = true, \
-	.va_bits = 48, \
 	.vm_max_level = 3
 
 static const struct xe_graphics_desc graphics_xehpg = {
@@ -84,7 +82,6 @@ static const struct xe_graphics_desc graphics_xehpc = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-	.va_bits = 57,
 	.vm_max_level = 4,
 	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 
@@ -108,7 +105,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
 	.has_range_tlb_inval = 1, \
 	.has_usm = 1, \
 	.has_64bit_timestamp = 1, \
-	.va_bits = 48, \
 	.vm_max_level = 4, \
 	.hw_engine_mask = \
 		BIT(XE_HW_ENGINE_RCS0) | \
@@ -303,6 +299,7 @@ static const __maybe_unused struct xe_device_desc pvc_desc = {
 	.max_gt_per_tile = 1,
 	.max_remote_tiles = 1,
 	.require_force_probe = true,
+	.va_bits = 57,
 	.has_mbx_power_limits = false,
 };
 

drivers/gpu/drm/xe/xe_pci.c static int xe_info_init_early(struct xe_device *xe, · line 584

Quoted 4 lines
drivers/gpu/drm/xe/xe_pci.c +1 -0
@@ -584,6 +581,8 @@ static int xe_info_init_early(struct xe_device *xe,
 		subplatform_desc->subplatform : XE_SUBPLATFORM_NONE;
 
 	xe->info.dma_mask_size = desc->dma_mask_size;
+	xe->info.va_bits = desc->va_bits ?: 48;

all other fields are just simple copy
this one requires (hard to spot) logic

Quoted 32 lines
drivers/gpu/drm/xe/xe_pci.c +1 -1
+
 	xe->info.is_dgfx = desc->is_dgfx;
 	xe->info.has_fan_control = desc->has_fan_control;
 	xe->info.has_mbx_power_limits = desc->has_mbx_power_limits;
@@ -713,7 +712,6 @@ static int xe_info_init(struct xe_device *xe,
 	}
 
 	xe->info.vram_flags = graphics_desc->vram_flags;
-	xe->info.va_bits = graphics_desc->va_bits;
 	xe->info.vm_max_level = graphics_desc->vm_max_level;
 	xe->info.has_asid = graphics_desc->has_asid;
 	xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
drivers/gpu/drm/xe/xe_pci_types.h +1 -1
index 9b9766a3baa3..095133a1aa44 100644
@@ -30,6 +30,7 @@ struct xe_device_desc {
 	u8 dma_mask_size;
 	u8 max_remote_tiles:2;
 	u8 max_gt_per_tile:2;
+	u8 va_bits;		/* default is 48 bits if not specified */
 
 	u8 require_force_probe:1;
 	u8 is_dgfx:1;
@@ -51,7 +52,6 @@ struct xe_device_desc {
 };
 
 struct xe_graphics_desc {
-	u8 va_bits;
 	u8 vm_max_level;
 	u8 vram_flags;
 
author
#7 lore raw

PATCH v2 4/22 drm/xe: Move 'vm_max_level' flag back to platform descriptor

In reply to Matt Roper

The number of page table levels for PPGTT virtual addresses is something that should be tracked at the platform level rather than the IP level. Even when mixing and matching various graphics, media, and display IP blocks, the platform as a whole has to have consistent page table handling. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

Since all platforms officially supported by the Xe driver use the same value (4 levels) and only some old Xe1 platforms have a different value, let's make this the default if a platform descriptor doesn't specify the value. If more platforms show up in the future with different numbers of page table levels, we can go back to requiring this to be explicitly specified for every platform at that time.

---
 drivers/gpu/drm/xe/xe_pci.c       | 17 +++++++++--------
 drivers/gpu/drm/xe/xe_pci_types.h |  2 +-
 2 files changed, 10 insertions(+), 9 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +9 -8
index 90dae6fa7fc8..0851fbe92cba 100644
@@ -51,13 +51,10 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
 
 static const struct xe_graphics_desc graphics_xelp = {
 	.hw_engine_mask = BIT(XE_HW_ENGINE_RCS0) | BIT(XE_HW_ENGINE_BCS0),
-
-	.vm_max_level = 3,
 };
 
 #define XE_HP_FEATURES \
-	.has_range_tlb_inval = true, \
-	.vm_max_level = 3
+	.has_range_tlb_inval = true
 
 static const struct xe_graphics_desc graphics_xehpg = {
 	.hw_engine_mask =
@@ -82,7 +79,6 @@ static const struct xe_graphics_desc graphics_xehpc = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-	.vm_max_level = 4,
 	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 
 	.has_asid = 1,
@@ -105,7 +101,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
 	.has_range_tlb_inval = 1, \
 	.has_usm = 1, \
 	.has_64bit_timestamp = 1, \
-	.vm_max_level = 4, \
 	.hw_engine_mask = \
 		BIT(XE_HW_ENGINE_RCS0) | \
 		BIT(XE_HW_ENGINE_BCS8) | BIT(XE_HW_ENGINE_BCS0) | \
@@ -181,6 +176,7 @@ static const struct xe_device_desc rkl_desc = {
 	.has_llc = true,
 	.max_gt_per_tile = 1,
 	.require_force_probe = true,
+	.vm_max_level = 3,
 };
 
 static const u16 adls_rpls_ids[] = { INTEL_RPLS_IDS(NOP), 0 };
@@ -199,6 +195,7 @@ static const struct xe_device_desc adl_s_desc = {
 		{ XE_SUBPLATFORM_ALDERLAKE_S_RPLS, "RPLS", adls_rpls_ids },
 		{},
 	},
+	.vm_max_level = 3,
 };
 
 static const u16 adlp_rplu_ids[] = { INTEL_RPLU_IDS(NOP), 0 };
@@ -217,6 +214,7 @@ static const struct xe_device_desc adl_p_desc = {
 		{ XE_SUBPLATFORM_ALDERLAKE_P_RPLU, "RPLU", adlp_rplu_ids },
 		{},
 	},
+	.vm_max_level = 3,
 };
 
 static const struct xe_device_desc adl_n_desc = {
@@ -229,6 +227,7 @@ static const struct xe_device_desc adl_n_desc = {
 	.has_sriov = true,
 	.max_gt_per_tile = 1,
 	.require_force_probe = true,
+	.vm_max_level = 3,
 };
 
 #define DGFX_FEATURES \
@@ -245,6 +244,7 @@ static const struct xe_device_desc dg1_desc = {
 	.has_heci_gscfi = 1,
 	.max_gt_per_tile = 1,
 	.require_force_probe = true,
+	.vm_max_level = 3,
 };
 
 static const u16 dg2_g10_ids[] = { INTEL_DG2_G10_IDS(NOP), INTEL_ATS_M150_IDS(NOP), 0 };
@@ -261,7 +261,8 @@ static const u16 dg2_g12_ids[] = { INTEL_DG2_G12_IDS(NOP), 0 };
 		{ XE_SUBPLATFORM_DG2_G11, "G11", dg2_g11_ids }, \
 		{ XE_SUBPLATFORM_DG2_G12, "G12", dg2_g12_ids }, \
 		{ } \
-	}
+	}, \
+	.vm_max_level = 3
 
 static const struct xe_device_desc ats_m_desc = {
 	.pre_gmdid_graphics_ip = &graphics_ip_xehpg,
@@ -582,6 +583,7 @@ static int xe_info_init_early(struct xe_device *xe,
 
 	xe->info.dma_mask_size = desc->dma_mask_size;
 	xe->info.va_bits = desc->va_bits ?: 48;
+	xe->info.vm_max_level = desc->vm_max_level ?: 4;
 
 	xe->info.is_dgfx = desc->is_dgfx;
 	xe->info.has_fan_control = desc->has_fan_control;
@@ -712,7 +714,6 @@ static int xe_info_init(struct xe_device *xe,
 	}
 
 	xe->info.vram_flags = graphics_desc->vram_flags;
-	xe->info.vm_max_level = graphics_desc->vm_max_level;
 	xe->info.has_asid = graphics_desc->has_asid;
 	xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
 	if (xe->info.platform != XE_PVC)
drivers/gpu/drm/xe/xe_pci_types.h +1 -1
index 095133a1aa44..f45b45a7f76a 100644
@@ -31,6 +31,7 @@ struct xe_device_desc {
 	u8 max_remote_tiles:2;
 	u8 max_gt_per_tile:2;
 	u8 va_bits;		/* default is 48 bits if not specified */
+	u8 vm_max_level;	/* default is 4 if not specified */
 
 	u8 require_force_probe:1;
 	u8 is_dgfx:1;
@@ -52,7 +53,6 @@ struct xe_device_desc {
 };
 
 struct xe_graphics_desc {
-	u8 vm_max_level;
 	u8 vram_flags;
 
 	u64 hw_engine_mask;	/* hardware engines provided by graphics IP */
Signature · 1 line
2.51.0
#8 lore raw

Re: [PATCH v2 04/22] drm/xe: Move 'vm_max_level' flag back to platform descriptor

Quoted 8 lines · Matt Roper

The number of page table levels for PPGTT virtual addresses is something that should be tracked at the platform level rather than the IP level. Even when mixing and matching various graphics, media, and display IP blocks, the platform as a whole has to have consistent page table handling. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

Quoted 6 lines

Since all platforms officially supported by the Xe driver use the same value (4 levels) and only some old Xe1 platforms have a different value, let's make this the default if a platform descriptor doesn't specify the value. If more platforms show up in the future with different numbers of page table levels, we can go back to requiring this to be explicitly specified for every platform at that time.

Same comment as in previous patch... making it explicit IMO is better.

Lucas De Marchi

Quoted 131 lines

---
drivers/gpu/drm/xe/xe_pci.c | 17 +++++++++--------
drivers/gpu/drm/xe/xe_pci_types.h | 2 +-

2 files changed, 10 insertions(+), 9 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +9 -8
index 90dae6fa7fc8..0851fbe92cba 100644
@@ -51,13 +51,10 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
 
 static const struct xe_graphics_desc graphics_xelp = {
 	.hw_engine_mask = BIT(XE_HW_ENGINE_RCS0) | BIT(XE_HW_ENGINE_BCS0),
-
-	.vm_max_level = 3,
 };
 
 #define XE_HP_FEATURES \
-	.has_range_tlb_inval = true, \
-	.vm_max_level = 3
+	.has_range_tlb_inval = true
 
 static const struct xe_graphics_desc graphics_xehpg = {
 	.hw_engine_mask =
@@ -82,7 +79,6 @@ static const struct xe_graphics_desc graphics_xehpc = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-	.vm_max_level = 4,
 	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 
 	.has_asid = 1,
@@ -105,7 +101,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
 	.has_range_tlb_inval = 1, \
 	.has_usm = 1, \
 	.has_64bit_timestamp = 1, \
-	.vm_max_level = 4, \
 	.hw_engine_mask = \
 		BIT(XE_HW_ENGINE_RCS0) | \
 		BIT(XE_HW_ENGINE_BCS8) | BIT(XE_HW_ENGINE_BCS0) | \
@@ -181,6 +176,7 @@ static const struct xe_device_desc rkl_desc = {
 	.has_llc = true,
 	.max_gt_per_tile = 1,
 	.require_force_probe = true,
+	.vm_max_level = 3,
 };
 
 static const u16 adls_rpls_ids[] = { INTEL_RPLS_IDS(NOP), 0 };
@@ -199,6 +195,7 @@ static const struct xe_device_desc adl_s_desc = {
 		{ XE_SUBPLATFORM_ALDERLAKE_S_RPLS, "RPLS", adls_rpls_ids },
 		{},
 	},
+	.vm_max_level = 3,
 };
 
 static const u16 adlp_rplu_ids[] = { INTEL_RPLU_IDS(NOP), 0 };
@@ -217,6 +214,7 @@ static const struct xe_device_desc adl_p_desc = {
 		{ XE_SUBPLATFORM_ALDERLAKE_P_RPLU, "RPLU", adlp_rplu_ids },
 		{},
 	},
+	.vm_max_level = 3,
 };
 
 static const struct xe_device_desc adl_n_desc = {
@@ -229,6 +227,7 @@ static const struct xe_device_desc adl_n_desc = {
 	.has_sriov = true,
 	.max_gt_per_tile = 1,
 	.require_force_probe = true,
+	.vm_max_level = 3,
 };
 
 #define DGFX_FEATURES \
@@ -245,6 +244,7 @@ static const struct xe_device_desc dg1_desc = {
 	.has_heci_gscfi = 1,
 	.max_gt_per_tile = 1,
 	.require_force_probe = true,
+	.vm_max_level = 3,
 };
 
 static const u16 dg2_g10_ids[] = { INTEL_DG2_G10_IDS(NOP), INTEL_ATS_M150_IDS(NOP), 0 };
@@ -261,7 +261,8 @@ static const u16 dg2_g12_ids[] = { INTEL_DG2_G12_IDS(NOP), 0 };
 		{ XE_SUBPLATFORM_DG2_G11, "G11", dg2_g11_ids }, \
 		{ XE_SUBPLATFORM_DG2_G12, "G12", dg2_g12_ids }, \
 		{ } \
-	}
+	}, \
+	.vm_max_level = 3
 
 static const struct xe_device_desc ats_m_desc = {
 	.pre_gmdid_graphics_ip = &graphics_ip_xehpg,
@@ -582,6 +583,7 @@ static int xe_info_init_early(struct xe_device *xe,
 
 	xe->info.dma_mask_size = desc->dma_mask_size;
 	xe->info.va_bits = desc->va_bits ?: 48;
+	xe->info.vm_max_level = desc->vm_max_level ?: 4;
 
 	xe->info.is_dgfx = desc->is_dgfx;
 	xe->info.has_fan_control = desc->has_fan_control;
@@ -712,7 +714,6 @@ static int xe_info_init(struct xe_device *xe,
 	}
 
 	xe->info.vram_flags = graphics_desc->vram_flags;
-	xe->info.vm_max_level = graphics_desc->vm_max_level;
 	xe->info.has_asid = graphics_desc->has_asid;
 	xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
 	if (xe->info.platform != XE_PVC)
drivers/gpu/drm/xe/xe_pci_types.h +1 -1
index 095133a1aa44..f45b45a7f76a 100644
@@ -31,6 +31,7 @@ struct xe_device_desc {
 	u8 max_remote_tiles:2;
 	u8 max_gt_per_tile:2;
 	u8 va_bits;		/* default is 48 bits if not specified */
+	u8 vm_max_level;	/* default is 4 if not specified */
 
 	u8 require_force_probe:1;
 	u8 is_dgfx:1;
@@ -52,7 +53,6 @@ struct xe_device_desc {
 };
 
 struct xe_graphics_desc {
-	u8 vm_max_level;
 	u8 vram_flags;
 
 	u64 hw_engine_mask;	/* hardware engines provided by graphics IP */
Signature · 1 line
2.51.0
author
#9 lore raw

PATCH v2 5/22 drm/xe: Move 'vram_flags' flag back to platform descriptor

In reply to Matt Roper

Restrictions and requirements on VRAM alignment are something that should be tracked at the platform level rather than the IP level. Even when mixing and matching various graphics, media, and display IP blocks, the platform as a whole has to have consistent memory allocation handling. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

---
 drivers/gpu/drm/xe/xe_pci.c       | 8 ++++----
 drivers/gpu/drm/xe/xe_pci_types.h | 3 +--
 2 files changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +4 -4
index 0851fbe92cba..21255ee5a830 100644
@@ -63,7 +63,6 @@ static const struct xe_graphics_desc graphics_xehpg = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 
 	.has_flat_ccs = 1,
 };
@@ -79,7 +78,6 @@ static const struct xe_graphics_desc graphics_xehpc = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 
 	.has_asid = 1,
 	.has_atomic_enable_pte_bit = 1,
@@ -262,7 +260,8 @@ static const u16 dg2_g12_ids[] = { INTEL_DG2_G12_IDS(NOP), 0 };
 		{ XE_SUBPLATFORM_DG2_G12, "G12", dg2_g12_ids }, \
 		{ } \
 	}, \
-	.vm_max_level = 3
+	.vm_max_level = 3, \
+	.vram_flags = XE_VRAM_FLAGS_NEED64K
 
 static const struct xe_device_desc ats_m_desc = {
 	.pre_gmdid_graphics_ip = &graphics_ip_xehpg,
@@ -301,6 +300,7 @@ static const __maybe_unused struct xe_device_desc pvc_desc = {
 	.max_remote_tiles = 1,
 	.require_force_probe = true,
 	.va_bits = 57,
+	.vram_flags = XE_VRAM_FLAGS_NEED64K,
 	.has_mbx_power_limits = false,
 };
 
@@ -584,6 +584,7 @@ static int xe_info_init_early(struct xe_device *xe,
 	xe->info.dma_mask_size = desc->dma_mask_size;
 	xe->info.va_bits = desc->va_bits ?: 48;
 	xe->info.vm_max_level = desc->vm_max_level ?: 4;
+	xe->info.vram_flags = desc->vram_flags;
 
 	xe->info.is_dgfx = desc->is_dgfx;
 	xe->info.has_fan_control = desc->has_fan_control;
@@ -713,7 +714,6 @@ static int xe_info_init(struct xe_device *xe,
 		media_desc = NULL;
 	}
 
-	xe->info.vram_flags = graphics_desc->vram_flags;
 	xe->info.has_asid = graphics_desc->has_asid;
 	xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
 	if (xe->info.platform != XE_PVC)
drivers/gpu/drm/xe/xe_pci_types.h +1 -2
index f45b45a7f76a..e7bc74f4b9b3 100644
@@ -32,6 +32,7 @@ struct xe_device_desc {
 	u8 max_gt_per_tile:2;
 	u8 va_bits;		/* default is 48 bits if not specified */
 	u8 vm_max_level;	/* default is 4 if not specified */
+	u8 vram_flags;
 
 	u8 require_force_probe:1;
 	u8 is_dgfx:1;
@@ -53,8 +54,6 @@ struct xe_device_desc {
 };
 
 struct xe_graphics_desc {
-	u8 vram_flags;
-
 	u64 hw_engine_mask;	/* hardware engines provided by graphics IP */
 
 	u8 has_asid:1;
Signature · 1 line
2.51.0
Reviewed-by on v2 5/22
#10 lore raw

Re: [PATCH v2 05/22] drm/xe: Move 'vram_flags' flag back to platform descriptor

Quoted 9 lines · Matt Roper

Restrictions and requirements on VRAM alignment are something that should be tracked at the platform level rather than the IP level. Even when mixing and matching various graphics, media, and display IP blocks, the platform as a whole has to have consistent memory allocation handling. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

Lucas De Marchi

author
#11 lore raw

PATCH v2 6/22 drm/xe: Move 'has_flatccs' flag back to platform descriptor

In reply to Matt Roper

FlatCCS presence/absence is a flag that should be tracked at the platform level rather than the IP level. FlatCCS affects the device-wide memory initialization and reservations so its effects are not confined to a single IP block or GT. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

---
 drivers/gpu/drm/xe/xe_pci.c       | 12 ++++++------
 drivers/gpu/drm/xe/xe_pci_types.h |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +6 -6
index 21255ee5a830..976002aae301 100644
@@ -63,8 +63,6 @@ static const struct xe_graphics_desc graphics_xehpg = {
 		BIT(XE_HW_ENGINE_CCS2) | BIT(XE_HW_ENGINE_CCS3),
 
 	XE_HP_FEATURES,
-
-	.has_flat_ccs = 1,
 };
 
 static const struct xe_graphics_desc graphics_xehpc = {
@@ -95,7 +93,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
 #define XE2_GFX_FEATURES \
 	.has_asid = 1, \
 	.has_atomic_enable_pte_bit = 1, \
-	.has_flat_ccs = 1, \
 	.has_range_tlb_inval = 1, \
 	.has_usm = 1, \
 	.has_64bit_timestamp = 1, \
@@ -252,6 +249,7 @@ static const u16 dg2_g12_ids[] = { INTEL_DG2_G12_IDS(NOP), 0 };
 #define DG2_FEATURES \
 	DGFX_FEATURES, \
 	PLATFORM(DG2), \
+	.has_flat_ccs = 1, \
 	.has_gsc_nvm = 1, \
 	.has_heci_gscfi = 1, \
 	.subplatforms = (const struct xe_subplatform_desc[]) { \
@@ -318,6 +316,7 @@ static const struct xe_device_desc lnl_desc = {
 	PLATFORM(LUNARLAKE),
 	.dma_mask_size = 46,
 	.has_display = true,
+	.has_flat_ccs = 1,
 	.has_pxp = true,
 	.max_gt_per_tile = 2,
 	.needs_scratch = true,
@@ -329,6 +328,7 @@ static const struct xe_device_desc bmg_desc = {
 	.dma_mask_size = 46,
 	.has_display = true,
 	.has_fan_control = true,
+	.has_flat_ccs = 1,
 	.has_mbx_power_limits = true,
 	.has_gsc_nvm = 1,
 	.has_heci_cscfi = 1,
@@ -342,6 +342,7 @@ static const struct xe_device_desc ptl_desc = {
 	PLATFORM(PANTHERLAKE),
 	.dma_mask_size = 46,
 	.has_display = true,
+	.has_flat_ccs = 1,
 	.has_sriov = true,
 	.max_gt_per_tile = 2,
 	.needs_scratch = true,
@@ -588,6 +589,8 @@ static int xe_info_init_early(struct xe_device *xe,
 
 	xe->info.is_dgfx = desc->is_dgfx;
 	xe->info.has_fan_control = desc->has_fan_control;
+	/* runtime fusing may force flat_ccs to disabled later */
+	xe->info.has_flat_ccs = desc->has_flat_ccs;
 	xe->info.has_mbx_power_limits = desc->has_mbx_power_limits;
 	xe->info.has_gsc_nvm = desc->has_gsc_nvm;
 	xe->info.has_heci_gscfi = desc->has_heci_gscfi;
@@ -719,9 +722,6 @@ static int xe_info_init(struct xe_device *xe,
 	if (xe->info.platform != XE_PVC)
 		xe->info.has_device_atomics_on_smem = 1;
 
-	/* Runtime detection may change this later */
-	xe->info.has_flat_ccs = graphics_desc->has_flat_ccs;
-
 	xe->info.has_range_tlb_inval = graphics_desc->has_range_tlb_inval;
 	xe->info.has_usm = graphics_desc->has_usm;
 	xe->info.has_64bit_timestamp = graphics_desc->has_64bit_timestamp;
drivers/gpu/drm/xe/xe_pci_types.h +1 -1
index e7bc74f4b9b3..6e2875ad2a41 100644
@@ -39,6 +39,7 @@ struct xe_device_desc {
 
 	u8 has_display:1;
 	u8 has_fan_control:1;
+	u8 has_flat_ccs:1;
 	u8 has_gsc_nvm:1;
 	u8 has_heci_gscfi:1;
 	u8 has_heci_cscfi:1;
@@ -58,7 +59,6 @@ struct xe_graphics_desc {
 
 	u8 has_asid:1;
 	u8 has_atomic_enable_pte_bit:1;
-	u8 has_flat_ccs:1;
 	u8 has_indirect_ring_state:1;
 	u8 has_range_tlb_inval:1;
 	u8 has_usm:1;
Signature · 1 line
2.51.0
Reviewed-by on v2 6/22
#12 lore raw

Re: [PATCH v2 06/22] drm/xe: Move 'has_flatccs' flag back to platform descriptor

Quoted 8 lines · Matt Roper

FlatCCS presence/absence is a flag that should be tracked at the platform level rather than the IP level. FlatCCS affects the device-wide memory initialization and reservations so its effects are not confined to a single IP block or GT. This is also a trait that should be tied to the platform even if the graphics IP itself is not present (e.g., if we disable the primary GT via configfs).

Lucas De Marchi

author
#13 lore raw

PATCH v2 7/22 drm/xe: Move primary GT allocation from xe_tile_init_early to xe_tile_init

In reply to Matt Roper

During the early days of the Xe driver, there were cases where we accessed some fields in the primary GT's xe_gt structure before the GT itself was formally initialized; this required that the structure itself be allocated during xe_tile_init_early(). A lot of refactoring of the device probe has happened since that time and there's no longer a need to allocate the primary GT early. Move the allocation into xe_tile_init() where GT initialization happens and where we're doing the allocation of the media GT.

---
 drivers/gpu/drm/xe/xe_pci.c  | 4 ++++
 drivers/gpu/drm/xe/xe_tile.c | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +4 -0
index 976002aae301..bd21940a6541 100644
@@ -745,6 +745,10 @@ static int xe_info_init(struct xe_device *xe,
 	for_each_tile(tile, xe, id) {
 		int err;
 
+		tile->primary_gt = xe_gt_alloc(tile);
+		if (IS_ERR(tile->primary_gt))
+			return PTR_ERR(tile->primary_gt);
+
 		gt = tile->primary_gt;
 		gt->info.type = XE_GT_TYPE_MAIN;
 		gt->info.id = tile->id * xe->info.max_gt_per_tile;
drivers/gpu/drm/xe/xe_tile.c +0 -4
index d49ba3401963..10545654f9eb 100644
@@ -149,10 +149,6 @@ int xe_tile_init_early(struct xe_tile *tile, struct xe_device *xe, u8 id)
 	if (err)
 		return err;
 
-	tile->primary_gt = xe_gt_alloc(tile);
-	if (IS_ERR(tile->primary_gt))
-		return PTR_ERR(tile->primary_gt);
-
 	xe_pcode_init(tile);
 
 	return 0;
Signature · 1 line
2.51.0
#14 lore raw

Re: [PATCH v2 07/22] drm/xe: Move primary GT allocation from xe_tile_init_early to xe_tile_init

Quoted 8 lines · Matt Roper

During the early days of the Xe driver, there were cases where we accessed some fields in the primary GT's xe_gt structure before the GT itself was formally initialized; this required that the structure itself be allocated during xe_tile_init_early(). A lot of refactoring of the device probe has happened since that time and there's no longer a need to allocate the primary GT early. Move the allocation into xe_tile_init() where GT initialization happens and where we're doing the allocation of the media GT.

except that it doesn't work for the VFs:

<6> [178.503309] xe 0000:03:00.1: [drm] Running in SR-IOV VF mode <1> [178.503346] BUG: kernel NULL pointer dereference, address: 0000000000000008 <1> [178.503364] #PF: supervisor read access in kernel mode
<1> [178.503373] #PF: error_code(0x0000) - not-present page
<4> [178.503441] RIP: 0010:read_gmdid+0x111/0x450 [xe]
<4> [178.503898] Call Trace:

<4> [178.503904]  <TASK>
<4> [178.503912]  ? trace_hardirqs_on+0x1e/0xd0
<4> [178.503928]  ? add_dr+0x90/0xc0
<4> [178.503945]  xe_info_init.isra.0+0x455/0x9e0 [xe]
<4> [178.504281]  ? xe_device_probe_early+0xea/0x230 [xe]
<4> [178.504565]  ? pci_write_config_word+0x27/0x50
<4> [178.504581]  ? __pci_set_master+0x5b/0xe0
<4> [178.504598]  xe_pci_probe+0x168/0x610 [xe]
Quoted 37 lines
---
 drivers/gpu/drm/xe/xe_pci.c  | 4 ++++
 drivers/gpu/drm/xe/xe_tile.c | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +4 -0
index 976002aae301..bd21940a6541 100644
@@ -745,6 +745,10 @@ static int xe_info_init(struct xe_device *xe,
 	for_each_tile(tile, xe, id) {
 		int err;
 
+		tile->primary_gt = xe_gt_alloc(tile);
+		if (IS_ERR(tile->primary_gt))
+			return PTR_ERR(tile->primary_gt);
+
 		gt = tile->primary_gt;
 		gt->info.type = XE_GT_TYPE_MAIN;
 		gt->info.id = tile->id * xe->info.max_gt_per_tile;
drivers/gpu/drm/xe/xe_tile.c +0 -4
index d49ba3401963..10545654f9eb 100644
@@ -149,10 +149,6 @@ int xe_tile_init_early(struct xe_tile *tile, struct xe_device *xe, u8 id)
 	if (err)
 		return err;
 
-	tile->primary_gt = xe_gt_alloc(tile);
-	if (IS_ERR(tile->primary_gt))
-		return PTR_ERR(tile->primary_gt);
-
 	xe_pcode_init(tile);
 
 	return 0;
#15 lore raw

Re: [PATCH v2 07/22] drm/xe: Move primary GT allocation from xe_tile_init_early to xe_tile_init

In reply to Matt Roper
Quoted 7 lines · Matt Roper

During the early days of the Xe driver, there were cases where we accessed some fields in the primary GT's xe_gt structure before the GT itself was formally initialized; this required that the structure itself be allocated during xe_tile_init_early(). A lot of refactoring of the device probe has happened since that time and there's no longer a need to allocate the primary GT early. Move the allocation into xe_tile_init() where GT initialization happens and where we're doing the

^^^^ typo? I think this should be xe_info_init()

with that, Reviewed-by: Lucas De Marchi <[email protected]>

Lucas De Marchi

Quoted 41 lines

allocation of the media GT.

---
drivers/gpu/drm/xe/xe_pci.c | 4 ++++
drivers/gpu/drm/xe/xe_tile.c | 4 ----

2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +4 -0
index 976002aae301..bd21940a6541 100644
@@ -745,6 +745,10 @@ static int xe_info_init(struct xe_device *xe,
 	for_each_tile(tile, xe, id) {
 		int err;
 
+		tile->primary_gt = xe_gt_alloc(tile);
+		if (IS_ERR(tile->primary_gt))
+			return PTR_ERR(tile->primary_gt);
+
 		gt = tile->primary_gt;
 		gt->info.type = XE_GT_TYPE_MAIN;
 		gt->info.id = tile->id * xe->info.max_gt_per_tile;
drivers/gpu/drm/xe/xe_tile.c +0 -4
index d49ba3401963..10545654f9eb 100644
@@ -149,10 +149,6 @@ int xe_tile_init_early(struct xe_tile *tile, struct xe_device *xe, u8 id)
 	if (err)
 		return err;
 
-	tile->primary_gt = xe_gt_alloc(tile);
-	if (IS_ERR(tile->primary_gt))
-		return PTR_ERR(tile->primary_gt);
-
 	xe_pcode_init(tile);
 
 	return 0;
Signature · 1 line
2.51.0
author
#16 lore raw

PATCH v2 8/22 drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

In reply to Matt Roper

If the primary GT is disabled via configfs, GT-side L2 and TD cache flushes are unnecessary since nothing is using/filling these caches.

---
 drivers/gpu/drm/xe/xe_device.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xe/xe_device.c +5 -0
index 09f8a66c9728..bf99792e772c 100644
@@ -1061,6 +1061,8 @@ void xe_device_l2_flush(struct xe_device *xe)
 	unsigned int fw_ref;
 
 	gt = xe_root_mmio_gt(xe);
+	if (!gt)
+		return;
 
 	if (!XE_GT_WA(gt, 16023588340))
 		return;
@@ -1106,6 +1108,9 @@ void xe_device_td_flush(struct xe_device *xe)
 		return;
 
 	root_gt = xe_root_mmio_gt(xe);
+	if (!root_gt)
+		return;
+
 	if (XE_GT_WA(root_gt, 16023588340)) {
 		/* A transient flush is not sufficient: flush the L2 */
 		xe_device_l2_flush(xe);
Signature · 1 line
2.51.0
#17 lore raw

RE: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 11 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matt Roper
Sent: 26 September 2025 05:17
To: [email protected]
Cc: Roper, Matthew D <[email protected]>
Subject: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 2 lines

If the primary GT is disabled via configfs, GT-side L2 and TD cache flushes are unnecessary since nothing is using/filling these caches.

Is it because PPC/render engine is on primary GT only? And its going to be same way always!

Tejas

Quoted 31 lines
---
 drivers/gpu/drm/xe/xe_device.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xe/xe_device.c +5 -1
index 09f8a66c9728..bf99792e772c 100644
@@ -1061,6 +1061,8 @@ void xe_device_l2_flush(struct xe_device *xe)
 	unsigned int fw_ref;
 
 	gt = xe_root_mmio_gt(xe);
+	if (!gt)
+		return;
 
 	if (!XE_GT_WA(gt, 16023588340))
 		return;
@@ -1106,6 +1108,9 @@ void xe_device_td_flush(struct xe_device *xe)
 		return;
 
 	root_gt = xe_root_mmio_gt(xe);
+	if (!root_gt)
+		return;
+
 	if (XE_GT_WA(root_gt, 16023588340)) {
 		/* A transient flush is not sufficient: flush the L2 */
 		xe_device_l2_flush(xe);
--

2.51.0

author
#18 lore raw

Re: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 11 lines · Tejas
Quoted 11 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matt Roper
Sent: 26 September 2025 05:17
To: [email protected]
Cc: Roper, Matthew D <[email protected]>
Subject: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 4 lines
Quoted 2 lines

If the primary GT is disabled via configfs, GT-side L2 and TD cache flushes are unnecessary since nothing is using/filling these caches.

Is it because PPC/render engine is on primary GT only? And its going to be same way always!

The device cache that we're flushing here (sometimes called L2, sometimes called L3, depending on what document you're looking at) is part of the primary GT. If we've disabled the primary GT via configfs, then nothing inside that GT (RCS, CCS, BCS, etc.) is active or doing any memory accesses (no reads or writes), so the cache usually[*] shouldn't be getting used or require any explicit flushing.

We also simply can't access the registers (0xb404 and 0xb418) if the primary GT is disabled.

[*] The "usually" here does get derailed a bit by certain workarounds like Wa_16023588340, which cause CPU writes to VRAM through the BAR to get cached in the device cache, even if the GT itself is sitting unused. That aspect of the workaround is only relevant to dgpu platforms though, and I don't think we expect to allow the primary GT to be disabled on dgpu's anytime soon due the extra reliance on BCS engines for VRAM operations on a dgpu. On an igpu platform there's no VRAM, so no CPU writes filling the device cache, etc.

Matt

Quoted 34 lines

Tejas

Quoted 31 lines
---
 drivers/gpu/drm/xe/xe_device.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xe/xe_device.c +5 -1
index 09f8a66c9728..bf99792e772c 100644
@@ -1061,6 +1061,8 @@ void xe_device_l2_flush(struct xe_device *xe)
 	unsigned int fw_ref;
 
 	gt = xe_root_mmio_gt(xe);
+	if (!gt)
+		return;
 
 	if (!XE_GT_WA(gt, 16023588340))
 		return;
@@ -1106,6 +1108,9 @@ void xe_device_td_flush(struct xe_device *xe)
 		return;
 
 	root_gt = xe_root_mmio_gt(xe);
+	if (!root_gt)
+		return;
+
 	if (XE_GT_WA(root_gt, 16023588340)) {
 		/* A transient flush is not sufficient: flush the L2 */
 		xe_device_l2_flush(xe);
--

2.51.0

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
#19 lore raw

RE: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 38 lines

-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: 30 September 2025 02:56
To: Upadhyay, Tejas <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 11 lines · Tejas
Quoted 11 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matt Roper
Sent: 26 September 2025 05:17
To: [email protected]
Cc: Roper, Matthew D <[email protected]>
Subject: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 4 lines
Quoted 2 lines

If the primary GT is disabled via configfs, GT-side L2 and TD cache flushes are unnecessary since nothing is using/filling these caches.

Is it because PPC/render engine is on primary GT only? And its going to be

same way always!

The device cache that we're flushing here (sometimes called L2, sometimes called L3, depending on what document you're looking at) is part of the primary GT. If we've disabled the primary GT via configfs, then nothing inside that GT (RCS, CCS, BCS, etc.) is active or doing any memory accesses (no reads or writes), so the cache usually[*] shouldn't be getting used or require any explicit flushing.

We also simply can't access the registers (0xb404 and 0xb418) if the primary GT is disabled.

Quoted 9 lines

[*] The "usually" here does get derailed a bit by certain workarounds like Wa_16023588340, which cause CPU writes to VRAM through the BAR to get cached in the device cache, even if the GT itself is sitting unused. That aspect of the workaround is only relevant to dgpu platforms though, and I don't think we expect to allow the primary GT to be disabled on dgpu's anytime soon due the extra reliance on BCS engines for VRAM operations on a dgpu. On an igpu platform there's no VRAM, so no CPU writes filling the device cache, etc.

In that case on xe, we don't handle l2/td flush for non-dgfx, (in xe3+ its handled by HW). So primary gt null check here not required probably!

Tejas

Quoted 44 lines

Matt

Quoted 25 lines

Tejas

Quoted 23 lines
---
 drivers/gpu/drm/xe/xe_device.c | 5 +++++
 1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/xe/xe_device.c index 09f8a66c9728..bf99792e772c 100644

drivers/gpu/drm/xe/xe_device.c +2 -0
@@ -1061,6 +1061,8 @@ void xe_device_l2_flush(struct xe_device *xe)
 	unsigned int fw_ref;
 
 	gt = xe_root_mmio_gt(xe);
+	if (!gt)
+		return;
 
 	if (!XE_GT_WA(gt, 16023588340))
 		return;
@@ -1106,6 +1108,9 @@ void xe_device_td_flush(struct xe_device *xe)
 		return;
 
Quoted 10 lines
Quoted 9 lines
drivers/gpu/drm/xe/xe_device.c +3 -1
 	root_gt = xe_root_mmio_gt(xe);
+	if (!root_gt)
+		return;
+
 	if (XE_GT_WA(root_gt, 16023588340)) {
 		/* A transient flush is not sufficient: flush the L2 */
 		xe_device_l2_flush(xe);
--

2.51.0

--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation

author
#20 lore raw

Re: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 48 lines · Tejas
Quoted 38 lines

-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: 30 September 2025 02:56
To: Upadhyay, Tejas <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 11 lines · Tejas
Quoted 11 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matt Roper
Sent: 26 September 2025 05:17
To: [email protected]
Cc: Roper, Matthew D <[email protected]>
Subject: [PATCH v2 08/22] drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled

Quoted 4 lines
Quoted 2 lines

If the primary GT is disabled via configfs, GT-side L2 and TD cache flushes are unnecessary since nothing is using/filling these caches.

Is it because PPC/render engine is on primary GT only? And its going to be

same way always!

The device cache that we're flushing here (sometimes called L2, sometimes called L3, depending on what document you're looking at) is part of the primary GT. If we've disabled the primary GT via configfs, then nothing inside that GT (RCS, CCS, BCS, etc.) is active or doing any memory accesses (no reads or writes), so the cache usually[*] shouldn't be getting used or require any explicit flushing.

We also simply can't access the registers (0xb404 and 0xb418) if the primary GT is disabled.

Quoted 9 lines

[*] The "usually" here does get derailed a bit by certain workarounds like Wa_16023588340, which cause CPU writes to VRAM through the BAR to get cached in the device cache, even if the GT itself is sitting unused. That aspect of the workaround is only relevant to dgpu platforms though, and I don't think we expect to allow the primary GT to be disabled on dgpu's anytime soon due the extra reliance on BCS engines for VRAM operations on a dgpu. On an igpu platform there's no VRAM, so no CPU writes filling the device cache, etc.

Quoted 1 line

In that case on xe, we don't handle l2/td flush for non-dgfx, (in xe3+ its handled by HW). So primary gt null check here not required probably!

If you pass a NULL gt poiner to XE_GT_WA(), it will cause a crash, regardless of how the XE_GT_WA() condition would have evaluated if the pointer had been non-NULL.

Matt

Quoted 46 lines

Tejas

Quoted 44 lines

Matt

Quoted 25 lines

Tejas

Quoted 23 lines
---
 drivers/gpu/drm/xe/xe_device.c | 5 +++++
 1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/xe/xe_device.c index 09f8a66c9728..bf99792e772c 100644

drivers/gpu/drm/xe/xe_device.c +2 -0
@@ -1061,6 +1061,8 @@ void xe_device_l2_flush(struct xe_device *xe)
 	unsigned int fw_ref;
 
 	gt = xe_root_mmio_gt(xe);
+	if (!gt)
+		return;
 
 	if (!XE_GT_WA(gt, 16023588340))
 		return;
@@ -1106,6 +1108,9 @@ void xe_device_td_flush(struct xe_device *xe)
 		return;
 
Quoted 10 lines
Quoted 9 lines
drivers/gpu/drm/xe/xe_device.c +3 -1
 	root_gt = xe_root_mmio_gt(xe);
+	if (!root_gt)
+		return;
+
 	if (XE_GT_WA(root_gt, 16023588340)) {
 		/* A transient flush is not sufficient: flush the L2 */
 		xe_device_l2_flush(xe);
--

2.51.0

--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#21 lore raw

PATCH v2 9/22 drm/xe/query: Report hwconfig size as 0 if primary GT is disabled

In reply to Matt Roper

The hwconfig table is part of the primary GT's GuC firmware. If the primary GT is disabled, the hwconfig is unavailable and should be reported to userspace as having size 0.

---
 drivers/gpu/drm/xe/xe_query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_query.c +1 -1
index 2e9ff33ed2fe..1c0915e2cc16 100644
@@ -436,7 +436,7 @@ static int query_hwconfig(struct xe_device *xe,
 			  struct drm_xe_device_query *query)
 {
 	struct xe_gt *gt = xe_root_mmio_gt(xe);
-	size_t size = xe_guc_hwconfig_size(&gt->uc.guc);
+	size_t size = gt ? xe_guc_hwconfig_size(&gt->uc.guc) : 0;
 	void __user *query_ptr = u64_to_user_ptr(query->data);
 	void *hwconfig;
 
Signature · 1 line
2.51.0
author
#22 lore raw

PATCH v2 10/22 drm/xe/pmu: Initialize PMU event types based on first available GT

In reply to Matt Roper

GT ID#0 (primary GT on tile 0) may not always be available if the primary GT has been disabled via configfs. Instead use the first available GT when determining which PMU events are supported. If there are no GTs, then don't advertise any GT-related events.

---
 drivers/gpu/drm/xe/xe_pmu.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_pmu.c +10 -1
index cab51d826345..c63335eb69e5 100644
@@ -497,7 +497,12 @@ static const struct attribute_group *pmu_events_attr_update[] = {
 static void set_supported_events(struct xe_pmu *pmu)
 {
 	struct xe_device *xe = container_of(pmu, typeof(*xe), pmu);
-	struct xe_gt *gt = xe_device_get_gt(xe, 0);
+	struct xe_gt *gt;
+	int id;
+
+	/* If there are no GTs, don't support any GT-related events */
+	if (xe->info.gt_count == 0)
+		return;
 
 	if (!xe->info.skip_guc_pc) {
 		pmu->supported_events |= BIT_ULL(XE_PMU_EVENT_GT_C6_RESIDENCY);
@@ -505,6 +510,10 @@ static void set_supported_events(struct xe_pmu *pmu)
 		pmu->supported_events |= BIT_ULL(XE_PMU_EVENT_GT_REQUESTED_FREQUENCY);
 	}
 
+	/* Find the first available GT to query engine event capabilities */
+	for_each_gt(gt, xe, id)
+		break;
+
 	if (xe_guc_engine_activity_supported(&gt->uc.guc)) {
 		pmu->supported_events |= BIT_ULL(XE_PMU_EVENT_ENGINE_ACTIVE_TICKS);
 		pmu->supported_events |= BIT_ULL(XE_PMU_EVENT_ENGINE_TOTAL_TICKS);
Signature · 1 line
2.51.0
author
#23 lore raw

PATCH v2 11/22 drm/xe: Check for primary GT before looking up Wa_22019338487

In reply to Matt Roper

If the primary GT is disabled via configfs, we need to make sure that we don't search for this workaround on a NULL xe_gt pointer. Since we can only disable the primary GT on igpu platforms, the media GT is the one we'd want to check anyway for this workaround.

The ternary operators in ggtt_update_access_counter() were getting a bit long/complicated, so rewrite them with regular if/else statements. While we're at it, throw in a couple extra assertions to make sure that we're truly picking the expected GT according to igpu/dgpu type.

---
 drivers/gpu/drm/xe/xe_ggtt.c | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/xe_ggtt.c +20 -6
index 7fdd0a97a628..0ed9ffc3278d 100644
@@ -107,10 +107,23 @@ static unsigned int probe_gsm_size(struct pci_dev *pdev)
 static void ggtt_update_access_counter(struct xe_ggtt *ggtt)
 {
 	struct xe_tile *tile = ggtt->tile;
-	struct xe_gt *affected_gt = XE_GT_WA(tile->primary_gt, 22019338487) ?
-		tile->primary_gt : tile->media_gt;
-	struct xe_mmio *mmio = &affected_gt->mmio;
-	u32 max_gtt_writes = XE_GT_WA(ggtt->tile->primary_gt, 22019338487) ? 1100 : 63;
+	struct xe_gt *affected_gt;
+	u32 max_gtt_writes;
+
+	if (tile->primary_gt && XE_GT_WA(tile->primary_gt, 22019338487)) {
+		affected_gt = tile->primary_gt;
+		max_gtt_writes = 1100;
+
+		/* Only expected to apply to primary GT on dgpu platforms */
+		xe_tile_assert(tile, IS_DGFX(tile_to_xe(tile)));
+	} else {
+		affected_gt = tile->media_gt;
+		max_gtt_writes = 63;
+
+		/* Only expected to apply to media GT on igpu platforms */
+		xe_tile_assert(tile, !IS_DGFX(tile_to_xe(tile)));
+	}
+
 	/*
 	 * Wa_22019338487: GMD_ID is a RO register, a dummy write forces gunit
 	 * to wait for completion of prior GTT writes before letting this through.
@@ -119,7 +132,7 @@ static void ggtt_update_access_counter(struct xe_ggtt *ggtt)
 	lockdep_assert_held(&ggtt->lock);
 
 	if ((++ggtt->access_count % max_gtt_writes) == 0) {
-		xe_mmio_write32(mmio, GMD_ID, 0x0);
+		xe_mmio_write32(&affected_gt->mmio, GMD_ID, 0x0);
 		ggtt->access_count = 0;
 	}
 }
@@ -286,7 +299,8 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
 	if (GRAPHICS_VERx100(xe) >= 1270)
 		ggtt->pt_ops = (ggtt->tile->media_gt &&
 			       XE_GT_WA(ggtt->tile->media_gt, 22019338487)) ||
-			       XE_GT_WA(ggtt->tile->primary_gt, 22019338487) ?
+			       (ggtt->tile->primary_gt &&
+				XE_GT_WA(ggtt->tile->primary_gt, 22019338487)) ?
 			       &xelpg_pt_wa_ops : &xelpg_pt_ops;
 	else
 		ggtt->pt_ops = &xelp_pt_ops;
Signature · 1 line
2.51.0
author
#24 lore raw

PATCH v2 12/22 drm/xe: Make display part of Wa_22019338487 a device workaround

In reply to Matt Roper

The display part of Wa_22019338487 (i.e., avoiding use of stolen memory) is using a platform test rather than an graphics/media IP test. Since this workaround is focused on non-GT uses of stolen memory, it makes sense that we'd want to still apply the workaround on affected platforms even if the GTs themselves are disabled via configfs.

---
 drivers/gpu/drm/xe/display/intel_fbdev_fb.c   | 4 ++--
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 4 ++--
 drivers/gpu/drm/xe/xe_device_wa_oob.rules     | 1 +
 drivers/gpu/drm/xe/xe_wa_oob.rules            | 1 -
 4 files changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/xe/display/intel_fbdev_fb.c +2 -2
index 35a5b07eeba4..af72f7305e5a 100644
@@ -10,7 +10,7 @@
 #include "xe_ttm_stolen_mgr.h"
 #include "xe_wa.h"
 
-#include <generated/xe_wa_oob.h>
+#include <generated/xe_device_wa_oob.h>
 
 struct drm_gem_object *intel_fbdev_fb_bo_create(struct drm_device *drm, int size)
 {
@@ -19,7 +19,7 @@ struct drm_gem_object *intel_fbdev_fb_bo_create(struct drm_device *drm, int size
 
 	obj = ERR_PTR(-ENODEV);
 
-	if (!IS_DGFX(xe) && !XE_GT_WA(xe_root_mmio_gt(xe), 22019338487_display)) {
+	if (!IS_DGFX(xe) && !XE_DEVICE_WA(xe, 22019338487_display)) {
 		obj = xe_bo_create_pin_map_novm(xe, xe_device_get_root_tile(xe),
 						size,
 						ttm_bo_type_kernel, XE_BO_FLAG_SCANOUT |
drivers/gpu/drm/xe/display/xe_plane_initial.c +2 -2
index 94f00def811b..12d25c5290fd 100644
@@ -25,7 +25,7 @@
 #include "xe_vram_types.h"
 #include "xe_wa.h"
 
-#include <generated/xe_wa_oob.h>
+#include <generated/xe_device_wa_oob.h>
 
 void intel_plane_initial_vblank_wait(struct intel_crtc *crtc)
 {
@@ -123,7 +123,7 @@ initial_plane_bo(struct xe_device *xe,
 		phys_base = base;
 		flags |= XE_BO_FLAG_STOLEN;
 
-		if (XE_GT_WA(xe_root_mmio_gt(xe), 22019338487_display))
+		if (XE_DEVICE_WA(xe, 22019338487_display))
 			return NULL;
 
 		/*
drivers/gpu/drm/xe/xe_device_wa_oob.rules +1 -0
index 3a0c4ccc4224..3cc93f0e77f8 100644
@@ -1,2 +1,3 @@
 15015404425     PLATFORM(LUNARLAKE)
 		PLATFORM(PANTHERLAKE)
+22019338487_display	PLATFORM(LUNARLAKE)
drivers/gpu/drm/xe/xe_wa_oob.rules +0 -1
index f3a6d5d239ce..eb761d30e066 100644
@@ -45,7 +45,6 @@
 22019338487	MEDIA_VERSION(2000)
 		GRAPHICS_VERSION(2001), FUNC(xe_rtp_match_not_sriov_vf)
 		MEDIA_VERSION(3000), MEDIA_STEP(A0, B0), FUNC(xe_rtp_match_not_sriov_vf)
-22019338487_display	PLATFORM(LUNARLAKE)
 16023588340	GRAPHICS_VERSION(2001), FUNC(xe_rtp_match_not_sriov_vf)
 14019789679	GRAPHICS_VERSION(1255)
 		GRAPHICS_VERSION_RANGE(1270, 2004)
Signature · 1 line
2.51.0
author
#25 lore raw

PATCH v2 13/22 drm/xe/irq: Don't try to lookup engine masks for non-existent primary GT

In reply to Matt Roper

If the primary GT is disabled via configfs, we shouldn't try to access it to lookup BCS/CCS engine masks. For the purposes of IRQ reset (which masks & disables interrupts in an sgunit register), assume all possible instances are present.

---
 drivers/gpu/drm/xe/xe_irq.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_irq.c +8 -4
index 5018a116852f..eaca56df08e4 100644
@@ -494,11 +494,15 @@ static irqreturn_t dg1_irq_handler(int irq, void *arg)
 static void gt_irq_reset(struct xe_tile *tile)
 {
 	struct xe_mmio *mmio = &tile->mmio;
+	u32 ccs_mask = ~0;
+	u32 bcs_mask = ~0;
 
-	u32 ccs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
-						   XE_ENGINE_CLASS_COMPUTE);
-	u32 bcs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
-						   XE_ENGINE_CLASS_COPY);
+	if (tile->primary_gt) {
+		ccs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
+						       XE_ENGINE_CLASS_COMPUTE);
+		bcs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
+						       XE_ENGINE_CLASS_COPY);
+	}
 
 	/* Disable RCS, BCS, VCS and VECS class engines. */
 	xe_mmio_write32(mmio, RENDER_COPY_INTR_ENABLE, 0);
Signature · 1 line
2.51.0
Reviewed-by on v2 13/22
#26 lore raw

RE: [PATCH v2 13/22] drm/xe/irq: Don't try to lookup engine masks for non-existent primary GT

Quoted 34 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matt Roper
Sent: 26 September 2025 05:17
To: [email protected]
Cc: Roper, Matthew D <[email protected]>
Subject: [PATCH v2 13/22] drm/xe/irq: Don't try to lookup engine masks for non-existent primary GT

If the primary GT is disabled via configfs, we shouldn't try to access it to lookup BCS/CCS engine masks. For the purposes of IRQ reset (which masks & disables interrupts in an sgunit register), assume all possible instances are present.

---
 drivers/gpu/drm/xe/xe_irq.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_irq.c index renamed from drivers/gpu/drm/xe/xe_irq.c +0 -0

5018a116852f..eaca56df08e4 100644

drivers/gpu/drm/xe/xe_irq.c +2 -2
@@ -494,11 +494,15 @@ static irqreturn_t dg1_irq_handler(int irq, void
 *arg)  static void gt_irq_reset(struct xe_tile *tile)  {
 	struct xe_mmio *mmio = &tile->mmio;
+	u32 ccs_mask = ~0;
+	u32 bcs_mask = ~0;
 
-	u32 ccs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
-
 XE_ENGINE_CLASS_COMPUTE);

drivers/gpu/drm/xe/xe_irq.c static irqreturn_t dg1_irq_handler(int irq, void · line 507

Quoted 10 lines
drivers/gpu/drm/xe/xe_irq.c +6 -2
-	u32 bcs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
-						   XE_ENGINE_CLASS_COPY);
+	if (tile->primary_gt) {
+		ccs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
+
 XE_ENGINE_CLASS_COMPUTE);
+		bcs_mask = xe_hw_engine_mask_per_class(tile->primary_gt,
+
 XE_ENGINE_CLASS_COPY);
+	}

Tejas

Quoted 5 lines
drivers/gpu/drm/xe/xe_irq.c +0 -0
 	/* Disable RCS, BCS, VCS and VECS class engines. */

xe_mmio_write32(mmio, RENDER_COPY_INTR_ENABLE, 0);
--
2.51.0

author
#27 lore raw

PATCH v2 14/22 drm/xe: Handle Wa_22010954014 and Wa_14022085890 as device workarounds

In reply to Matt Roper

When Wa_22010954014 and Wa_14022085890 were first implemented, we didn't have a device workaround infrastructure so we hacked them into the GT workaround list. Now that we have proper device workaround support, move them to the proper place. Note that Wa_14022085890 specifically applies to BMG-G21 platforms, so this requires defining a BMG subplatform to capture the correct subset of device IDs.

---
 drivers/gpu/drm/xe/xe_device_wa_oob.rules | 2 ++
 drivers/gpu/drm/xe/xe_guc_pc.c            | 3 ++-
 drivers/gpu/drm/xe/xe_pci.c               | 6 ++++++
 drivers/gpu/drm/xe/xe_platform_types.h    | 1 +
 drivers/gpu/drm/xe/xe_wa.c                | 2 +-
 drivers/gpu/drm/xe/xe_wa_oob.rules        | 5 -----
 include/drm/intel/pciids.h                | 7 +++++--
 7 files changed, 17 insertions(+), 9 deletions(-)
drivers/gpu/drm/xe/xe_device_wa_oob.rules +2 -0
index 3cc93f0e77f8..55ba01bc8f38 100644
@@ -1,3 +1,5 @@
+22010954014	PLATFORM(DG2)
 15015404425     PLATFORM(LUNARLAKE)
 		PLATFORM(PANTHERLAKE)
 22019338487_display	PLATFORM(LUNARLAKE)
+14022085890	SUBPLATFORM(BATTLEMAGE, G21)
drivers/gpu/drm/xe/xe_guc_pc.c +2 -1
index 3c0feb50a1e2..ff22235857f8 100644
@@ -14,6 +14,7 @@
 
 #include <drm/drm_managed.h>
 #include <drm/drm_print.h>
+#include <generated/xe_device_wa_oob.h>
 #include <generated/xe_wa_oob.h>
 
 #include "abi/guc_actions_slpc_abi.h"
@@ -886,7 +887,7 @@ static int pc_adjust_freq_bounds(struct xe_guc_pc *pc)
 	if (pc_get_min_freq(pc) > pc->rp0_freq)
 		ret = pc_set_min_freq(pc, pc->rp0_freq);
 
-	if (XE_GT_WA(tile->primary_gt, 14022085890))
+	if (XE_DEVICE_WA(tile_to_xe(tile), 14022085890))
 		ret = pc_set_min_freq(pc, max(BMG_MIN_FREQ, pc_get_min_freq(pc)));
 
 out:
drivers/gpu/drm/xe/xe_pci.c +6 -0
index bd21940a6541..84b373dccee1 100644
@@ -322,6 +322,8 @@ static const struct xe_device_desc lnl_desc = {
 	.needs_scratch = true,
 };
 
+static const u16 bmg_g21_ids[] = { INTEL_BMG_G21_IDS(NOP), 0 };
+
 static const struct xe_device_desc bmg_desc = {
 	DGFX_FEATURES,
 	PLATFORM(BATTLEMAGE),
@@ -336,6 +338,10 @@ static const struct xe_device_desc bmg_desc = {
 	.has_sriov = true,
 	.max_gt_per_tile = 2,
 	.needs_scratch = true,
+	.subplatforms = (const struct xe_subplatform_desc[]) {
+		{ XE_SUBPLATFORM_BATTLEMAGE_G21, "G21", bmg_g21_ids },
+		{ }
+	},
 };
 
 static const struct xe_device_desc ptl_desc = {
drivers/gpu/drm/xe/xe_platform_types.h +1 -0
index d08574c4cdb8..3e332214c7bb 100644
@@ -34,6 +34,7 @@ enum xe_subplatform {
 	XE_SUBPLATFORM_DG2_G10,
 	XE_SUBPLATFORM_DG2_G11,
 	XE_SUBPLATFORM_DG2_G12,
+	XE_SUBPLATFORM_BATTLEMAGE_G21,
 };
 
 #endif
drivers/gpu/drm/xe/xe_wa.c +1 -1
index cd03891654a1..68987e2825ad 100644
@@ -1127,6 +1127,6 @@ void xe_wa_apply_tile_workarounds(struct xe_tile *tile)
 	if (IS_SRIOV_VF(tile->xe))
 		return;
 
-	if (XE_GT_WA(tile->primary_gt, 22010954014))
+	if (XE_DEVICE_WA(tile->xe, 22010954014))
 		xe_mmio_rmw32(mmio, XEHP_CLOCK_GATE_DIS, 0, SGSI_SIDECLK_DIS);
 }
drivers/gpu/drm/xe/xe_wa_oob.rules +0 -5
index eb761d30e066..113a62f1b541 100644
@@ -14,7 +14,6 @@
 14016763929	SUBPLATFORM(DG2, G10)
 		SUBPLATFORM(DG2, G12)
 16017236439	PLATFORM(PVC)
-22010954014	PLATFORM(DG2)
 14019821291	MEDIA_VERSION_RANGE(1300, 2000)
 14015076503	MEDIA_VERSION(1300)
 16020292621	GRAPHICS_VERSION(2004), GRAPHICS_STEP(A0, B0)
@@ -74,9 +73,5 @@
 16023683509	MEDIA_VERSION(2000), FUNC(xe_rtp_match_psmi_enabled)
 		MEDIA_VERSION(3000), MEDIA_STEP(A0, B0), FUNC(xe_rtp_match_psmi_enabled)
 
-# SoC workaround - currently applies to all platforms with the following
-# primary GT GMDID
-14022085890	GRAPHICS_VERSION(2001)
-
 15015404425_disable	PLATFORM(PANTHERLAKE), MEDIA_STEP(B0, FOREVER)
 16026007364    MEDIA_VERSION(3000)
include/drm/intel/pciids.h +5 -2
index 69d4ae92d822..452c1de606ff 100644
@@ -849,7 +849,7 @@
 	MACRO__(0x64B0, ## __VA_ARGS__)
 
 /* BMG */
-#define INTEL_BMG_IDS(MACRO__, ...) \
+#define INTEL_BMG_G21_IDS(MACRO__, ...) \
 	MACRO__(0xE202, ## __VA_ARGS__), \
 	MACRO__(0xE209, ## __VA_ARGS__), \
 	MACRO__(0xE20B, ## __VA_ARGS__), \
@@ -858,7 +858,10 @@
 	MACRO__(0xE210, ## __VA_ARGS__), \
 	MACRO__(0xE211, ## __VA_ARGS__), \
 	MACRO__(0xE212, ## __VA_ARGS__), \
-	MACRO__(0xE216, ## __VA_ARGS__), \
+	MACRO__(0xE216, ## __VA_ARGS__)
+
+#define INTEL_BMG_IDS(MACRO__, ...) \
+	INTEL_BMG_G21_IDS(MACRO__, __VA_ARGS__), \
 	MACRO__(0xE220, ## __VA_ARGS__), \
 	MACRO__(0xE221, ## __VA_ARGS__), \
 	MACRO__(0xE222, ## __VA_ARGS__), \
Signature · 1 line
2.51.0
author
#28 lore raw

PATCH v2 15/22 drm/xe/rtp: Pass xe_device parameter to FUNC matches

In reply to Matt Roper

FUNC matches in RTP only pass the GT and hwe, preventing them from being used effectively in device workarounds. Add an additional xe_device parameter so that we can use them in device workarounds where a GT may not be available.

---
 drivers/gpu/drm/xe/tests/xe_rtp_test.c |  6 ++++--
 drivers/gpu/drm/xe/xe_hw_engine.c      | 10 ++++++----
 drivers/gpu/drm/xe/xe_reg_whitelist.c  |  3 ++-
 drivers/gpu/drm/xe/xe_rtp.c            | 24 +++++++++++++-----------
 drivers/gpu/drm/xe/xe_rtp.h            | 18 +++++++++++++-----
 drivers/gpu/drm/xe/xe_rtp_types.h      |  4 +++-
 6 files changed, 41 insertions(+), 24 deletions(-)
drivers/gpu/drm/xe/tests/xe_rtp_test.c +4 -2
index b0254b014fe4..d2255a59e58f 100644
@@ -48,12 +48,14 @@ struct rtp_test_case {
 	const struct xe_rtp_entry *entries;
 };
 
-static bool match_yes(const struct xe_gt *gt, const struct xe_hw_engine *hwe)
+static bool match_yes(const struct xe_device *xe, const struct xe_gt *gt,
+		      const struct xe_hw_engine *hwe)
 {
 	return true;
 }
 
-static bool match_no(const struct xe_gt *gt, const struct xe_hw_engine *hwe)
+static bool match_no(const struct xe_device *xe, const struct xe_gt *gt,
+		     const struct xe_hw_engine *hwe)
 {
 	return false;
 }
drivers/gpu/drm/xe/xe_hw_engine.c +6 -4
index 1cf623b4a5bc..cba4375525c7 100644
@@ -346,17 +346,19 @@ void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe)
 	xe_hw_engine_mmio_read32(hwe, RING_MI_MODE(0));
 }
 
-static bool xe_hw_engine_match_fixed_cslice_mode(const struct xe_gt *gt,
+static bool xe_hw_engine_match_fixed_cslice_mode(const struct xe_device *xe,
+						 const struct xe_gt *gt,
 						 const struct xe_hw_engine *hwe)
 {
 	return xe_gt_ccs_mode_enabled(gt) &&
-	       xe_rtp_match_first_render_or_compute(gt, hwe);
+	       xe_rtp_match_first_render_or_compute(xe, gt, hwe);
 }
 
-static bool xe_rtp_cfeg_wmtp_disabled(const struct xe_gt *gt,
+static bool xe_rtp_cfeg_wmtp_disabled(const struct xe_device *xe,
+				      const struct xe_gt *gt,
 				      const struct xe_hw_engine *hwe)
 {
-	if (GRAPHICS_VER(gt_to_xe(gt)) < 20)
+	if (GRAPHICS_VER(xe) < 20)
 		return false;
 
 	if (hwe->class != XE_ENGINE_CLASS_COMPUTE &&
drivers/gpu/drm/xe/xe_reg_whitelist.c +2 -1
index 23f6c81d9994..690bc327a363 100644
@@ -19,7 +19,8 @@
 #undef XE_REG_MCR
 #define XE_REG_MCR(...)     XE_REG(__VA_ARGS__, .mcr = 1)
 
-static bool match_not_render(const struct xe_gt *gt,
+static bool match_not_render(const struct xe_device *xe,
+			     const struct xe_gt *gt,
 			     const struct xe_hw_engine *hwe)
 {
 	return hwe->class != XE_ENGINE_CLASS_RENDER;
drivers/gpu/drm/xe/xe_rtp.c +13 -11
index b5f430d59f80..66707cc89ec9 100644
@@ -133,10 +133,7 @@ static bool rule_matches(const struct xe_device *xe,
 			match = hwe->class != r->engine_class;
 			break;
 		case XE_RTP_MATCH_FUNC:
-			if (drm_WARN_ON(&xe->drm, !gt))
-				return false;
-
-			match = r->match_func(gt, hwe);
+			match = r->match_func(xe, gt, hwe);
 			break;
 		default:
 			drm_warn(&xe->drm, "Invalid RTP match %u\n",
@@ -343,13 +340,15 @@ void xe_rtp_process(struct xe_rtp_process_ctx *ctx,
 }
 EXPORT_SYMBOL_IF_KUNIT(xe_rtp_process);
 
-bool xe_rtp_match_even_instance(const struct xe_gt *gt,
+bool xe_rtp_match_even_instance(const struct xe_device *xe,
+				const struct xe_gt *gt,
 				const struct xe_hw_engine *hwe)
 {
 	return hwe->instance % 2 == 0;
 }
 
-bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt,
+bool xe_rtp_match_first_render_or_compute(const struct xe_device *xe,
+					  const struct xe_gt *gt,
 					  const struct xe_hw_engine *hwe)
 {
 	u64 render_compute_mask = gt->info.engine_mask &
@@ -359,19 +358,22 @@ bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt,
 		hwe->engine_id == __ffs(render_compute_mask);
 }
 
-bool xe_rtp_match_not_sriov_vf(const struct xe_gt *gt,
+bool xe_rtp_match_not_sriov_vf(const struct xe_device *xe,
+			       const struct xe_gt *gt,
 			       const struct xe_hw_engine *hwe)
 {
-	return !IS_SRIOV_VF(gt_to_xe(gt));
+	return !IS_SRIOV_VF(xe);
 }
 
-bool xe_rtp_match_psmi_enabled(const struct xe_gt *gt,
+bool xe_rtp_match_psmi_enabled(const struct xe_device *xe,
+			       const struct xe_gt *gt,
 			       const struct xe_hw_engine *hwe)
 {
-	return xe_configfs_get_psmi_enabled(to_pci_dev(gt_to_xe(gt)->drm.dev));
+	return xe_configfs_get_psmi_enabled(to_pci_dev(xe->drm.dev));
 }
 
-bool xe_rtp_match_gt_has_discontiguous_dss_groups(const struct xe_gt *gt,
+bool xe_rtp_match_gt_has_discontiguous_dss_groups(const struct xe_device *xe,
+						  const struct xe_gt *gt,
 						  const struct xe_hw_engine *hwe)
 {
 	return xe_gt_has_discontiguous_dss_groups(gt);
drivers/gpu/drm/xe/xe_rtp.h +13 -5
index ac12ddf6cde6..e5b8a9452e29 100644
@@ -440,18 +440,21 @@ void xe_rtp_process(struct xe_rtp_process_ctx *ctx,
 
 /**
  * xe_rtp_match_even_instance - Match if engine instance is even
+ * @xe: Device structure
  * @gt: GT structure
  * @hwe: Engine instance
  *
  * Returns: true if engine instance is even, false otherwise
  */
-bool xe_rtp_match_even_instance(const struct xe_gt *gt,
+bool xe_rtp_match_even_instance(const struct xe_device *xe,
+				const struct xe_gt *gt,
 				const struct xe_hw_engine *hwe);
 
 /*
  * xe_rtp_match_first_render_or_compute - Match if it's first render or compute
  * engine in the GT
  *
+ * @xe: Device structure
  * @gt: GT structure
  * @hwe: Engine instance
  *
@@ -463,24 +466,29 @@ bool xe_rtp_match_even_instance(const struct xe_gt *gt,
  * Returns: true if engine id is the first to match the render reset domain,
  * false otherwise.
  */
-bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt,
+bool xe_rtp_match_first_render_or_compute(const struct xe_device *xe,
+					  const struct xe_gt *gt,
 					  const struct xe_hw_engine *hwe);
 
 /*
  * xe_rtp_match_not_sriov_vf - Match when not on SR-IOV VF device
  *
+ * @xe: Device structure
  * @gt: GT structure
  * @hwe: Engine instance
  *
  * Returns: true if device is not VF, false otherwise.
  */
-bool xe_rtp_match_not_sriov_vf(const struct xe_gt *gt,
+bool xe_rtp_match_not_sriov_vf(const struct xe_device *xe,
+			       const struct xe_gt *gt,
 			       const struct xe_hw_engine *hwe);
 
-bool xe_rtp_match_psmi_enabled(const struct xe_gt *gt,
+bool xe_rtp_match_psmi_enabled(const struct xe_device *xe,
+			       const struct xe_gt *gt,
 			       const struct xe_hw_engine *hwe);
 
-bool xe_rtp_match_gt_has_discontiguous_dss_groups(const struct xe_gt *gt,
+bool xe_rtp_match_gt_has_discontiguous_dss_groups(const struct xe_device *xe,
+						  const struct xe_gt *gt,
 						  const struct xe_hw_engine *hwe);
 
 #endif
drivers/gpu/drm/xe/xe_rtp_types.h +3 -1
index f4cf30e298cf..6ba7f226c227 100644
@@ -10,6 +10,7 @@
 
 #include "regs/xe_reg_defs.h"
 
+struct xe_device;
 struct xe_hw_engine;
 struct xe_gt;
 
@@ -86,7 +87,8 @@ struct xe_rtp_rule {
 			u8 engine_class;
 		};
 		/* MATCH_FUNC */
-		bool (*match_func)(const struct xe_gt *gt,
+		bool (*match_func)(const struct xe_device *xe,
+				   const struct xe_gt *gt,
 				   const struct xe_hw_engine *hwe);
 	};
 };
Signature · 1 line
2.51.0
author
#29 lore raw

PATCH v2 16/22 drm/xe: Bypass Wa_14018094691 when primary GT is disabled

In reply to Matt Roper

Don't try to lookup Wa_14018094691 on a NULL GT when the primary GT is disabled. If the primary GT is disabled, there's no mid-thread preemption happening which would make this workaround relevant anyway.

---
 drivers/gpu/drm/xe/xe_gsc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_gsc.c +2 -2
index 83d61bf8ec62..dd69cb834f8e 100644
@@ -266,7 +266,7 @@ static int gsc_upload_and_init(struct xe_gsc *gsc)
 	unsigned int fw_ref;
 	int ret;
 
-	if (XE_GT_WA(tile->primary_gt, 14018094691)) {
+	if (tile->primary_gt && XE_GT_WA(tile->primary_gt, 14018094691)) {
 		fw_ref = xe_force_wake_get(gt_to_fw(tile->primary_gt), XE_FORCEWAKE_ALL);
 
 		/*
@@ -281,7 +281,7 @@ static int gsc_upload_and_init(struct xe_gsc *gsc)
 
 	ret = gsc_upload(gsc);
 
-	if (XE_GT_WA(tile->primary_gt, 14018094691))
+	if (tile->primary_gt && XE_GT_WA(tile->primary_gt, 14018094691))
 		xe_force_wake_put(gt_to_fw(tile->primary_gt), fw_ref);
 
 	if (ret)
Signature · 1 line
2.51.0
author
#30 lore raw

PATCH v2 17/22 drm/xe: Correct lineage for Wa_22014953428 and only check with valid GT

In reply to Matt Roper

Wa_22014953428 was incorrectly labelled with a release-specific ID number rather than the cross-platform lineage number; fix that. Also check that the GT is not NULL before trying to lookup the workaround in it. Since this workaround only applies to DG2 discrete GPUs (where the primary GT cannot be disabled), no coverage is lost.

---
 drivers/gpu/drm/xe/xe_vm.c         | 3 ++-
 drivers/gpu/drm/xe/xe_wa_oob.rules | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_vm.c +2 -1
index 80b7f13ecd80..1677ae729e85 100644
@@ -1886,6 +1886,7 @@ int xe_vm_create_ioctl(struct drm_device *dev, void *data,
 	struct xe_device *xe = to_xe_device(dev);
 	struct xe_file *xef = to_xe_file(file);
 	struct drm_xe_vm_create *args = data;
+	struct xe_gt *wa_gt = xe_root_mmio_gt(xe);
 	struct xe_vm *vm;
 	u32 id;
 	int err;
@@ -1894,7 +1895,7 @@ int xe_vm_create_ioctl(struct drm_device *dev, void *data,
 	if (XE_IOCTL_DBG(xe, args->extensions))
 		return -EINVAL;
 
-	if (XE_GT_WA(xe_root_mmio_gt(xe), 14016763929))
+	if (wa_gt && XE_GT_WA(wa_gt, 22014953428))
 		args->flags |= DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE;
 
 	if (XE_IOCTL_DBG(xe, args->flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE &&
drivers/gpu/drm/xe/xe_wa_oob.rules +1 -1
index 113a62f1b541..4bb94e5799ed 100644
@@ -11,7 +11,7 @@
 18020744125	PLATFORM(PVC)
 1509372804	PLATFORM(PVC), GRAPHICS_STEP(A0, C0)
 1409600907	GRAPHICS_VERSION_RANGE(1200, 1250)
-14016763929	SUBPLATFORM(DG2, G10)
+22014953428	SUBPLATFORM(DG2, G10)
 		SUBPLATFORM(DG2, G12)
 16017236439	PLATFORM(PVC)
 14019821291	MEDIA_VERSION_RANGE(1300, 2000)
Signature · 1 line
2.51.0
author
#31 lore raw

PATCH v2 18/22 drm/xe: Check that GT is not NULL before testing Wa_16023588340

In reply to Matt Roper

If the primary GT is disabled, skip the check for this workaround (which only applies to dgpu platforms where the primary GT cannot be NULL).

---
 drivers/gpu/drm/xe/display/xe_display_wa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/display/xe_display_wa.c +2 -1
index 8ada1cbcb16c..2aa1b8c03411 100644
@@ -13,6 +13,7 @@
 bool intel_display_needs_wa_16023588340(struct intel_display *display)
 {
 	struct xe_device *xe = to_xe_device(display->drm);
+	struct xe_gt *wa_gt = xe_root_mmio_gt(xe);
 
-	return XE_GT_WA(xe_root_mmio_gt(xe), 16023588340);
+	return wa_gt && XE_GT_WA(wa_gt, 16023588340);
 }
Signature · 1 line
2.51.0
Reviewed-by on v2 18/22
#32 lore raw

RE: [PATCH v2 18/22] drm/xe: Check that GT is not NULL before testing Wa_16023588340

Quoted 25 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matt Roper
Sent: 26 September 2025 05:17
To: [email protected]
Cc: Roper, Matthew D <[email protected]>
Subject: [PATCH v2 18/22] drm/xe: Check that GT is not NULL before testing Wa_16023588340

If the primary GT is disabled, skip the check for this workaround (which only applies to dgpu platforms where the primary GT cannot be NULL).

---
 drivers/gpu/drm/xe/display/xe_display_wa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/display/xe_display_wa.c +0 -0
index 8ada1cbcb16c..2aa1b8c03411 100644

drivers/gpu/drm/xe/display/xe_display_wa.c line 17

Quoted 6 lines
drivers/gpu/drm/xe/display/xe_display_wa.c +2 -1
@@ -13,6 +13,7 @@
 bool intel_display_needs_wa_16023588340(struct intel_display *display)  {
 	struct xe_device *xe = to_xe_device(display->drm);
+	struct xe_gt *wa_gt = xe_root_mmio_gt(xe);
 
-	return XE_GT_WA(xe_root_mmio_gt(xe), 16023588340);
+	return wa_gt && XE_GT_WA(wa_gt, 16023588340);

Should we add fixes?, anyways

Quoted 3 lines
drivers/gpu/drm/xe/display/xe_display_wa.c +0 -1
 }
--

2.51.0

author
#33 lore raw

Re: [PATCH v2 18/22] drm/xe: Check that GT is not NULL before testing Wa_16023588340

Quoted 29 lines · Tejas
Quoted 29 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matt Roper
Sent: 26 September 2025 05:17
To: [email protected]
Cc: Roper, Matthew D <[email protected]>
Subject: [PATCH v2 18/22] drm/xe: Check that GT is not NULL before testing Wa_16023588340

If the primary GT is disabled, skip the check for this workaround (which only applies to dgpu platforms where the primary GT cannot be NULL).

---
 drivers/gpu/drm/xe/display/xe_display_wa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/display/xe_display_wa.c +1 -0
index 8ada1cbcb16c..2aa1b8c03411 100644
@@ -13,6 +13,7 @@
 bool intel_display_needs_wa_16023588340(struct intel_display *display)  {
 	struct xe_device *xe = to_xe_device(display->drm);
+	struct xe_gt *wa_gt = xe_root_mmio_gt(xe);
 
Quoted 4 lines

drivers/gpu/drm/xe/display/xe_display_wa.c line 18

Quoted 2 lines
drivers/gpu/drm/xe/display/xe_display_wa.c +1 -1
-	return XE_GT_WA(xe_root_mmio_gt(xe), 16023588340);
+	return wa_gt && XE_GT_WA(wa_gt, 16023588340);

Should we add fixes?, anyways

No need for fixes since the current code is fine today (the GT is always non-NULL). This is just preparing for future changes that will allow it to start being NULL.

Matt

Quoted 7 lines
Quoted 3 lines
drivers/gpu/drm/xe/display/xe_display_wa.c +0 -1
 }
--

2.51.0

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#34 lore raw

PATCH v2 19/22 drm/xe: Don't check BIOS-disabled FlatCCS if primary GT is disabled

In reply to Matt Roper

If the primary is GT is disabled via configfs, we can't read the GT registers that would tell us whether the BIOS has disabled FlatCCS on a platform that would otherwise have it; we'll just proceed as if the FlatCCS is still enabled. This is similar to the situation seen by SRIOV VFs and doesn't cause any functional problems since the hardware will simply drop writes to the CCS region and reads will always come back as 0 (indicating uncompressed data). We'll simply miss out on the chance to avoid some unnecessary overhead during BO creation and migration.

---
 drivers/gpu/drm/xe/xe_device.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/xe/xe_device.c +2 -0
index bf99792e772c..0b4fa7769f05 100644
@@ -781,6 +781,8 @@ static int probe_has_flat_ccs(struct xe_device *xe)
 		return 0;
 
 	gt = xe_root_mmio_gt(xe);
+	if (!gt)
+		return 0;
 
 	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
 	if (!fw_ref)
Signature · 1 line
2.51.0
author
#35 lore raw

PATCH v2 20/22 drm/xe: Break GT setup out of xe_info_init()

In reply to Matt Roper

xe_info_init() is getting a bit long and hard to follow. Break the allocation and basic initialization of the xe_gt structures out to their own functions.

---
 drivers/gpu/drm/xe/xe_pci.c | 88 +++++++++++++++++++++++--------------
 1 file changed, 54 insertions(+), 34 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +54 -34
index 84b373dccee1..df5b39d70b80 100644
@@ -664,6 +664,53 @@ static void xe_info_probe_tile_count(struct xe_device *xe)
 	}
 }
 
+static struct xe_gt *init_primary_gt(struct xe_tile *tile,
+				     const struct xe_graphics_desc *graphics_desc,
+				     const struct xe_media_desc *media_desc)
+{
+	struct xe_device *xe = tile_to_xe(tile);
+	struct xe_gt *gt;
+
+	gt = xe_gt_alloc(tile);
+	if (IS_ERR(gt))
+		return gt;
+
+	gt->info.type = XE_GT_TYPE_MAIN;
+	gt->info.id = tile->id * xe->info.max_gt_per_tile;
+	gt->info.has_indirect_ring_state = graphics_desc->has_indirect_ring_state;
+	gt->info.engine_mask = graphics_desc->hw_engine_mask;
+
+	/*
+	 * Before media version 13, the media IP was part of the primary GT
+	 * so we need to add the media engines to the primary GT's engine list.
+	 */
+	if (MEDIA_VER(xe) < 13 && media_desc)
+		gt->info.engine_mask |= media_desc->hw_engine_mask;
+
+	return gt;
+}
+
+static struct xe_gt *init_media_gt(struct xe_tile *tile,
+				   const struct xe_media_desc *media_desc)
+{
+	struct xe_device *xe = tile_to_xe(tile);
+	struct xe_gt *gt;
+
+	gt = xe_gt_alloc(tile);
+	if (IS_ERR(gt))
+		return gt;
+
+	if (MEDIA_VER(xe) < 13 || !media_desc)
+		return NULL;
+
+	gt->info.type = XE_GT_TYPE_MEDIA;
+	gt->info.id = tile->id * xe->info.max_gt_per_tile + 1;
+	gt->info.has_indirect_ring_state = media_desc->has_indirect_ring_state;
+	gt->info.engine_mask = media_desc->hw_engine_mask;
+
+	return gt;
+}
+
 /*
  * Initialize device info content that does require knowledge about
  * graphics / media IP version.
@@ -742,48 +789,21 @@ static int xe_info_init(struct xe_device *xe,
 			return err;
 	}
 
-	/*
-	 * All platforms have at least one primary GT.  Any platform with media
-	 * version 13 or higher has an additional dedicated media GT.  And
-	 * depending on the graphics IP there may be additional "remote tiles."
-	 * All of these together determine the overall GT count.
-	 */
+	/* Allocate any GT and VRAM structures necessary for the platform. */
 	for_each_tile(tile, xe, id) {
 		int err;
 
-		tile->primary_gt = xe_gt_alloc(tile);
+		err = xe_tile_alloc_vram(tile);
+		if (err)
+			return err;
+
+		tile->primary_gt = init_primary_gt(tile, graphics_desc, media_desc);
 		if (IS_ERR(tile->primary_gt))
 			return PTR_ERR(tile->primary_gt);
 
-		gt = tile->primary_gt;
-		gt->info.type = XE_GT_TYPE_MAIN;
-		gt->info.id = tile->id * xe->info.max_gt_per_tile;
-		gt->info.has_indirect_ring_state = graphics_desc->has_indirect_ring_state;
-		gt->info.engine_mask = graphics_desc->hw_engine_mask;
-
-		err = xe_tile_alloc_vram(tile);
-		if (err)
-			return err;
-
-		if (MEDIA_VER(xe) < 13 && media_desc)
-			gt->info.engine_mask |= media_desc->hw_engine_mask;
-
-		if (MEDIA_VER(xe) < 13 || !media_desc)
-			continue;
-
-		/*
-		 * Allocate and setup media GT for platforms with standalone
-		 * media.
-		 */
-		tile->media_gt = xe_gt_alloc(tile);
+		tile->media_gt = init_media_gt(tile, media_desc);
 		if (IS_ERR(tile->media_gt))
 			return PTR_ERR(tile->media_gt);
-
-		gt = tile->media_gt;
-		gt->info.type = XE_GT_TYPE_MEDIA;
-		gt->info.id = tile->id * xe->info.max_gt_per_tile + 1;
-		gt->info.has_indirect_ring_state = media_desc->has_indirect_ring_state;
-		gt->info.engine_mask = media_desc->hw_engine_mask;
 	}
 
 	/*
Signature · 1 line
2.51.0
author
#36 lore raw

PATCH v2 21/22 drm/xe/configfs: Add attribute to disable GT types

In reply to Matt Roper

Preventing the driver from initializing GTs of specific type(s) can be useful for debugging and early hardware bringup. Add a configfs attribute to allow this kind of control for debugging.

With today's platforms and software design, this configuration setting is only effective for disabling the media GT since the driver currently requires that there always be a primary GT to probe the device. However this might change in the future --- in theory it should be possible (with some additional driver work) to allow an igpu device to come up with only the media GT and no primary GT. Or to allow an igpu device to come up with no GTs at all (for display-only usage). A primary GT will likely always be required on dgpu platforms because we rely on the BCS engines inside the primary GT for various vram operations.

v2:
- Expand/clarify kerneldoc for configfs attribute. (Gustavo)
- Tighten type usage in gt_types[] structure. (Gustavo)
- Adjust string parsing/name matching to match exact GT names and not accept partial names. (Gustavo)

Cc Gustavo Sousa <[email protected]>
---
 drivers/gpu/drm/xe/xe_configfs.c | 130 +++++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h |   2 +
 drivers/gpu/drm/xe/xe_pci.c      |  37 ++++++++-
 3 files changed, 165 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_configfs.c +130 -0
index 139663423185..aaa98166f527 100644
@@ -15,6 +15,7 @@
 
 #include "instructions/xe_mi_commands.h"
 #include "xe_configfs.h"
+#include "xe_gt_types.h"
 #include "xe_hw_engine_types.h"
 #include "xe_module.h"
 #include "xe_pci_types.h"
@@ -56,6 +57,7 @@
  *	:
  *	└── 0000:03:00.0
  *	    ├── survivability_mode
+ *	    ├── gt_types_allowed
  *	    ├── engines_allowed
  *	    └── enable_psmi
  *
@@ -79,6 +81,44 @@
  *
  * This attribute can only be set before binding to the device.
  *
+ * Allowed GT types:
+ * -----------------
+ *
+ * Allow only specific types of GTs to be detected and initialized by the
+ * driver.  Any combination of GT types can be enabled/disabled, although
+ * some settings will cause the device to fail to probe.
+ *
+ * Writes support both comma- and newline-separated input format. Reads
+ * will always return one GT type per line. "primary" and "media" are the
+ * GT type names supported by this interface.
+ *
+ * This attribute can only be set before binding to the device.
+ *
+ * Examples:
+ *
+ * Allow both primary and media GTs to be initialized and used.  This matches
+ * the driver's default behavior::
+ *
+ *	# echo 'primary,media' > /sys/kernel/config/xe/0000:03:00.0/gt_types_allowed
+ *
+ * Allow only the primary GT of each tile to be initialized and used,
+ * effectively disabling the media GT if it exists on the platform::
+ *
+ *	# echo 'primary' > /sys/kernel/config/xe/0000:03:00.0/gt_types_allowed
+ *
+ * Allow only the media GT of each tile to be initialized and used,
+ * effectively disabling the primary GT.  **This configuration will cause
+ * device probe failure on all current platforms, but may be allowed on
+ * igpu platforms in the future**::
+ *
+ *	# echo 'media' > /sys/kernel/config/xe/0000:03:00.0/gt_types_allowed
+ *
+ * Disable all GTs.  Only other GPU IP (such as display) is potentially usable.
+ * **This configuration will cause device probe failure on all current
+ * platforms, but may be allowed on igpu platforms in the future**::
+ *
+ *	# echo '' > /sys/kernel/config/xe/0000:03:00.0/gt_types_allowed
+ *
  * Allowed engines:
  * ----------------
  *
@@ -187,6 +227,7 @@ struct xe_config_group_device {
 	struct config_group group;
 
 	struct xe_config_device {
+		u64 gt_types_allowed;
 		u64 engines_allowed;
 		struct wa_bb ctx_restore_post_bb[XE_ENGINE_CLASS_MAX];
 		struct wa_bb ctx_restore_mid_bb[XE_ENGINE_CLASS_MAX];
@@ -201,6 +242,7 @@ struct xe_config_group_device {
 };
 
 static const struct xe_config_device device_defaults = {
+	.gt_types_allowed = U64_MAX,
 	.engines_allowed = U64_MAX,
 	.survivability_mode = false,
 	.enable_psmi = false,
@@ -220,6 +262,7 @@ struct engine_info {
 /* Some helpful macros to aid on the sizing of buffer allocation when parsing */
 #define MAX_ENGINE_CLASS_CHARS 5
 #define MAX_ENGINE_INSTANCE_CHARS 2
+#define MAX_GT_TYPE_CHARS 7
 
 static const struct engine_info engine_info[] = {
 	{ .cls = "rcs", .mask = XE_HW_ENGINE_RCS_MASK, .engine_class = XE_ENGINE_CLASS_RENDER },
@@ -230,6 +273,14 @@ static const struct engine_info engine_info[] = {
 	{ .cls = "gsccs", .mask = XE_HW_ENGINE_GSCCS_MASK, .engine_class = XE_ENGINE_CLASS_OTHER },
 };
 
+static const struct {
+	const char name[MAX_GT_TYPE_CHARS + 1];
+	enum xe_gt_type type;
+} gt_types[] = {
+	{ .name = "primary", .type = XE_GT_TYPE_MAIN },
+	{ .name = "media", .type = XE_GT_TYPE_MEDIA },
+};
+
 static struct xe_config_group_device *to_xe_config_group_device(struct config_item *item)
 {
 	return container_of(to_config_group(item), struct xe_config_group_device, group);
@@ -292,6 +343,62 @@ static ssize_t survivability_mode_store(struct config_item *item, const char *pa
 	return len;
 }
 
+static ssize_t gt_types_allowed_show(struct config_item *item, char *page)
+{
+	struct xe_config_device *dev = to_xe_config_device(item);
+	char *p = page;
+
+	for (size_t i = 0; i < ARRAY_SIZE(gt_types); i++)
+		if (dev->gt_types_allowed & BIT_ULL(gt_types[i].type))
+			p += sprintf(p, "%s\n", gt_types[i].name);
+
+	return p - page;
+}
+
+static ssize_t gt_types_allowed_store(struct config_item *item, const char *page,
+				      size_t len)
+{
+	struct xe_config_group_device *dev = to_xe_config_group_device(item);
+	char *buf = kstrdup(page, GFP_KERNEL);
+	char *p = buf;
+	u64 typemask = 0;
+
+	if (!buf)
+		return -ENOMEM;
+
+	while (p) {
+		char *typename = strsep(&p, ",\n");
+		bool matched = false;
+
+		if (typename[0] == '\0')
+			continue;
+
+		for (size_t i = 0; i < ARRAY_SIZE(gt_types); i++) {
+			if (strcmp(typename, gt_types[i].name) == 0) {
+				typemask |= BIT(gt_types[i].type);
+				matched = true;
+				break;
+			}
+		}
+
+		if (!matched) {
+			len = -EINVAL;
+			goto out;
+		}
+	}
+
+	scoped_guard(mutex, &dev->lock) {
+		if (is_bound(dev))
+			return -EBUSY;
+
+		dev->config.gt_types_allowed = typemask;
+	}
+
+out:
+	kfree(buf);
+	return len;
+}
+
 static ssize_t engines_allowed_show(struct config_item *item, char *page)
 {
 	struct xe_config_device *dev = to_xe_config_device(item);
@@ -672,6 +779,7 @@ CONFIGFS_ATTR(, ctx_restore_mid_bb);
 CONFIGFS_ATTR(, ctx_restore_post_bb);
 CONFIGFS_ATTR(, enable_psmi);
 CONFIGFS_ATTR(, engines_allowed);
+CONFIGFS_ATTR(, gt_types_allowed);
 CONFIGFS_ATTR(, survivability_mode);
 
 static struct configfs_attribute *xe_config_device_attrs[] = {
@@ -679,6 +787,7 @@ static struct configfs_attribute *xe_config_device_attrs[] = {
 	&attr_ctx_restore_post_bb,
 	&attr_enable_psmi,
 	&attr_engines_allowed,
+	&attr_gt_types_allowed,
 	&attr_survivability_mode,
 	NULL,
 };
@@ -846,6 +955,7 @@ static void dump_custom_dev_config(struct pci_dev *pdev,
 				 dev->config.attr_); \
 	} while (0)
 
+	PRI_CUSTOM_ATTR("%llx", gt_types_allowed);
 	PRI_CUSTOM_ATTR("%llx", engines_allowed);
 	PRI_CUSTOM_ATTR("%d", enable_psmi);
 	PRI_CUSTOM_ATTR("%d", survivability_mode);
@@ -896,6 +1006,26 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
 	return mode;
 }
 
+/**
+ * xe_configfs_get_gt_types_allowed - get GT type allowed mask from configfs
+ * @pdev: pci device
+ *
+ * Return: GT type mask set in configfs
+ */
+u64 xe_configfs_get_gt_types_allowed(struct pci_dev *pdev)
+{
+	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
+	u64 mask;
+
+	if (!dev)
+		return device_defaults.gt_types_allowed;
+
+	mask = dev->config.gt_types_allowed;
+	config_group_put(&dev->group);
+
+	return mask;
+}
+
 /**
  * xe_configfs_get_engines_allowed - get engine allowed mask from configfs
  * @pdev: pci device
drivers/gpu/drm/xe/xe_configfs.h +2 -0
index c61e0e47ed94..c6ad8df9e913 100644
@@ -17,6 +17,7 @@ int xe_configfs_init(void);
 void xe_configfs_exit(void);
 void xe_configfs_check_device(struct pci_dev *pdev);
 bool xe_configfs_get_survivability_mode(struct pci_dev *pdev);
+u64 xe_configfs_get_gt_types_allowed(struct pci_dev *pdev);
 u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);
 bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev);
 u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,
@@ -28,6 +29,7 @@ static inline int xe_configfs_init(void) { return 0; }
 static inline void xe_configfs_exit(void) { }
 static inline void xe_configfs_check_device(struct pci_dev *pdev) { }
 static inline bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) { return false; }
+static inline u64 xe_configfs_get_gt_types_allowed(struct pci_dev *pdev) { return U64_MAX; }
 static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) { return U64_MAX; }
 static inline bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev) { return false; }
 static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,
drivers/gpu/drm/xe/xe_pci.c +33 -4
index df5b39d70b80..cef7751d2f0f 100644
@@ -666,11 +666,17 @@ static void xe_info_probe_tile_count(struct xe_device *xe)
 
 static struct xe_gt *init_primary_gt(struct xe_tile *tile,
 				     const struct xe_graphics_desc *graphics_desc,
-				     const struct xe_media_desc *media_desc)
+				     const struct xe_media_desc *media_desc,
+				     u64 gt_types_allowed)
 {
 	struct xe_device *xe = tile_to_xe(tile);
 	struct xe_gt *gt;
 
+	if ((gt_types_allowed & BIT_ULL(XE_GT_TYPE_MAIN)) == 0) {
+		drm_info(&xe->drm, "Primary GT disabled via configfs\n");
+		return NULL;
+	}
+
 	gt = xe_gt_alloc(tile);
 	if (IS_ERR(gt))
 		return gt;
@@ -691,11 +697,17 @@ static struct xe_gt *init_primary_gt(struct xe_tile *tile,
 }
 
 static struct xe_gt *init_media_gt(struct xe_tile *tile,
-				   const struct xe_media_desc *media_desc)
+				   const struct xe_media_desc *media_desc,
+				   u64 gt_types_allowed)
 {
 	struct xe_device *xe = tile_to_xe(tile);
 	struct xe_gt *gt;
 
+	if ((gt_types_allowed & BIT_ULL(XE_GT_TYPE_MEDIA)) == 0) {
+		drm_info(&xe->drm, "Media GT disabled via configfs\n");
+		return NULL;
+	}
+
 	gt = xe_gt_alloc(tile);
 	if (IS_ERR(gt))
 		return gt;
@@ -727,6 +739,7 @@ static int xe_info_init(struct xe_device *xe,
 	const struct xe_media_desc *media_desc;
 	struct xe_tile *tile;
 	struct xe_gt *gt;
+	u64 gt_types_allowed;
 	u8 id;
 
 	/*
@@ -789,6 +802,8 @@ static int xe_info_init(struct xe_device *xe,
 			return err;
 	}
 
+	gt_types_allowed = xe_configfs_get_gt_types_allowed(to_pci_dev(xe->drm.dev));
+
 	/* Allocate any GT and VRAM structures necessary for the platform. */
 	for_each_tile(tile, xe, id) {
 		int err;
@@ -797,11 +812,25 @@ static int xe_info_init(struct xe_device *xe,
 		if (err)
 			return err;
 
-		tile->primary_gt = init_primary_gt(tile, graphics_desc, media_desc);
+		tile->primary_gt = init_primary_gt(tile, graphics_desc, media_desc,
+						   gt_types_allowed);
 		if (IS_ERR(tile->primary_gt))
 			return PTR_ERR(tile->primary_gt);
 
-		tile->media_gt = init_media_gt(tile, media_desc);
+		/*
+		 * It's not currently possible to probe a device with the
+		 * primary GT disabled.  With some work, this may be future in
+		 * the possible for igpu platforms (although probably not for
+		 * dgpu's since access to the primary GT's BCS engines is
+		 * required for VRAM management).
+		 */
+		if (!tile->primary_gt) {
+			drm_err(&xe->drm, "Cannot probe device with without a primary GT\n");
+			return -ENODEV;
+		}
+
+		tile->media_gt = init_media_gt(tile, media_desc,
+					       gt_types_allowed);
 		if (IS_ERR(tile->media_gt))
 			return PTR_ERR(tile->media_gt);
 	}
Signature · 1 line
2.51.0
author
#37 lore raw

PATCH v2 22/22 drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfs

In reply to Matt Roper

SR-IOV operation relies on the primary GT's GuC to operate (in both PF and VF mode). If the primary GT is disabled in VF mode, fail the probe. If the primary GT is disabled in PF mode, force the device back to native (non-sriov) mode.

Cc Michal Wajdeczko <[email protected]>
---
 drivers/gpu/drm/xe/xe_device.c |  4 +++-
 drivers/gpu/drm/xe/xe_sriov.c  | 19 ++++++++++++++++++-
 drivers/gpu/drm/xe/xe_sriov.h  |  2 +-
 3 files changed, 22 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_device.c +3 -1
index 0b4fa7769f05..1ae984f1fb90 100644
@@ -736,7 +736,9 @@ int xe_device_probe_early(struct xe_device *xe)
 	if (err)
 		return err;
 
-	xe_sriov_probe_early(xe);
+	err = xe_sriov_probe_early(xe);
+	if (err)
+		return err;
 
 	sriov_update_device_info(xe);
 
drivers/gpu/drm/xe/xe_sriov.c +18 -1
index 7d2d6de2aabf..9fa864f8c3fa 100644
@@ -10,6 +10,7 @@
 #include "regs/xe_regs.h"
 
 #include "xe_assert.h"
+#include "xe_configfs.h"
 #include "xe_device.h"
 #include "xe_mmio.h"
 #include "xe_sriov.h"
@@ -55,11 +56,25 @@ static bool test_is_vf(struct xe_device *xe)
  * SR-IOV PF mode detection is based on PCI @dev_is_pf() function.
  * SR-IOV VF mode detection is based on dedicated MMIO register read.
  */
-void xe_sriov_probe_early(struct xe_device *xe)
+int xe_sriov_probe_early(struct xe_device *xe)
 {
 	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
 	enum xe_sriov_mode mode = XE_SRIOV_MODE_NONE;
 	bool has_sriov = xe->info.has_sriov;
+	bool has_primary_gt = xe_configfs_get_gt_types_allowed(to_pci_dev(xe->drm.dev)) &
+		BIT_ULL(XE_GT_TYPE_MAIN);
+
+	/*
+	 * SR-IOV operation relies on the primary GT's GuC.  Fail VF device
+	 * probe if the primary GT is disabled, and force PF probe back to
+	 * native (non-SRIOV) mode.
+	 */
+	if (test_is_vf(xe) && !has_primary_gt) {
+		drm_err(&xe->drm, "Cannot probe device in SR-IOV VF without primary GT enabled.\n");
+		return -ENODEV;
+	} else if (!has_primary_gt) {
+		has_sriov = false;
+	}
 
 	if (has_sriov) {
 		if (test_is_vf(xe))
@@ -85,6 +100,8 @@ void xe_sriov_probe_early(struct xe_device *xe)
 	if (IS_SRIOV(xe))
 		drm_info(&xe->drm, "Running in %s mode\n",
 			 xe_sriov_mode_to_string(xe_device_sriov_mode(xe)));
+
+	return 0;
 }
 
 static void fini_sriov(struct drm_device *drm, void *arg)
drivers/gpu/drm/xe/xe_sriov.h +1 -1
index 6db45df55615..9c283c028377 100644
@@ -15,7 +15,7 @@ struct drm_printer;
 const char *xe_sriov_mode_to_string(enum xe_sriov_mode mode);
 const char *xe_sriov_function_name(unsigned int n, char *buf, size_t len);
 
-void xe_sriov_probe_early(struct xe_device *xe);
+int xe_sriov_probe_early(struct xe_device *xe);
 void xe_sriov_print_info(struct xe_device *xe, struct drm_printer *p);
 int xe_sriov_init(struct xe_device *xe);
 int xe_sriov_init_late(struct xe_device *xe);
Signature · 1 line
2.51.0
#38 lore raw

Re: [PATCH v2 22/22] drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfs

Quoted 41 lines · Matt Roper

SR-IOV operation relies on the primary GT's GuC to operate (in both PF and VF mode). If the primary GT is disabled in VF mode, fail the probe. If the primary GT is disabled in PF mode, force the device back to native (non-sriov) mode.

Cc Michal Wajdeczko <[email protected]>
---
 drivers/gpu/drm/xe/xe_device.c |  4 +++-
 drivers/gpu/drm/xe/xe_sriov.c  | 19 ++++++++++++++++++-
 drivers/gpu/drm/xe/xe_sriov.h  |  2 +-
 3 files changed, 22 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_device.c +3 -1
index 0b4fa7769f05..1ae984f1fb90 100644
@@ -736,7 +736,9 @@ int xe_device_probe_early(struct xe_device *xe)
 	if (err)
 		return err;
 
-	xe_sriov_probe_early(xe);
+	err = xe_sriov_probe_early(xe);
+	if (err)
+		return err;
 
 	sriov_update_device_info(xe);
 
drivers/gpu/drm/xe/xe_sriov.c +1 -0
index 7d2d6de2aabf..9fa864f8c3fa 100644
@@ -10,6 +10,7 @@
 #include "regs/xe_regs.h"
 
 #include "xe_assert.h"
+#include "xe_configfs.h"
 #include "xe_device.h"
 #include "xe_mmio.h"
 #include "xe_sriov.h"

drivers/gpu/drm/xe/xe_sriov.c static bool test_is_vf(struct xe_device *xe) · line 59

Quoted 5 lines
drivers/gpu/drm/xe/xe_sriov.c +1 -1
@@ -55,11 +56,25 @@ static bool test_is_vf(struct xe_device *xe)
  * SR-IOV PF mode detection is based on PCI @dev_is_pf() function.
  * SR-IOV VF mode detection is based on dedicated MMIO register read.
  */
-void xe_sriov_probe_early(struct xe_device *xe)
+int xe_sriov_probe_early(struct xe_device *xe)

the goal of this function was to only probe the SRIOV mode, not to decide if we need to abort the driver load, as there are many reasons to do so

drivers/gpu/drm/xe/xe_sriov.c static bool test_is_vf(struct xe_device *xe) · line 65

Quoted 6 lines
drivers/gpu/drm/xe/xe_sriov.c +2 -0
 {
 	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
 	enum xe_sriov_mode mode = XE_SRIOV_MODE_NONE;
 	bool has_sriov = xe->info.has_sriov;
+	bool has_primary_gt = xe_configfs_get_gt_types_allowed(to_pci_dev(xe->drm.dev)) &
+		BIT_ULL(XE_GT_TYPE_MAIN);

little ugly, what about adding some helper:

xe_supports_primary_gt(xe)

drivers/gpu/drm/xe/xe_sriov.c static bool test_is_vf(struct xe_device *xe) · line 77

Quoted 12 lines
drivers/gpu/drm/xe/xe_sriov.c +12 -0
+
+	/*
+	 * SR-IOV operation relies on the primary GT's GuC.  Fail VF device
+	 * probe if the primary GT is disabled, and force PF probe back to
+	 * native (non-SRIOV) mode.
+	 */
+	if (test_is_vf(xe) && !has_primary_gt) {
+		drm_err(&xe->drm, "Cannot probe device in SR-IOV VF without primary GT enabled.\n");
+		return -ENODEV;
+	} else if (!has_primary_gt) {
+		has_sriov = false;
+	}

maybe cleaner solution would be to just to reset info.has_sriov in the xe_info_init_early so there will be no PF, and thus no VFs could be even created?

and if someone will still try to run PF with primary GT and then disable primary GT on the already enabled VF, we can either let the driver continue running as native and then just die, or ..

add this unconditional check for test_vf regardless of .has_sriov (as one could try to load older VF Xe driver without .has_sriov enabled yet on the newer PF that has this flag enabled) and then just correctly handle lack of primary GT in GMDID case, so we will abort from xe_info_init like the native would do

Quoted 25 lines
drivers/gpu/drm/xe/xe_sriov.c +2 -0
 	if (has_sriov) {
 		if (test_is_vf(xe))
@@ -85,6 +100,8 @@ void xe_sriov_probe_early(struct xe_device *xe)
 	if (IS_SRIOV(xe))
 		drm_info(&xe->drm, "Running in %s mode\n",
 			 xe_sriov_mode_to_string(xe_device_sriov_mode(xe)));
+
+	return 0;
 }
 
 static void fini_sriov(struct drm_device *drm, void *arg)
drivers/gpu/drm/xe/xe_sriov.h +1 -1
index 6db45df55615..9c283c028377 100644
@@ -15,7 +15,7 @@ struct drm_printer;
 const char *xe_sriov_mode_to_string(enum xe_sriov_mode mode);
 const char *xe_sriov_function_name(unsigned int n, char *buf, size_t len);
 
-void xe_sriov_probe_early(struct xe_device *xe);
+int xe_sriov_probe_early(struct xe_device *xe);
 void xe_sriov_print_info(struct xe_device *xe, struct drm_printer *p);
 int xe_sriov_init(struct xe_device *xe);
 int xe_sriov_init_late(struct xe_device *xe);
#39 lore raw

✗ CI.checkpatch: warning for Allow configfs to disable specific GT type(s) (rev2)

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: Allow configfs to disable specific GT type(s) (rev2)
URL : https://patchwork.freedesktop.org/series/154739/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master fbd08a78c3a3bb17964db2a326514c69c1dca660
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 55f08593156d4892526d72a4b1378e6739d1d9d0

Author: Matt Roper <[email protected]>
Date:   Thu Sep 25 16:46:50 2025 -0700

drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfs

SR-IOV operation relies on the primary GT's GuC to operate (in both PF and VF mode). If the primary GT is disabled in VF mode, fail the probe. If the primary GT is disabled in PF mode, force the device back to native (non-sriov) mode.

Cc Michal Wajdeczko <[email protected]>

+ /mt/dim checkpatch 927b4d44359a2e2b1782f80bb5302950d8a7cb6d drm-intel 2bbc3e0b3721 drm/xe/huc: Adjust HuC check on primary GT
31ba4ba6ef1e drm/xe: Drop GT parameter to xe_display_irq_postinstall() 1de00ca2aaf0 drm/xe: Move 'va_bits' flag back to platform descriptor 1832b578d8af drm/xe: Move 'vm_max_level' flag back to platform descriptor 0facdf3bb966 drm/xe: Move 'vram_flags' flag back to platform descriptor f8ab9f783ba6 drm/xe: Move 'has_flatccs' flag back to platform descriptor 19cfcb4ed66e drm/xe: Move primary GT allocation from xe_tile_init_early to xe_tile_init af272dedc53d drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled 8b041f7ef5ad drm/xe/query: Report hwconfig size as 0 if primary GT is disabled febaeaea4b6c drm/xe/pmu: Initialize PMU event types based on first available GT 6ab189c71f8a drm/xe: Check for primary GT before looking up Wa_22019338487 62372ed22033 drm/xe: Make display part of Wa_22019338487 a device workaround 4ee423638d82 drm/xe/irq: Don't try to lookup engine masks for non-existent primary GT 84a83981b676 drm/xe: Handle Wa_22010954014 and Wa_14022085890 as device workarounds -:126: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #126: FILE: include/drm/intel/pciids.h:852:
+#define INTEL_BMG_G21_IDS(MACRO__, ...) \
MACRO__(0xE202, ## __VA_ARGS__), \
MACRO__(0xE209, ## __VA_ARGS__), \
MACRO__(0xE20B, ## __VA_ARGS__), \

BUT SEE:

do {} while (0) advice is over-stated in a few situations:

The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name.

More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions.

Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper.

Enjoy this qualification while we work to improve our heuristics.

-:126: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects? #126: FILE: include/drm/intel/pciids.h:852:
+#define INTEL_BMG_G21_IDS(MACRO__, ...) \
MACRO__(0xE202, ## __VA_ARGS__), \
MACRO__(0xE209, ## __VA_ARGS__), \
MACRO__(0xE20B, ## __VA_ARGS__), \

-:137: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #137: FILE: include/drm/intel/pciids.h:863:
+#define INTEL_BMG_IDS(MACRO__, ...) \
+ INTEL_BMG_G21_IDS(MACRO__, __VA_ARGS__), \
MACRO__(0xE220, ## __VA_ARGS__), \
MACRO__(0xE221, ## __VA_ARGS__), \
MACRO__(0xE222, ## __VA_ARGS__), \

BUT SEE:

do {} while (0) advice is over-stated in a few situations:

The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name.

More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions.

Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper.

Enjoy this qualification while we work to improve our heuristics.

-:137: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects? #137: FILE: include/drm/intel/pciids.h:863:
+#define INTEL_BMG_IDS(MACRO__, ...) \
+ INTEL_BMG_G21_IDS(MACRO__, __VA_ARGS__), \
MACRO__(0xE220, ## __VA_ARGS__), \
MACRO__(0xE221, ## __VA_ARGS__), \
MACRO__(0xE222, ## __VA_ARGS__), \

total: 2 errors, 0 warnings, 2 checks, 87 lines checked
0f6d25960ba4 drm/xe/rtp: Pass xe_device parameter to FUNC matches f7517e71d152 drm/xe: Bypass Wa_14018094691 when primary GT is disabled 6ab54fc43dbb drm/xe: Correct lineage for Wa_22014953428 and only check with valid GT 7916925adfb3 drm/xe: Check that GT is not NULL before testing Wa_16023588340 b3a76157ee18 drm/xe: Don't check BIOS-disabled FlatCCS if primary GT is disabled f3d9964e6826 drm/xe: Break GT setup out of xe_info_init()
cbcb4942d743 drm/xe/configfs: Add attribute to disable GT types 55f08593156d drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfs

#40 lore raw

✓ CI.KUnit: success for Allow configfs to disable specific GT type(s) (rev2)

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: Allow configfs to disable specific GT type(s) (rev2)
URL : https://patchwork.freedesktop.org/series/154739/
State : success

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [23:56:24] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[23:56:28] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[23:56:57] Starting KUnit Kernel (1/1)...
[23:56:57] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[23:56:57] ================== guc_buf (11 subtests) ===================
[23:56:57] [PASSED] test_smallest
[23:56:57] [PASSED] test_largest
[23:56:57] [PASSED] test_granular
[23:56:57] [PASSED] test_unique
[23:56:57] [PASSED] test_overlap
[23:56:57] [PASSED] test_reusable
[23:56:57] [PASSED] test_too_big
[23:56:57] [PASSED] test_flush
[23:56:57] [PASSED] test_lookup
[23:56:57] [PASSED] test_data
[23:56:57] [PASSED] test_class
[23:56:57] ===================== [PASSED] guc_buf =====================
[23:56:57] =================== guc_dbm (7 subtests) ===================
[23:56:57] [PASSED] test_empty
[23:56:57] [PASSED] test_default
[23:56:57] ======================== test_size  ========================
[23:56:57] [PASSED] 4
[23:56:57] [PASSED] 8
[23:56:57] [PASSED] 32
[23:56:57] [PASSED] 256
[23:56:57] ==================== [PASSED] test_size ====================
[23:56:57] ======================= test_reuse  ========================
[23:56:57] [PASSED] 4
[23:56:57] [PASSED] 8
[23:56:58] [PASSED] 32
[23:56:58] [PASSED] 256
[23:56:58] =================== [PASSED] test_reuse ====================
[23:56:58] =================== test_range_overlap  ====================
[23:56:58] [PASSED] 4
[23:56:58] [PASSED] 8
[23:56:58] [PASSED] 32
[23:56:58] [PASSED] 256
[23:56:58] =============== [PASSED] test_range_overlap ================
[23:56:58] =================== test_range_compact  ====================
[23:56:58] [PASSED] 4
[23:56:58] [PASSED] 8
[23:56:58] [PASSED] 32
[23:56:58] [PASSED] 256
[23:56:58] =============== [PASSED] test_range_compact ================
[23:56:58] ==================== test_range_spare  =====================
[23:56:58] [PASSED] 4
[23:56:58] [PASSED] 8
[23:56:58] [PASSED] 32
[23:56:58] [PASSED] 256
[23:56:58] ================ [PASSED] test_range_spare =================
[23:56:58] ===================== [PASSED] guc_dbm =====================
[23:56:58] =================== guc_idm (6 subtests) ===================
[23:56:58] [PASSED] bad_init
[23:56:58] [PASSED] no_init
[23:56:58] [PASSED] init_fini
[23:56:58] [PASSED] check_used
[23:56:58] [PASSED] check_quota
[23:56:58] [PASSED] check_all
[23:56:58] ===================== [PASSED] guc_idm =====================
[23:56:58] ================== no_relay (3 subtests) ===================
[23:56:58] [PASSED] xe_drops_guc2pf_if_not_ready
[23:56:58] [PASSED] xe_drops_guc2vf_if_not_ready
[23:56:58] [PASSED] xe_rejects_send_if_not_ready
[23:56:58] ==================== [PASSED] no_relay =====================
[23:56:58] ================== pf_relay (14 subtests) ==================
[23:56:58] [PASSED] pf_rejects_guc2pf_too_short
[23:56:58] [PASSED] pf_rejects_guc2pf_too_long
[23:56:58] [PASSED] pf_rejects_guc2pf_no_payload
[23:56:58] [PASSED] pf_fails_no_payload
[23:56:58] [PASSED] pf_fails_bad_origin
[23:56:58] [PASSED] pf_fails_bad_type
[23:56:58] [PASSED] pf_txn_reports_error
[23:56:58] [PASSED] pf_txn_sends_pf2guc
[23:56:58] [PASSED] pf_sends_pf2guc
[23:56:58] [SKIPPED] pf_loopback_nop
[23:56:58] [SKIPPED] pf_loopback_echo
[23:56:58] [SKIPPED] pf_loopback_fail
[23:56:58] [SKIPPED] pf_loopback_busy
[23:56:58] [SKIPPED] pf_loopback_retry
[23:56:58] ==================== [PASSED] pf_relay =====================
[23:56:58] ================== vf_relay (3 subtests) ===================
[23:56:58] [PASSED] vf_rejects_guc2vf_too_short
[23:56:58] [PASSED] vf_rejects_guc2vf_too_long
[23:56:58] [PASSED] vf_rejects_guc2vf_no_payload
[23:56:58] ==================== [PASSED] vf_relay =====================
[23:56:58] ===================== lmtt (1 subtest) =====================
[23:56:58] ======================== test_ops  =========================
[23:56:58] [PASSED] 2-level
[23:56:58] [PASSED] multi-level
[23:56:58] ==================== [PASSED] test_ops =====================
[23:56:58] ====================== [PASSED] lmtt =======================
[23:56:58] ================= pf_service (11 subtests) =================
[23:56:58] [PASSED] pf_negotiate_any
[23:56:58] [PASSED] pf_negotiate_base_match
[23:56:58] [PASSED] pf_negotiate_base_newer
[23:56:58] [PASSED] pf_negotiate_base_next
[23:56:58] [SKIPPED] pf_negotiate_base_older
[23:56:58] [PASSED] pf_negotiate_base_prev
[23:56:58] [PASSED] pf_negotiate_latest_match
[23:56:58] [PASSED] pf_negotiate_latest_newer
[23:56:58] [PASSED] pf_negotiate_latest_next
[23:56:58] [SKIPPED] pf_negotiate_latest_older
[23:56:58] [SKIPPED] pf_negotiate_latest_prev
[23:56:58] =================== [PASSED] pf_service ====================
[23:56:58] ================= xe_guc_g2g (2 subtests) ==================
[23:56:58] ============== xe_live_guc_g2g_kunit_default  ==============
[23:56:58] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[23:56:58] ============== xe_live_guc_g2g_kunit_allmem  ===============
[23:56:58] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[23:56:58] =================== [SKIPPED] xe_guc_g2g ===================
[23:56:58] =================== xe_mocs (2 subtests) ===================
[23:56:58] ================ xe_live_mocs_kernel_kunit  ================
[23:56:58] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[23:56:58] ================ xe_live_mocs_reset_kunit  =================
[23:56:58] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[23:56:58] ==================== [SKIPPED] xe_mocs =====================
[23:56:58] ================= xe_migrate (2 subtests) ==================
[23:56:58] ================= xe_migrate_sanity_kunit  =================
[23:56:58] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[23:56:58] ================== xe_validate_ccs_kunit  ==================
[23:56:58] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[23:56:58] =================== [SKIPPED] xe_migrate ===================
[23:56:58] ================== xe_dma_buf (1 subtest) ==================
[23:56:58] ==================== xe_dma_buf_kunit  =====================
[23:56:58] ================ [SKIPPED] xe_dma_buf_kunit ================
[23:56:58] =================== [SKIPPED] xe_dma_buf ===================
[23:56:58] ================= xe_bo_shrink (1 subtest) =================
[23:56:58] =================== xe_bo_shrink_kunit  ====================
[23:56:58] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[23:56:58] ================== [SKIPPED] xe_bo_shrink ==================
[23:56:58] ==================== xe_bo (2 subtests) ====================
[23:56:58] ================== xe_ccs_migrate_kunit  ===================
[23:56:58] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[23:56:58] ==================== xe_bo_evict_kunit  ====================
[23:56:58] =============== [SKIPPED] xe_bo_evict_kunit ================
[23:56:58] ===================== [SKIPPED] xe_bo ======================
[23:56:58] ==================== args (11 subtests) ====================
[23:56:58] [PASSED] count_args_test
[23:56:58] [PASSED] call_args_example
[23:56:58] [PASSED] call_args_test
[23:56:58] [PASSED] drop_first_arg_example
[23:56:58] [PASSED] drop_first_arg_test
[23:56:58] [PASSED] first_arg_example
[23:56:58] [PASSED] first_arg_test
[23:56:58] [PASSED] last_arg_example
[23:56:58] [PASSED] last_arg_test
[23:56:58] [PASSED] pick_arg_example
[23:56:58] [PASSED] sep_comma_example
[23:56:58] ====================== [PASSED] args =======================
[23:56:58] =================== xe_pci (3 subtests) ====================
[23:56:58] ==================== check_graphics_ip  ====================
[23:56:58] [PASSED] 12.00 Xe_LP
[23:56:58] [PASSED] 12.10 Xe_LP+
[23:56:58] [PASSED] 12.55 Xe_HPG
[23:56:58] [PASSED] 12.60 Xe_HPC
[23:56:58] [PASSED] 12.70 Xe_LPG
[23:56:58] [PASSED] 12.71 Xe_LPG
[23:56:58] [PASSED] 12.74 Xe_LPG+
[23:56:58] [PASSED] 20.01 Xe2_HPG
[23:56:58] [PASSED] 20.02 Xe2_HPG
[23:56:58] [PASSED] 20.04 Xe2_LPG
[23:56:58] [PASSED] 30.00 Xe3_LPG
[23:56:58] [PASSED] 30.01 Xe3_LPG
[23:56:58] [PASSED] 30.03 Xe3_LPG
[23:56:58] ================ [PASSED] check_graphics_ip ================
[23:56:58] ===================== check_media_ip  ======================
[23:56:58] [PASSED] 12.00 Xe_M
[23:56:58] [PASSED] 12.55 Xe_HPM
[23:56:58] [PASSED] 13.00 Xe_LPM+
[23:56:58] [PASSED] 13.01 Xe2_HPM
[23:56:58] [PASSED] 20.00 Xe2_LPM
[23:56:58] [PASSED] 30.00 Xe3_LPM
[23:56:58] [PASSED] 30.02 Xe3_LPM
[23:56:58] ================= [PASSED] check_media_ip ==================
[23:56:58] ================= check_platform_gt_count  =================
[23:56:58] [PASSED] 0x9A60 (TIGERLAKE)
[23:56:58] [PASSED] 0x9A68 (TIGERLAKE)
[23:56:58] [PASSED] 0x9A70 (TIGERLAKE)
[23:56:58] [PASSED] 0x9A40 (TIGERLAKE)
[23:56:58] [PASSED] 0x9A49 (TIGERLAKE)
[23:56:58] [PASSED] 0x9A59 (TIGERLAKE)
[23:56:58] [PASSED] 0x9A78 (TIGERLAKE)
[23:56:58] [PASSED] 0x9AC0 (TIGERLAKE)
[23:56:58] [PASSED] 0x9AC9 (TIGERLAKE)
[23:56:58] [PASSED] 0x9AD9 (TIGERLAKE)
[23:56:58] [PASSED] 0x9AF8 (TIGERLAKE)
[23:56:58] [PASSED] 0x4C80 (ROCKETLAKE)
[23:56:58] [PASSED] 0x4C8A (ROCKETLAKE)
[23:56:58] [PASSED] 0x4C8B (ROCKETLAKE)
[23:56:58] [PASSED] 0x4C8C (ROCKETLAKE)
[23:56:58] [PASSED] 0x4C90 (ROCKETLAKE)
[23:56:58] [PASSED] 0x4C9A (ROCKETLAKE)
[23:56:58] [PASSED] 0x4680 (ALDERLAKE_S)
[23:56:58] [PASSED] 0x4682 (ALDERLAKE_S)
[23:56:58] [PASSED] 0x4688 (ALDERLAKE_S)
[23:56:58] [PASSED] 0x468A (ALDERLAKE_S)
[23:56:58] [PASSED] 0x468B (ALDERLAKE_S)
[23:56:58] [PASSED] 0x4690 (ALDERLAKE_S)
[23:56:58] [PASSED] 0x4692 (ALDERLAKE_S)
[23:56:58] [PASSED] 0x4693 (ALDERLAKE_S)
[23:56:58] [PASSED] 0x46A0 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46A1 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46A2 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46A3 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46A6 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46A8 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46AA (ALDERLAKE_P)
[23:56:58] [PASSED] 0x462A (ALDERLAKE_P)
[23:56:58] [PASSED] 0x4626 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x4628 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46B0 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46B1 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46B2 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46B3 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46C0 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46C1 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46C2 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46C3 (ALDERLAKE_P)
[23:56:58] [PASSED] 0x46D0 (ALDERLAKE_N)
[23:56:58] [PASSED] 0x46D1 (ALDERLAKE_N)
[23:56:58] [PASSED] 0x46D2 (ALDERLAKE_N)
[23:56:58] [PASSED] 0x46D3 (ALDERLAKE_N)
[23:56:58] [PASSED] 0x46D4 (ALDERLAKE_N)
[23:56:58] [PASSED] 0xA721 (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7A1 (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7A9 (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7AC (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7AD (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA720 (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7A0 (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7A8 (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7AA (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA7AB (ALDERLAKE_P)
[23:56:58] [PASSED] 0xA780 (ALDERLAKE_S)
[23:56:58] [PASSED] 0xA781 (ALDERLAKE_S)
[23:56:58] [PASSED] 0xA782 (ALDERLAKE_S)
[23:56:58] [PASSED] 0xA783 (ALDERLAKE_S)
[23:56:58] [PASSED] 0xA788 (ALDERLAKE_S)
[23:56:58] [PASSED] 0xA789 (ALDERLAKE_S)
[23:56:58] [PASSED] 0xA78A (ALDERLAKE_S)
[23:56:58] [PASSED] 0xA78B (ALDERLAKE_S)
[23:56:58] [PASSED] 0x4905 (DG1)
[23:56:58] [PASSED] 0x4906 (DG1)
[23:56:58] [PASSED] 0x4907 (DG1)
[23:56:58] [PASSED] 0x4908 (DG1)
[23:56:58] [PASSED] 0x4909 (DG1)
[23:56:58] [PASSED] 0x56C0 (DG2)
[23:56:58] [PASSED] 0x56C2 (DG2)
[23:56:58] [PASSED] 0x56C1 (DG2)
[23:56:58] [PASSED] 0x7D51 (METEORLAKE)
[23:56:58] [PASSED] 0x7DD1 (METEORLAKE)
[23:56:58] [PASSED] 0x7D41 (METEORLAKE)
[23:56:58] [PASSED] 0x7D67 (METEORLAKE)
[23:56:58] [PASSED] 0xB640 (METEORLAKE)
[23:56:58] [PASSED] 0x56A0 (DG2)
[23:56:58] [PASSED] 0x56A1 (DG2)
[23:56:58] [PASSED] 0x56A2 (DG2)
[23:56:58] [PASSED] 0x56BE (DG2)
[23:56:58] [PASSED] 0x56BF (DG2)
[23:56:58] [PASSED] 0x5690 (DG2)
[23:56:58] [PASSED] 0x5691 (DG2)
[23:56:58] [PASSED] 0x5692 (DG2)
[23:56:58] [PASSED] 0x56A5 (DG2)
[23:56:58] [PASSED] 0x56A6 (DG2)
[23:56:58] [PASSED] 0x56B0 (DG2)
[23:56:58] [PASSED] 0x56B1 (DG2)
[23:56:58] [PASSED] 0x56BA (DG2)
[23:56:58] [PASSED] 0x56BB (DG2)
[23:56:58] [PASSED] 0x56BC (DG2)
[23:56:58] [PASSED] 0x56BD (DG2)
[23:56:58] [PASSED] 0x5693 (DG2)
[23:56:58] [PASSED] 0x5694 (DG2)
[23:56:58] [PASSED] 0x5695 (DG2)
[23:56:58] [PASSED] 0x56A3 (DG2)
[23:56:58] [PASSED] 0x56A4 (DG2)
[23:56:58] [PASSED] 0x56B2 (DG2)
[23:56:58] [PASSED] 0x56B3 (DG2)
[23:56:58] [PASSED] 0x5696 (DG2)
[23:56:58] [PASSED] 0x5697 (DG2)
[23:56:58] [PASSED] 0xB69 (PVC)
[23:56:58] [PASSED] 0xB6E (PVC)
[23:56:58] [PASSED] 0xBD4 (PVC)
[23:56:58] [PASSED] 0xBD5 (PVC)
[23:56:58] [PASSED] 0xBD6 (PVC)
[23:56:58] [PASSED] 0xBD7 (PVC)
[23:56:58] [PASSED] 0xBD8 (PVC)
[23:56:58] [PASSED] 0xBD9 (PVC)
[23:56:58] [PASSED] 0xBDA (PVC)
[23:56:58] [PASSED] 0xBDB (PVC)
[23:56:58] [PASSED] 0xBE0 (PVC)
[23:56:58] [PASSED] 0xBE1 (PVC)
[23:56:58] [PASSED] 0xBE5 (PVC)
[23:56:58] [PASSED] 0x7D40 (METEORLAKE)
[23:56:58] [PASSED] 0x7D45 (METEORLAKE)
[23:56:58] [PASSED] 0x7D55 (METEORLAKE)
[23:56:58] [PASSED] 0x7D60 (METEORLAKE)
[23:56:58] [PASSED] 0x7DD5 (METEORLAKE)
[23:56:58] [PASSED] 0x6420 (LUNARLAKE)
[23:56:58] [PASSED] 0x64A0 (LUNARLAKE)
[23:56:58] [PASSED] 0x64B0 (LUNARLAKE)
[23:56:58] [PASSED] 0xE202 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE209 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE20B (BATTLEMAGE)
[23:56:58] [PASSED] 0xE20C (BATTLEMAGE)
[23:56:58] [PASSED] 0xE20D (BATTLEMAGE)
[23:56:58] [PASSED] 0xE210 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE211 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE212 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE216 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE220 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE221 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE222 (BATTLEMAGE)
[23:56:58] [PASSED] 0xE223 (BATTLEMAGE)
[23:56:58] [PASSED] 0xB080 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB081 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB082 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB083 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB084 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB085 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB086 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB087 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB08F (PANTHERLAKE)
[23:56:58] [PASSED] 0xB090 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB0A0 (PANTHERLAKE)
[23:56:58] [PASSED] 0xB0B0 (PANTHERLAKE)
[23:56:58] [PASSED] 0xFD80 (PANTHERLAKE)
[23:56:58] [PASSED] 0xFD81 (PANTHERLAKE)
[23:56:58] ============= [PASSED] check_platform_gt_count =============
[23:56:58] ===================== [PASSED] xe_pci ======================
[23:56:58] =================== xe_rtp (2 subtests) ====================
[23:56:58] =============== xe_rtp_process_to_sr_tests  ================
[23:56:58] [PASSED] coalesce-same-reg
[23:56:58] [PASSED] no-match-no-add
[23:56:58] [PASSED] match-or
[23:56:58] [PASSED] match-or-xfail
[23:56:58] [PASSED] no-match-no-add-multiple-rules
[23:56:58] [PASSED] two-regs-two-entries
[23:56:58] [PASSED] clr-one-set-other
[23:56:58] [PASSED] set-field
[23:56:58] [PASSED] conflict-duplicate
[23:56:58] [PASSED] conflict-not-disjoint
[23:56:58] [PASSED] conflict-reg-type
[23:56:58] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[23:56:58] ================== xe_rtp_process_tests  ===================
[23:56:58] [PASSED] active1
[23:56:58] [PASSED] active2
[23:56:58] [PASSED] active-inactive
[23:56:58] [PASSED] inactive-active
[23:56:58] [PASSED] inactive-1st_or_active-inactive
[23:56:58] [PASSED] inactive-2nd_or_active-inactive
[23:56:58] [PASSED] inactive-last_or_active-inactive
[23:56:58] [PASSED] inactive-no_or_active-inactive
[23:56:58] ============== [PASSED] xe_rtp_process_tests ===============
[23:56:58] ===================== [PASSED] xe_rtp ======================
[23:56:58] ==================== xe_wa (1 subtest) =====================
[23:56:58] ======================== xe_wa_gt  =========================
[23:56:58] [PASSED] TIGERLAKE B0
[23:56:58] [PASSED] DG1 A0
[23:56:58] [PASSED] DG1 B0
[23:56:58] [PASSED] ALDERLAKE_S A0
[23:56:58] [PASSED] ALDERLAKE_S B0
stty: 'standard input': Inappropriate ioctl for device
[23:56:58] [PASSED] ALDERLAKE_S C0
[23:56:58] [PASSED] ALDERLAKE_S D0
[23:56:58] [PASSED] ALDERLAKE_P A0
[23:56:58] [PASSED] ALDERLAKE_P B0
[23:56:58] [PASSED] ALDERLAKE_P C0
[23:56:58] [PASSED] ALDERLAKE_S RPLS D0
[23:56:58] [PASSED] ALDERLAKE_P RPLU E0
[23:56:58] [PASSED] DG2 G10 C0
[23:56:58] [PASSED] DG2 G11 B1
[23:56:58] [PASSED] DG2 G12 A1
[23:56:58] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[23:56:58] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[23:56:58] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[23:56:58] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[23:56:58] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[23:56:58] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[23:56:58] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[23:56:58] ==================== [PASSED] xe_wa_gt =====================
[23:56:58] ====================== [PASSED] xe_wa ======================
[23:56:58] ============================================================
[23:56:58] Testing complete. Ran 306 tests: passed: 288, skipped: 18
[23:56:58] Elapsed time: 33.434s total, 4.252s configuring, 28.816s building, 0.338s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [23:56:58] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[23:57:00] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[23:57:23] Starting KUnit Kernel (1/1)...
[23:57:23] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[23:57:23] ============ drm_test_pick_cmdline (2 subtests) ============
[23:57:23] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[23:57:23] =============== drm_test_pick_cmdline_named  ===============
[23:57:23] [PASSED] NTSC
[23:57:23] [PASSED] NTSC-J
[23:57:23] [PASSED] PAL
[23:57:23] [PASSED] PAL-M
[23:57:23] =========== [PASSED] drm_test_pick_cmdline_named ===========
[23:57:23] ============== [PASSED] drm_test_pick_cmdline ==============
[23:57:23] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[23:57:23] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[23:57:23] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[23:57:23] =========== drm_validate_clone_mode (2 subtests) ===========
[23:57:23] ============== drm_test_check_in_clone_mode  ===============
[23:57:23] [PASSED] in_clone_mode
[23:57:23] [PASSED] not_in_clone_mode
[23:57:23] ========== [PASSED] drm_test_check_in_clone_mode ===========
[23:57:23] =============== drm_test_check_valid_clones  ===============
[23:57:23] [PASSED] not_in_clone_mode
[23:57:23] [PASSED] valid_clone
[23:57:23] [PASSED] invalid_clone
[23:57:23] =========== [PASSED] drm_test_check_valid_clones ===========
[23:57:23] ============= [PASSED] drm_validate_clone_mode =============
[23:57:23] ============= drm_validate_modeset (1 subtest) =============
[23:57:23] [PASSED] drm_test_check_connector_changed_modeset
[23:57:23] ============== [PASSED] drm_validate_modeset ===============
[23:57:23] ====== drm_test_bridge_get_current_state (2 subtests) ======
[23:57:23] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[23:57:23] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[23:57:23] ======== [PASSED] drm_test_bridge_get_current_state ========
[23:57:23] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[23:57:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[23:57:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[23:57:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[23:57:23] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[23:57:23] ============== drm_bridge_alloc (2 subtests) ===============
[23:57:23] [PASSED] drm_test_drm_bridge_alloc_basic
[23:57:23] [PASSED] drm_test_drm_bridge_alloc_get_put
[23:57:23] ================ [PASSED] drm_bridge_alloc =================
[23:57:23] ================== drm_buddy (7 subtests) ==================
[23:57:23] [PASSED] drm_test_buddy_alloc_limit
[23:57:23] [PASSED] drm_test_buddy_alloc_optimistic
[23:57:23] [PASSED] drm_test_buddy_alloc_pessimistic
[23:57:23] [PASSED] drm_test_buddy_alloc_pathological
[23:57:23] [PASSED] drm_test_buddy_alloc_contiguous
[23:57:23] [PASSED] drm_test_buddy_alloc_clear
[23:57:23] [PASSED] drm_test_buddy_alloc_range_bias
[23:57:23] ==================== [PASSED] drm_buddy ====================
[23:57:23] ============= drm_cmdline_parser (40 subtests) =============
[23:57:23] [PASSED] drm_test_cmdline_force_d_only
[23:57:23] [PASSED] drm_test_cmdline_force_D_only_dvi
[23:57:23] [PASSED] drm_test_cmdline_force_D_only_hdmi
[23:57:23] [PASSED] drm_test_cmdline_force_D_only_not_digital
[23:57:23] [PASSED] drm_test_cmdline_force_e_only
[23:57:23] [PASSED] drm_test_cmdline_res
[23:57:23] [PASSED] drm_test_cmdline_res_vesa
[23:57:23] [PASSED] drm_test_cmdline_res_vesa_rblank
[23:57:23] [PASSED] drm_test_cmdline_res_rblank
[23:57:23] [PASSED] drm_test_cmdline_res_bpp
[23:57:23] [PASSED] drm_test_cmdline_res_refresh
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[23:57:23] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[23:57:23] [PASSED] drm_test_cmdline_res_margins_force_on
[23:57:23] [PASSED] drm_test_cmdline_res_vesa_margins
[23:57:23] [PASSED] drm_test_cmdline_name
[23:57:23] [PASSED] drm_test_cmdline_name_bpp
[23:57:23] [PASSED] drm_test_cmdline_name_option
[23:57:23] [PASSED] drm_test_cmdline_name_bpp_option
[23:57:23] [PASSED] drm_test_cmdline_rotate_0
[23:57:23] [PASSED] drm_test_cmdline_rotate_90
[23:57:23] [PASSED] drm_test_cmdline_rotate_180
[23:57:23] [PASSED] drm_test_cmdline_rotate_270
[23:57:23] [PASSED] drm_test_cmdline_hmirror
[23:57:23] [PASSED] drm_test_cmdline_vmirror
[23:57:23] [PASSED] drm_test_cmdline_margin_options
[23:57:23] [PASSED] drm_test_cmdline_multiple_options
[23:57:23] [PASSED] drm_test_cmdline_bpp_extra_and_option
[23:57:23] [PASSED] drm_test_cmdline_extra_and_option
[23:57:23] [PASSED] drm_test_cmdline_freestanding_options
[23:57:23] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[23:57:23] [PASSED] drm_test_cmdline_panel_orientation
[23:57:23] ================ drm_test_cmdline_invalid  =================
[23:57:23] [PASSED] margin_only
[23:57:23] [PASSED] interlace_only
[23:57:23] [PASSED] res_missing_x
[23:57:23] [PASSED] res_missing_y
[23:57:23] [PASSED] res_bad_y
[23:57:23] [PASSED] res_missing_y_bpp
[23:57:23] [PASSED] res_bad_bpp
[23:57:23] [PASSED] res_bad_refresh
[23:57:23] [PASSED] res_bpp_refresh_force_on_off
[23:57:23] [PASSED] res_invalid_mode
[23:57:23] [PASSED] res_bpp_wrong_place_mode
[23:57:23] [PASSED] name_bpp_refresh
[23:57:23] [PASSED] name_refresh
[23:57:23] [PASSED] name_refresh_wrong_mode
[23:57:23] [PASSED] name_refresh_invalid_mode
[23:57:23] [PASSED] rotate_multiple
[23:57:23] [PASSED] rotate_invalid_val
[23:57:23] [PASSED] rotate_truncated
[23:57:23] [PASSED] invalid_option
[23:57:23] [PASSED] invalid_tv_option
[23:57:23] [PASSED] truncated_tv_option
[23:57:23] ============ [PASSED] drm_test_cmdline_invalid =============
[23:57:23] =============== drm_test_cmdline_tv_options  ===============
[23:57:23] [PASSED] NTSC
[23:57:23] [PASSED] NTSC_443
[23:57:23] [PASSED] NTSC_J
[23:57:23] [PASSED] PAL
[23:57:23] [PASSED] PAL_M
[23:57:23] [PASSED] PAL_N
[23:57:23] [PASSED] SECAM
[23:57:23] [PASSED] MONO_525
[23:57:23] [PASSED] MONO_625
[23:57:23] =========== [PASSED] drm_test_cmdline_tv_options ===========
[23:57:23] =============== [PASSED] drm_cmdline_parser ================
[23:57:23] ========== drmm_connector_hdmi_init (20 subtests) ==========
[23:57:23] [PASSED] drm_test_connector_hdmi_init_valid
[23:57:23] [PASSED] drm_test_connector_hdmi_init_bpc_8
[23:57:23] [PASSED] drm_test_connector_hdmi_init_bpc_10
[23:57:23] [PASSED] drm_test_connector_hdmi_init_bpc_12
[23:57:23] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[23:57:23] [PASSED] drm_test_connector_hdmi_init_bpc_null
[23:57:23] [PASSED] drm_test_connector_hdmi_init_formats_empty
[23:57:23] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[23:57:23] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[23:57:23] [PASSED] supported_formats=0x9 yuv420_allowed=1
[23:57:23] [PASSED] supported_formats=0x9 yuv420_allowed=0
[23:57:23] [PASSED] supported_formats=0x3 yuv420_allowed=1
[23:57:23] [PASSED] supported_formats=0x3 yuv420_allowed=0
[23:57:23] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[23:57:23] [PASSED] drm_test_connector_hdmi_init_null_ddc
[23:57:23] [PASSED] drm_test_connector_hdmi_init_null_product
[23:57:23] [PASSED] drm_test_connector_hdmi_init_null_vendor
[23:57:23] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[23:57:23] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[23:57:23] [PASSED] drm_test_connector_hdmi_init_product_valid
[23:57:23] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[23:57:23] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[23:57:23] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[23:57:23] ========= drm_test_connector_hdmi_init_type_valid  =========
[23:57:23] [PASSED] HDMI-A
[23:57:23] [PASSED] HDMI-B
[23:57:23] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[23:57:23] ======== drm_test_connector_hdmi_init_type_invalid  ========
[23:57:23] [PASSED] Unknown
[23:57:23] [PASSED] VGA
[23:57:23] [PASSED] DVI-I
[23:57:23] [PASSED] DVI-D
[23:57:23] [PASSED] DVI-A
[23:57:23] [PASSED] Composite
[23:57:23] [PASSED] SVIDEO
[23:57:23] [PASSED] LVDS
[23:57:23] [PASSED] Component
[23:57:23] [PASSED] DIN
[23:57:23] [PASSED] DP
[23:57:23] [PASSED] TV
[23:57:23] [PASSED] eDP
[23:57:23] [PASSED] Virtual
[23:57:23] [PASSED] DSI
[23:57:23] [PASSED] DPI
[23:57:23] [PASSED] Writeback
[23:57:23] [PASSED] SPI
[23:57:23] [PASSED] USB
[23:57:23] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[23:57:23] ============ [PASSED] drmm_connector_hdmi_init =============
[23:57:23] ============= drmm_connector_init (3 subtests) =============
[23:57:23] [PASSED] drm_test_drmm_connector_init
[23:57:23] [PASSED] drm_test_drmm_connector_init_null_ddc
[23:57:23] ========= drm_test_drmm_connector_init_type_valid  =========
[23:57:23] [PASSED] Unknown
[23:57:23] [PASSED] VGA
[23:57:23] [PASSED] DVI-I
[23:57:23] [PASSED] DVI-D
[23:57:23] [PASSED] DVI-A
[23:57:23] [PASSED] Composite
[23:57:23] [PASSED] SVIDEO
[23:57:23] [PASSED] LVDS
[23:57:23] [PASSED] Component
[23:57:23] [PASSED] DIN
[23:57:23] [PASSED] DP
[23:57:23] [PASSED] HDMI-A
[23:57:23] [PASSED] HDMI-B
[23:57:23] [PASSED] TV
[23:57:23] [PASSED] eDP
[23:57:23] [PASSED] Virtual
[23:57:23] [PASSED] DSI
[23:57:23] [PASSED] DPI
[23:57:23] [PASSED] Writeback
[23:57:23] [PASSED] SPI
[23:57:23] [PASSED] USB
[23:57:23] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[23:57:23] =============== [PASSED] drmm_connector_init ===============
[23:57:23] ========= drm_connector_dynamic_init (6 subtests) ==========
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_init
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_init_properties
[23:57:23] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[23:57:23] [PASSED] Unknown
[23:57:23] [PASSED] VGA
[23:57:23] [PASSED] DVI-I
[23:57:23] [PASSED] DVI-D
[23:57:23] [PASSED] DVI-A
[23:57:23] [PASSED] Composite
[23:57:23] [PASSED] SVIDEO
[23:57:23] [PASSED] LVDS
[23:57:23] [PASSED] Component
[23:57:23] [PASSED] DIN
[23:57:23] [PASSED] DP
[23:57:23] [PASSED] HDMI-A
[23:57:23] [PASSED] HDMI-B
[23:57:23] [PASSED] TV
[23:57:23] [PASSED] eDP
[23:57:23] [PASSED] Virtual
[23:57:23] [PASSED] DSI
[23:57:23] [PASSED] DPI
[23:57:23] [PASSED] Writeback
[23:57:23] [PASSED] SPI
[23:57:23] [PASSED] USB
[23:57:23] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[23:57:23] ======== drm_test_drm_connector_dynamic_init_name  =========
[23:57:23] [PASSED] Unknown
[23:57:23] [PASSED] VGA
[23:57:23] [PASSED] DVI-I
[23:57:23] [PASSED] DVI-D
[23:57:23] [PASSED] DVI-A
[23:57:23] [PASSED] Composite
[23:57:23] [PASSED] SVIDEO
[23:57:23] [PASSED] LVDS
[23:57:23] [PASSED] Component
[23:57:23] [PASSED] DIN
[23:57:23] [PASSED] DP
[23:57:23] [PASSED] HDMI-A
[23:57:23] [PASSED] HDMI-B
[23:57:23] [PASSED] TV
[23:57:23] [PASSED] eDP
[23:57:23] [PASSED] Virtual
[23:57:23] [PASSED] DSI
[23:57:23] [PASSED] DPI
[23:57:23] [PASSED] Writeback
[23:57:23] [PASSED] SPI
[23:57:23] [PASSED] USB
[23:57:23] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[23:57:23] =========== [PASSED] drm_connector_dynamic_init ============
[23:57:23] ==== drm_connector_dynamic_register_early (4 subtests) =====
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[23:57:23] ====== [PASSED] drm_connector_dynamic_register_early =======
[23:57:23] ======= drm_connector_dynamic_register (7 subtests) ========
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[23:57:23] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[23:57:23] ========= [PASSED] drm_connector_dynamic_register ==========
[23:57:23] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[23:57:23] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[23:57:23] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[23:57:23] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[23:57:23] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[23:57:23] ========== drm_test_get_tv_mode_from_name_valid  ===========
[23:57:23] [PASSED] NTSC
[23:57:23] [PASSED] NTSC-443
[23:57:23] [PASSED] NTSC-J
[23:57:23] [PASSED] PAL
[23:57:23] [PASSED] PAL-M
[23:57:23] [PASSED] PAL-N
[23:57:23] [PASSED] SECAM
[23:57:23] [PASSED] Mono
[23:57:23] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[23:57:23] [PASSED] drm_test_get_tv_mode_from_name_truncated
[23:57:23] ============ [PASSED] drm_get_tv_mode_from_name ============
[23:57:23] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[23:57:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[23:57:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[23:57:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[23:57:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[23:57:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[23:57:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[23:57:23] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[23:57:23] [PASSED] VIC 96
[23:57:23] [PASSED] VIC 97
[23:57:23] [PASSED] VIC 101
[23:57:23] [PASSED] VIC 102
[23:57:23] [PASSED] VIC 106
[23:57:23] [PASSED] VIC 107
[23:57:23] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[23:57:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[23:57:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[23:57:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[23:57:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[23:57:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[23:57:23] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[23:57:23] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[23:57:23] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[23:57:23] [PASSED] Automatic
[23:57:23] [PASSED] Full
[23:57:23] [PASSED] Limited 16:235
[23:57:23] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[23:57:23] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[23:57:23] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[23:57:23] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[23:57:23] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[23:57:23] [PASSED] RGB
[23:57:23] [PASSED] YUV 4:2:0
[23:57:23] [PASSED] YUV 4:2:2
[23:57:23] [PASSED] YUV 4:4:4
[23:57:23] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[23:57:23] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[23:57:23] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[23:57:23] ============= drm_damage_helper (21 subtests) ==============
[23:57:23] [PASSED] drm_test_damage_iter_no_damage
[23:57:23] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[23:57:23] [PASSED] drm_test_damage_iter_no_damage_src_moved
[23:57:23] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[23:57:23] [PASSED] drm_test_damage_iter_no_damage_not_visible
[23:57:23] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[23:57:23] [PASSED] drm_test_damage_iter_no_damage_no_fb
[23:57:23] [PASSED] drm_test_damage_iter_simple_damage
[23:57:23] [PASSED] drm_test_damage_iter_single_damage
[23:57:23] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[23:57:23] [PASSED] drm_test_damage_iter_single_damage_outside_src
[23:57:23] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[23:57:23] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[23:57:23] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[23:57:23] [PASSED] drm_test_damage_iter_single_damage_src_moved
[23:57:23] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[23:57:23] [PASSED] drm_test_damage_iter_damage
[23:57:23] [PASSED] drm_test_damage_iter_damage_one_intersect
[23:57:23] [PASSED] drm_test_damage_iter_damage_one_outside
[23:57:23] [PASSED] drm_test_damage_iter_damage_src_moved
[23:57:23] [PASSED] drm_test_damage_iter_damage_not_visible
[23:57:23] ================ [PASSED] drm_damage_helper ================
[23:57:23] ============== drm_dp_mst_helper (3 subtests) ==============
[23:57:23] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[23:57:23] [PASSED] Clock 154000 BPP 30 DSC disabled
[23:57:23] [PASSED] Clock 234000 BPP 30 DSC disabled
[23:57:23] [PASSED] Clock 297000 BPP 24 DSC disabled
[23:57:23] [PASSED] Clock 332880 BPP 24 DSC enabled
[23:57:23] [PASSED] Clock 324540 BPP 24 DSC enabled
[23:57:23] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[23:57:23] ============== drm_test_dp_mst_calc_pbn_div  ===============
[23:57:23] [PASSED] Link rate 2000000 lane count 4
[23:57:23] [PASSED] Link rate 2000000 lane count 2
[23:57:23] [PASSED] Link rate 2000000 lane count 1
[23:57:23] [PASSED] Link rate 1350000 lane count 4
[23:57:23] [PASSED] Link rate 1350000 lane count 2
[23:57:23] [PASSED] Link rate 1350000 lane count 1
[23:57:23] [PASSED] Link rate 1000000 lane count 4
[23:57:23] [PASSED] Link rate 1000000 lane count 2
[23:57:23] [PASSED] Link rate 1000000 lane count 1
[23:57:23] [PASSED] Link rate 810000 lane count 4
[23:57:23] [PASSED] Link rate 810000 lane count 2
[23:57:23] [PASSED] Link rate 810000 lane count 1
[23:57:23] [PASSED] Link rate 540000 lane count 4
[23:57:23] [PASSED] Link rate 540000 lane count 2
[23:57:23] [PASSED] Link rate 540000 lane count 1
[23:57:23] [PASSED] Link rate 270000 lane count 4
[23:57:23] [PASSED] Link rate 270000 lane count 2
[23:57:23] [PASSED] Link rate 270000 lane count 1
[23:57:23] [PASSED] Link rate 162000 lane count 4
[23:57:23] [PASSED] Link rate 162000 lane count 2
[23:57:23] [PASSED] Link rate 162000 lane count 1
[23:57:23] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[23:57:23] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[23:57:23] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[23:57:23] [PASSED] DP_POWER_UP_PHY with port number
[23:57:23] [PASSED] DP_POWER_DOWN_PHY with port number
[23:57:23] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[23:57:23] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[23:57:23] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[23:57:23] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[23:57:23] [PASSED] DP_QUERY_PAYLOAD with port number
[23:57:23] [PASSED] DP_QUERY_PAYLOAD with VCPI
[23:57:23] [PASSED] DP_REMOTE_DPCD_READ with port number
[23:57:23] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[23:57:23] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[23:57:23] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[23:57:23] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[23:57:23] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[23:57:23] [PASSED] DP_REMOTE_I2C_READ with port number
[23:57:23] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[23:57:23] [PASSED] DP_REMOTE_I2C_READ with transactions array
[23:57:23] [PASSED] DP_REMOTE_I2C_WRITE with port number
[23:57:23] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[23:57:23] [PASSED] DP_REMOTE_I2C_WRITE with data array
[23:57:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[23:57:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[23:57:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[23:57:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[23:57:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[23:57:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[23:57:23] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[23:57:23] ================ [PASSED] drm_dp_mst_helper ================
[23:57:23] ================== drm_exec (7 subtests) ===================
[23:57:23] [PASSED] sanitycheck
[23:57:23] [PASSED] test_lock
[23:57:23] [PASSED] test_lock_unlock
[23:57:23] [PASSED] test_duplicates
[23:57:23] [PASSED] test_prepare
[23:57:23] [PASSED] test_prepare_array
[23:57:23] [PASSED] test_multiple_loops
[23:57:23] ==================== [PASSED] drm_exec =====================
[23:57:23] =========== drm_format_helper_test (17 subtests) ===========
[23:57:23] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[23:57:23] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[23:57:23] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[23:57:23] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[23:57:23] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[23:57:23] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[23:57:23] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[23:57:23] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[23:57:23] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[23:57:23] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[23:57:23] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[23:57:23] ============== drm_test_fb_xrgb8888_to_mono  ===============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[23:57:23] ==================== drm_test_fb_swab  =====================
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ================ [PASSED] drm_test_fb_swab =================
[23:57:23] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[23:57:23] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[23:57:23] [PASSED] single_pixel_source_buffer
[23:57:23] [PASSED] single_pixel_clip_rectangle
[23:57:23] [PASSED] well_known_colors
[23:57:23] [PASSED] destination_pitch
[23:57:23] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[23:57:23] ================= drm_test_fb_clip_offset  =================
[23:57:23] [PASSED] pass through
[23:57:23] [PASSED] horizontal offset
[23:57:23] [PASSED] vertical offset
[23:57:23] [PASSED] horizontal and vertical offset
[23:57:23] [PASSED] horizontal offset (custom pitch)
[23:57:23] [PASSED] vertical offset (custom pitch)
[23:57:23] [PASSED] horizontal and vertical offset (custom pitch)
[23:57:23] ============= [PASSED] drm_test_fb_clip_offset =============
[23:57:23] =================== drm_test_fb_memcpy  ====================
[23:57:23] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[23:57:23] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[23:57:23] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[23:57:23] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[23:57:23] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[23:57:23] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[23:57:23] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[23:57:23] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[23:57:23] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[23:57:23] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[23:57:23] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[23:57:23] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[23:57:23] =============== [PASSED] drm_test_fb_memcpy ================
[23:57:23] ============= [PASSED] drm_format_helper_test ==============
[23:57:23] ================= drm_format (18 subtests) =================
[23:57:23] [PASSED] drm_test_format_block_width_invalid
[23:57:23] [PASSED] drm_test_format_block_width_one_plane
[23:57:23] [PASSED] drm_test_format_block_width_two_plane
[23:57:23] [PASSED] drm_test_format_block_width_three_plane
[23:57:23] [PASSED] drm_test_format_block_width_tiled
[23:57:23] [PASSED] drm_test_format_block_height_invalid
[23:57:23] [PASSED] drm_test_format_block_height_one_plane
[23:57:23] [PASSED] drm_test_format_block_height_two_plane
[23:57:23] [PASSED] drm_test_format_block_height_three_plane
[23:57:23] [PASSED] drm_test_format_block_height_tiled
[23:57:23] [PASSED] drm_test_format_min_pitch_invalid
[23:57:23] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[23:57:23] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[23:57:23] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[23:57:23] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[23:57:23] [PASSED] drm_test_format_min_pitch_two_plane
[23:57:23] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[23:57:23] [PASSED] drm_test_format_min_pitch_tiled
[23:57:23] =================== [PASSED] drm_format ====================
[23:57:23] ============== drm_framebuffer (10 subtests) ===============
[23:57:23] ========== drm_test_framebuffer_check_src_coords  ==========
[23:57:23] [PASSED] Success: source fits into fb
[23:57:23] [PASSED] Fail: overflowing fb with x-axis coordinate
[23:57:23] [PASSED] Fail: overflowing fb with y-axis coordinate
[23:57:23] [PASSED] Fail: overflowing fb with source width
[23:57:23] [PASSED] Fail: overflowing fb with source height
[23:57:23] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[23:57:23] [PASSED] drm_test_framebuffer_cleanup
[23:57:23] =============== drm_test_framebuffer_create  ===============
[23:57:23] [PASSED] ABGR8888 normal sizes
[23:57:23] [PASSED] ABGR8888 max sizes
[23:57:23] [PASSED] ABGR8888 pitch greater than min required
[23:57:23] [PASSED] ABGR8888 pitch less than min required
[23:57:23] [PASSED] ABGR8888 Invalid width
[23:57:23] [PASSED] ABGR8888 Invalid buffer handle
[23:57:23] [PASSED] No pixel format
[23:57:23] [PASSED] ABGR8888 Width 0
[23:57:23] [PASSED] ABGR8888 Height 0
[23:57:23] [PASSED] ABGR8888 Out of bound height * pitch combination
[23:57:23] [PASSED] ABGR8888 Large buffer offset
[23:57:23] [PASSED] ABGR8888 Buffer offset for inexistent plane
[23:57:23] [PASSED] ABGR8888 Invalid flag
[23:57:23] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[23:57:23] [PASSED] ABGR8888 Valid buffer modifier
[23:57:23] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[23:57:23] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[23:57:23] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[23:57:23] [PASSED] NV12 Normal sizes
[23:57:23] [PASSED] NV12 Max sizes
[23:57:23] [PASSED] NV12 Invalid pitch
[23:57:23] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[23:57:23] [PASSED] NV12 different  modifier per-plane
[23:57:23] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[23:57:23] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[23:57:23] [PASSED] NV12 Modifier for inexistent plane
[23:57:23] [PASSED] NV12 Handle for inexistent plane
[23:57:23] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[23:57:23] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[23:57:23] [PASSED] YVU420 Normal sizes
[23:57:23] [PASSED] YVU420 Max sizes
[23:57:23] [PASSED] YVU420 Invalid pitch
[23:57:23] [PASSED] YVU420 Different pitches
[23:57:23] [PASSED] YVU420 Different buffer offsets/pitches
[23:57:23] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[23:57:23] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[23:57:23] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[23:57:23] [PASSED] YVU420 Valid modifier
[23:57:23] [PASSED] YVU420 Different modifiers per plane
[23:57:23] [PASSED] YVU420 Modifier for inexistent plane
[23:57:23] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[23:57:23] [PASSED] X0L2 Normal sizes
[23:57:23] [PASSED] X0L2 Max sizes
[23:57:23] [PASSED] X0L2 Invalid pitch
[23:57:23] [PASSED] X0L2 Pitch greater than minimum required
[23:57:23] [PASSED] X0L2 Handle for inexistent plane
[23:57:23] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[23:57:23] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[23:57:23] [PASSED] X0L2 Valid modifier
[23:57:23] [PASSED] X0L2 Modifier for inexistent plane
[23:57:23] =========== [PASSED] drm_test_framebuffer_create ===========
[23:57:23] [PASSED] drm_test_framebuffer_free
[23:57:23] [PASSED] drm_test_framebuffer_init
[23:57:23] [PASSED] drm_test_framebuffer_init_bad_format
[23:57:23] [PASSED] drm_test_framebuffer_init_dev_mismatch
[23:57:23] [PASSED] drm_test_framebuffer_lookup
[23:57:23] [PASSED] drm_test_framebuffer_lookup_inexistent
[23:57:23] [PASSED] drm_test_framebuffer_modifiers_not_supported
[23:57:23] ================= [PASSED] drm_framebuffer =================
[23:57:23] ================ drm_gem_shmem (8 subtests) ================
[23:57:23] [PASSED] drm_gem_shmem_test_obj_create
[23:57:23] [PASSED] drm_gem_shmem_test_obj_create_private
[23:57:23] [PASSED] drm_gem_shmem_test_pin_pages
[23:57:23] [PASSED] drm_gem_shmem_test_vmap
[23:57:23] [PASSED] drm_gem_shmem_test_get_pages_sgt
[23:57:23] [PASSED] drm_gem_shmem_test_get_sg_table
[23:57:23] [PASSED] drm_gem_shmem_test_madvise
[23:57:23] [PASSED] drm_gem_shmem_test_purge
[23:57:23] ================== [PASSED] drm_gem_shmem ==================
[23:57:23] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[23:57:23] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[23:57:23] [PASSED] Automatic
[23:57:23] [PASSED] Full
[23:57:23] [PASSED] Limited 16:235
[23:57:23] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[23:57:23] [PASSED] drm_test_check_disable_connector
[23:57:23] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[23:57:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[23:57:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[23:57:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[23:57:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[23:57:23] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[23:57:23] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[23:57:23] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[23:57:23] [PASSED] drm_test_check_output_bpc_dvi
[23:57:23] [PASSED] drm_test_check_output_bpc_format_vic_1
[23:57:23] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[23:57:23] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[23:57:23] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[23:57:23] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[23:57:23] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[23:57:23] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[23:57:23] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[23:57:23] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[23:57:23] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[23:57:23] [PASSED] drm_test_check_broadcast_rgb_value
[23:57:23] [PASSED] drm_test_check_bpc_8_value
[23:57:23] [PASSED] drm_test_check_bpc_10_value
[23:57:23] [PASSED] drm_test_check_bpc_12_value
[23:57:23] [PASSED] drm_test_check_format_value
[23:57:23] [PASSED] drm_test_check_tmds_char_value
[23:57:23] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[23:57:23] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[23:57:23] [PASSED] drm_test_check_mode_valid
[23:57:23] [PASSED] drm_test_check_mode_valid_reject
[23:57:23] [PASSED] drm_test_check_mode_valid_reject_rate
[23:57:23] [PASSED] drm_test_check_mode_valid_reject_max_clock
[23:57:23] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[23:57:23] ================= drm_managed (2 subtests) =================
[23:57:23] [PASSED] drm_test_managed_release_action
[23:57:23] [PASSED] drm_test_managed_run_action
[23:57:23] =================== [PASSED] drm_managed ===================
[23:57:23] =================== drm_mm (6 subtests) ====================
[23:57:23] [PASSED] drm_test_mm_init
[23:57:23] [PASSED] drm_test_mm_debug
[23:57:23] [PASSED] drm_test_mm_align32
[23:57:23] [PASSED] drm_test_mm_align64
[23:57:23] [PASSED] drm_test_mm_lowest
[23:57:23] [PASSED] drm_test_mm_highest
[23:57:23] ===================== [PASSED] drm_mm ======================
[23:57:23] ============= drm_modes_analog_tv (5 subtests) =============
[23:57:23] [PASSED] drm_test_modes_analog_tv_mono_576i
[23:57:23] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[23:57:23] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[23:57:23] [PASSED] drm_test_modes_analog_tv_pal_576i
[23:57:23] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[23:57:23] =============== [PASSED] drm_modes_analog_tv ===============
[23:57:23] ============== drm_plane_helper (2 subtests) ===============
[23:57:23] =============== drm_test_check_plane_state  ================
[23:57:23] [PASSED] clipping_simple
[23:57:23] [PASSED] clipping_rotate_reflect
[23:57:23] [PASSED] positioning_simple
[23:57:23] [PASSED] upscaling
[23:57:23] [PASSED] downscaling
[23:57:23] [PASSED] rounding1
[23:57:23] [PASSED] rounding2
[23:57:23] [PASSED] rounding3
[23:57:23] [PASSED] rounding4
[23:57:23] =========== [PASSED] drm_test_check_plane_state ============
[23:57:23] =========== drm_test_check_invalid_plane_state  ============
[23:57:23] [PASSED] positioning_invalid
[23:57:23] [PASSED] upscaling_invalid
[23:57:23] [PASSED] downscaling_invalid
[23:57:23] ======= [PASSED] drm_test_check_invalid_plane_state ========
[23:57:23] ================ [PASSED] drm_plane_helper =================
[23:57:23] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[23:57:23] ====== drm_test_connector_helper_tv_get_modes_check  =======
[23:57:23] [PASSED] None
[23:57:23] [PASSED] PAL
[23:57:23] [PASSED] NTSC
[23:57:23] [PASSED] Both, NTSC Default
[23:57:23] [PASSED] Both, PAL Default
[23:57:23] [PASSED] Both, NTSC Default, with PAL on command-line
[23:57:23] [PASSED] Both, PAL Default, with NTSC on command-line
[23:57:23] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[23:57:23] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[23:57:23] ================== drm_rect (9 subtests) ===================
[23:57:23] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[23:57:23] [PASSED] drm_test_rect_clip_scaled_not_clipped
[23:57:23] [PASSED] drm_test_rect_clip_scaled_clipped
[23:57:23] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[23:57:23] ================= drm_test_rect_intersect  =================
[23:57:23] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[23:57:23] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[23:57:23] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[23:57:23] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[23:57:23] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[23:57:23] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[23:57:23] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[23:57:23] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[23:57:23] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[23:57:23] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[23:57:23] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[23:57:23] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[23:57:23] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[23:57:23] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[23:57:23] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[23:57:23] ============= [PASSED] drm_test_rect_intersect =============
[23:57:23] ================ drm_test_rect_calc_hscale  ================
[23:57:23] [PASSED] normal use
[23:57:23] [PASSED] out of max range
[23:57:23] [PASSED] out of min range
[23:57:23] [PASSED] zero dst
[23:57:23] [PASSED] negative src
[23:57:23] [PASSED] negative dst
[23:57:23] ============ [PASSED] drm_test_rect_calc_hscale ============
[23:57:23] ================ drm_test_rect_calc_vscale  ================
[23:57:23] [PASSED] normal use
[23:57:23] [PASSED] out of max range
[23:57:23] [PASSED] out of min range
[23:57:23] [PASSED] zero dst
[23:57:23] [PASSED] negative src
stty: 'standard input': Inappropriate ioctl for device
[23:57:23] [PASSED] negative dst
[23:57:23] ============ [PASSED] drm_test_rect_calc_vscale ============
[23:57:23] ================== drm_test_rect_rotate  ===================
[23:57:23] [PASSED] reflect-x
[23:57:23] [PASSED] reflect-y
[23:57:23] [PASSED] rotate-0
[23:57:23] [PASSED] rotate-90
[23:57:23] [PASSED] rotate-180
[23:57:23] [PASSED] rotate-270
[23:57:23] ============== [PASSED] drm_test_rect_rotate ===============
[23:57:23] ================ drm_test_rect_rotate_inv  =================
[23:57:23] [PASSED] reflect-x
[23:57:23] [PASSED] reflect-y
[23:57:23] [PASSED] rotate-0
[23:57:23] [PASSED] rotate-90
[23:57:23] [PASSED] rotate-180
[23:57:23] [PASSED] rotate-270
[23:57:23] ============ [PASSED] drm_test_rect_rotate_inv =============
[23:57:23] ==================== [PASSED] drm_rect =====================
[23:57:23] ============ drm_sysfb_modeset_test (1 subtest) ============
[23:57:23] ============ drm_test_sysfb_build_fourcc_list  =============
[23:57:23] [PASSED] no native formats
[23:57:23] [PASSED] XRGB8888 as native format
[23:57:23] [PASSED] remove duplicates
[23:57:23] [PASSED] convert alpha formats
[23:57:23] [PASSED] random formats
[23:57:23] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[23:57:23] ============= [PASSED] drm_sysfb_modeset_test ==============
[23:57:23] ============================================================
[23:57:23] Testing complete. Ran 621 tests: passed: 621
[23:57:23] Elapsed time: 25.654s total, 1.756s configuring, 23.728s building, 0.152s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [23:57:24] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[23:57:25] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[23:57:34] Starting KUnit Kernel (1/1)...
[23:57:34] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[23:57:34] ================= ttm_device (5 subtests) ==================
[23:57:34] [PASSED] ttm_device_init_basic
[23:57:34] [PASSED] ttm_device_init_multiple
[23:57:34] [PASSED] ttm_device_fini_basic
[23:57:34] [PASSED] ttm_device_init_no_vma_man
[23:57:34] ================== ttm_device_init_pools  ==================
[23:57:34] [PASSED] No DMA allocations, no DMA32 required
[23:57:34] [PASSED] DMA allocations, DMA32 required
[23:57:34] [PASSED] No DMA allocations, DMA32 required
[23:57:34] [PASSED] DMA allocations, no DMA32 required
[23:57:34] ============== [PASSED] ttm_device_init_pools ==============
[23:57:34] =================== [PASSED] ttm_device ====================
[23:57:34] ================== ttm_pool (8 subtests) ===================
[23:57:34] ================== ttm_pool_alloc_basic  ===================
[23:57:34] [PASSED] One page
[23:57:34] [PASSED] More than one page
[23:57:34] [PASSED] Above the allocation limit
[23:57:34] [PASSED] One page, with coherent DMA mappings enabled
[23:57:34] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[23:57:34] ============== [PASSED] ttm_pool_alloc_basic ===============
[23:57:34] ============== ttm_pool_alloc_basic_dma_addr  ==============
[23:57:34] [PASSED] One page
[23:57:34] [PASSED] More than one page
[23:57:34] [PASSED] Above the allocation limit
[23:57:34] [PASSED] One page, with coherent DMA mappings enabled
[23:57:34] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[23:57:34] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[23:57:34] [PASSED] ttm_pool_alloc_order_caching_match
[23:57:34] [PASSED] ttm_pool_alloc_caching_mismatch
[23:57:34] [PASSED] ttm_pool_alloc_order_mismatch
[23:57:34] [PASSED] ttm_pool_free_dma_alloc
[23:57:34] [PASSED] ttm_pool_free_no_dma_alloc
[23:57:34] [PASSED] ttm_pool_fini_basic
[23:57:34] ==================== [PASSED] ttm_pool =====================
[23:57:34] ================ ttm_resource (8 subtests) =================
[23:57:34] ================= ttm_resource_init_basic  =================
[23:57:34] [PASSED] Init resource in TTM_PL_SYSTEM
[23:57:34] [PASSED] Init resource in TTM_PL_VRAM
[23:57:34] [PASSED] Init resource in a private placement
[23:57:34] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[23:57:34] ============= [PASSED] ttm_resource_init_basic =============
[23:57:34] [PASSED] ttm_resource_init_pinned
[23:57:34] [PASSED] ttm_resource_fini_basic
[23:57:34] [PASSED] ttm_resource_manager_init_basic
[23:57:34] [PASSED] ttm_resource_manager_usage_basic
[23:57:34] [PASSED] ttm_resource_manager_set_used_basic
[23:57:34] [PASSED] ttm_sys_man_alloc_basic
[23:57:34] [PASSED] ttm_sys_man_free_basic
[23:57:34] ================== [PASSED] ttm_resource ===================
[23:57:34] =================== ttm_tt (15 subtests) ===================
[23:57:34] ==================== ttm_tt_init_basic  ====================
[23:57:34] [PASSED] Page-aligned size
[23:57:34] [PASSED] Extra pages requested
[23:57:34] ================ [PASSED] ttm_tt_init_basic ================
[23:57:34] [PASSED] ttm_tt_init_misaligned
[23:57:34] [PASSED] ttm_tt_fini_basic
[23:57:34] [PASSED] ttm_tt_fini_sg
[23:57:34] [PASSED] ttm_tt_fini_shmem
[23:57:34] [PASSED] ttm_tt_create_basic
[23:57:34] [PASSED] ttm_tt_create_invalid_bo_type
[23:57:34] [PASSED] ttm_tt_create_ttm_exists
[23:57:34] [PASSED] ttm_tt_create_failed
[23:57:34] [PASSED] ttm_tt_destroy_basic
[23:57:34] [PASSED] ttm_tt_populate_null_ttm
[23:57:34] [PASSED] ttm_tt_populate_populated_ttm
[23:57:34] [PASSED] ttm_tt_unpopulate_basic
[23:57:34] [PASSED] ttm_tt_unpopulate_empty_ttm
[23:57:34] [PASSED] ttm_tt_swapin_basic
[23:57:34] ===================== [PASSED] ttm_tt ======================
[23:57:34] =================== ttm_bo (14 subtests) ===================
[23:57:34] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[23:57:34] [PASSED] Cannot be interrupted and sleeps
[23:57:34] [PASSED] Cannot be interrupted, locks straight away
[23:57:34] [PASSED] Can be interrupted, sleeps
[23:57:34] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[23:57:34] [PASSED] ttm_bo_reserve_locked_no_sleep
[23:57:34] [PASSED] ttm_bo_reserve_no_wait_ticket
[23:57:34] [PASSED] ttm_bo_reserve_double_resv
[23:57:34] [PASSED] ttm_bo_reserve_interrupted
[23:57:34] [PASSED] ttm_bo_reserve_deadlock
[23:57:34] [PASSED] ttm_bo_unreserve_basic
[23:57:34] [PASSED] ttm_bo_unreserve_pinned
[23:57:34] [PASSED] ttm_bo_unreserve_bulk
[23:57:34] [PASSED] ttm_bo_fini_basic
[23:57:34] [PASSED] ttm_bo_fini_shared_resv
[23:57:34] [PASSED] ttm_bo_pin_basic
[23:57:34] [PASSED] ttm_bo_pin_unpin_resource
[23:57:34] [PASSED] ttm_bo_multiple_pin_one_unpin
[23:57:34] ===================== [PASSED] ttm_bo ======================
[23:57:34] ============== ttm_bo_validate (21 subtests) ===============
[23:57:34] ============== ttm_bo_init_reserved_sys_man  ===============
[23:57:34] [PASSED] Buffer object for userspace
[23:57:34] [PASSED] Kernel buffer object
[23:57:34] [PASSED] Shared buffer object
[23:57:34] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[23:57:34] ============== ttm_bo_init_reserved_mock_man  ==============
[23:57:34] [PASSED] Buffer object for userspace
[23:57:34] [PASSED] Kernel buffer object
[23:57:34] [PASSED] Shared buffer object
[23:57:34] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[23:57:34] [PASSED] ttm_bo_init_reserved_resv
[23:57:34] ================== ttm_bo_validate_basic  ==================
[23:57:34] [PASSED] Buffer object for userspace
[23:57:34] [PASSED] Kernel buffer object
[23:57:34] [PASSED] Shared buffer object
[23:57:34] ============== [PASSED] ttm_bo_validate_basic ==============
[23:57:34] [PASSED] ttm_bo_validate_invalid_placement
[23:57:34] ============= ttm_bo_validate_same_placement  ==============
[23:57:34] [PASSED] System manager
[23:57:34] [PASSED] VRAM manager
[23:57:34] ========= [PASSED] ttm_bo_validate_same_placement ==========
[23:57:34] [PASSED] ttm_bo_validate_failed_alloc
[23:57:34] [PASSED] ttm_bo_validate_pinned
[23:57:34] [PASSED] ttm_bo_validate_busy_placement
[23:57:34] ================ ttm_bo_validate_multihop  =================
[23:57:34] [PASSED] Buffer object for userspace
[23:57:34] [PASSED] Kernel buffer object
[23:57:34] [PASSED] Shared buffer object
[23:57:34] ============ [PASSED] ttm_bo_validate_multihop =============
[23:57:34] ========== ttm_bo_validate_no_placement_signaled  ==========
[23:57:34] [PASSED] Buffer object in system domain, no page vector
[23:57:34] [PASSED] Buffer object in system domain with an existing page vector
[23:57:34] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[23:57:34] ======== ttm_bo_validate_no_placement_not_signaled  ========
[23:57:34] [PASSED] Buffer object for userspace
[23:57:34] [PASSED] Kernel buffer object
[23:57:34] [PASSED] Shared buffer object
[23:57:34] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[23:57:34] [PASSED] ttm_bo_validate_move_fence_signaled
[23:57:35] ========= ttm_bo_validate_move_fence_not_signaled  =========
[23:57:35] [PASSED] Waits for GPU
[23:57:35] [PASSED] Tries to lock straight away
[23:57:35] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[23:57:35] [PASSED] ttm_bo_validate_happy_evict
[23:57:35] [PASSED] ttm_bo_validate_all_pinned_evict
[23:57:35] [PASSED] ttm_bo_validate_allowed_only_evict
[23:57:35] [PASSED] ttm_bo_validate_deleted_evict
[23:57:35] [PASSED] ttm_bo_validate_busy_domain_evict
[23:57:35] [PASSED] ttm_bo_validate_evict_gutting
[23:57:35] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[23:57:35] ================= [PASSED] ttm_bo_validate =================
[23:57:35] ============================================================
[23:57:35] Testing complete. Ran 101 tests: passed: 101
[23:57:35] Elapsed time: 11.067s total, 1.732s configuring, 9.119s building, 0.181s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

#41 lore raw

✗ Xe.CI.BAT: failure for Allow configfs to disable specific GT type(s) (rev2)

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: Allow configfs to disable specific GT type(s) (rev2)
URL : https://patchwork.freedesktop.org/series/154739/
State : failure

== Summary ==

CI Bug Log - changes from xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d_BAT -> xe-pw-154739v2_BAT
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with xe-pw-154739v2_BAT need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in xe-pw-154739v2_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in xe-pw-154739v2_BAT:

### IGT changes ###

#### Warnings ####

* igt@sriov_basic@enable-vfs-autoprobe-on:
- bat-bmg-2: [DMESG-WARN][1] ([Intel XE#6190]) -> [ABORT][2] +1 other test abort
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d/bat-bmg-2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154739v2/bat-bmg-2/igt@[email protected]

* igt@sriov_basic@enable-vfs-autoprobe-on@numvfs-1:
- bat-bmg-1: [DMESG-WARN][3] ([Intel XE#6190]) -> [ABORT][4] +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d/bat-bmg-1/igt@sriov_basic@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154739v2/bat-bmg-1/igt@sriov_basic@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@sriov_basic@enable-vfs-autoprobe-on:
- {bat-ptl-1}: [PASS][5] -> [ABORT][6] +1 other test abort
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d/bat-ptl-1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154739v2/bat-ptl-1/igt@[email protected]

* igt@sriov_basic@enable-vfs-autoprobe-on@numvfs-1:
- {bat-ptl-2}: [PASS][7] -> [ABORT][8] +1 other test abort
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d/bat-ptl-2/igt@sriov_basic@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154739v2/bat-ptl-2/igt@sriov_basic@[email protected]

* igt@xe_module_load@load:
- {bat-ptl-vm}: [PASS][9] -> [ABORT][10]
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d/bat-ptl-vm/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154739v2/bat-ptl-vm/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#6190]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6190

Build changes
-------------

* IGT: IGT_8552 -> IGT_8554
* Linux: xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d -> xe-pw-154739v2

IGT_8552: 8552
IGT_8554: 8554
xe-3830-927b4d44359a2e2b1782f80bb5302950d8a7cb6d: 927b4d44359a2e2b1782f80bb5302950d8a7cb6d
xe-pw-154739v2: 154739v2

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154739v2/index.html