Skip to contentSkip to conversation

arm64: dts: qcom: x1-dell-thena: Add missing pinctrl for eDP HPD

PATCH Superseded Val Packett 2 participants 2 messages Sep 27, 2025

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: x1-dell-thena: Add missing pinctrl for eDP HPD

Match the change for the XPS 13 (a41d2314) as the board is identical between the XPS and the Latitude/Inspiron.

This allows us not to rely on the boot firmware to set up the pinctrl for the eDP HPD line of the internal display.

Fixes e7733b42111c ("arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455")
---
 arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi +3 -0
index ef83e87e1b7a..0aad80a1159c 100644
@@ -1104,6 +1104,9 @@ &mdss_dp1_out {
 &mdss_dp3 {
 	/delete-property/ #sound-dai-cells;
 
+	pinctrl-0 = <&edp0_hpd_default>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	aux-bus {
Signature · 1 line
2.51.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Val Packett

Match the change for the XPS 13 (a41d2314) as the board is identical between the XPS and the Latitude/Inspiron.

Same comment on the commit identification.

Also, are the boards identical ? I don't think that statement is true, say the "board DP here is identical" but there are GPIOs on the PCBs which read back different values to differentiate.

They are not identical PCBs.

Quoted 15 lines

This allows us not to rely on the boot firmware to set up the pinctrl for the eDP HPD line of the internal display.

Fixes e7733b42111c ("arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455")
---
  arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 3 +++
  1 file changed, 3 insertions(+)
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi +0 -0
index ef83e87e1b7a..0aad80a1159c 100644

arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi &mdss_dp1_out { · line 1112

Quoted 9 lines
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi +3 -0
@@ -1104,6 +1104,9 @@ &mdss_dp1_out {
  &mdss_dp3 {
  	/delete-property/ #sound-dai-cells;
 
+	pinctrl-0 = <&edp0_hpd_default>;
+	pinctrl-names = "default";
+
  	status = "okay";
 
  	aux-bus {

Once fixed.