Skip to contentSkip to conversation

scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM

PATCH Superseded Xose Vazquez Perez 2 participants 4 messages Oct 4, 2025 – Mar 19 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM

DISK-SUBSYSTEM is a special model name returned when LUs are not installed in "OPEN-" models. Full info: https://marc.info/?l=linux-scsi&m=125424006417825

Cc Ewan D. Milne <[email protected]>
Cc Anthony Cheung <[email protected]>
Cc Takahiro Yasui <[email protected]>
Cc Matthias Rudolph <[email protected]>
Cc James E.J. Bottomley <[email protected]>
Cc Martin K. Petersen <[email protected]>
Cc SCSI-ML <[email protected]>
---
 drivers/scsi/scsi_devinfo.c | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/scsi_devinfo.c +1 -0
index 78346b2b69c9..b39019f57db6 100644
@@ -185,6 +185,7 @@ static struct {
 	{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
 	{"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
 	{"HPE", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
+	{"HPE", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
 	{"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN},
 	{"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"IBM", "2076", NULL, BLIST_NO_VPD_SIZE},
Signature · 1 line
2.51.0
#1 lore raw

On 10/4/25 4:54 PM, Xose Vazquez Perez wrote:

Same here, any problem/drawback?

Quoted 27 lines

DISK-SUBSYSTEM is a special model name returned when LUs are not installed in "OPEN-" models. Full info: https://marc.info/?l=linux-scsi&m=125424006417825

Cc Ewan D. Milne <[email protected]>
Cc Anthony Cheung <[email protected]>
Cc Takahiro Yasui <[email protected]>
Cc Matthias Rudolph <[email protected]>
Cc James E.J. Bottomley <[email protected]>
Cc Martin K. Petersen <[email protected]>
Cc SCSI-ML <[email protected]>
---
  drivers/scsi/scsi_devinfo.c | 1 +
  1 file changed, 1 insertion(+)
drivers/scsi/scsi_devinfo.c +1 -0
index 78346b2b69c9..b39019f57db6 100644
@@ -185,6 +185,7 @@ static struct {
  	{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
  	{"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
  	{"HPE", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
+	{"HPE", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
  	{"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN},
  	{"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
  	{"IBM", "2076", NULL, BLIST_NO_VPD_SIZE},
#2 lore raw
Quoted 3 lines · Xose Vazquez Perez

On 10/4/25 4:54 PM, Xose Vazquez Perez wrote:

Same here, any problem/drawback?

The could be asked the other way around. What serious enough problem are you trying to fix that warrants bloating the devinfo lists?

#3 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · Xose Vazquez Perez

On 10/4/25 4:54 PM, Xose Vazquez Perez wrote:

Same here, any problem/drawback?

The could be asked the other way around. What serious enough problem are you trying to fix that warrants bloating the devinfo lists?

This entry was originally covered when "HP" was used as a prefix, as seen in (add HP DISK-SUBSYSTEM device, for HP XP arrays)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f96f42b76e00e2871033745ff029056cc725c76

However, after (fixup string compare: ... Vendor strings must match exactly)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b8018b973c7cefa5eb386540130fa47315b8e337
the "HP" entry no longer covers devices reporting as "HPE".

This patch simply restores the intended behavior for the newer "HPE" vendor string.

Thanks.

[ This thread is almost six months old, for reference:
https://lore.kernel.org/linux-scsi/[email protected]/ ]