clk: qcom: gcc-x1e80100: Enable runtime PM
Subsystems (3)
PATCH 1/1 clk: qcom: gcc-x1e80100: Enable runtime PM
Enable the main clock controller driver to participate in runtime power management.
---
Seems like this would be one of the prerequisites for actually reaching deeper power states.. I've been running with this patch on a Dell Latitude 7455 for quite a while, did not see any harm for sure.
--- drivers/clk/qcom/gcc-x1e80100.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/qcom/gcc-x1e80100.c +1 -0
@@ -6721,6 +6721,7 @@ static const struct qcom_cc_desc gcc_x1e80100_desc = { .num_resets = ARRAY_SIZE(gcc_x1e80100_resets), .gdscs = gcc_x1e80100_gdscs, .num_gdscs = ARRAY_SIZE(gcc_x1e80100_gdscs), + .use_rpm = true, };static const struct of_device_id gcc_x1e80100_match_table[] = {
Signature · 1 line
2.51.0
Quoted 17 lines · Val Packett
Enable the main clock controller driver to participate in runtime power management.
Signed-off-by Val Packett <[email protected]>---
Seems like this would be one of the prerequisites for actually reaching deeper power states.. I've been running with this patch on a Dell Latitude 7455 for quite a while, did not see any harm for sure.--- drivers/clk/qcom/gcc-x1e80100.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/qcom/gcc-x1e80100.c +0
-0
drivers/clk/qcom/gcc-x1e80100.c static const struct qcom_cc_desc gcc_x1e80100_desc = { · line 6724
Quoted 4 lines
drivers/clk/qcom/gcc-x1e80100.c +1
-0@@ -6721,6 +6721,7 @@ static const struct qcom_cc_desc gcc_x1e80100_desc = { .num_resets = ARRAY_SIZE(gcc_x1e80100_resets), .gdscs = gcc_x1e80100_gdscs, .num_gdscs = ARRAY_SIZE(gcc_x1e80100_gdscs), + .use_rpm = true,
This is not required to be set for the global clock controller as 'CX' is the rail powering this clock controller.
Quoted 3 lines
drivers/clk/qcom/gcc-x1e80100.c +0
-0};static const struct of_device_id gcc_x1e80100_match_table[] = {
Signature · 2 lines
Thanks, Taniya Das
Quoted 2 lines · Val Packett
Enable the main clock controller driver to participate in runtime power management.
The commit message does not explain whether there's any observable benefits to this change
Quoted 5 lines
Signed-off-by Val Packett <[email protected]>---
Seems like this would be one of the prerequisites for actually reaching deeper power states.. I've been running with this patch on a Dell Latitude 7455 for quite a while, did not see any harm for sure.
"seems like" is vague.. is there any change in behavior that suggests this really makes a difference?
Konrad