Skip to contentSkip to conversation

clk: qcom: gcc-x1e80100: Enable runtime PM

PATCH In review Val Packett 3 participants 3 messages Oct 12, 2025 – Oct 29, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: qcom: gcc-x1e80100: Enable runtime PM

Enable the main clock controller driver to participate in runtime power management.

---
Seems like this would be one of the prerequisites for actually reaching deeper power states.. I've been running with this patch on a Dell Latitude 7455 for quite a while, did not see any harm for sure.

---
 drivers/clk/qcom/gcc-x1e80100.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/qcom/gcc-x1e80100.c +1 -0
index 301fc9fc32d8..96bb604c6378 100644
@@ -6721,6 +6721,7 @@ static const struct qcom_cc_desc gcc_x1e80100_desc = {
 	.num_resets = ARRAY_SIZE(gcc_x1e80100_resets),
 	.gdscs = gcc_x1e80100_gdscs,
 	.num_gdscs = ARRAY_SIZE(gcc_x1e80100_gdscs),
+	.use_rpm = true,
 };
 
 static const struct of_device_id gcc_x1e80100_match_table[] = {
Signature · 1 line
2.51.0
#1 lore raw
Quoted 17 lines · Val Packett

Enable the main clock controller driver to participate in runtime power management.

---
Seems like this would be one of the prerequisites for actually reaching deeper power states.. I've been running with this patch on a Dell Latitude 7455 for quite a while, did not see any harm for sure.

---
 drivers/clk/qcom/gcc-x1e80100.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/qcom/gcc-x1e80100.c +0 -0
index 301fc9fc32d8..96bb604c6378 100644

drivers/clk/qcom/gcc-x1e80100.c static const struct qcom_cc_desc gcc_x1e80100_desc = { · line 6724

Quoted 4 lines
drivers/clk/qcom/gcc-x1e80100.c +1 -0
@@ -6721,6 +6721,7 @@ static const struct qcom_cc_desc gcc_x1e80100_desc = {
 	.num_resets = ARRAY_SIZE(gcc_x1e80100_resets),
 	.gdscs = gcc_x1e80100_gdscs,
 	.num_gdscs = ARRAY_SIZE(gcc_x1e80100_gdscs),
+	.use_rpm = true,

This is not required to be set for the global clock controller as 'CX' is the rail powering this clock controller.

Quoted 3 lines
drivers/clk/qcom/gcc-x1e80100.c +0 -0
 };
 
 static const struct of_device_id gcc_x1e80100_match_table[] = {
Signature · 2 lines
Thanks,
Taniya Das
#2 lore raw
In reply to Val Packett
Quoted 2 lines · Val Packett

Enable the main clock controller driver to participate in runtime power management.

The commit message does not explain whether there's any observable benefits to this change

Quoted 5 lines

---
Seems like this would be one of the prerequisites for actually reaching deeper power states.. I've been running with this patch on a Dell Latitude 7455 for quite a while, did not see any harm for sure.

"seems like" is vague.. is there any change in behavior that suggests this really makes a difference?

Konrad