perf trace: Don't synthesize mmaps unless callchains are enabled
Ian Rogers
reviewerPATCH 1/1 perf trace: Don't synthesize mmaps unless callchains are enabled
Synthesizing mmaps in perf trace is unnecessary unless call chains are being generated.
Signed-off-by Ian Rogers <[email protected]>
--- tools/perf/builtin-trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/builtin-trace.c +3 -1
@@ -2005,7 +2005,9 @@ static int trace__symbols_init(struct trace *trace, int argc, const char **argv, err =__machine__synthesize_threads (trace->host, &trace->tool, &trace->opts.target, evlist->core.threads, trace__tool_process, - true, false,1 ); +/*needs_mmap=*/ callchain_param.enabled, +/*mmap_data=*/ false, +/*nr_threads_synthesize=*/ 1 ); out:if (err) {perf_env__exit (&trace->host_env);
Signature · 1 line
2.51.0.858.gf9c4a03a3a-goog
Hi Ian,
(It's been a while, forgot to switch on plain text mode)
Quoted 5 lines · Ian Rogers
Synthesizing mmaps in perf trace is unnecessary unless call chains are being generated.
Signed-off-by Ian Rogers <[email protected]>
Acked-by Howard Chu <[email protected]>
Thanks,
Howard
Quoted 23 lines
--- tools/perf/builtin-trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)tools/perf/builtin-trace.c +3
-2@@ -2005,7 +2005,9 @@ static int trace__symbols_init(struct trace *trace, int argc, const char **argv, err =__machine__synthesize_threads (trace->host, &trace->tool, &trace->opts.target, evlist->core.threads, trace__tool_process, - true, false,1 ); +/*needs_mmap=*/ callchain_param.enabled, +/*mmap_data=*/ false, +/*nr_threads_synthesize=*/ 1 ); out:if (err) {perf_env__exit (&trace->host_env); --2.51.0.858.gf9c4a03a3a-goog
Quoted 4 lines · Ian Rogers
Synthesizing mmaps in perf trace is unnecessary unless call chains are being generated.
Applied to perf-tools-next, thanks!
Best regards,
Namhyung