f2fs/023: test sanity check condition w/ error injection
PATCH 1/1 f2fs/023: test sanity check condition w/ error injection
After commit 5c1768b67250 ("f2fs: fix to do sanity check correctly on i_inline_xattr_size"), f2fs should handle corrupted i_inline_xattr_size correctly, let's add this regression testcase to check that.
--- tests/f2fs/023 | 44 ++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/023.out | 2 ++ 2 files changed, 46 insertions(+) create mode 100755 tests/f2fs/023 create mode 100644 tests/f2fs/023.out
tests/f2fs/023 new file +44 -0
@@ -0,0 +1,44 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu <[email protected]> +# +# FS QA Test No. f2fs/023 +# +# This testcase tries to inject fault into inode.i_inline_xattr_size, +# and check whether sanity check of f2fs can handle fault correctly. +# + +. ./common/preamble +_begin_fstest auto quick rw + +_fixed_by_kernel_commit 5c1768b67250 \ + "f2fs: fix to do sanity check correctly on i_inline_xattr_size" + +_require_scratch_nocheck +_require_inject_f2fs_command node i_inline +_require_inject_f2fs_command node i_inline_xattr_size + +testfile=$SCRATCH_MNT/testfile + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +_scratch_mkfs "-O extra_attr,flexible_inline_xattr" >> $seqres.full +_scratch_mount "-o inline_xattr_size=512" >>$seqres.full 2>&1 +touch $testfile +_scratch_unmount + +# inject .i_inline field: clear F2FS_EXTRA_ATTR bit +$F2FS_INJECT_PROG --node --mb i_inline --nid 4 --val 0x1 $SCRATCH_DEV \ + >>$seqres.full || _fail "failed to inject i_inline" + +# inject .i_inline_xattr_size field from 512 to 2048 +$F2FS_INJECT_PROG --node --mb i_inline_xattr_size --nid 4 --val 2048 $SCRATCH_DEV \ + >>$seqres.full || _fail "failed to inject i_inline_xattr_size" + +_scratch_mount + +getfattr -n user.test "$testfile" 2>&1 | awk -F ': ' '/Structure needs cleaning/ { print $NF }' + +status=0 +exit
tests/f2fs/023.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 023 +Structure needs cleaning
Signature · 1 line
2.49.0
Quoted 7 lines · Chao Yu
After commit
5c1768b67250("f2fs: fix to do sanity check correctly oni_inline_xattr_size"), f2fs should handle corruptedi_inline_xattr_sizecorrectly, let's add this regression testcase to check that.Cc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
Hi Chao,
Thanks for new test case for f2fs. Some review points as below :)
Quoted 28 lines
tests/f2fs/023 | 44 ++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/023.out | 2 ++ 2 files changed, 46 insertions(+) create mode 100755 tests/f2fs/023 create mode 100644 tests/f2fs/023.outtests/f2fs/023 new file +16
-0@@ -0,0 +1,44 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu <[email protected]> +# +# FS QA Test No. f2fs/023 +# +# This testcase tries to inject fault into inode.i_inline_xattr_size, +# and check whether sanity check of f2fs can handle fault correctly. +# + +. ./common/preamble +_begin_fstest auto quick rw + +_fixed_by_kernel_commit 5c1768b67250 \ + "f2fs: fix to do sanity check correctly on i_inline_xattr_size" +
tests/f2fs/023 line 26
Quoted 10 lines
tests/f2fs/023 new file +10
-0+_require_scratch_nocheck +_require_inject_f2fs_command node i_inline +_require_inject_f2fs_command node i_inline_xattr_size + +testfile=$SCRATCH_MNT/testfile + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +_scratch_mkfs "-O extra_attr,flexible_inline_xattr" >> $seqres.full
As you use specific mkfs options, so better to _fail "..." if mkfs fails.
tests/f2fs/023 line 37
Quoted 11 lines
tests/f2fs/023 new file +11
-0+_scratch_mount "-o inline_xattr_size=512" >>$seqres.full 2>&1 +touch $testfile +_scratch_unmount + +# inject .i_inline field: clear F2FS_EXTRA_ATTR bit +$F2FS_INJECT_PROG --node --mb i_inline --nid 4 --val 0x1 $SCRATCH_DEV \ + >>$seqres.full || _fail "failed to inject i_inline" + +# inject .i_inline_xattr_size field from 512 to 2048 +$F2FS_INJECT_PROG --node --mb i_inline_xattr_size --nid 4 --val 2048 $SCRATCH_DEV \ + >>$seqres.full || _fail "failed to inject i_inline_xattr_size"
I found my system doesn't support i_inline_xattr_size,
# inject.f2fs -V inject.f2fs 1.16.0 (2025-08-12)
I tried to removed above "_require_inject_f2fs_command node i_inline_xattr_size", but I found this test didn't exit from above _fail. The .full file got:
[inject_inode:833] unknown or unsupported member "i_inline_xattr_size"
So are you sure the $F2FS_INJECT_PROG return error if "failed to inject i_inline_xattr_size" :)
tests/f2fs/023 line 41
Quoted 4 lines
tests/f2fs/023 new file +4
-0+ +_scratch_mount + +getfattr -n user.test "$testfile" 2>&1 | awk -F ': ' '/Structure needs cleaning/ { print $NF }'
As you need "user" attribute, so you need "_require_attrs" (. ./common/attr), also the test group should have "attr".
If you don't need _getfattr, please use $GETFATTR_PROG at least.
And how about replace the "awk" with "_filter_scratch" (. ./common/filter)
Thanks,
Zorro
Quoted 14 lines
tests/f2fs/023 new file +3
-0+ +status=0 +exittests/f2fs/023.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 023 +Structure needs cleaningSignature · 1 line
2.49.0
Zorro,
Quoted 71 lines · Zorro Lang
Quoted 7 lines · Chao Yu
After commit
5c1768b67250("f2fs: fix to do sanity check correctly oni_inline_xattr_size"), f2fs should handle corruptedi_inline_xattr_sizecorrectly, let's add this regression testcase to check that.Cc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
Hi Chao,
Thanks for new test case for f2fs. Some review points as below :)
Quoted 28 lines
tests/f2fs/023 | 44 ++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/023.out | 2 ++ 2 files changed, 46 insertions(+) create mode 100755 tests/f2fs/023 create mode 100644 tests/f2fs/023.outtests/f2fs/023 new file +16
-0@@ -0,0 +1,44 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu <[email protected]> +# +# FS QA Test No. f2fs/023 +# +# This testcase tries to inject fault into inode.i_inline_xattr_size, +# and check whether sanity check of f2fs can handle fault correctly. +# + +. ./common/preamble +_begin_fstest auto quick rw + +_fixed_by_kernel_commit 5c1768b67250 \ + "f2fs: fix to do sanity check correctly on i_inline_xattr_size" +tests/f2fs/023 line 26
Quoted 10 lines
tests/f2fs/023 new file +10
-0+_require_scratch_nocheck +_require_inject_f2fs_command node i_inline +_require_inject_f2fs_command node i_inline_xattr_size + +testfile=$SCRATCH_MNT/testfile + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +_scratch_mkfs "-O extra_attr,flexible_inline_xattr" >> $seqres.fullAs you use specific mkfs options, so better to
_fail"..." if mkfs fails.tests/f2fs/023 line 37
Quoted 11 lines
tests/f2fs/023 new file +11
-0+_scratch_mount "-o inline_xattr_size=512" >>$seqres.full 2>&1 +touch $testfile +_scratch_unmount + +# inject .i_inline field: clear F2FS_EXTRA_ATTR bit +$F2FS_INJECT_PROG --node --mb i_inline --nid 4 --val 0x1 $SCRATCH_DEV \ + >>$seqres.full || _fail "failed to inject i_inline" + +# inject .i_inline_xattr_size field from 512 to 2048 +$F2FS_INJECT_PROG --node --mb i_inline_xattr_size --nid 4 --val 2048 $SCRATCH_DEV \ + >>$seqres.full || _fail "failed to inject i_inline_xattr_size"I found my system doesn't support
i_inline_xattr_size,# inject.f2fs -V inject.f2fs 1.16.0 (2025-08-12)
Quoted 6 lines
I tried to removed above "
_require_inject_f2fs_commandnodei_inline_xattr_size", but I found this test didn't exit from above_fail. The .full file got:[inject_inode:833] unknown or unsupported member "
i_inline_xattr_size"So are you sure the $F2FS_INJECT_PROG return error if "failed to inject
i_inline_xattr_size" :)
Oops, I found that inject.f2fs missed to return correct value for error case, let me fix this.
In order to keep compatibility for old inject.f2fs tool, let me check output instead of return value from inject.f2fs.
Let me know if you have any other concern.
Quoted 9 lines
tests/f2fs/023 line 41
Quoted 5 lines
tests/f2fs/023 new file +4
-0+ +_scratch_mount + +getfattr -n user.test "$testfile" 2>&1 | awk -F ': ' '/Structure needs cleaning/ { print $NF }'As you need "user" attribute, so you need "
_require_attrs" (. ./common/attr), also the test group should have "attr".
Quoted 3 lines
If you don't need
_getfattr, please use $GETFATTR_PROG at least.And how about replace the "awk" with "
_filter_scratch" (. ./common/filter)
Thanks for all your comments, will fix them all in v2. :)
Thankss,
Quoted 19 lines
Thanks,
ZorroQuoted 14 lines
tests/f2fs/023 new file +3
-0+ +status=0 +exittests/f2fs/023.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 023 +Structure needs cleaningSignature · 1 line
2.49.0