KVM: riscv: Support enabling dirty log gradually in small chunks
Subsystems (4)
PATCH 1/1 KVM: riscv: Support enabling dirty log gradually in small chunks
From: Dong Yang <[email protected]>
There is already support of enabling dirty log gradually in small chunks for x86 in commit 3c9bd4006bfc ("KVM: x86: enable dirty log gradually in small chunks") and c862626 ("KVM: arm64: Support enabling dirty log gradually in small chunks"). This adds support for riscv.
x86 and arm64 writes protect both huge pages and normal pages now, so riscv protect also protects both huge pages and normal pages.
On a nested virtualization setup (RISC-V KVM running inside a QEMU VM on an [Intel® Core™ i5-12500H] host), I did some tests with a 2G Linux VM using different backing page sizes. The time taken for memory_global_dirty_log_start in the L2 QEMU is listed below:
Page Size Before After Optimization
4K 4490.23ms 31.94ms 2M 48.97ms 45.46ms 1G 28.40ms 30.93ms
--- Documentation/virt/kvm/api.rst | 2 +- arch/riscv/include/asm/kvm_host.h | 3 +++ arch/riscv/kvm/mmu.c | 5 ++++- 3 files changed, 8 insertions(+), 2 deletions(-)
Documentation/virt/kvm/api.rst +1 -1
@@ -8028,7 +8028,7 @@ will be initialized to 1 when created. This also improves performance because dirty logging can be enabled gradually in small chunks on the first call to KVM_CLEAR_DIRTY_LOG. KVM_DIRTY_LOG_INITIALLY_SET depends on KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE (it is also only available on -x86 and arm64 for now). +x86, arm64 and riscv for now). KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 was previously available under the name KVM_CAP_MANUAL_DIRTY_LOG_PROTECT, but the implementation had bugs that make
arch/riscv/include/asm/kvm_host.h +3 -0
@@ -59,6 +59,9 @@ BIT(IRQ_VS_TIMER) | \ BIT(IRQ_VS_EXT)) +#define KVM_DIRTY_LOG_MANUAL_CAPS (KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE | \ + KVM_DIRTY_LOG_INITIALLY_SET) +struct kvm_vm_stat {struct kvm_vm_stat_generic generic; };
arch/riscv/kvm/mmu.c +4 -1
@@ -161,8 +161,11 @@ void kvm_arch_commit_memory_region(struct kvm *kvm,* allocated dirty_bitmap[], dirty pages will be tracked while * the memory slot is write protected. */ -if (change !=KVM_MR_DELETE && new->flags &KVM_MEM_LOG_DIRTY_PAGES ) +if (change !=KVM_MR_DELETE && new->flags &KVM_MEM_LOG_DIRTY_PAGES ) { +if (kvm_dirty_log_manual_protect_and_init_set (kvm)) +return ;mmu_wp_memory_region (kvm, new->id); + } } int kvm_arch_prepare_memory_region(struct kvm *kvm,
Signature · 1 line
2.34.1
Quoted 16 lines · On Mon, Nov 3, 2025 at 11:58 AM <[email protected]> wrote:
From: Dong Yang <[email protected]>
There is already support of enabling dirty log gradually in small chunks for x86 in commit
3c9bd4006bfc("KVM: x86: enable dirty log gradually in small chunks") and c862626 ("KVM: arm64: Support enabling dirty log gradually in small chunks"). This adds support for riscv.x86 and arm64 writes protect both huge pages and normal pages now, so riscv protect also protects both huge pages and normal pages.
On a nested virtualization setup (RISC-V KVM running inside a QEMU VM on an [Intel® Core™ i5-12500H] host), I did some tests with a 2G Linux VM using different backing page sizes. The time taken for
memory_global_dirty_log_startin the L2 QEMU is listed below:
Quoted 7 lines
Page Size Before After Optimization
4K 4490.23ms 31.94ms 2M 48.97ms 45.46ms 1G 28.40ms 30.93msSigned-off-by Quan Zhou <[email protected]>Signed-off-by Dong Yang <[email protected]>
LGTM.
Queued this patch for Linux-6.19
Thanks,
Anup
Quoted 53 lines
--- Documentation/virt/kvm/api.rst | 2 +- arch/riscv/include/asm/kvm_host.h | 3 +++ arch/riscv/kvm/mmu.c | 5 ++++- 3 files changed, 8 insertions(+), 2 deletions(-)Documentation/virt/kvm/api.rst +1
-1@@ -8028,7 +8028,7 @@ will be initialized to 1 when created. This also improves performance because dirty logging can be enabled gradually in small chunks on the first call to KVM_CLEAR_DIRTY_LOG. KVM_DIRTY_LOG_INITIALLY_SET depends on KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE (it is also only available on -x86 and arm64 for now). +x86, arm64 and riscv for now). KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 was previously available under the name KVM_CAP_MANUAL_DIRTY_LOG_PROTECT, but the implementation had bugs that makearch/riscv/include/asm/kvm_host.h +3
-0@@ -59,6 +59,9 @@ BIT(IRQ_VS_TIMER) | \ BIT(IRQ_VS_EXT)) +#define KVM_DIRTY_LOG_MANUAL_CAPS (KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE | \ + KVM_DIRTY_LOG_INITIALLY_SET) +struct kvm_vm_stat {struct kvm_vm_stat_generic generic; };arch/riscv/kvm/mmu.c +4
-2@@ -161,8 +161,11 @@ void kvm_arch_commit_memory_region(struct kvm *kvm,* allocated dirty_bitmap[], dirty pages will be tracked while * the memory slot is write protected. */ -if (change !=KVM_MR_DELETE && new->flags &KVM_MEM_LOG_DIRTY_PAGES ) +if (change !=KVM_MR_DELETE && new->flags &KVM_MEM_LOG_DIRTY_PAGES ) { +if (kvm_dirty_log_manual_protect_and_init_set (kvm)) +return ;mmu_wp_memory_region (kvm, new->id); + } } int kvm_arch_prepare_memory_region(struct kvm *kvm, --2.34.1