common/mlx5: release unused mempool entries
PATCH 2/4 common/mlx5: release unused mempool entries
From: Roi Dayan <[email protected]>
When creating a new mempool but assigning a shared entries from a different mempool need to release the newly unused allocated entries. Fix it.
--- drivers/common/mlx5/mlx5_common_mr.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/common/mlx5/mlx5_common_mr.c +6 -0
@@ -1717,18 +1717,24 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,* hugepage can be shared across mempools that also fit in it. */ if (share_hugepage) { +struct mlx5_mempool_mr *gc_mrs =NULL ; +rte_rwlock_write_lock (&share_cache->rwlock); LIST_FOREACH(mpr, &share_cache->mempool_reg_list, next) {if (mpr->mrs[0 ].pmd_mr.addr == (void *)ranges[0 ].start)break ; }if (mpr !=NULL ) { +/* Releasing MRs here can create a dead-lock on share_cache->rwlock */ + gc_mrs = new_mpr->mrs; new_mpr->mrs = mpr->mrs;mlx5_mempool_reg_attach (new_mpr);LIST_INSERT_HEAD (&share_cache->mempool_reg_list, new_mpr, next); }rte_rwlock_write_unlock (&share_cache->rwlock); +if (gc_mrs !=NULL ) +mlx5_free (gc_mrs);if (mpr !=NULL ) { DRV_LOG(DEBUG, "Shared MR %#x in PD %p for mempool %s with mempool %s", mpr->mrs[0].pmd_mr.lkey, pd, mp->name,
Signature · 1 line
2.34.1
Quoted 19 lines
-----Original Message-----
From: Bing Zhao <[email protected]>
Sent: Wednesday, November 12, 2025 3:42 PM
To: Slava Ovsiienko <[email protected]>; [email protected]; Raslan Darawsheh <[email protected]>
Cc: Ori Kam <[email protected]>; Dariusz Sosnowski <[email protected]>; Suanming Mou <[email protected]>; Matan Azrad <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Bing Zhao <[email protected]>; Roi Dayan <[email protected]>; Gregory Etelson <[email protected]>
Subject: [PATCH 2/4] common/mlx5: release unused mempool entriesFrom: Roi Dayan <[email protected]>
When creating a new mempool but assigning a shared entries from a different mempool need to release the newly unused allocated entries. Fix it.
Quoted 6 lines
Fixes 8947eebc999e ("common/mlx5: fix shared memory region rangesallocation")
Cc: [email protected]Signed-off-by Roi Dayan <[email protected]>Signed-off-by Gregory Etelson <[email protected]>