drm/panel: panel-simple: Add Sharp LQ070Y3LG05
Subsystems (4)
PATCH 1/2 drm/panel: panel-simple: Add Sharp LQ070Y3LG05
Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
--- drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +28 -0
@@ -4266,6 +4266,31 @@ static const struct panel_desc sharp_lq070y3dg3b = { DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE, }; +static const struct display_timing sharp_lq070y3lg05_timing = { + .pixelclock = {28000000 ,33000000 ,40000000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {40 ,40 ,40 }, + .hback_porch = {40 ,40 ,40 }, + .hsync_len = {48 ,48 ,48 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {13 ,13 ,13 }, + .vback_porch = {29 ,29 ,29 }, + .vsync_len = {3 ,3 ,3 }, + .flags =DISPLAY_FLAGS_PIXDATA_POSEDGE , +}; + +static const struct panel_desc sharp_lq070y3lg05 = { + .timings = &sharp_lq070y3lg05_timing, + .num_timings =1 , + .bpc =8 , + .size = { + .width =154 ,/* 153.6mm */ + .height =87 ,/* 86.6mm */ + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X7X4_SPWG , + .connector_type =DRM_MODE_CONNECTOR_LVDS , +}; +static const struct drm_display_mode sharp_lq035q7db03_mode = { .clock =5500 , .hdisplay =240 ,
@@ -5367,6 +5392,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "sharp,lq070y3dg3b", .data = &sharp_lq070y3dg3b, + }, { + .compatible = "sharp,lq070y3lg05", + .data = &sharp_lq070y3lg05, }, { .compatible = "sharp,lq101k1ly04", .data = &sharp_lq101k1ly04,
Signature · 1 line
2.25.1
PATCH 2/2 dt-bindings: display: simple: Add Sharp LQ070Y3LG05
Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
--- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
@@ -284,6 +284,8 @@ properties: - sharp,lq035q7db03 # Sharp LQ070Y3DG3B 7.0" WVGA landscape TFT LCD panel - sharp,lq070y3dg3b + # Sharp LQ070Y3LG05 7.0" WVGA langscape LVDS TFT LCD panel + - sharp,lq070y3lg05 # Sharp Display Corp. LQ101K1LY04 10.07" WXGA TFT LCD panel - sharp,lq101k1ly04 # Sharp LS020B1DD01D 2.0" HQVGA TFT LCD panel
Signature · 1 line
2.25.1
Re: [PATCH 2/2] dt-bindings: display: simple: Add Sharp LQ070Y3LG05
Quoted 4 lines · Daniel Schultz
Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
Signed-off-by Daniel Schultz <[email protected]>---
In the future:
Please organize the patch documenting the compatible (DT bindings) before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
Best regards,
Krzysztof
Maxime Ripard
maintainerQuoted 6 lines · Daniel Schultz
Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
Signed-off-by Daniel Schultz <[email protected]>--- drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
Any reason to use panel-simple over panel-lvds?
Maxime
Quoted 8 lines · Maxime Ripard
Quoted 6 lines · Daniel Schultz
Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
Signed-off-by Daniel Schultz <[email protected]>--- drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)Any reason to use panel-simple over panel-lvds?
I didn't know panel-lvds exist. I just convert these timings to panel-lvds and works fine, too. Thanks!
I don't plan to send my device-tree with the new timings included in the near future. Should or can I already add this panel as compatible to panel-simple.yaml?
- Daniel
Quoted 2 lines
Maxime
[email protected]
maintainerQuoted 8 lines · Daniel Schultz
Quoted 7 lines · Maxime Ripard
Quoted 6 lines · Daniel Schultz
Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
Signed-off-by Daniel Schultz <[email protected]>---
drivers/gpu/drm/panel/panel-simple.c| 28 ++++++++++++++++++++++++++++1 file changed, 28 insertions(+)
Quoted 5 lines
Quoted 1 line
Any reason to use panel-simple over panel-lvds?
I didn't know panel-lvds exist. I just convert these timings to panel-lvds and works fine, too. Thanks!
I don't plan to send my device-tree with the new timings included in the near future. Should or can I already add this panel as compatible to
panel-simple.yaml?
Any reason why it won't fit in Documentation/devicetree/bindings/display/panel/panel-lvds.yaml ?
Neil
Quoted 5 lines
- Daniel
Quoted 2 lines
Maxime