staging: fluke_gpib: use kzalloc instead of kmalloc + memset
PATCH v2 1/1 staging: fluke_gpib: use kzalloc instead of kmalloc + memset
v2:
- Add proper commit description
- No changes in patch
Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.
Also use sizeof(*board->private_data) instead of repeating the struct name. This avoids duplication and keeps the code correct if the struct name changes in the future.
--- drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gpib/eastwood/fluke_gpib.c +1 -2
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board) {struct fluke_priv *priv; - board->private_data =kmalloc (sizeof (struct fluke_priv ),GFP_KERNEL ); + board->private_data =kzalloc (sizeof (*board->private_data),GFP_KERNEL );if (!board->private_data)return -ENOMEM ; priv = board->private_data; -memset (priv,0 ,sizeof (struct fluke_priv ));init_nec7210_private (&priv->nec7210_priv); priv->dma_buffer_size =0x7ff ; priv->dma_buffer =kmalloc (priv->dma_buffer_size,GFP_KERNEL );
Signature · 1 line
2.52.0
Quoted 4 lines · Tomasz Sadowski
v2:
- Add proper commit description
- No changes in patch
This stuff needs to go under the --- cut off line.
Quoted 8 lines
Use
kzalloc()instead ofkmalloc()+memset()to simplify memory allocation.Also use
sizeof(*board->private_data)instead of repeating the struct name. This avoids duplication and keeps the code correct if the struct name changes in the future.Signed-off-by Tomasz Sadowski <[email protected]>---
^^^
Here.
regards,
dan carpenter