Skip to contentSkip to conversation

staging: fluke_gpib: use kzalloc instead of kmalloc + memset

PATCH In review Tomasz Sadowski 2 participants 2 messages Nov 27, 2025 – Dec 13, 2025 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: fluke_gpib: use kzalloc instead of kmalloc + memset

Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.

Also use sizeof(*board->private_data) instead of repeating the struct name. This avoids duplication and keeps the code correct if the struct name changes in the future.

---
v3:
- Move version history below "---"

v2:
- Add proper commit description
- No changes in patch

 drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gpib/eastwood/fluke_gpib.c +1 -2
index 3ae848e3f738..2b6ba7882dba 100644
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
 {
 	struct fluke_priv *priv;
 
-	board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);
 	if (!board->private_data)
 		return -ENOMEM;
 	priv = board->private_data;
-	memset(priv, 0, sizeof(struct fluke_priv));
 	init_nec7210_private(&priv->nec7210_priv);
 	priv->dma_buffer_size = 0x7ff;
 	priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
Signature · 1 line
2.52.0
#1 lore raw
Quoted 23 lines · Tomasz Sadowski

Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.

Also use sizeof(*board->private_data) instead of repeating the struct name. This avoids duplication and keeps the code correct if the struct name changes in the future.

---
v3:
- Move version history below "---"

v2:
- Add proper commit description
- No changes in patch

 drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gpib/eastwood/fluke_gpib.c +0 -0
index 3ae848e3f738..2b6ba7882dba 100644

drivers/staging/gpib/eastwood/fluke_gpib.c static int fluke_allocate_private(struct gpib_board *board) · line 856

Quoted 5 lines
drivers/staging/gpib/eastwood/fluke_gpib.c +1 -1
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
 {
 	struct fluke_priv *priv;
 
-	board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);

Good thing to use kzalloc here but using sizeof(*board->private_data) will not work. sizeof(void) is 1 not the size of the structure.

Quoted 10 lines
drivers/staging/gpib/eastwood/fluke_gpib.c +0 -1
 	if (!board->private_data)
 		return -ENOMEM;
 	priv = board->private_data;
-	memset(priv, 0, sizeof(struct fluke_priv));
 	init_nec7210_private(&priv->nec7210_priv);
 	priv->dma_buffer_size = 0x7ff;
 	priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
Signature · 1 line
2.52.0