most: core: fix resource leak in most_register_interface error paths
Subsystems (2)
PATCH v4 1/1 most: core: fix resource leak in most_register_interface error paths
The function most_register_interface() did not correctly release resources if it failed early (before registering the device). In these cases, it returned an error code immediately, leaking the memory allocated for the interface.
Fix this by initializing the device early via device_initialize() and calling put_device() on all error paths.
The most_register_interface() is expected to call put_device() on error which frees the resources allocated in the caller. The put_device() either calls release_mdev() or dim2_release(), depending on the caller.
Switch to using device_add() instead of device_register() to handle the split initialization.
---
Changes in v4:
- Removed the '!iface->dev' NULL check as suggested by Dan Carpenter.
- Updated commit message to explicitly explain how put_device() triggers the caller's release function (suggested by Dan Carpenter).
Changes in v3:
- Dropped USB cleanup patch (already applied upstream).
- Added Acked-by.
drivers/most/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/most/core.c +5 -1
@@ -1286,15 +1286,19 @@ int most_register_interface(struct most_interface *iface) !iface->poison_channel || (iface->num_channels > MAX_CHANNELS))return -EINVAL ; +device_initialize (iface->dev); + id =ida_alloc (&mdev_id,GFP_KERNEL );if (id <0 ) {dev_err (iface->dev,"Failed to allocate device ID\n" ); +put_device (iface->dev);return id; } iface->p =kzalloc (sizeof (*iface->p),GFP_KERNEL );if (!iface->p) {ida_free (&mdev_id, id); +put_device (iface->dev);return -ENOMEM ; }
@@ -1304,7 +1308,7 @@ int most_register_interface(struct most_interface *iface) iface->dev->bus = &mostbus; iface->dev->groups = interface_attr_groups;dev_set_drvdata (iface->dev, iface); -if (device_register (iface->dev)) { +if (device_add (iface->dev)) {dev_err (iface->dev,"Failed to register interface device\n" );kfree (iface->p);put_device (iface->dev);
Signature · 1 line
2.43.0
Quoted 13 lines · Navaneeth K
The function
most_register_interface()did not correctly release resources if it failed early (before registering the device). In these cases, it returned an error code immediately, leaking the memory allocated for the interface.Fix this by initializing the device early via
device_initialize()and callingput_device()on all error paths.The
most_register_interface()is expected to callput_device()on error which frees the resources allocated in the caller. Theput_device()either callsrelease_mdev()ordim2_release(), depending on the caller.
Quoted 6 lines
Switch to using
device_add()instead ofdevice_register()to handle the split initialization.Acked-by Abdun Nihaal <[email protected]>Signed-off-by Navaneeth K <[email protected]>---
Thanks!
regards,
dan carpenter