Skip to contentSkip to conversation

gpio: tb10x: fix OF_GPIO dependency

PATCH Applied Arnd Bergmann 2 participants 2 messages Dec 5, 2025 – Dec 6, 2025 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gpio: tb10x: fix OF_GPIO dependency

From: Arnd Bergmann <[email protected]>

Selecting OF_GPIO is generally not allowed, it always gets enabled when both GPIOLIB and OF are turned on.

The tb10x driver now warns about this after it was enabled for compile-testing:

WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
Selected by [y]:
- GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])

OF_GPIO is not required for compile-testing and is already enabled when the driver is usable, so just drop the 'select' line.

Fixes 682fbb18e14c ("gpio: tb10x: allow building the module with COMPILE_TEST=y")
---
 drivers/gpio/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/Kconfig +0 -1
index 02099ef48f22..e9dc19ce3545 100644
@@ -737,7 +737,6 @@ config GPIO_TB10X
 	depends on ARC_PLAT_TB10X || COMPILE_TEST
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
-	select OF_GPIO
 
 config GPIO_TEGRA
 	tristate "NVIDIA Tegra GPIO support"
Signature · 1 line
2.39.5
#1 lore raw
Quoted 6 lines · Arnd Bergmann

Selecting OF_GPIO is generally not allowed, it always gets enabled when both GPIOLIB and OF are turned on.

The tb10x driver now warns about this after it was enabled for compile-testing:

Quoted 6 lines

WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
Selected by [y]:
- GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])

[...]

Applied, thanks!

[1/1] gpio: tb10x: fix OF_GPIO dependency

      https://git.kernel.org/brgl/linux/c/a0cf7d69016e1917c2ac284840254b5f1dd75e23

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>