gpio: tb10x: fix OF_GPIO dependency

From: Arnd Bergmann <[email protected]>

Selecting OF_GPIO is generally not allowed, it always gets enabled when both GPIOLIB and OF are turned on.

The tb10x driver now warns about this after it was enabled for compile-testing:

WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
Selected by [y]:
- GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])

Use the usual 'depends on' here.

---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index 0fed90ef587a..a1fd130a2408 100644
@@ -735,9 +735,9 @@ config GPIO_TANGIER
 config GPIO_TB10X
 	bool "Abilis Systems TB10x GPIO controller"
 	depends on ARC_PLAT_TB10X || COMPILE_TEST
+	depends on OF_GPIO
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
-	select OF_GPIO
 
 config GPIO_TEGRA
 	tristate "NVIDIA Tegra GPIO support"

2.39.5

Hi Arnd!

Actually a better fix is to simply drop this select and not introduce the depends on. This driver doesn't call any symbols from gpiolib-of.h and even then - they provide stubs. This also limits the COMPILE_TEST coverage to systems with OF_GPIO selected.

Same for the other patch you sent.

Bart