Skip to contentSkip to conversation

dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

PATCH Superseded Akhila YS 2 participants 2 messages Jan 2 – Jan 5

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Akhila YS

author
#0 lore raw

PATCH v2 1/1 dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

Convert Microchip 23K256 SPI SRAM MTD binding to YAML format.

---
Changes in v2:
- Removed "#address-cells" and "#size-cells" from the required, properties and example.
- Changed description and title for yaml.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../bindings/mtd/microchip,mchp23k256.txt          | 18 --------
 .../bindings/mtd/microchip,mchp23k256.yaml         | 49 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 18 deletions(-)
Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt deleted +0 -18
deleted file mode 100644
index 7328eb92a03c..000000000000
@@ -1,18 +0,0 @@
-* MTD SPI driver for Microchip 23K256 (and similar) serial SRAM
-
-Required properties:
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- compatible : Must be one of "microchip,mchp23k256" or "microchip,mchp23lcv1024"
-- reg : Chip-Select number
-- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
-
-Example:
-
-	spi-sram@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "microchip,mchp23k256";
-		reg = <0>;
-		spi-max-frequency = <20000000>;
-	};
Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml new file +49 -0

49 lines not on this page · raw message

---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251229-nxp-526e29da9f29

Best regards,

Signature · 1 line
Akhila YS <[email protected]>
#1 lore raw
Quoted 1 line · Akhila YS

Convert Microchip 23K256 SPI SRAM MTD binding to YAML format.

You changed silently the binding. Every change - like dropping properties - must be explicitly documented and EXPLAINED WHY in the commit msg.

Quoted 80 lines

---
Changes in v2:
- Removed "#address-cells" and "#size-cells" from the required, properties and example.
- Changed description and title for yaml.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../bindings/mtd/microchip,mchp23k256.txt          | 18 --------
 .../bindings/mtd/microchip,mchp23k256.yaml         | 49 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 18 deletions(-)
Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt deleted +0 -18
deleted file mode 100644
index 7328eb92a03c..000000000000
@@ -1,18 +0,0 @@
-* MTD SPI driver for Microchip 23K256 (and similar) serial SRAM
-
-Required properties:
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- compatible : Must be one of "microchip,mchp23k256" or "microchip,mchp23lcv1024"
-- reg : Chip-Select number
-- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
-
-Example:
-
-	spi-sram@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "microchip,mchp23k256";
-		reg = <0>;
-		spi-max-frequency = <20000000>;
-	};
Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml new file +37 -0
new file mode 100644
index 000000000000..e928d375ae81
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip 23K256 SPI SRAM
+
+maintainers:
+  - Richard Weinberger <[email protected]>
+
+description:
+  The Microchip 23K256 is a 256 Kbit (32 Kbyte) serial SRAM with an
+  SPI interface,supporting clock frequencies up to 20 MHz. It features
+  a 32-byte page size for writes and supports byte, page, and
+  sequential access modes.
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    enum:
+      - microchip,mchp23k256
+      - microchip,mchp23lcv1024
+
+  reg:
+    maxItems: 1
+
+required:
+  - reg
+  - compatible
+  - spi-max-frequency
+
+unevaluatedProperties: false
+
+examples:

Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml line 47

Quoted 10 lines
Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml new file +10 -0
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sram@0 {
+            compatible = "microchip,mchp23k256";
+            reg = <0>;
+            spi-max-frequency = <20000000>;
+       };

Messed indentation now.

Best regards,
Krzysztof