Skip to contentSkip to conversation

dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

PATCH Applied Akhila YS 3 participants 3 messages Jan 5 – Jan 19

Subsystems (2)
lore
Share & tools
lore

Akhila YS

author
#0 lore raw

PATCH v3 1/1 dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

Convert Microchip 23K256 SPI SRAM MTD binding to YAML format. Changes during conversion:
- Remove "address-cells" and "size-cells" from properties and required sections as there is no child node for sram.

---
Changes in v3:
- Changed commit description to document changes during yaml conversion.
- Corrected indentation for example.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Removed "#address-cells" and "#size-cells" from the required, properties and example.
- Changed description and title for yaml.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../bindings/mtd/microchip,mchp23k256.txt          | 18 --------
 .../bindings/mtd/microchip,mchp23k256.yaml         | 49 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 18 deletions(-)
Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt deleted +0 -18
deleted file mode 100644
index 7328eb92a03c..000000000000
@@ -1,18 +0,0 @@
-* MTD SPI driver for Microchip 23K256 (and similar) serial SRAM
-
-Required properties:
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- compatible : Must be one of "microchip,mchp23k256" or "microchip,mchp23lcv1024"
-- reg : Chip-Select number
-- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
-
-Example:
-
-	spi-sram@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "microchip,mchp23k256";
-		reg = <0>;
-		spi-max-frequency = <20000000>;
-	};
Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml new file +49 -0

49 lines not on this page · raw message

---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251229-nxp-526e29da9f29

Best regards,

Signature · 1 line
Akhila YS <[email protected]>
Acked-by on v3 1/1
#1 lore raw
Quoted 4 lines · Akhila YS

Convert Microchip 23K256 SPI SRAM MTD binding to YAML format. Changes during conversion:
- Remove "address-cells" and "size-cells" from properties and required sections as there is no child node for sram.

I looked at the driver and clearly see usage of partitions from DT, thus the binding needed both above and the partitions coming from MTD schema, so this is not really correct. Looks like you did not really try to understand this binding and the driver.

Converting bindings is not trivial task and you must really understand also what was incomplete in the binding.

Anyway, I don't want to deal with this more, so:

Best regards,
Krzysztof

maintainer Applied
#2 lore raw
In reply to Akhila YS
Quoted 6 lines · Akhila YS

Convert Microchip 23K256 SPI SRAM MTD binding to YAML format. Changes during conversion:
- Remove "address-cells" and "size-cells" from properties and required sections as there is no child node for sram.

Applied to mtd/next, thanks!

[1/1] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

      commit: 2372fe1ceaf5a1e681c81f3dc35eb7f954526cbd

Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl