Skip to contentSkip to conversation

nvme/host: fixup some typos

PATCH Superseded Wilfred Mallawa 3 participants 5 messages Jan 5 – Jan 7 NVMe

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nvme/host: fixup some typos

From: Wilfred Mallawa <[email protected]>

Fixup some minor typos in the nvme host drivers.

---
 drivers/nvme/host/ioctl.c | 2 +-
 drivers/nvme/host/tcp.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/nvme/host/ioctl.c +1 -1
index a9c097dacad6..62d4bff7ebdd 100644
@@ -718,7 +718,7 @@ int nvme_ns_head_ioctl(struct block_device *bdev, blk_mode_t mode,
 
 	/*
 	 * Handle ioctls that apply to the controller instead of the namespace
-	 * separately and drop the ns SRCU reference early.  This avoids a
+	 * separately and drop the ns SRCU reference early. This avoids a
 	 * deadlock when deleting namespaces using the passthrough interface.
 	 */
 	if (is_ctrl_ioctl(cmd))
drivers/nvme/host/tcp.c +2 -2
index 69cb04406b47..8d389399187d 100644
@@ -25,7 +25,7 @@
 
 struct nvme_tcp_queue;
 
-/* Define the socket priority to use for connections were it is desirable
+/* Define the socket priority to use for connections where it is desirable
  * that the NIC consider performing optimized packet processing or filtering.
  * A non-zero value being sufficient to indicate general consideration of any
  * possible optimization.  Making it a module param allows for alternative
@@ -926,7 +926,7 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb,
 			req->curr_bio = req->curr_bio->bi_next;
 
 			/*
-			 * If we don`t have any bios it means that controller
+			 * If we don't have any bios it means that controller
 			 * sent more data than we requested, hence error
 			 */
 			if (!req->curr_bio) {
Signature · 1 line
2.52.0
#1 lore raw

Bit: the subject prefix is we usually use is just "nvme: ".

drivers/nvme/host/ioctl.c int nvme_ns_head_ioctl(struct block_device *bdev, blk_mode_t mode, · line 721

Quoted 4 lines
drivers/nvme/host/ioctl.c +1 -1
 	/*
 	 * Handle ioctls that apply to the controller instead of the namespace
-	 * separately and drop the ns SRCU reference early.  This avoids a
+	 * separately and drop the ns SRCU reference early. This avoids a

I don't see a typo here, just a reformatting to a different comment style not very commonly used in the nvme code.

drivers/nvme/host/tcp.c line 28

Quoted 2 lines
drivers/nvme/host/tcp.c +1 -1
-/* Define the socket priority to use for connections were it is desirable
+/* Define the socket priority to use for connections where it is desirable

The change looks good, but if you touch this, you might as well fix up the comment style to match the normal kernel style:

/*
* Define the socket priority to use for connections where it is desirable

#2 lore raw
Quoted 12 lines · Christoph Hellwig

Bit: the subject prefix is we usually use is just "nvme: ".

Quoted 7 lines

  /*
  * Handle ioctls that apply to the controller instead of the namespace

(quoted diff) +0 -1
-	 * separately and drop the ns SRCU reference early.  This

avoids a

(quoted diff) +1 -0
+	 * separately and drop the ns SRCU reference early. This

avoids a

I don't see a typo here, just a reformatting to a different comment style not very commonly used in the nvme code.

It's just the extra white space before the "This avoids". Is that not a typo?

Quoted 10 lines
Quoted 5 lines

-/* Define the socket priority to use for connections were it is desirable
+/* Define the socket priority to use for connections where it is desirable

The change looks good, but if you touch this, you might as well fix up
the comment style to match the normal kernel style:

Quoted 3 lines

/*
 * Define the socket priority to use for connections where it is desirable

Ah no worries, will fixup!

Wilfred

maintainer
#3 lore raw
Quoted 5 lines · Wilfred Mallawa
Quoted 2 lines

I don't see a typo here, just a reformatting to a different comment style not very commonly used in the nvme code.

It's just the extra white space before the "This avoids". Is that not a typo?

Double spaces after the end of a sentence is common style for fixed width font text and recommended by various (usually older) coding guidelines. But even typesetting for variable-sided fonts sometimes add extra space, in TeX this is known as "french spacing"

#4 lore raw
Quoted 5 lines · hch
Quoted 4 lines · Wilfred Mallawa
Quoted 3 lines

I don't see a typo here, just a reformatting to a different comment
style not very commonly used in the nvme code.

Quoted 9 lines
Quoted 3 lines

It's just the extra white space before the "This avoids". Is that not a
typo?

Double spaces after the end of a sentence is common style for fixed width font text and recommended by various (usually older) coding guidelines.  But even typesetting for variable-sided fonts sometimes add extra space, in TeX this is known as "french spacing"

Ah I see, thanks for letting me know!

Wilfred