Skip to contentSkip to conversation

configure: Set $PYTHON in the configuration of the optionroms

PATCH In review Thomas Huth 2 participants 2 messages Jan 14

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Set $PYTHON in the configuration of the optionroms

From: Thomas Huth <[email protected]>

pc-bios/optionrom/Makefile uses $(PYTHON) for running a Python script, but this variable is never initialized here. So the script gets run via its shebang line - which fails if the "python3" binary is not available on the system. To fix this, write the PYTHON configuration to the config.mak file of the optionroms.

---
 configure | 1 +
 1 file changed, 1 insertion(+)
configure +1 -0
index 55e0bd34256..f7e8d7ad4c8 100755
@@ -1643,6 +1643,7 @@ probe_target_compiler() {
 }
 
 write_target_makefile() {
+  echo "PYTHON=$python"
   echo "EXTRA_CFLAGS=$target_cflags"
   if test -z "$target_cc" && test -z "$target_as"; then
     test -z "$container_image" && error_exit "Internal error: could not find cross compiler for $1?"
Signature · 1 line
2.52.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Thomas Huth

From: Thomas Huth <[email protected]>

pc-bios/optionrom/Makefile uses $(PYTHON) for running a Python script, but this variable is never initialized here. So the script gets run via its shebang line - which fails if the "python3" binary is not available on the system. To fix this, write the PYTHON configuration to the config.mak file of the optionroms.

Quoted 4 lines
---
 configure | 1 +
 1 file changed, 1 insertion(+)

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|