target/i386/nvmm: Include missing ramlist.h header
PATCH 1/1 target/i386/nvmm: Include missing ramlist.h header
From: Thomas Huth <[email protected]>
Compiling on NetBSD currently fails with:
../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size,
| ^~~~~~~~~~~~~~~~
../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type
1152 | static struct RAMBlockNotifier nvmm_ram_notifier = {
| ^~~~~~~~~~~~~~~~
../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added'
1153 | .ram_block_added = nvmm_ram_block_added
| ^~~~~~~~~~~~~~~
../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function)
1153 | .ram_block_added = nvmm_ram_block_added
| ^~~~~~~~~~~~~~~~~~~~Include the right header to get this fixed.
--- target/i386/nvmm/nvmm-all.c | 1 + 1 file changed, 1 insertion(+)
target/i386/nvmm/nvmm-all.c +1 -0
@@ -16,6 +16,7 @@#include "system/nvmm.h" #include "system/cpus.h" #include "system/memory.h" +#include "system/ramlist.h" #include "system/runstate.h" #include "qemu/main-loop.h" #include "qemu/error-report.h"
Signature · 1 line
2.52.0
Quoted 17 lines · Thomas Huth
From: Thomas Huth <[email protected]>
Compiling on NetBSD currently fails with:
../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host,size_tsize,| ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type 1152 | static struct RAMBlockNotifier nvmm_ram_notifier = { | ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added' 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function) 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~~~~~~
Quoted 3 lines
Include the right header to get this fixed.
Signed-off-by Thomas Huth <[email protected]>
Quoted 16 lines
--- target/i386/nvmm/nvmm-all.c | 1 + 1 file changed, 1 insertion(+)target/i386/nvmm/nvmm-all.c +1
-0@@ -16,6 +16,7 @@#include "system/nvmm.h" #include "system/cpus.h" #include "system/memory.h" +#include "system/ramlist.h" #include "system/runstate.h" #include "qemu/main-loop.h" #include "qemu/error-report.h"
Quoted 17 lines · Thomas Huth
From: Thomas Huth <[email protected]>
Compiling on NetBSD currently fails with:
../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host,size_tsize,| ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type 1152 | static struct RAMBlockNotifier nvmm_ram_notifier = { | ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added' 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function) 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~~~~~~
Quoted 6 lines
Include the right header to get this fixed.
Signed-off-by Thomas Huth <[email protected]>--- target/i386/nvmm/nvmm-all.c | 1 + 1 file changed, 1 insertion(+)
Quoted 17 lines · Thomas Huth
From: Thomas Huth <[email protected]>
Compiling on NetBSD currently fails with:
../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host,size_tsize,| ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type 1152 | static struct RAMBlockNotifier nvmm_ram_notifier = { | ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added' 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function) 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~~~~~~
Quoted 7 lines
Include the right header to get this fixed.
Signed-off-by Thomas Huth <[email protected]>--- target/i386/nvmm/nvmm-all.c | 1 + 1 file changed, 1 insertion(+)
For what it's worth, I added netbsd build (was already doing freebsd builds) here:
https://github.com/pbo-linaro/qemu-ci/branches/all
This way, a future regression will be caught directly.
Regards,
Pierrick
Philippe Mathieu-Daudé
AppliedQuoted 17 lines · Thomas Huth
From: Thomas Huth <[email protected]>
Compiling on NetBSD currently fails with:
../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host,size_tsize,| ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type 1152 | static struct RAMBlockNotifier nvmm_ram_notifier = { | ^~~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added' 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~ ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function) 1153 | .ram_block_added = nvmm_ram_block_added | ^~~~~~~~~~~~~~~~~~~~
Quoted 6 lines
Include the right header to get this fixed.
Signed-off-by Thomas Huth <[email protected]>--- target/i386/nvmm/nvmm-all.c | 1 + 1 file changed, 1 insertion(+)
Queued via accel-next tree, thanks!