Skip to contentSkip to conversation

target/i386/nvmm: Include missing ramlist.h header

PATCH Applied Thomas Huth 4 participants 5 messages Jan 14 – Jan 15

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/i386/nvmm: Include missing ramlist.h header

From: Thomas Huth <[email protected]>

Compiling on NetBSD currently fails with:

../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size,

       |                      ^~~~~~~~~~~~~~~~
 ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type
  1152 | static struct RAMBlockNotifier nvmm_ram_notifier = {
       |               ^~~~~~~~~~~~~~~~
 ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added'
  1153 |     .ram_block_added = nvmm_ram_block_added
       |      ^~~~~~~~~~~~~~~
 ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function)
  1153 |     .ram_block_added = nvmm_ram_block_added
       |                        ^~~~~~~~~~~~~~~~~~~~

Include the right header to get this fixed.

---
 target/i386/nvmm/nvmm-all.c | 1 +
 1 file changed, 1 insertion(+)
target/i386/nvmm/nvmm-all.c +1 -0
index f808828d492..8a1af35ed32 100644
@@ -16,6 +16,7 @@
 #include "system/nvmm.h"
 #include "system/cpus.h"
 #include "system/memory.h"
+#include "system/ramlist.h"
 #include "system/runstate.h"
 #include "qemu/main-loop.h"
 #include "qemu/error-report.h"
Signature · 1 line
2.52.0
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Compiling on NetBSD currently fails with:

../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size,

        |                      ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type
   1152 | static struct RAMBlockNotifier nvmm_ram_notifier = {
        |               ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added'
   1153 |     .ram_block_added = nvmm_ram_block_added
        |      ^~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function)
   1153 |     .ram_block_added = nvmm_ram_block_added
        |                        ^~~~~~~~~~~~~~~~~~~~
Quoted 3 lines

Include the right header to get this fixed.

Quoted 16 lines
---
  target/i386/nvmm/nvmm-all.c | 1 +
  1 file changed, 1 insertion(+)
target/i386/nvmm/nvmm-all.c +1 -0
index f808828d492..8a1af35ed32 100644
@@ -16,6 +16,7 @@
  #include "system/nvmm.h"
  #include "system/cpus.h"
  #include "system/memory.h"
+#include "system/ramlist.h"
  #include "system/runstate.h"
  #include "qemu/main-loop.h"
  #include "qemu/error-report.h"
Tested-by Pierrick Bouvier Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 17 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Compiling on NetBSD currently fails with:

../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size,

        |                      ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type
   1152 | static struct RAMBlockNotifier nvmm_ram_notifier = {
        |               ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added'
   1153 |     .ram_block_added = nvmm_ram_block_added
        |      ^~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function)
   1153 |     .ram_block_added = nvmm_ram_block_added
        |                        ^~~~~~~~~~~~~~~~~~~~
Quoted 6 lines

Include the right header to get this fixed.

---
  target/i386/nvmm/nvmm-all.c | 1 +
  1 file changed, 1 insertion(+)
Reviewed-by on v1 1/1
#3 lore raw
In reply to Thomas Huth
Quoted 17 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Compiling on NetBSD currently fails with:

../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size,

        |                      ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type
   1152 | static struct RAMBlockNotifier nvmm_ram_notifier = {
        |               ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added'
   1153 |     .ram_block_added = nvmm_ram_block_added
        |      ^~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function)
   1153 |     .ram_block_added = nvmm_ram_block_added
        |                        ^~~~~~~~~~~~~~~~~~~~
Quoted 7 lines

Include the right header to get this fixed.

---
  target/i386/nvmm/nvmm-all.c | 1 +
  1 file changed, 1 insertion(+)

For what it's worth, I added netbsd build (was already doing freebsd builds) here:
https://github.com/pbo-linaro/qemu-ci/branches/all

This way, a future regression will be caught directly.

Regards,
Pierrick

#4 lore raw
In reply to Thomas Huth
Quoted 17 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Compiling on NetBSD currently fails with:

../src/target/i386/nvmm/nvmm-all.c:1136:22: error: unknown type name 'RAMBlockNotifier'
1136 | nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size,

        |                      ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1152:15: error: variable 'nvmm_ram_notifier' has initializer but incomplete type
   1152 | static struct RAMBlockNotifier nvmm_ram_notifier = {
        |               ^~~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:6: error: 'struct RAMBlockNotifier' has no member named 'ram_block_added'
   1153 |     .ram_block_added = nvmm_ram_block_added
        |      ^~~~~~~~~~~~~~~
  ../src/target/i386/nvmm/nvmm-all.c:1153:24: error: 'nvmm_ram_block_added' undeclared here (not in a function)
   1153 |     .ram_block_added = nvmm_ram_block_added
        |                        ^~~~~~~~~~~~~~~~~~~~
Quoted 6 lines

Include the right header to get this fixed.

---
  target/i386/nvmm/nvmm-all.c | 1 +
  1 file changed, 1 insertion(+)

Queued via accel-next tree, thanks!