Skip to contentSkip to conversation

scsi: mpt3sas: Fix use-after-free race in event log access

PATCH RESEND New Chengfeng Ye 1 participant 1 message Jan 18

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 scsi: mpt3sas: Fix use-after-free race in event log access

A use-after-free race exists between ioctl operations accessing the event log and device removal freeing it. The race occurs because ioc->remove_host flag is set without synchronization, creating a window where an ioctl can pass the removal check but still access freed memory.

Race scenario:

CPU0 (ioctl) CPU1 (device removal)
---------------- ---------------------
_ctl_ioctl_main()

    mutex_lock(&pci_access_mutex)
    if (!ioc->remove_host)
      [check passes]
                                     scsih_remove()
                                       ioc->remove_host = 1
                                       mpt3sas_ctl_release()
                                         kfree(ioc->event_log)

    _ctl_eventreport()
      copy_to_user(..., ioc->event_log, ...)  <- use-after-free

mutex_unlock(&pci_access_mutex)

Fix by setting ioc->remove_host while holding pci_access_mutex. This ensures the ioctl path either completes before removal starts, or sees the flag and returns -EAGAIN.

Fixes 6a965ee1892a ("scsi: mpt3sas: Suppress a warning in debug kernel")
CC Markus Elfring <[email protected]>
CC Sathya Prakash <[email protected]>
CC Sreekanth Reddy <[email protected]>
CC Suganath Prabu Subramani <[email protected]>
CC James E.J. Bottomley <[email protected]>
CC Martin K. Petersen <[email protected]>
CC Tomas Henzl <[email protected]>

---
V1 -> V2: Use scoped_guard instead of lock/unlock pair

 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/scsi/mpt3sas/mpt3sas_scsih.c +4 -1
index 7092d0debef3..973893528747 100644
@@ -11264,7 +11264,10 @@ static void scsih_remove(struct pci_dev *pdev)
 	if (_scsih_get_shost_and_ioc(pdev, &shost, &ioc))
 		return;
 
-	ioc->remove_host = 1;
+	/* Set remove_host flag under pci_access_mutex to synchronize with ioctl path */
+	scoped_guard(mutex, &ioc->pci_access_mutex) {
+		ioc->remove_host = 1;
+	}
 
 	if (!pci_device_is_present(pdev)) {
 		mpt3sas_base_pause_mq_polling(ioc);
Signature · 1 line
2.25.1