scsi: mpt3sas: Fix use-after-free race in event log access
Subsystems (2)
PATCH v2 1/1 scsi: mpt3sas: Fix use-after-free race in event log access
A use-after-free race exists between ioctl operations accessing the event log and device removal freeing it. The race occurs because ioc->remove_host flag is set without synchronization, creating a window where an ioctl can pass the removal check but still access freed memory.
Race scenario:
CPU0 (ioctl) CPU1 (device removal)
---------------- ---------------------
_ctl_ioctl_main()
mutex_lock(&pci_access_mutex)
if (!ioc->remove_host)
[check passes]
scsih_remove()
ioc->remove_host = 1
mpt3sas_ctl_release()
kfree(ioc->event_log)
_ctl_eventreport()
copy_to_user(..., ioc->event_log, ...) <- use-after-free mutex_unlock(&pci_access_mutex)
Fix by setting ioc->remove_host while holding pci_access_mutex. This ensures the ioctl path either completes before removal starts, or sees the flag and returns -EAGAIN.
--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/scsi/mpt3sas/mpt3sas_scsih.c +4 -1
@@ -11264,7 +11264,10 @@ static void scsih_remove(struct pci_dev *pdev)if (_scsih_get_shost_and_ioc (pdev, &shost, &ioc))return ; - ioc->remove_host =1 ; +/* Set remove_host flag under pci_access_mutex to synchronize with ioctl path */ + scoped_guard(mutex, &ioc->pci_access_mutex) { + ioc->remove_host =1 ; + }if (!pci_device_is_present (pdev)) {mpt3sas_base_pause_mq_polling (ioc);
Signature · 1 line
2.25.1
…
Quoted 2 lines
--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 ++++-
…
Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n310
Regards,
Markus
Quoted 3 lines
Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n310
No problem, resend the patch with the change log included.
Best regards,
Chengfeng