Skip to contentSkip to conversation

net: usb: r8152: fix transmit queue timeout

PATCH Superseded insyelu 2 participants 2 messages Jan 19

Subsystems (4)
lore
Share & tools
lore

insyelu

author
#0 lore raw

PATCH v2 1/1 net: usb: r8152: fix transmit queue timeout

When the TX queue length reaches the threshold, the netdev watchdog immediately detects a TX queue timeout.

This patch updates the trans_start timestamp of the transmit queue on every asynchronous USB URB submission along the transmit path, ensuring that the network watchdog accurately reflects ongoing transmission activity.

---
v2: Update the transmit timestamp when submitting the USB URB.

---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/usb/r8152.c +2 -0
index fa5192583860..880b59ed5422 100644
@@ -2449,6 +2449,8 @@ static int r8152_tx_agg_fill(struct r8152 *tp, struct tx_agg *agg)
 	ret = usb_submit_urb(agg->urb, GFP_ATOMIC);
 	if (ret < 0)
 		usb_autopm_put_interface_async(tp->intf);
+	else
+		netif_trans_update(tp->netdev);
 
 out_tx_fill:
 	return ret;
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 9 lines · insyelu

When the TX queue length reaches the threshold, the netdev watchdog immediately detects a TX queue timeout.

This patch updates the trans_start timestamp of the transmit queue on every asynchronous USB URB submission along the transmit path, ensuring that the network watchdog accurately reflects ongoing transmission activity.

We need a real name please.

thanks,

greg k-h