Skip to contentSkip to conversation

net: usb: r8152: fix transmit queue timeout

PATCH Applied Mingj Ye 3 participants 3 messages Jan 20 – Jan 21

Subsystems (4)
lore
Share & tools
lore

Mingj Ye

author
#0 lore raw

PATCH v2 1/1 net: usb: r8152: fix transmit queue timeout

When the TX queue length reaches the threshold, the netdev watchdog immediately detects a TX queue timeout.

This patch updates the trans_start timestamp of the transmit queue on every asynchronous USB URB submission along the transmit path, ensuring that the network watchdog accurately reflects ongoing transmission activity.

---
v2: Update the transmit timestamp when submitting the USB URB.

---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/usb/r8152.c +2 -0
index fa5192583860..880b59ed5422 100644
@@ -2449,6 +2449,8 @@ static int r8152_tx_agg_fill(struct r8152 *tp, struct tx_agg *agg)
 	ret = usb_submit_urb(agg->urb, GFP_ATOMIC);
 	if (ret < 0)
 		usb_autopm_put_interface_async(tp->intf);
+	else
+		netif_trans_update(tp->netdev);
 
 out_tx_fill:
 	return ret;
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 2 lines

From: Mingj Ye <[email protected]>
Sent: Tuesday, January 20, 2026 10:00 AM

[...]

Quoted 11 lines

When the TX queue length reaches the threshold, the netdev watchdog immediately detects a TX queue timeout.

This patch updates the trans_start timestamp of the transmit queue on every asynchronous USB URB submission along the transmit path, ensuring that the network watchdog accurately reflects ongoing transmission activity.

---
v2: Update the transmit timestamp when submitting the USB URB.

Best Regards,
Hayes

#2 lore raw
In reply to Mingj Ye
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Tue, 20 Jan 2026 09:59:49 +0800 you wrote:

When the TX queue length reaches the threshold, the netdev watchdog immediately detects a TX queue timeout.

This patch updates the trans_start timestamp of the transmit queue on every asynchronous USB URB submission along the transmit path, ensuring that the network watchdog accurately reflects ongoing transmission activity.

[...]

Here is the summary with links:
- [v2] net: usb: r8152: fix transmit queue timeout

    https://git.kernel.org/netdev/net-next/c/833dcd75d54f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html