Skip to contentSkip to conversation

Add SMI reset and clamp for MediaTek MT8188 SoC

PATCH In review Friday Yang 2 participants 4 messages Jan 19 – Feb 13

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v12 cover Add SMI reset and clamp for MediaTek MT8188 SoC

Based on tag: next-20260116, linux-next/master

On the MediaTek MT8188 SoC platform, we encountered power-off failures and SMI bus hang issues during camera stress tests. The issue arises because bus glitches are sometimes produced when MTCMOS powers on or off. While this is fairly normal, the software must handle these glitches to avoid mistaking them for transaction signals. What's more, this issue emerged only after the initial upstreaming of SMI driver.

The software solutions can be summarized as follows:

1. Use CLAMP to disable the SMI sub-common port after turning off the LARB CG and before turning off the LARB MTCMOS.
2. Use CLAMP to disable/enable the SMI sub-common port.
3. Implement an AXI reset for SMI LARBs.

---
Changes in v12:
- We used to parse 'mediatek,smi' property in 'mtk_smi_larb_parse_syscon' to get smi sub common regmap. The property has already been parsed in 'mtk_smi_device_link_common'. To remove redundant code, we remove 'mtk_smi_larb_parse_syscon' function and get the smi sub common regmap in 'mtk_smi_device_link_common'.
- We need to get driver data in 'mtk_smi_device_link_common', so move 'platform_set_drvdata' before 'mtk_smi_device_link_common' in 'mtk_smi_larb_probe'.

Changes in v11:
- Add error checking in the 'mtk_smi_genpd_callback' function and use 'switch-case' statement instead of 'if-else'.
- Use 'larb->larb_gen->clamp_port[larb->larbid]' to determine whether smi larb requires clamp and reset operations or not in 'mtk_smi_larb_probe'. Remove the '_optional' suffix from the function name.
- Replace 'devm_reset_control_get_optional_exclusive' with 'devm_reset_control_get_exclusive' in 'mtk_smi_larb_parse_reset', return the error code if it fails to get the reset controller.
- Remove genpd callback when smi larb probe fails.
- Link to v11:
https://lore.kernel.org/lkml/[email protected]/

Changes in v10:
- Rename 'smi_comm_inport_id' to 'smi_comm_in_port_id'.
- Return 0 when it fails to get 'larb_id' in 'mtk_smi_larb_parse_clamp_optional'.
- Link to v10:
https://lore.kernel.org/lkml/[email protected]/

Changes in v9:
- Add 'dev_pm_genpd_remove_notifier' in 'mtk_smi_larb_remove'.
- Remove unused macros.
- Rename 'sub_comm_syscon' to 'smi_comm_syscon'.
- Rename 'sub_comm_inport_id' to 'smi_comm_inport_id'.
- Add more detailed descriptions in change log.
- Fix incorrect tags.
- Link to v9:
https://lore.kernel.org/lkml/[email protected]/

Changes in v8:
- Fix incorrect tags.
- Link to v8:
https://lore.kernel.org/lkml/[email protected]/

Changes in v7:
- We replaced 'pm_runtime_enable' with 'devm_pm_runtime_enable' in the v6 patch. This changed the order of cleanup, and reviewers expressed concerns that it could introduce unexpected issues. So v7 discard this change and continue using 'pm_runtime_enable'. We need to conduct further investigation to determine if there are any issues related to the cleanup order. This might be resolved in the future, but for now, we just maintain the current status.
- Link to v7:
https://lore.kernel.org/lkml/[email protected]/

Changes in v6:
- Fix coding style.
- Add another patch to replace 'pm_runtime_enable' with 'devm_pm_runtime_enable'.
- Link to v6:
https://lore.kernel.org/lkml/[email protected]/

Changes in v5:
- Use 'devm_pm_runtime_enable' instead of 'pm_runtime_enable'.
- Remove 'pm_runtime_disable' in 'mtk_smi_common_remove' and 'mtk_smi_larb_remove'.
- Link to v5:
https://lore.kernel.org/lkml/[email protected]/

Changes in v4:
- Use 'devm_reset_control_get_optional_exclusive' instead of 'devm_reset_control_get'.
- Link to v4:
https://lore.kernel.org/lkml/[email protected]/

Changes in v3:
- Remove redundant descriptions for 'resets' and 'reset-names'.
- Modify the requirements for 'resets' and 'reset-names'.
- Rename 'mtk_smi_larb_parse_clamp' to 'mtk_smi_larb_parse_clamp_optional'.
- Rename 'mtk_smi_larb_parse_reset' to 'mtk_smi_larb_parse_reset_optional'.
- Merge 'mtk_smi_larb_clamp_protect_enable' and 'mtk_smi_larb_clamp_protect_disble' into one function.
- Modify the definition for mtk_smi_larb_clamp_port_mt8188,
use 'larbid' as the index of the array.
- Use 'syscon_regmap_lookup_by_phandle' instead of 'device_node_to_regmap'.
- Do Not parse 'resets', just check the return value of 'devm_reset_control_get'.
- Add 'has_gals' flag for 'mtk_smi_sub_common_mt8188'.
- Link to v3:
https://lore.kernel.org/lkml/[email protected]/

Changes in v2:
- According to previous discussions in v1, divided these four patches into two topic separately.
- Modify the description for 'resets' in binding.
- Add const value 'larb' for 'reset-names' in binding.
- Modify requirement for 'resets' and 'reset-names' in binding.
- Delete 'mediatek,smi-sub-comm' in binding.
- Delete 'mediatek,smi-sub-comm-in-portid' in binding.
- Modify the example in binding.
- Add 'mtk_smi_larb_clamp_port_mt8188' definition in SMI driver.
- Change the way to parse the 'resets' in driver.
- Change label from 'err_pm_disable' to 'err_link_remove'.
- Link to v2:
https://lore.kernel.org/lkml/[email protected]/

Friday Yang (2):
dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188
memory: mtk-smi: mt8188: Add SMI reset and clamp

 .../mediatek,smi-common.yaml                  |   2 +
 .../memory-controllers/mediatek,smi-larb.yaml |  19 ++
 drivers/memory/mtk-smi.c                      | 177 +++++++++++++++++-
 3 files changed, 188 insertions(+), 10 deletions(-)

--
2.46.0

#1 lore raw

PATCH v12 1/2 dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188

On the MediaTek MT8188 SoC, bus glitches may occur during MTCMOS on/off transitions. The root cause is a hardware design choice in the camera subsystem where the SMI LARB and SMI Sub-Common modules are located in separate power domains and controlled by independent MTCMOS gates. A timing window exists after the main power domain is enabled but before the sub-power domain is enabled. During this window, unstable glitch signals can appear on the bus. Unlike other subsystems, the camera subsystem lacks a GALs (Globally Asynchronous Locally Synchronous) hardware module, which would normally handle cross-domain synchronization and filter out such glitches. In contrast, other subsystems have their SMI LARB and SMI Sub-Common within one power domain or could rely on GALs for synchronization. Thus they are not affected by this issue.

To prevent these glitches from causing bus hang, SMI requires clamp and reset operations. This change adds the 'resets' and 'reset-names' properties to SMI LARBs within camera subsystem to support the necessary reset operations. This reset setting is exclusively required for the MediaTek MT8188 platform and remains inactive on other SoCs.

We also add 'smi-sub-common' in the smi-common binding for MT8188. This indicates that some SMI LARBs are connected to the SMI Sub-Common, which in turn is connected to the SMI Common. The hardware block diagram can be described as follows.

SMI-Common(Smart Multimedia Interface Common)
|
+----------------+------------------+
| | |
| | |
| | |
| | |
| | |
larb0 SMI-Sub-Common0 SMI-Sub-Common1
| | | | |
larb1 larb2 larb3 larb7 larb9

---
 .../mediatek,smi-common.yaml                  |  2 ++
 .../memory-controllers/mediatek,smi-larb.yaml | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+)
Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml +2 -0
index 0762e0ff66ef..3d98c08b2149 100644
@@ -40,6 +40,7 @@ properties:
           - mediatek,mt8186-smi-common
           - mediatek,mt8188-smi-common-vdo
           - mediatek,mt8188-smi-common-vpp
+          - mediatek,mt8188-smi-sub-common
           - mediatek,mt8192-smi-common
           - mediatek,mt8195-smi-common-vdo
           - mediatek,mt8195-smi-common-vpp
@@ -108,6 +109,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - mediatek,mt8188-smi-sub-common
               - mediatek,mt8195-smi-sub-common
     then:
       required:
Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml +19 -0
index 2e7fac4b5094..fc5feb2eac1f 100644
@@ -70,6 +70,12 @@ properties:
     description: the hardware id of this larb. It's only required when this
       hardware id is not consecutive from its M4U point of view.
 
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: larb
+
 required:
   - compatible
   - reg
@@ -126,6 +132,19 @@ allOf:
       required:
         - mediatek,larb-id
 
+  - if:  # only for image, camera and ipe subsys
+      properties:
+        compatible:
+          const: mediatek,mt8188-smi-larb
+        mediatek,larb-id:
+          enum:
+            [ 9, 10, 11, 12, 13, 16, 17, 18, 19, 20 ]
+
+    then:
+      required:
+        - resets
+        - reset-names
+
 additionalProperties: false
 
 examples:

--
2.46.0

#2 lore raw

PATCH v12 2/2 memory: mtk-smi: mt8188: Add SMI reset and clamp

In reply to Friday Yang

To prevent handling glitch signals during MTCMOS on/off transitions, SMI requires clamp and reset operations. Parse the reset settings for SMI LARBs and the clamp settings for the SMI Sub-Common. Register genpd callback for the SMI LARBs located in image, camera and IPE subsystems, and apply reset and clamp operations within the callback. The 'mtk_smi_device_link_common' already parses the 'mediatek,smi' property. A similar step is required to obtain the SMI Common regmap from the 'mediatek,smi' property for the clamp function. To centralize this process and avoid redundant parsing, we achieve it together.

---
 drivers/memory/mtk-smi.c | 177 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 167 insertions(+), 10 deletions(-)
drivers/memory/mtk-smi.c +167 -10
index aaeba8ab211e..042b4c040def 100644
@@ -10,11 +10,15 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/iopoll.h>
+#include <linux/mfd/syscon.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
+#include <linux/pm_domain.h>
 #include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>
 #include <linux/soc/mediatek/mtk_sip_svc.h>
 #include <soc/mediatek/smi.h>
 #include <dt-bindings/memory/mt2701-larb-port.h>
@@ -34,6 +38,8 @@
 #define SMI_FIFO_TH1			0x238
 #define SMI_FIFO_TH2			0x23c
 #define SMI_DCM				0x300
+#define SMI_COMMON_CLAMP_EN_SET		0x3c4
+#define SMI_COMMON_CLAMP_EN_CLR		0x3c8
 #define SMI_DUMMY			0x444
 
 /* SMI LARB */
@@ -134,6 +140,7 @@ struct mtk_smi_larb_gen {
 	unsigned int			larb_direct_to_common_mask;
 	unsigned int			flags_general;
 	const u8			(*ostd)[SMI_LARB_PORT_NR_MAX];
+	const u8			*clamp_port;
 };
 
 struct mtk_smi {
@@ -150,6 +157,7 @@ struct mtk_smi {
 };
 
 struct mtk_smi_larb { /* larb: local arbiter */
+	struct device			*dev;
 	struct mtk_smi			smi;
 	void __iomem			*base;
 	struct device			*smi_common_dev; /* common or sub-common dev */
@@ -157,6 +165,10 @@ struct mtk_smi_larb { /* larb: local arbiter */
 	int				larbid;
 	u32				*mmu;
 	unsigned char			*bank;
+	struct regmap			*smi_comm_syscon; /* smi-comm or sub-comm */
+	u8				smi_comm_in_port_id; /* smi-comm or sub-comm */
+	struct notifier_block		nb;
+	struct reset_control		*rst_con;
 };
 
 static int
@@ -478,6 +490,19 @@ static const u8 mtk_smi_larb_mt8195_ostd[][SMI_LARB_PORT_NR_MAX] = {
 	[28] = {0x1a, 0x0e, 0x0a, 0x0a, 0x0c, 0x0e, 0x10,},
 };
 
+static const u8 mtk_smi_larb_clamp_port_mt8188[MTK_LARB_NR_MAX] = {
+	[9]	= BIT(1), /* larb10 */
+	[10]	= BIT(2), /* larb11a */
+	[11]	= BIT(2), /* larb11b */
+	[12]	= BIT(3), /* larb11c */
+	[13]	= BIT(0), /* larb12 */
+	[16]	= BIT(1), /* larb15 */
+	[17]	= BIT(2), /* larb16a */
+	[18]	= BIT(2), /* larb16b */
+	[19]	= BIT(3), /* larb17a */
+	[20]	= BIT(3), /* larb17b */
+};
+
 static const struct mtk_smi_larb_gen mtk_smi_larb_mt2701 = {
 	.port_in_larb = {
 		LARB0_PORT_OFFSET, LARB1_PORT_OFFSET,
@@ -531,6 +556,7 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8188 = {
 	.flags_general	            = MTK_SMI_FLAG_THRT_UPDATE | MTK_SMI_FLAG_SW_FLAG |
 				      MTK_SMI_FLAG_SLEEP_CTL | MTK_SMI_FLAG_CFG_PORT_SEC_CTL,
 	.ostd		            = mtk_smi_larb_mt8188_ostd,
+	.clamp_port                 = mtk_smi_larb_clamp_port_mt8188,
 };
 
 static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = {
@@ -582,28 +608,79 @@ static void mtk_smi_larb_sleep_ctrl_disable(struct mtk_smi_larb *larb)
 	writel_relaxed(0, larb->base + SMI_LARB_SLP_CON);
 }
 
-static int mtk_smi_device_link_common(struct device *dev, struct device **com_dev)
+static int mtk_smi_larb_clamp_protect_enable(struct device *dev, bool enable)
+{
+	struct mtk_smi_larb *larb = dev_get_drvdata(dev);
+	u32 reg;
+	int ret;
+
+	reg = enable ? SMI_COMMON_CLAMP_EN_SET : SMI_COMMON_CLAMP_EN_CLR;
+	ret = regmap_write(larb->smi_comm_syscon, reg, larb->smi_comm_in_port_id);
+	if (ret)
+		dev_err(dev, "Unable to %s clamp for input port %d: %d\n",
+			enable ? "enable" : "disable",
+			larb->smi_comm_in_port_id, ret);
+
+	return ret;
+}
+
+static int mtk_smi_genpd_callback(struct notifier_block *nb,
+				  unsigned long event, void *data)
+{
+	struct mtk_smi_larb *larb = container_of(nb, struct mtk_smi_larb, nb);
+	struct device *dev = larb->dev;
+	int ret = 0;
+
+	switch (event) {
+	case GENPD_NOTIFY_PRE_ON:
+	case GENPD_NOTIFY_PRE_OFF:
+		/* Clamp this larb to avoid the redundant commands */
+		ret = mtk_smi_larb_clamp_protect_enable(dev, true);
+		break;
+	case GENPD_NOTIFY_ON:
+		ret = reset_control_reset(larb->rst_con);
+		if (ret) {
+			dev_err(dev, "Failed to reset smi larb %d\n", ret);
+			break;
+		}
+
+		ret = mtk_smi_larb_clamp_protect_enable(dev, false);
+		break;
+	default:
+		break;
+	}
+	if (ret)
+		return NOTIFY_BAD;
+
+	return NOTIFY_OK;
+}
+
+static int mtk_smi_device_link_common(struct device *dev, struct device **com_dev,
+				      bool require_clamp)
 {
 	struct platform_device *smi_com_pdev;
 	struct device_node *smi_com_node;
 	struct device *smi_com_dev;
 	struct device_link *link;
+	const struct mtk_smi_larb_gen *larb_gen;
+	struct mtk_smi_larb *larb;
+	int larbid, ret;
 
 	smi_com_node = of_parse_phandle(dev->of_node, "mediatek,smi", 0);
 	if (!smi_com_node)
 		return -EINVAL;
 
 	smi_com_pdev = of_find_device_by_node(smi_com_node);
-	of_node_put(smi_com_node);
 	if (!smi_com_pdev) {
 		dev_err(dev, "Failed to get the smi_common device\n");
-		return -EINVAL;
+		ret = -EINVAL;
+		goto err_put_node;
 	}
 
 	/* smi common is the supplier, Make sure it is ready before */
 	if (!platform_get_drvdata(smi_com_pdev)) {
-		put_device(&smi_com_pdev->dev);
-		return -EPROBE_DEFER;
+		ret = -EPROBE_DEFER;
+		goto err_put_device;
 	}
 
 	smi_com_dev = &smi_com_pdev->dev;
@@ -611,13 +688,36 @@ static int mtk_smi_device_link_common(struct device *dev, struct device **com_de
 			       DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS);
 	if (!link) {
 		dev_err(dev, "Unable to link smi-common dev\n");
-		put_device(&smi_com_pdev->dev);
-		return -ENODEV;
+		ret = -ENODEV;
+		goto err_put_device;
 	}
 
 	*com_dev = smi_com_dev;
 
+	if (require_clamp) {
+		larb = dev_get_drvdata(dev);
+		larb_gen = larb->larb_gen;
+		larbid = larb->larbid;
+		larb->smi_comm_in_port_id = larb_gen->clamp_port[larbid];
+		larb->smi_comm_syscon = syscon_node_to_regmap(smi_com_node);
+		if (IS_ERR(larb->smi_comm_syscon)) {
+			dev_err(dev, "Failed to get smi syscon for larb %d\n", larbid);
+			ret = PTR_ERR(larb->smi_comm_syscon);
+			larb->smi_comm_syscon = NULL;
+			goto err_remove_link;
+		}
+	}
+	of_node_put(smi_com_node);
+
 	return 0;
+
+err_remove_link:
+	device_link_remove(dev, smi_com_dev);
+err_put_device:
+	put_device(&smi_com_pdev->dev);
+err_put_node:
+	of_node_put(smi_com_node);
+	return ret;
 }
 
 static int mtk_smi_dts_clk_init(struct device *dev, struct mtk_smi *smi,
@@ -641,16 +741,39 @@ static int mtk_smi_dts_clk_init(struct device *dev, struct mtk_smi *smi,
 	return ret;
 }
 
+static int mtk_smi_larb_parse_reset(struct mtk_smi_larb *larb)
+{
+	struct device *dev = larb->dev;
+	int ret;
+
+	larb->rst_con = devm_reset_control_get_exclusive(dev, "larb");
+	if (IS_ERR(larb->rst_con))
+		return dev_err_probe(dev, PTR_ERR(larb->rst_con),
+				     "Failed to get reset controller\n");
+
+	larb->nb.notifier_call = mtk_smi_genpd_callback;
+	ret = dev_pm_genpd_add_notifier(dev, &larb->nb);
+	if (ret) {
+		larb->nb.notifier_call = NULL;
+		return dev_err_probe(dev, ret,
+				     "Failed to add genpd callback\n");
+	}
+
+	return 0;
+}
+
 static int mtk_smi_larb_probe(struct platform_device *pdev)
 {
 	struct mtk_smi_larb *larb;
 	struct device *dev = &pdev->dev;
+	bool require_clamp = false;
 	int ret;
 
 	larb = devm_kzalloc(dev, sizeof(*larb), GFP_KERNEL);
 	if (!larb)
 		return -ENOMEM;
 
+	larb->dev = dev;
 	larb->larb_gen = of_device_get_match_data(dev);
 	larb->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(larb->base))
@@ -663,19 +786,44 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
 
 	larb->smi.dev = dev;
 
-	ret = mtk_smi_device_link_common(dev, &larb->smi_common_dev);
+	platform_set_drvdata(pdev, larb);
+	/* The larbid are sequential for IOMMU if this property is not present */
+	ret = of_property_read_s32(dev->of_node, "mediatek,larb-id", &larb->larbid);
+	if (ret == -EINVAL)
+		goto add_dev_link;
+	else if (ret || larb->larbid >= MTK_LARB_NR_MAX)
+		return dev_err_probe(dev, -EINVAL, "Invalid larbid:%d\n", larb->larbid);
+
+	if (larb->larb_gen->clamp_port && larb->larb_gen->clamp_port[larb->larbid])
+		require_clamp = true;
+
+add_dev_link:
+	ret = mtk_smi_device_link_common(dev, &larb->smi_common_dev, require_clamp);
 	if (ret < 0)
 		return ret;
 
+	/*
+	 * Only SMI LARBs in camera, image and IPE subsys need to
+	 * apply clamp and reset operations, others can be skipped.
+	 */
+	if (require_clamp) {
+		ret = mtk_smi_larb_parse_reset(larb);
+		if (ret)
+			goto err_link_remove;
+	}
+
 	pm_runtime_enable(dev);
-	platform_set_drvdata(pdev, larb);
 	ret = component_add(dev, &mtk_smi_larb_component_ops);
 	if (ret)
 		goto err_pm_disable;
 	return 0;
 
 err_pm_disable:
+	if (larb->nb.notifier_call)
+		dev_pm_genpd_remove_notifier(&pdev->dev);
+
 	pm_runtime_disable(dev);
+err_link_remove:
 	device_link_remove(dev, larb->smi_common_dev);
 	put_device(larb->smi_common_dev);
 	return ret;
@@ -685,6 +833,9 @@ static void mtk_smi_larb_remove(struct platform_device *pdev)
 {
 	struct mtk_smi_larb *larb = platform_get_drvdata(pdev);
 
+	if (larb->nb.notifier_call)
+		dev_pm_genpd_remove_notifier(&pdev->dev);
+
 	device_link_remove(&pdev->dev, larb->smi_common_dev);
 	pm_runtime_disable(&pdev->dev);
 	component_del(&pdev->dev, &mtk_smi_larb_component_ops);
@@ -808,6 +959,11 @@ static const struct mtk_smi_common_plat mtk_smi_common_mt8188_vpp = {
 	.init     = mtk_smi_common_mt8195_init,
 };
 
+static const struct mtk_smi_common_plat mtk_smi_sub_common_mt8188 = {
+	.type     = MTK_SMI_GEN2_SUB_COMM,
+	.has_gals = true,
+};
+
 static const struct mtk_smi_common_plat mtk_smi_common_mt8192 = {
 	.type     = MTK_SMI_GEN2,
 	.has_gals = true,
@@ -852,6 +1008,7 @@ static const struct of_device_id mtk_smi_common_of_ids[] = {
 	{.compatible = "mediatek,mt8186-smi-common", .data = &mtk_smi_common_mt8186},
 	{.compatible = "mediatek,mt8188-smi-common-vdo", .data = &mtk_smi_common_mt8188_vdo},
 	{.compatible = "mediatek,mt8188-smi-common-vpp", .data = &mtk_smi_common_mt8188_vpp},
+	{.compatible = "mediatek,mt8188-smi-sub-common", .data = &mtk_smi_sub_common_mt8188},
 	{.compatible = "mediatek,mt8192-smi-common", .data = &mtk_smi_common_mt8192},
 	{.compatible = "mediatek,mt8195-smi-common-vdo", .data = &mtk_smi_common_mt8195_vdo},
 	{.compatible = "mediatek,mt8195-smi-common-vpp", .data = &mtk_smi_common_mt8195_vpp},
@@ -905,7 +1062,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
 
 	/* link its smi-common if this is smi-sub-common */
 	if (common->plat->type == MTK_SMI_GEN2_SUB_COMM) {
-		ret = mtk_smi_device_link_common(dev, &common->smi_common_dev);
+		ret = mtk_smi_device_link_common(dev, &common->smi_common_dev, false);
 		if (ret < 0)
 			return ret;
 	}

--
2.46.0

maintainer
#3 lore raw

Re: [PATCH v12 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp

Quoted 16 lines · Friday Yang

To prevent handling glitch signals during MTCMOS on/off transitions, SMI requires clamp and reset operations. Parse the reset settings for SMI LARBs and the clamp settings for the SMI Sub-Common. Register genpd callback for the SMI LARBs located in image, camera and IPE subsystems, and apply reset and clamp operations within the callback. The 'mtk_smi_device_link_common' already parses the 'mediatek,smi' property. A similar step is required to obtain the SMI Common regmap from the 'mediatek,smi' property for the clamp function. To centralize
this process and avoid redundant parsing, we achieve it together.

---
 drivers/memory/mtk-smi.c | 177 ++++++++++++++++++++++++++++++++++++-
--
 1 file changed, 167 insertions(+), 10 deletions(-)

[snip]

Quoted 25 lines
drivers/memory/mtk-smi.c +0 -0
 	smi_com_dev = &smi_com_pdev->dev;
@@ -611,13 +688,36 @@ static int mtk_smi_device_link_common(struct

device *dev, struct device **com_de

drivers/memory/mtk-smi.c +7 -2
 			       DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS);
 	if (!link) {
 		dev_err(dev, "Unable to link smi-common dev\n");
-		put_device(&smi_com_pdev->dev);
-		return -ENODEV;
+		ret = -ENODEV;
+		goto err_put_device;
 	}
 
 	*com_dev = smi_com_dev;
 
+	if (require_clamp) {
+		larb = dev_get_drvdata(dev);
+		larb_gen = larb->larb_gen;
+		larbid = larb->larbid;
+		larb->smi_comm_in_port_id = larb_gen-
Quoted 1 line

clamp_port[larbid];

(quoted diff) +1 -0
+		larb->smi_comm_syscon =

syscon_node_to_regmap(smi_com_node);

(quoted diff) +2 -0
+		if (IS_ERR(larb->smi_comm_syscon)) {
+			dev_err(dev, "Failed to get smi syscon for larb

%d\n", larbid);

drivers/memory/mtk-smi.c static int mtk_smi_device_link_common(struct device *dev, struct device **com_de · line 709

Quoted 5 lines
drivers/memory/mtk-smi.c +5 -0
+			ret = PTR_ERR(larb->smi_comm_syscon);
+			larb->smi_comm_syscon = NULL;
+			goto err_remove_link;
+		}
+	}

sorry for the late reply.

It looks strange to put this part in this device_link function. If we want to avoid re-parse the "mediatek,smi" phandle, save the "smi_com_node" to a variable, then move this part into the below mtk_smi_larb_parse_reset.

Thanks.