Skip to contentSkip to conversation

fsnotify: Independent inode tracking

PATCH Superseded Jan Kara 2 participants 11 messages Jan 19 – Jan 20

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jan Kara

author maintainer
#0 lore raw

cover fsnotify: Independent inode tracking

Hello!

This patch set implements independent tracking of inodes that have any notification marks attached through a linked list of mark connectors used for inodes. We then use this list to destroy all inode marks for a superblock during unmount instead of iterating all inodes on a superblock. With this more efficient way of destroying all inode marks we can move this destruction earlier in generic_shutdown_super() before dcache (and sb->s_root in particular) is pruned which fixes races between fsnotify events encoding handles and accessing sb->s_root after generic_shutdown_super() has freed them.

Honza

author maintainer
#1 lore raw

PATCH 1/3 fsnotify: Track inode connectors for a superblock

Introduce a linked list tracking all inode connectors for a superblock. We will use this list when the superblock is getting shutdown to properly clean up all the inode marks instead of relying on scanning all inodes in the superblock which can get rather slow.

---
 fs/notify/fsnotify.c             |  8 ++-
 fs/notify/fsnotify.h             |  5 +-
 fs/notify/mark.c                 | 97 +++++++++++++++++++++++++++++---
 include/linux/fsnotify_backend.h |  6 +-
 4 files changed, 102 insertions(+), 14 deletions(-)
fs/notify/fsnotify.c +5 -3
index 71bd44e5ab6d..706484fb3bf3 100644
@@ -112,7 +112,10 @@ void fsnotify_sb_delete(struct super_block *sb)
 
 void fsnotify_sb_free(struct super_block *sb)
 {
-	kfree(sb->s_fsnotify_info);
+	if (sb->s_fsnotify_info) {
+		WARN_ON_ONCE(!list_empty(&sb->s_fsnotify_info->inode_conn_list));
+		kfree(sb->s_fsnotify_info);
+	}
 }
 
 /*
@@ -777,8 +780,7 @@ static __init int fsnotify_init(void)
 	if (ret)
 		panic("initializing fsnotify_mark_srcu");
 
-	fsnotify_mark_connector_cachep = KMEM_CACHE(fsnotify_mark_connector,
-						    SLAB_PANIC);
+	fsnotify_init_connector_caches();
 
 	return 0;
 }
fs/notify/fsnotify.h +4 -1
index 5950c7a67f41..4e271875dcad 100644
@@ -67,6 +67,9 @@ static inline fsnotify_connp_t *fsnotify_sb_marks(struct super_block *sb)
 	return sbinfo ? &sbinfo->sb_marks : NULL;
 }
 
+struct fsnotify_mark_connector *fsnotify_inode_connector_from_list(
+						struct list_head *head);
+
 /* destroy all events sitting in this groups notification queue */
 extern void fsnotify_flush_notify(struct fsnotify_group *group);
 
@@ -106,6 +109,6 @@ static inline void fsnotify_clear_marks_by_mntns(struct mnt_namespace *mntns)
  */
 extern void fsnotify_set_children_dentry_flags(struct inode *inode);
 
-extern struct kmem_cache *fsnotify_mark_connector_cachep;
+void fsnotify_init_connector_caches(void);
 
 #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
fs/notify/mark.c +88 -9

147 lines not on this page · raw message

include/linux/fsnotify_backend.h +5 -1
index 0d954ea7b179..7f2157d06043 100644
@@ -546,6 +546,7 @@ struct fsnotify_mark_connector {
 	unsigned char prio;	/* Highest priority group */
 #define FSNOTIFY_CONN_FLAG_IS_WATCHED	0x01
 #define FSNOTIFY_CONN_FLAG_HAS_IREF	0x02
+#define FSNOTIFY_CONN_FLAG_TRACKED	0x04
 	unsigned short flags;	/* flags [lock] */
 	union {
 		/* Object pointer [lock] */
@@ -553,7 +554,7 @@ struct fsnotify_mark_connector {
 		/* Used listing heads to free after srcu period expires */
 		struct fsnotify_mark_connector *destroy_next;
 	};
-	struct hlist_head list;
+	struct hlist_head list;	/* List of marks */
 };
 
 /*
@@ -562,6 +563,9 @@ struct fsnotify_mark_connector {
  */
 struct fsnotify_sb_info {
 	struct fsnotify_mark_connector __rcu *sb_marks;
+	/* List of connectors for inode marks */
+	struct list_head inode_conn_list;
+	spinlock_t list_lock;	/* Lock protecting inode_conn_list */
 	/*
 	 * Number of inode/mount/sb objects that are being watched in this sb.
 	 * Note that inodes objects are currently double-accounted.
Signature · 1 line
2.51.0
#2 lore raw

Re: [PATCH 1/3] fsnotify: Track inode connectors for a superblock

Quoted 158 lines · Jan Kara

Introduce a linked list tracking all inode connectors for a superblock. We will use this list when the superblock is getting shutdown to properly clean up all the inode marks instead of relying on scanning all inodes in the superblock which can get rather slow.

---
 fs/notify/fsnotify.c             |  8 ++-
 fs/notify/fsnotify.h             |  5 +-
 fs/notify/mark.c                 | 97 +++++++++++++++++++++++++++++---
 include/linux/fsnotify_backend.h |  6 +-
 4 files changed, 102 insertions(+), 14 deletions(-)
fs/notify/fsnotify.c +5 -3
index 71bd44e5ab6d..706484fb3bf3 100644
@@ -112,7 +112,10 @@ void fsnotify_sb_delete(struct super_block *sb)
 
 void fsnotify_sb_free(struct super_block *sb)
 {
-       kfree(sb->s_fsnotify_info);
+       if (sb->s_fsnotify_info) {
+               WARN_ON_ONCE(!list_empty(&sb->s_fsnotify_info->inode_conn_list));
+               kfree(sb->s_fsnotify_info);
+       }
 }
 
 /*
@@ -777,8 +780,7 @@ static __init int fsnotify_init(void)
        if (ret)
                panic("initializing fsnotify_mark_srcu");
 
-       fsnotify_mark_connector_cachep = KMEM_CACHE(fsnotify_mark_connector,
-                                                   SLAB_PANIC);
+       fsnotify_init_connector_caches();
 
        return 0;
 }
fs/notify/fsnotify.h +4 -1
index 5950c7a67f41..4e271875dcad 100644
@@ -67,6 +67,9 @@ static inline fsnotify_connp_t *fsnotify_sb_marks(struct super_block *sb)
        return sbinfo ? &sbinfo->sb_marks : NULL;
 }
 
+struct fsnotify_mark_connector *fsnotify_inode_connector_from_list(
+                                               struct list_head *head);
+
 /* destroy all events sitting in this groups notification queue */
 extern void fsnotify_flush_notify(struct fsnotify_group *group);
 
@@ -106,6 +109,6 @@ static inline void fsnotify_clear_marks_by_mntns(struct mnt_namespace *mntns)
  */
 extern void fsnotify_set_children_dentry_flags(struct inode *inode);
 
-extern struct kmem_cache *fsnotify_mark_connector_cachep;
+void fsnotify_init_connector_caches(void);
 
 #endif /* __FS_NOTIFY_FSNOTIFY_H_ */
fs/notify/mark.c +40 -8
index 55a03bb05aa1..eb26bb8c5c63 100644
@@ -79,7 +79,8 @@
 #define FSNOTIFY_REAPER_DELAY  (1)     /* 1 jiffy */
 
 struct srcu_struct fsnotify_mark_srcu;
-struct kmem_cache *fsnotify_mark_connector_cachep;
+static struct kmem_cache *fsnotify_mark_connector_cachep;
+static struct kmem_cache *fsnotify_inode_mark_connector_cachep;
 
 static DEFINE_SPINLOCK(destroy_lock);
 static LIST_HEAD(destroy_list);
@@ -323,10 +324,12 @@ static void fsnotify_connector_destroy_workfn(struct work_struct *work)
        while (conn) {
                free = conn;
                conn = conn->destroy_next;
-               kmem_cache_free(fsnotify_mark_connector_cachep, free);
+               kfree(free);
        }
 }
 
+static void fsnotify_untrack_connector(struct fsnotify_mark_connector *conn);
+
 static void *fsnotify_detach_connector_from_object(
                                        struct fsnotify_mark_connector *conn,
                                        unsigned int *type)
@@ -342,6 +345,7 @@ static void *fsnotify_detach_connector_from_object(
        if (conn->type == FSNOTIFY_OBJ_TYPE_INODE) {
                inode = fsnotify_conn_inode(conn);
                inode->i_fsnotify_mask = 0;
+               fsnotify_untrack_connector(conn);
 
                /* Unpin inode when detaching from connector */
                if (!(conn->flags & FSNOTIFY_CONN_FLAG_HAS_IREF))
@@ -644,6 +648,8 @@ static int fsnotify_attach_info_to_sb(struct super_block *sb)
        if (!sbinfo)
                return -ENOMEM;
 
+       INIT_LIST_HEAD(&sbinfo->inode_conn_list);
+       spin_lock_init(&sbinfo->list_lock);
        /*
         * cmpxchg() provides the barrier so that callers of fsnotify_sb_info()
         * will observe an initialized structure
@@ -655,20 +661,83 @@ static int fsnotify_attach_info_to_sb(struct super_block *sb)
        return 0;
 }
 
-static int fsnotify_attach_connector_to_object(fsnotify_connp_t *connp,
-                                              void *obj, unsigned int obj_type)
+struct fsnotify_inode_mark_connector {
+       struct fsnotify_mark_connector common;
+       struct list_head conns_list;
+};
+
+struct fsnotify_mark_connector *fsnotify_inode_connector_from_list(
+                                               struct list_head *head)
 {
-       struct fsnotify_mark_connector *conn;
+       return &list_entry(head, struct fsnotify_inode_mark_connector,
+                         conns_list)->common;
+}
 
-       conn = kmem_cache_alloc(fsnotify_mark_connector_cachep, GFP_KERNEL);
-       if (!conn)
-               return -ENOMEM;
+static void fsnotify_init_connector(struct fsnotify_mark_connector *conn,
+                                   void *obj, unsigned int obj_type)
+{
        spin_lock_init(&conn->lock);
        INIT_HLIST_HEAD(&conn->list);
        conn->flags = 0;
        conn->prio = 0;
        conn->type = obj_type;
        conn->obj = obj;
+}
+
+static struct fsnotify_mark_connector *
+fsnotify_alloc_inode_connector(struct inode *inode)
+{
+       struct fsnotify_inode_mark_connector *iconn;
+       struct fsnotify_sb_info *sbinfo = fsnotify_sb_info(inode->i_sb);
+
+       iconn = kmem_cache_alloc(fsnotify_inode_mark_connector_cachep,
+                                GFP_KERNEL);
+       if (!iconn)
+               return NULL;
+
+       fsnotify_init_connector(&iconn->common, inode, FSNOTIFY_OBJ_TYPE_INODE);
+       spin_lock(&sbinfo->list_lock);
+       list_add(&iconn->conns_list, &sbinfo->inode_conn_list);
+       spin_unlock(&sbinfo->list_lock);
+       iconn->common.flags |= FSNOTIFY_CONN_FLAG_TRACKED;
+

fs/notify/mark.c static int fsnotify_attach_info_to_sb(struct super_block *sb) · line 713

Quoted 10 lines
fs/notify/mark.c +10 -0
+       return &iconn->common;
+}
+
+static void fsnotify_untrack_connector(struct fsnotify_mark_connector *conn)
+{
+       struct fsnotify_inode_mark_connector *iconn;
+       struct fsnotify_sb_info *sbinfo;
+
+       if (!(conn->flags & FSNOTIFY_CONN_FLAG_TRACKED))
+               return;

Is this condition somehow possible?
If not, please add a WARN_ON_ONCE or consider dropping the flag because it is equivalent to type == FSNOTIFY_OBJ_TYPE_INODE,
is it not?
IOW, if conn->obj points to an inode, it is tracked, from alloc() to free().

Unless I missed something?
I have no problem with keeping it as a sanity-explicit flag.

Thanks,
Amir.

author maintainer
#3 lore raw

Re: [PATCH 1/3] fsnotify: Track inode connectors for a superblock

Quoted 9 lines · Amir Goldstein
Quoted 8 lines · Jan Kara

Introduce a linked list tracking all inode connectors for a superblock. We will use this list when the superblock is getting shutdown to properly clean up all the inode marks instead of relying on scanning all inodes in the superblock which can get rather slow.

...

Quoted 34 lines
Quoted 17 lines
fs/notify/mark.c +17 -0
+static struct fsnotify_mark_connector *
+fsnotify_alloc_inode_connector(struct inode *inode)
+{
+       struct fsnotify_inode_mark_connector *iconn;
+       struct fsnotify_sb_info *sbinfo = fsnotify_sb_info(inode->i_sb);
+
+       iconn = kmem_cache_alloc(fsnotify_inode_mark_connector_cachep,
+                                GFP_KERNEL);
+       if (!iconn)
+               return NULL;
+
+       fsnotify_init_connector(&iconn->common, inode, FSNOTIFY_OBJ_TYPE_INODE);
+       spin_lock(&sbinfo->list_lock);
+       list_add(&iconn->conns_list, &sbinfo->inode_conn_list);
+       spin_unlock(&sbinfo->list_lock);
+       iconn->common.flags |= FSNOTIFY_CONN_FLAG_TRACKED;
+

fs/notify/mark.c static int fsnotify_attach_info_to_sb(struct super_block *sb) · line 713

Quoted 10 lines
fs/notify/mark.c +10 -0
+       return &iconn->common;
+}
+
+static void fsnotify_untrack_connector(struct fsnotify_mark_connector *conn)
+{
+       struct fsnotify_inode_mark_connector *iconn;
+       struct fsnotify_sb_info *sbinfo;
+
+       if (!(conn->flags & FSNOTIFY_CONN_FLAG_TRACKED))
+               return;

Is this condition somehow possible?
If not, please add a WARN_ON_ONCE or consider dropping the flag because it is equivalent to type == FSNOTIFY_OBJ_TYPE_INODE,
is it not?
IOW, if conn->obj points to an inode, it is tracked, from alloc() to free().

Quoted 2 lines

Unless I missed something?
I have no problem with keeping it as a sanity-explicit flag.

No, you're right. Let's replace this with conn->type check. Originally I've ported this flag when I was creating this commit based on rhashtable code but then I've realized this simple version cannot observe unattached connectors in fsnotify_untrack_connector(). So I've ditched some pointless code but the flag stayed...

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
author maintainer
#4 lore raw

PATCH 2/3 fsnotify: Use connector hash for destroying inode marks

In reply to Jan Kara

Instead of iterating all inodes belonging to a superblock to find inode marks and remove them on umount, iterate all inode connectors for the superblock. This may be substantially faster since there are generally much less inodes with fsnotify marks than all inodes. It also removes one use of sb->s_inodes list which we strive to ultimately remove.

---
 fs/notify/fsnotify.c | 74 +++++++++++++++-----------------------------
 1 file changed, 25 insertions(+), 49 deletions(-)
fs/notify/fsnotify.c +25 -49
index 706484fb3bf3..16a4a537d8c3 100644
@@ -34,62 +34,38 @@ void __fsnotify_mntns_delete(struct mnt_namespace *mntns)
 }
 
 /**
- * fsnotify_unmount_inodes - an sb is unmounting.  handle any watched inodes.
- * @sb: superblock being unmounted.
+ * fsnotify_unmount_inodes - an sb is unmounting. Handle any watched inodes.
+ * @sbinfo: fsnotify info for superblock being unmounted.
  *
- * Called during unmount with no locks held, so needs to be safe against
- * concurrent modifiers. We temporarily drop sb->s_inode_list_lock and CAN block.
+ * Walk all inode connectors for the superblock and free all associated marks.
  */
-static void fsnotify_unmount_inodes(struct super_block *sb)
+static void fsnotify_unmount_inodes(struct fsnotify_sb_info *sbinfo)
 {
-	struct inode *inode, *iput_inode = NULL;
-
-	spin_lock(&sb->s_inode_list_lock);
-	list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
-		/*
-		 * We cannot __iget() an inode in state I_FREEING,
-		 * I_WILL_FREE, or I_NEW which is fine because by that point
-		 * the inode cannot have any associated watches.
-		 */
-		spin_lock(&inode->i_lock);
-		if (inode_state_read(inode) & (I_FREEING | I_WILL_FREE | I_NEW)) {
-			spin_unlock(&inode->i_lock);
-			continue;
-		}
-
-		/*
-		 * If i_count is zero, the inode cannot have any watches and
-		 * doing an __iget/iput with SB_ACTIVE clear would actually
-		 * evict all inodes with zero i_count from icache which is
-		 * unnecessarily violent and may in fact be illegal to do.
-		 * However, we should have been called /after/ evict_inodes
-		 * removed all zero refcount inodes, in any case.  Test to
-		 * be sure.
-		 */
-		if (!icount_read(inode)) {
-			spin_unlock(&inode->i_lock);
-			continue;
-		}
+	int idx;
+	struct fsnotify_mark_connector *conn;
+	struct inode *inode;
 
+	/*
+	 * We hold srcu over the iteration so that returned connectors stay
+	 * allocated until we can grab them in fsnotify_destroy_conn_marks()
+	 */
+	idx = srcu_read_lock(&fsnotify_mark_srcu);
+	spin_lock(&sbinfo->list_lock);
+	while (!list_empty(&sbinfo->inode_conn_list)) {
+		conn = fsnotify_inode_connector_from_list(
+						sbinfo->inode_conn_list.next);
+		/* All connectors on the list are still attached to an inode */
+		inode = conn->obj;
 		__iget(inode);
-		spin_unlock(&inode->i_lock);
-		spin_unlock(&sb->s_inode_list_lock);
-
-		iput(iput_inode);
-
-		/* for each watch, send FS_UNMOUNT and then remove it */
+		spin_unlock(&sbinfo->list_lock);
 		fsnotify_inode(inode, FS_UNMOUNT);
-
-		fsnotify_inode_delete(inode);
-
-		iput_inode = inode;
-
+		fsnotify_destroy_marks(&inode->i_fsnotify_marks);
+		iput(inode);
 		cond_resched();
-		spin_lock(&sb->s_inode_list_lock);
+		spin_lock(&sbinfo->list_lock);
 	}
-	spin_unlock(&sb->s_inode_list_lock);
-
-	iput(iput_inode);
+	spin_unlock(&sbinfo->list_lock);
+	srcu_read_unlock(&fsnotify_mark_srcu, idx);
 }
 
 void fsnotify_sb_delete(struct super_block *sb)
@@ -100,7 +76,7 @@ void fsnotify_sb_delete(struct super_block *sb)
 	if (!sbinfo)
 		return;
 
-	fsnotify_unmount_inodes(sb);
+	fsnotify_unmount_inodes(sbinfo);
 	fsnotify_clear_marks_by_sb(sb);
 	/* Wait for outstanding object references from connectors */
 	wait_var_event(fsnotify_sb_watched_objects(sb),
Signature · 1 line
2.51.0
reviewer Reviewed-by on v1 2/3
#5 lore raw

Re: [PATCH 2/3] fsnotify: Use connector hash for destroying inode marks

Quoted 57 lines · Jan Kara

Instead of iterating all inodes belonging to a superblock to find inode marks and remove them on umount, iterate all inode connectors for the superblock. This may be substantially faster since there are generally much less inodes with fsnotify marks than all inodes. It also removes one use of sb->s_inodes list which we strive to ultimately remove.

---
 fs/notify/fsnotify.c | 74 +++++++++++++++-----------------------------
 1 file changed, 25 insertions(+), 49 deletions(-)
fs/notify/fsnotify.c +4 -30
index 706484fb3bf3..16a4a537d8c3 100644
@@ -34,62 +34,38 @@ void __fsnotify_mntns_delete(struct mnt_namespace *mntns)
 }
 
 /**
- * fsnotify_unmount_inodes - an sb is unmounting.  handle any watched inodes.
- * @sb: superblock being unmounted.
+ * fsnotify_unmount_inodes - an sb is unmounting. Handle any watched inodes.
+ * @sbinfo: fsnotify info for superblock being unmounted.
  *
- * Called during unmount with no locks held, so needs to be safe against
- * concurrent modifiers. We temporarily drop sb->s_inode_list_lock and CAN block.
+ * Walk all inode connectors for the superblock and free all associated marks.
  */
-static void fsnotify_unmount_inodes(struct super_block *sb)
+static void fsnotify_unmount_inodes(struct fsnotify_sb_info *sbinfo)
 {
-       struct inode *inode, *iput_inode = NULL;
-
-       spin_lock(&sb->s_inode_list_lock);
-       list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
-               /*
-                * We cannot __iget() an inode in state I_FREEING,
-                * I_WILL_FREE, or I_NEW which is fine because by that point
-                * the inode cannot have any associated watches.
-                */
-               spin_lock(&inode->i_lock);
-               if (inode_state_read(inode) & (I_FREEING | I_WILL_FREE | I_NEW)) {
-                       spin_unlock(&inode->i_lock);
-                       continue;
-               }
-
-               /*
-                * If i_count is zero, the inode cannot have any watches and
-                * doing an __iget/iput with SB_ACTIVE clear would actually
-                * evict all inodes with zero i_count from icache which is
-                * unnecessarily violent and may in fact be illegal to do.
-                * However, we should have been called /after/ evict_inodes
-                * removed all zero refcount inodes, in any case.  Test to
-                * be sure.
-                */
-               if (!icount_read(inode)) {

fs/notify/fsnotify.c void __fsnotify_mntns_delete(struct mnt_namespace *mntns) · line 50

Quoted 10 lines
fs/notify/fsnotify.c +6 -3
-                       spin_unlock(&inode->i_lock);
-                       continue;
-               }
+       int idx;
+       struct fsnotify_mark_connector *conn;
+       struct inode *inode;
 
+       /*
+        * We hold srcu over the iteration so that returned connectors stay
+        * allocated until we can grab them in fsnotify_destroy_conn_marks()

fsnotify_destroy_marks()

Quoted 17 lines
fs/notify/fsnotify.c +9 -6
+        */
+       idx = srcu_read_lock(&fsnotify_mark_srcu);
+       spin_lock(&sbinfo->list_lock);
+       while (!list_empty(&sbinfo->inode_conn_list)) {
+               conn = fsnotify_inode_connector_from_list(
+                                               sbinfo->inode_conn_list.next);
+               /* All connectors on the list are still attached to an inode */
+               inode = conn->obj;
                __iget(inode);
-               spin_unlock(&inode->i_lock);
-               spin_unlock(&sb->s_inode_list_lock);
-
-               iput(iput_inode);
-
-               /* for each watch, send FS_UNMOUNT and then remove it */
+               spin_unlock(&sbinfo->list_lock);
                fsnotify_inode(inode, FS_UNMOUNT);

fs/notify/fsnotify.c void __fsnotify_mntns_delete(struct mnt_namespace *mntns) · line 65

Quoted 10 lines
fs/notify/fsnotify.c +3 -6
-
-               fsnotify_inode_delete(inode);
-
-               iput_inode = inode;
-
+               fsnotify_destroy_marks(&inode->i_fsnotify_marks);
+               iput(inode);
                cond_resched();
-               spin_lock(&sb->s_inode_list_lock);
+               spin_lock(&sbinfo->list_lock);

The list could be long.
Do we maybe want to avoid holding srcu read for the entire list walk?

Anyway, with or without, feel free to add:

Thanks,
Amir.

author maintainer
#6 lore raw

Re: [PATCH 2/3] fsnotify: Use connector hash for destroying inode marks

Quoted 102 lines · Amir Goldstein
Quoted 57 lines · Jan Kara

Instead of iterating all inodes belonging to a superblock to find inode marks and remove them on umount, iterate all inode connectors for the superblock. This may be substantially faster since there are generally much less inodes with fsnotify marks than all inodes. It also removes one use of sb->s_inodes list which we strive to ultimately remove.

---
 fs/notify/fsnotify.c | 74 +++++++++++++++-----------------------------
 1 file changed, 25 insertions(+), 49 deletions(-)
fs/notify/fsnotify.c +4 -30
index 706484fb3bf3..16a4a537d8c3 100644
@@ -34,62 +34,38 @@ void __fsnotify_mntns_delete(struct mnt_namespace *mntns)
 }
 
 /**
- * fsnotify_unmount_inodes - an sb is unmounting.  handle any watched inodes.
- * @sb: superblock being unmounted.
+ * fsnotify_unmount_inodes - an sb is unmounting. Handle any watched inodes.
+ * @sbinfo: fsnotify info for superblock being unmounted.
  *
- * Called during unmount with no locks held, so needs to be safe against
- * concurrent modifiers. We temporarily drop sb->s_inode_list_lock and CAN block.
+ * Walk all inode connectors for the superblock and free all associated marks.
  */
-static void fsnotify_unmount_inodes(struct super_block *sb)
+static void fsnotify_unmount_inodes(struct fsnotify_sb_info *sbinfo)
 {
-       struct inode *inode, *iput_inode = NULL;
-
-       spin_lock(&sb->s_inode_list_lock);
-       list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
-               /*
-                * We cannot __iget() an inode in state I_FREEING,
-                * I_WILL_FREE, or I_NEW which is fine because by that point
-                * the inode cannot have any associated watches.
-                */
-               spin_lock(&inode->i_lock);
-               if (inode_state_read(inode) & (I_FREEING | I_WILL_FREE | I_NEW)) {
-                       spin_unlock(&inode->i_lock);
-                       continue;
-               }
-
-               /*
-                * If i_count is zero, the inode cannot have any watches and
-                * doing an __iget/iput with SB_ACTIVE clear would actually
-                * evict all inodes with zero i_count from icache which is
-                * unnecessarily violent and may in fact be illegal to do.
-                * However, we should have been called /after/ evict_inodes
-                * removed all zero refcount inodes, in any case.  Test to
-                * be sure.
-                */
-               if (!icount_read(inode)) {

fs/notify/fsnotify.c void __fsnotify_mntns_delete(struct mnt_namespace *mntns) · line 50

Quoted 10 lines
fs/notify/fsnotify.c +6 -3
-                       spin_unlock(&inode->i_lock);
-                       continue;
-               }
+       int idx;
+       struct fsnotify_mark_connector *conn;
+       struct inode *inode;
 
+       /*
+        * We hold srcu over the iteration so that returned connectors stay
+        * allocated until we can grab them in fsnotify_destroy_conn_marks()

fsnotify_destroy_marks()

Quoted 17 lines
fs/notify/fsnotify.c +9 -6
+        */
+       idx = srcu_read_lock(&fsnotify_mark_srcu);
+       spin_lock(&sbinfo->list_lock);
+       while (!list_empty(&sbinfo->inode_conn_list)) {
+               conn = fsnotify_inode_connector_from_list(
+                                               sbinfo->inode_conn_list.next);
+               /* All connectors on the list are still attached to an inode */
+               inode = conn->obj;
                __iget(inode);
-               spin_unlock(&inode->i_lock);
-               spin_unlock(&sb->s_inode_list_lock);
-
-               iput(iput_inode);
-
-               /* for each watch, send FS_UNMOUNT and then remove it */
+               spin_unlock(&sbinfo->list_lock);
                fsnotify_inode(inode, FS_UNMOUNT);

fs/notify/fsnotify.c void __fsnotify_mntns_delete(struct mnt_namespace *mntns) · line 65

Quoted 10 lines
fs/notify/fsnotify.c +3 -6
-
-               fsnotify_inode_delete(inode);
-
-               iput_inode = inode;
-
+               fsnotify_destroy_marks(&inode->i_fsnotify_marks);
+               iput(inode);
                cond_resched();
-               spin_lock(&sb->s_inode_list_lock);
+               spin_lock(&sbinfo->list_lock);

The list could be long.
Do we maybe want to avoid holding srcu read for the entire list walk?

Quoted 2 lines

Anyway, with or without, feel free to add:

Thanks for review! Actually now that I think about it sbinfo->list_lock is enough to protect lifetime of the connector so we don't need srcu at all here. I'll remove it for the next revision.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#7 lore raw

Re: [PATCH 2/3] fsnotify: Use connector hash for destroying inode marks

Quoted 104 lines · Jan Kara
Quoted 102 lines · Amir Goldstein
Quoted 57 lines · Jan Kara

Instead of iterating all inodes belonging to a superblock to find inode marks and remove them on umount, iterate all inode connectors for the superblock. This may be substantially faster since there are generally much less inodes with fsnotify marks than all inodes. It also removes one use of sb->s_inodes list which we strive to ultimately remove.

---
 fs/notify/fsnotify.c | 74 +++++++++++++++-----------------------------
 1 file changed, 25 insertions(+), 49 deletions(-)
fs/notify/fsnotify.c +4 -30
index 706484fb3bf3..16a4a537d8c3 100644
@@ -34,62 +34,38 @@ void __fsnotify_mntns_delete(struct mnt_namespace *mntns)
 }
 
 /**
- * fsnotify_unmount_inodes - an sb is unmounting.  handle any watched inodes.
- * @sb: superblock being unmounted.
+ * fsnotify_unmount_inodes - an sb is unmounting. Handle any watched inodes.
+ * @sbinfo: fsnotify info for superblock being unmounted.
  *
- * Called during unmount with no locks held, so needs to be safe against
- * concurrent modifiers. We temporarily drop sb->s_inode_list_lock and CAN block.
+ * Walk all inode connectors for the superblock and free all associated marks.
  */
-static void fsnotify_unmount_inodes(struct super_block *sb)
+static void fsnotify_unmount_inodes(struct fsnotify_sb_info *sbinfo)
 {
-       struct inode *inode, *iput_inode = NULL;
-
-       spin_lock(&sb->s_inode_list_lock);
-       list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
-               /*
-                * We cannot __iget() an inode in state I_FREEING,
-                * I_WILL_FREE, or I_NEW which is fine because by that point
-                * the inode cannot have any associated watches.
-                */
-               spin_lock(&inode->i_lock);
-               if (inode_state_read(inode) & (I_FREEING | I_WILL_FREE | I_NEW)) {
-                       spin_unlock(&inode->i_lock);
-                       continue;
-               }
-
-               /*
-                * If i_count is zero, the inode cannot have any watches and
-                * doing an __iget/iput with SB_ACTIVE clear would actually
-                * evict all inodes with zero i_count from icache which is
-                * unnecessarily violent and may in fact be illegal to do.
-                * However, we should have been called /after/ evict_inodes
-                * removed all zero refcount inodes, in any case.  Test to
-                * be sure.
-                */
-               if (!icount_read(inode)) {

fs/notify/fsnotify.c void __fsnotify_mntns_delete(struct mnt_namespace *mntns) · line 50

Quoted 10 lines
fs/notify/fsnotify.c +6 -3
-                       spin_unlock(&inode->i_lock);
-                       continue;
-               }
+       int idx;
+       struct fsnotify_mark_connector *conn;
+       struct inode *inode;
 
+       /*
+        * We hold srcu over the iteration so that returned connectors stay
+        * allocated until we can grab them in fsnotify_destroy_conn_marks()

fsnotify_destroy_marks()

Quoted 17 lines
fs/notify/fsnotify.c +9 -6
+        */
+       idx = srcu_read_lock(&fsnotify_mark_srcu);
+       spin_lock(&sbinfo->list_lock);
+       while (!list_empty(&sbinfo->inode_conn_list)) {
+               conn = fsnotify_inode_connector_from_list(
+                                               sbinfo->inode_conn_list.next);
+               /* All connectors on the list are still attached to an inode */
+               inode = conn->obj;
                __iget(inode);
-               spin_unlock(&inode->i_lock);
-               spin_unlock(&sb->s_inode_list_lock);
-
-               iput(iput_inode);
-
-               /* for each watch, send FS_UNMOUNT and then remove it */
+               spin_unlock(&sbinfo->list_lock);
                fsnotify_inode(inode, FS_UNMOUNT);

fs/notify/fsnotify.c void __fsnotify_mntns_delete(struct mnt_namespace *mntns) · line 65

Quoted 10 lines
fs/notify/fsnotify.c +3 -6
-
-               fsnotify_inode_delete(inode);
-
-               iput_inode = inode;
-
+               fsnotify_destroy_marks(&inode->i_fsnotify_marks);
+               iput(inode);
                cond_resched();
-               spin_lock(&sb->s_inode_list_lock);
+               spin_lock(&sbinfo->list_lock);

The list could be long.
Do we maybe want to avoid holding srcu read for the entire list walk?

Quoted 6 lines
Quoted 2 lines

Anyway, with or without, feel free to add:

Thanks for review! Actually now that I think about it sbinfo->list_lock is enough to protect lifetime of the connector so we don't need srcu at all here. I'll remove it for the next revision.

OK, in that case, without the need for the comment about fsnotify_destroy_marks(), I was going to suggest using the nicer wrapper

fsnotify_clear_marks_by_inode(inode);

Thanks,
Amir.

author maintainer
#8 lore raw

Re: [PATCH 2/3] fsnotify: Use connector hash for destroying inode marks

Quoted 35 lines · Amir Goldstein
Quoted 34 lines · Jan Kara
Quoted 33 lines
Quoted 17 lines
fs/notify/fsnotify.c +9 -6
+        */
+       idx = srcu_read_lock(&fsnotify_mark_srcu);
+       spin_lock(&sbinfo->list_lock);
+       while (!list_empty(&sbinfo->inode_conn_list)) {
+               conn = fsnotify_inode_connector_from_list(
+                                               sbinfo->inode_conn_list.next);
+               /* All connectors on the list are still attached to an inode */
+               inode = conn->obj;
                __iget(inode);
-               spin_unlock(&inode->i_lock);
-               spin_unlock(&sb->s_inode_list_lock);
-
-               iput(iput_inode);
-
-               /* for each watch, send FS_UNMOUNT and then remove it */
+               spin_unlock(&sbinfo->list_lock);
                fsnotify_inode(inode, FS_UNMOUNT);

fs/notify/fsnotify.c void __fsnotify_mntns_delete(struct mnt_namespace *mntns) · line 65

Quoted 10 lines
fs/notify/fsnotify.c +3 -6
-
-               fsnotify_inode_delete(inode);
-
-               iput_inode = inode;
-
+               fsnotify_destroy_marks(&inode->i_fsnotify_marks);
+               iput(inode);
                cond_resched();
-               spin_lock(&sb->s_inode_list_lock);
+               spin_lock(&sbinfo->list_lock);

The list could be long.
Do we maybe want to avoid holding srcu read for the entire list walk?

Anyway, with or without, feel free to add:

Quoted 8 lines
Quoted 3 lines

Thanks for review! Actually now that I think about it sbinfo->list_lock is enough to protect lifetime of the connector so we don't need srcu at all here. I'll remove it for the next revision.

OK, in that case, without the need for the comment about fsnotify_destroy_marks(), I was going to suggest using the nicer wrapper

fsnotify_clear_marks_by_inode(inode);

Right, done.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
author maintainer
#9 lore raw

PATCH 3/3 fsnotify: Shutdown fsnotify before destroying sb's dcache

In reply to Jan Kara

Currently fsnotify_sb_delete() was called after we have evicted superblock's dcache and inode cache. This was done mainly so that we iterate as few inodes as possible when removing inode marks. However, as Jakub reported, this is problematic because for some filesystems encoding of file handles uses sb->s_root which gets cleared as part of dcache eviction. And either delayed fsnotify events or reading fdinfo for fsnotify group with marks on fs being unmounted may trigger encoding of file handles during unmount. So move shutdown of fsnotify subsystem before shrinking of dcache.

---
 fs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/super.c +2 -2
index 3d85265d1400..9c13e68277dd 100644
@@ -618,6 +618,7 @@ void generic_shutdown_super(struct super_block *sb)
 	const struct super_operations *sop = sb->s_op;
 
 	if (sb->s_root) {
+		fsnotify_sb_delete(sb);
 		shrink_dcache_for_umount(sb);
 		sync_filesystem(sb);
 		sb->s_flags &= ~SB_ACTIVE;
@@ -629,9 +630,8 @@ void generic_shutdown_super(struct super_block *sb)
 
 		/*
 		 * Clean up and evict any inodes that still have references due
-		 * to fsnotify or the security policy.
+		 * to the security policy.
 		 */
-		fsnotify_sb_delete(sb);
 		security_sb_delete(sb);
 
 		if (sb->s_dio_done_wq) {
Signature · 1 line
2.51.0
reviewer Reviewed-by on v1 3/3
#10 lore raw

Re: [PATCH 3/3] fsnotify: Shutdown fsnotify before destroying sb's dcache

Quoted 11 lines · Jan Kara

Currently fsnotify_sb_delete() was called after we have evicted superblock's dcache and inode cache. This was done mainly so that we iterate as few inodes as possible when removing inode marks. However, as Jakub reported, this is problematic because for some filesystems encoding of file handles uses sb->s_root which gets cleared as part of dcache eviction. And either delayed fsnotify events or reading fdinfo for fsnotify group with marks on fs being unmounted may trigger encoding of file handles during unmount. So move shutdown of fsnotify subsystem before shrinking of dcache.

Quoted 2 lines

You may want to add:

Feel free to add:

Thanks,
Amir.

Quoted 30 lines
---
 fs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/super.c +2 -3
index 3d85265d1400..9c13e68277dd 100644
@@ -618,6 +618,7 @@ void generic_shutdown_super(struct super_block *sb)
        const struct super_operations *sop = sb->s_op;
 
        if (sb->s_root) {
+               fsnotify_sb_delete(sb);
                shrink_dcache_for_umount(sb);
                sync_filesystem(sb);
                sb->s_flags &= ~SB_ACTIVE;
@@ -629,9 +630,8 @@ void generic_shutdown_super(struct super_block *sb)
 
                /*
                 * Clean up and evict any inodes that still have references due
-                * to fsnotify or the security policy.
+                * to the security policy.
                 */
-               fsnotify_sb_delete(sb);
                security_sb_delete(sb);
 
                if (sb->s_dio_done_wq) {
--

2.51.0