Skip to contentSkip to conversation

kvm: Add needs_driver support to check for kvm driver

PATCH In review Kushal Chand K 3 participants 5 messages Jan 22 – Jan 29

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: Add needs_driver support to check for kvm driver

This patch adds needs_driver field in kvm testcases to check for kvm driver

---
 testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++
 testcases/kernel/kvm/kvm_svm01.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm02.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm03.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm04.c       | 4 ++++
 testcases/kernel/kvm/kvm_vmx01.c       | 4 ++++
 testcases/kernel/kvm/kvm_vmx02.c       | 4 ++++
 7 files changed, 28 insertions(+)
testcases/kernel/kvm/kvm_pagefault01.c +4 -0
index db526cb7e..2b477f7af 100644
@@ -165,6 +165,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		NULL
testcases/kernel/kvm/kvm_svm01.c +4 -0
index 32d15526b..f81602567 100644
@@ -108,6 +108,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_svm02.c +4 -0
index 6914fdcba..701f2731d 100644
@@ -129,6 +129,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_svm03.c +4 -0
index 87164d013..faafaf7cf 100644
@@ -154,6 +154,10 @@ static struct tst_test test = {
 	.test_all = run,
 	.setup = setup,
 	.cleanup = cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.min_cpus = 2,
 	.supported_archs = (const char *const []) {
 		"x86_64",
testcases/kernel/kvm/kvm_svm04.c +4 -0
index 75fcbfdcf..af3c8b1c6 100644
@@ -295,6 +295,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_vmx01.c +4 -0
index 5bffbe946..d0c4913c9 100644
@@ -269,6 +269,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_vmx02.c +4 -0
index 3fcfebb3b..4ce225e56 100644
@@ -183,6 +183,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",

--
2.43.0

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi all,

Quoted 1 line

This patch adds needs_driver field in kvm testcases to check for kvm driver

@Kushal Thanks for your patch. very nit: s/needs_driver/needs_drivers/ (can be changed before merge).

Implements: https://github.com/linux-test-project/ltp/issues/1219

@Martin Is it enough to have kvm driver? Or do tests depend on any of specific kvm kernel config options (not only from virt/kvm/Kconfig, but arch dependent configs e.g. CONFIG_KVM_GUEST=y from arch/x86/Kconfig ?)

Kind regards,
Petr

Quoted 116 lines
---
 testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++
 testcases/kernel/kvm/kvm_svm01.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm02.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm03.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm04.c       | 4 ++++
 testcases/kernel/kvm/kvm_vmx01.c       | 4 ++++
 testcases/kernel/kvm/kvm_vmx02.c       | 4 ++++
 7 files changed, 28 insertions(+)
testcases/kernel/kvm/kvm_pagefault01.c +4 -0
index db526cb7e..2b477f7af 100644
@@ -165,6 +165,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		NULL
testcases/kernel/kvm/kvm_svm01.c +4 -0
index 32d15526b..f81602567 100644
@@ -108,6 +108,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_svm02.c +4 -0
index 6914fdcba..701f2731d 100644
@@ -129,6 +129,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_svm03.c +4 -0
index 87164d013..faafaf7cf 100644
@@ -154,6 +154,10 @@ static struct tst_test test = {
 	.test_all = run,
 	.setup = setup,
 	.cleanup = cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.min_cpus = 2,
 	.supported_archs = (const char *const []) {
 		"x86_64",
testcases/kernel/kvm/kvm_svm04.c +4 -0
index 75fcbfdcf..af3c8b1c6 100644
@@ -295,6 +295,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_vmx01.c +4 -0
index 5bffbe946..d0c4913c9 100644
@@ -269,6 +269,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
testcases/kernel/kvm/kvm_vmx02.c +4 -0
index 3fcfebb3b..4ce225e56 100644
@@ -183,6 +183,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 5 lines · Petr Vorel

Hi all,

@Martin Is it enough to have kvm driver? Or do tests depend on any of specific kvm kernel config options (not only from virt/kvm/Kconfig, but arch dependent configs e.g. CONFIG_KVM_GUEST=y from arch/x86/Kconfig ?)

Some KVM tests can be run by unprivileged user so those also need a check whether they have permission to open /dev/kvm for writing. But that can be fixed in a separate patch. Let's merge this one with the commit message fix.

Signature · 10 lines
Martin Doucha   [email protected]
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw
Quoted 10 lines · Petr Vorel
Quoted 5 lines

Hi all,

@Martin Is it enough to have kvm driver? Or do tests depend on any of specific kvm kernel config options (not only from virt/kvm/Kconfig, but arch dependent configs e.g. CONFIG_KVM_GUEST=y from arch/x86/Kconfig ?)

Some KVM tests can be run by unprivileged user so those also need a check whether they have permission to open /dev/kvm for writing. But that can be fixed in a separate patch. Let's merge this one with the commit message fix.

+1, thank you!

Merged and I noted this TODO
https://github.com/linux-test-project/ltp/issues/1219#issuecomment-3817000775

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#4 lore raw
In reply to Kushal Chand K

Hi!
Thanks for the patch.

Quoted 122 lines · Kushal Chand K

This patch adds needs_driver field in kvm testcases to check for kvm driver

---
  testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++
  testcases/kernel/kvm/kvm_svm01.c       | 4 ++++
  testcases/kernel/kvm/kvm_svm02.c       | 4 ++++
  testcases/kernel/kvm/kvm_svm03.c       | 4 ++++
  testcases/kernel/kvm/kvm_svm04.c       | 4 ++++
  testcases/kernel/kvm/kvm_vmx01.c       | 4 ++++
  testcases/kernel/kvm/kvm_vmx02.c       | 4 ++++
  7 files changed, 28 insertions(+)
testcases/kernel/kvm/kvm_pagefault01.c +4 -0
index db526cb7e..2b477f7af 100644
@@ -165,6 +165,10 @@ static struct tst_test test = {
  	.setup = setup,
  	.cleanup = tst_kvm_cleanup,
  	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
  	.supported_archs = (const char *const []) {
  		"x86_64",
  		NULL
testcases/kernel/kvm/kvm_svm01.c +4 -0
index 32d15526b..f81602567 100644
@@ -108,6 +108,10 @@ static struct tst_test test = {
  	.test_all = tst_kvm_run,
  	.setup = tst_kvm_setup,
  	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
  	.supported_archs = (const char *const []) {
  		"x86_64",
  		"x86",
testcases/kernel/kvm/kvm_svm02.c +4 -0
index 6914fdcba..701f2731d 100644
@@ -129,6 +129,10 @@ static struct tst_test test = {
  	.test_all = tst_kvm_run,
  	.setup = tst_kvm_setup,
  	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
  	.supported_archs = (const char *const []) {
  		"x86_64",
  		"x86",
testcases/kernel/kvm/kvm_svm03.c +4 -0
index 87164d013..faafaf7cf 100644
@@ -154,6 +154,10 @@ static struct tst_test test = {
  	.test_all = run,
  	.setup = setup,
  	.cleanup = cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
  	.min_cpus = 2,
  	.supported_archs = (const char *const []) {
  		"x86_64",
testcases/kernel/kvm/kvm_svm04.c +4 -0
index 75fcbfdcf..af3c8b1c6 100644
@@ -295,6 +295,10 @@ static struct tst_test test = {
  	.test_all = tst_kvm_run,
  	.setup = tst_kvm_setup,
  	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
  	.supported_archs = (const char *const []) {
  		"x86_64",
  		"x86",
testcases/kernel/kvm/kvm_vmx01.c +4 -0
index 5bffbe946..d0c4913c9 100644
@@ -269,6 +269,10 @@ static struct tst_test test = {
  	.setup = setup,
  	.cleanup = tst_kvm_cleanup,
  	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
  	.supported_archs = (const char *const []) {
  		"x86_64",
  		"x86",
testcases/kernel/kvm/kvm_vmx02.c +4 -1
index 3fcfebb3b..4ce225e56 100644
@@ -183,6 +183,10 @@ static struct tst_test test = {
  	.setup = setup,
  	.cleanup = tst_kvm_cleanup,
  	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
  	.supported_archs = (const char *const []) {
  		"x86_64",
  		"x86",
--

2.43.0

Signature · 10 lines
Martin Doucha   [email protected]
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp