kvm: Add needs_driver support to check for kvm driver
PATCH 1/1 kvm: Add needs_driver support to check for kvm driver
This patch adds needs_driver field in kvm testcases to check for kvm driver
--- testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++ testcases/kernel/kvm/kvm_svm01.c | 4 ++++ testcases/kernel/kvm/kvm_svm02.c | 4 ++++ testcases/kernel/kvm/kvm_svm03.c | 4 ++++ testcases/kernel/kvm/kvm_svm04.c | 4 ++++ testcases/kernel/kvm/kvm_vmx01.c | 4 ++++ testcases/kernel/kvm/kvm_vmx02.c | 4 ++++ 7 files changed, 28 insertions(+)
testcases/kernel/kvm/kvm_pagefault01.c +4 -0
@@ -165,6 +165,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,NULL
testcases/kernel/kvm/kvm_svm01.c +4 -0
@@ -108,6 +108,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,
testcases/kernel/kvm/kvm_svm02.c +4 -0
@@ -129,6 +129,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,
testcases/kernel/kvm/kvm_svm03.c +4 -0
@@ -154,6 +154,10 @@ static struct tst_test test = { .test_all = run, .setup = setup, .cleanup = cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .min_cpus = 2, .supported_archs = (const char *const []) {"x86_64" ,
testcases/kernel/kvm/kvm_svm04.c +4 -0
@@ -295,6 +295,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,
testcases/kernel/kvm/kvm_vmx01.c +4 -0
@@ -269,6 +269,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,
testcases/kernel/kvm/kvm_vmx02.c +4 -0
@@ -183,6 +183,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,
--
2.43.0
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
Quoted 1 line
This patch adds
needs_driverfield in kvm testcases to check for kvm driver
@Kushal Thanks for your patch. very nit: s/needs_driver/needs_drivers/ (can be changed before merge).
Implements: https://github.com/linux-test-project/ltp/issues/1219
@Martin Is it enough to have kvm driver? Or do tests depend on any of specific kvm kernel config options (not only from virt/kvm/Kconfig, but arch dependent configs e.g. CONFIG_KVM_GUEST=y from arch/x86/Kconfig ?)
Kind regards,
Petr
Quoted 116 lines
Signed-off-by Kushal Chand K <[email protected]>--- testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++ testcases/kernel/kvm/kvm_svm01.c | 4 ++++ testcases/kernel/kvm/kvm_svm02.c | 4 ++++ testcases/kernel/kvm/kvm_svm03.c | 4 ++++ testcases/kernel/kvm/kvm_svm04.c | 4 ++++ testcases/kernel/kvm/kvm_vmx01.c | 4 ++++ testcases/kernel/kvm/kvm_vmx02.c | 4 ++++ 7 files changed, 28 insertions(+)testcases/kernel/kvm/kvm_pagefault01.c +4
-0@@ -165,6 +165,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,NULL testcases/kernel/kvm/kvm_svm01.c +4
-0@@ -108,6 +108,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_svm02.c +4
-0@@ -129,6 +129,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_svm03.c +4
-0@@ -154,6 +154,10 @@ static struct tst_test test = { .test_all = run, .setup = setup, .cleanup = cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .min_cpus = 2, .supported_archs = (const char *const []) {"x86_64" ,testcases/kernel/kvm/kvm_svm04.c +4
-0@@ -295,6 +295,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_vmx01.c +4
-0@@ -269,6 +269,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_vmx02.c +4
-0@@ -183,6 +183,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 5 lines · Petr Vorel
Hi all,
@Martin Is it enough to have kvm driver? Or do tests depend on any of specific kvm kernel config options (not only from
virt/kvm/Kconfig, but arch dependent configs e.g.CONFIG_KVM_GUEST=yfromarch/x86/Kconfig?)
Some KVM tests can be run by unprivileged user so those also need a check whether they have permission to open /dev/kvm for writing. But that can be fixed in a separate patch. Let's merge this one with the commit message fix.
Signature · 10 lines
Martin Doucha [email protected] SW Quality Engineer SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 10 lines · Petr Vorel
Quoted 5 lines
Hi all,
@Martin Is it enough to have kvm driver? Or do tests depend on any of specific kvm kernel config options (not only from
virt/kvm/Kconfig, but arch dependent configs e.g.CONFIG_KVM_GUEST=yfromarch/x86/Kconfig?)Some KVM tests can be run by unprivileged user so those also need a check whether they have permission to open
/dev/kvmfor writing. But that can be fixed in a separate patch. Let's merge this one with the commit message fix.
+1, thank you!
Merged and I noted this TODO
https://github.com/linux-test-project/ltp/issues/1219#issuecomment-3817000775
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Thanks for the patch.
Quoted 122 lines · Kushal Chand K
This patch adds
needs_driverfield in kvm testcases to check for kvm driverSigned-off-by Kushal Chand K <[email protected]>--- testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++ testcases/kernel/kvm/kvm_svm01.c | 4 ++++ testcases/kernel/kvm/kvm_svm02.c | 4 ++++ testcases/kernel/kvm/kvm_svm03.c | 4 ++++ testcases/kernel/kvm/kvm_svm04.c | 4 ++++ testcases/kernel/kvm/kvm_vmx01.c | 4 ++++ testcases/kernel/kvm/kvm_vmx02.c | 4 ++++ 7 files changed, 28 insertions(+)testcases/kernel/kvm/kvm_pagefault01.c +4
-0@@ -165,6 +165,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,NULL testcases/kernel/kvm/kvm_svm01.c +4
-0@@ -108,6 +108,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_svm02.c +4
-0@@ -129,6 +129,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_svm03.c +4
-0@@ -154,6 +154,10 @@ static struct tst_test test = { .test_all = run, .setup = setup, .cleanup = cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .min_cpus = 2, .supported_archs = (const char *const []) {"x86_64" ,testcases/kernel/kvm/kvm_svm04.c +4
-0@@ -295,6 +295,10 @@ static struct tst_test test = { .test_all = tst_kvm_run, .setup = tst_kvm_setup, .cleanup = tst_kvm_cleanup, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_vmx01.c +4
-0@@ -269,6 +269,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" ,testcases/kernel/kvm/kvm_vmx02.c +4
-1@@ -183,6 +183,10 @@ static struct tst_test test = { .setup = setup, .cleanup = tst_kvm_cleanup, .needs_root = 1, + .needs_drivers = (const char *const []) { +"kvm" , +NULL + }, .supported_archs = (const char *const []) {"x86_64" ,"x86" , --2.43.0
Signature · 10 lines
Martin Doucha [email protected] SW Quality Engineer SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp