Skip to contentSkip to conversation

idpf: change IRQ naming to match netdev and ethtool queue numbering

PATCH Superseded Brian Vazquez 5 participants 9 messages Jan 26

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 idpf: change IRQ naming to match netdev and ethtool queue numbering

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

     tx_q-0_pkts: 1002
     tx_q-1_pkts: 2679
     tx_q-2_pkts: 1113
     tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
     rx_q-0_pkts: 1143
     rx_q-1_pkts: 3172
     rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

     tx_q-0_pkts: 118
     tx_q-1_pkts: 134
     tx_q-2_pkts: 228
     tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
     rx_q-0_pkts: 111
     rx_q-1_pkts: 366
     rx_q-2_pkts: 120
Fixes d4d558718266 ("idpf: initialize interrupts and enable vport")

---
V2: Add mising Fixes tag

 drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/idpf/idpf_txrx.c +1 -1
index c2a1fe3c79ec..c1f8dfc570ce 100644
@@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport,
 			continue;
 
 		name = kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name, if_name,
-				 vec_name, vidx);
+				 vec_name, vector);
 
 		err = request_irq(irq_num, idpf_vport_intr_clean_queues, 0,
 				  name, q_vector);
Signature · 1 line
2.52.0.457.g6b5491de43-goog
#1 lore raw
Quoted 40 lines · Brian Vazquez

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

     tx_q-0_pkts: 1002
     tx_q-1_pkts: 2679
     tx_q-2_pkts: 1113
     tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
     rx_q-0_pkts: 1143
     rx_q-1_pkts: 3172
     rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

Quoted 7 lines
     tx_q-0_pkts: 118
     tx_q-1_pkts: 134
     tx_q-2_pkts: 228
     tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
     rx_q-0_pkts: 111
     rx_q-1_pkts: 366
     rx_q-2_pkts: 120

Are there any ABI issues here?

Andrew

#2 lore raw
Quoted 50 lines · Andrew Lunn
Quoted 40 lines · Brian Vazquez

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

     tx_q-0_pkts: 1002
     tx_q-1_pkts: 2679
     tx_q-2_pkts: 1113
     tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
     rx_q-0_pkts: 1143
     rx_q-1_pkts: 3172
     rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

Quoted 7 lines
     tx_q-0_pkts: 118
     tx_q-1_pkts: 134
     tx_q-2_pkts: 228
     tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
     rx_q-0_pkts: 111
     rx_q-1_pkts: 366
     rx_q-2_pkts: 120
Quoted 1 line

Are there any ABI issues here?

The patch doesn't change the format, it just fixes the numbering in the name to make it consistent with other reporting tools. It shouldn't break any library.

Quoted 1 line

Andrew

#3 lore raw
Quoted 51 lines · Brian Vazquez
Quoted 50 lines · Andrew Lunn
Quoted 47 lines · Brian Vazquez

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

     tx_q-0_pkts: 1002
     tx_q-1_pkts: 2679
     tx_q-2_pkts: 1113
     tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
     rx_q-0_pkts: 1143
     rx_q-1_pkts: 3172
     rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

     tx_q-0_pkts: 118
     tx_q-1_pkts: 134
     tx_q-2_pkts: 228
     tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
     rx_q-0_pkts: 111
     rx_q-1_pkts: 366
     rx_q-2_pkts: 120
Quoted 5 lines
Quoted 1 line

Are there any ABI issues here?

The patch doesn't change the format, it just fixes the numbering in the name to make it consistent with other reporting tools. It shouldn't break any library.

But is the numbering part of the ABI?

Making a comment about ABI in the commit message makes it clear it is something you have considered, and you have decided it is not an issue. If there is no such comment, reviewers probably should ask.

Andrew

#4 lore raw
Quoted 58 lines · Andrew Lunn
Quoted 51 lines · Brian Vazquez
Quoted 50 lines · Andrew Lunn
Quoted 47 lines · Brian Vazquez

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 1002
      tx_q-1_pkts: 2679
      tx_q-2_pkts: 1113
      tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
      rx_q-0_pkts: 1143
      rx_q-1_pkts: 3172
      rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 118
      tx_q-1_pkts: 134
      tx_q-2_pkts: 228
      tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
      rx_q-0_pkts: 111
      rx_q-1_pkts: 366
      rx_q-2_pkts: 120
Quoted 5 lines
Quoted 1 line

Are there any ABI issues here?

The patch doesn't change the format, it just fixes the numbering in the name to make it consistent with other reporting tools. It shouldn't break any library.

Quoted 7 lines

But is the numbering part of the ABI?

Making a comment about ABI in the commit message makes it clear it is something you have considered, and you have decided it is not an issue. If there is no such comment, reviewers probably should ask.

Andrew

I don't see how an application can depend on the name if it can't correlate it to anything meaningful. The change fixes the ID values used so that they *do* correlate. If an application was previously assuming it correlated to the queue ID, it would incorrect associate the IRQ with the wrong queue.

#5 lore raw
Quoted 68 lines · Jacob Keller
Quoted 64 lines · Andrew Lunn
Quoted 51 lines · Brian Vazquez
Quoted 50 lines · Andrew Lunn
Quoted 47 lines · Brian Vazquez

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 1002
      tx_q-1_pkts: 2679
      tx_q-2_pkts: 1113
      tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
      rx_q-0_pkts: 1143
      rx_q-1_pkts: 3172
      rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 118
      tx_q-1_pkts: 134
      tx_q-2_pkts: 228
      tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
      rx_q-0_pkts: 111
      rx_q-1_pkts: 366
      rx_q-2_pkts: 120
Quoted 5 lines
Quoted 1 line

Are there any ABI issues here?

The patch doesn't change the format, it just fixes the numbering in the name to make it consistent with other reporting tools. It shouldn't break any library.

But is the numbering part of the ABI?

Making a comment about ABI in the commit message makes it clear it is something you have considered, and you have decided it is not an issue. If there is no such comment, reviewers probably should ask.

Quoted 7 lines
Quoted 1 line

Andrew

I don't see how an application can depend on the name if it can't correlate it to anything meaningful. The change fixes the ID values used so that they *do* correlate. If an application was previously assuming it correlated to the queue ID, it would incorrect associate the IRQ with the wrong queue.

Agree, this mismatch caused me some surprises, we can not keep a broken ABI (which has been broken by accident)

#6 lore raw
Quoted 71 lines · Eric Dumazet
Quoted 70 lines · Jacob Keller
Quoted 65 lines · Andrew Lunn
Quoted 51 lines · Brian Vazquez
Quoted 50 lines · Andrew Lunn
Quoted 47 lines · Brian Vazquez

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 1002
      tx_q-1_pkts: 2679
      tx_q-2_pkts: 1113
      tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
      rx_q-0_pkts: 1143
      rx_q-1_pkts: 3172
      rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 118
      tx_q-1_pkts: 134
      tx_q-2_pkts: 228
      tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
      rx_q-0_pkts: 111
      rx_q-1_pkts: 366
      rx_q-2_pkts: 120
Quoted 5 lines
Quoted 1 line

Are there any ABI issues here?

The patch doesn't change the format, it just fixes the numbering in the name to make it consistent with other reporting tools. It shouldn't break any library.

But is the numbering part of the ABI?

Making a comment about ABI in the commit message makes it clear it is something you have considered, and you have decided it is not an issue. If there is no such comment, reviewers probably should ask.

Andrew

Quoted 8 lines
Quoted 5 lines

I don't see how an application can depend on the name if it can't correlate it to anything meaningful. The change fixes the ID values used so that they *do* correlate. If an application was previously assuming it correlated to the queue ID, it would incorrect associate the IRQ with the wrong queue.

Agree, this mismatch caused me some surprises, we can not keep a broken ABI (which has been broken by accident)

So everybody is agreed, great. I just think it would of been good to mention ABI in the commit message, to show due diligence has been done.

Andrew

#7 lore raw

Sure, sending v3 to add more details about the ABI.

Quoted 87 lines · Andrew Lunn
Quoted 71 lines · Eric Dumazet
Quoted 70 lines · Jacob Keller
Quoted 65 lines · Andrew Lunn
Quoted 51 lines · Brian Vazquez
Quoted 50 lines · Andrew Lunn
Quoted 47 lines · Brian Vazquez

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 1002
      tx_q-1_pkts: 2679
      tx_q-2_pkts: 1113
      tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
      rx_q-0_pkts: 1143
      rx_q-1_pkts: 3172
      rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 118
      tx_q-1_pkts: 134
      tx_q-2_pkts: 228
      tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
      rx_q-0_pkts: 111
      rx_q-1_pkts: 366
      rx_q-2_pkts: 120
Quoted 5 lines
Quoted 1 line

Are there any ABI issues here?

The patch doesn't change the format, it just fixes the numbering in the name to make it consistent with other reporting tools. It shouldn't break any library.

But is the numbering part of the ABI?

Making a comment about ABI in the commit message makes it clear it is something you have considered, and you have decided it is not an issue. If there is no such comment, reviewers probably should ask.

Andrew

Quoted 8 lines
Quoted 5 lines

I don't see how an application can depend on the name if it can't correlate it to anything meaningful. The change fixes the ID values used so that they *do* correlate. If an application was previously assuming it correlated to the queue ID, it would incorrect associate the IRQ with the wrong queue.

Agree, this mismatch caused me some surprises, we can not keep a broken ABI (which has been broken by accident)

So everybody is agreed, great. I just think it would of been good to mention ABI in the commit message, to show due diligence has been done.

Andrew

Reviewed-by on v2 1/1
#8 lore raw
In reply to Brian Vazquez

Dear Brian,

Thank you for your patch.

Am 26.01.26 um 15:46 schrieb Brian Vazquez via Intel-wired-lan:

Quoted 63 lines

The code uses the vidx for the IRQ name but that doesn't match ethtool reporting or netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.

Before:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 1002
      tx_q-1_pkts: 2679
      tx_q-2_pkts: 1113
      tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
      rx_q-0_pkts: 1143
      rx_q-1_pkts: 3172
      rx_q-2_pkts: 1074

After:

ethtool -L eth1 tx 1 combined 3

grep . /proc/irq/*/*idpf*/../smp_affinity_list

/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3

ethtool -S eth1 | grep -v ': 0'
NIC statistics:

      tx_q-0_pkts: 118
      tx_q-1_pkts: 134
      tx_q-2_pkts: 228
      tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
      rx_q-0_pkts: 111
      rx_q-1_pkts: 366
      rx_q-2_pkts: 120
Fixes d4d558718266 ("idpf: initialize interrupts and enable vport")

---
V2: Add mising Fixes tag

  drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/idpf/idpf_txrx.c +0 -0
index c2a1fe3c79ec..c1f8dfc570ce 100644

drivers/net/ethernet/intel/idpf/idpf_txrx.c static int idpf_vport_intr_req_irq(struct idpf_vport *vport, · line 4099

Quoted 8 lines
drivers/net/ethernet/intel/idpf/idpf_txrx.c +1 -1
@@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport,
  			continue;
 
  		name = kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name, if_name,
-				 vec_name, vidx);
+				 vec_name, vector);
 
  		err = request_irq(irq_num, idpf_vport_intr_clean_queues, 0,
  				  name, q_vector);

With Andrew’s comment addressed in the commit message, this looks sensible.

Kind regards,

Paul