idpf: change IRQ naming to match netdev and ethtool queue numbering
Subsystems (3)
PATCH v3 1/1 idpf: change IRQ naming to match netdev and ethtool queue numbering
The code uses the vidx for the IRQ name but that doesn't match ethtool reporting nor netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.
This commit changes the interrupt numbering but preserves the name format, maintaining ABI compatibility. Existing tools relying on the old numbering are already non-functional, as they lack a useful correlation to the interrupts.
Before:
ethtool -L eth1 tx 1 combined 3
grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
ethtool -S eth1 | grep -v ': 0'
NIC statistics:
tx_q-0_pkts: 1002
tx_q-1_pkts: 2679
tx_q-2_pkts: 1113
tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
rx_q-0_pkts: 1143
rx_q-1_pkts: 3172
rx_q-2_pkts: 1074After:
ethtool -L eth1 tx 1 combined 3
grep . /proc/irq/*/*idpf*/../smp_affinity_list
/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
ethtool -S eth1 | grep -v ': 0'
NIC statistics:
tx_q-0_pkts: 118
tx_q-1_pkts: 134
tx_q-2_pkts: 228
tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
rx_q-0_pkts: 111
rx_q-1_pkts: 366
rx_q-2_pkts: 120---
V3: Add more context to the commit message
V2: Add mising Fixes tag
drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/idpf/idpf_txrx.c +1 -1
@@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport,continue ; name =kasprintf (GFP_KERNEL ,"%s-%s-%s-%d" , drv_name, if_name, - vec_name, vidx); + vec_name, vector); err =request_irq (irq_num, idpf_vport_intr_clean_queues,0 , name, q_vector);
Signature · 1 line
2.52.0.457.g6b5491de43-goog
Dear Brian,
Thank you for your patch.
Am 26.01.26 um 22:55 schrieb Brian Vazquez via Intel-wired-lan:
Quoted 69 lines
The code uses the vidx for the IRQ name but that doesn't match ethtool reporting nor netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.
This commit changes the interrupt numbering but preserves the name format, maintaining ABI compatibility. Existing tools relying on the old numbering are already non-functional, as they lack a useful correlation to the interrupts.
Before:
ethtool -L eth1 tx 1 combined 3
grep .
/proc/irq/*/*idpf*/../smp_affinity_list/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167/proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0/proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1/proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2/proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3ethtool -S eth1 | grep -v ': 0'
NIC statistics:tx_q-0_pkts: 1002 tx_q-1_pkts: 2679 tx_q-2_pkts: 1113 tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5 rx_q-0_pkts: 1143 rx_q-1_pkts: 3172 rx_q-2_pkts: 1074After:
ethtool -L eth1 tx 1 combined 3
grep .
/proc/irq/*/*idpf*/../smp_affinity_list/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
/proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0/proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1/proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2/proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3ethtool -S eth1 | grep -v ': 0'
NIC statistics:tx_q-0_pkts: 118 tx_q-1_pkts: 134 tx_q-2_pkts: 228 tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3 rx_q-0_pkts: 111 rx_q-1_pkts: 366 rx_q-2_pkts: 120Fixes d4d558718266 ("idpf: initialize interrupts and enable vport")Signed-off-by Brian Vazquez <[email protected]>Reviewed-by Brett Creeley <[email protected]>Reviewed-by Aleksandr Loktionov <[email protected]>---
V3: Add more context to the commit message
V2: Add mising Fixes tagdrivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/intel/idpf/idpf_txrx.c +0
-0
drivers/net/ethernet/intel/idpf/idpf_txrx.c static int idpf_vport_intr_req_irq(struct idpf_vport *vport, · line 4099
Quoted 8 lines
drivers/net/ethernet/intel/idpf/idpf_txrx.c +1
-1@@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport,continue ; name =kasprintf (GFP_KERNEL ,"%s-%s-%s-%d" , drv_name, if_name, - vec_name, vidx); + vec_name, vector); err =request_irq (irq_num, idpf_vport_intr_clean_queues,0 , name, q_vector);
Kind regards,
Paul
Quoted 11 lines · Brian Vazquez
The code uses the vidx for the IRQ name but that doesn't match ethtool reporting nor netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.
This commit changes the interrupt numbering but preserves the name format, maintaining ABI compatibility. Existing tools relying on the old numbering are already non-functional, as they lack a useful correlation to the interrupts.
Salin, Samuel
Tested-byQuoted 26 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Eric Dumazet via Intel-wired-lan
Sent: Tuesday, January 27, 2026 8:38 AM
To: Brian Vazquez <[email protected]>
Cc: Brian Vazquez <[email protected]>; Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel- [email protected]; David Decotigny <[email protected]>; Li Li <[email protected]>; Singhai, Anjali <[email protected]>; Samudrala, Sridhar <[email protected]>; [email protected]; [email protected]; Tantilov, Emil S <[email protected]>; Brett Creeley <[email protected]>; Loktionov, Aleksandr <[email protected]>
Subject: Re: [Intel-wired-lan] [iwl-net PATCH v3] idpf: change IRQ naming to match netdev and ethtool queue numberingQuoted 6 lines · Brian Vazquez
The code uses the vidx for the IRQ name but that doesn't match ethtool reporting nor netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent.
Quoted 7 lines
Quoted 5 lines
This commit changes the interrupt numbering but preserves the name format, maintaining ABI compatibility. Existing tools relying on the old numbering are already non-functional, as they lack a useful correlation to the interrupts.
Reviewed-by Eric Dumazet <[email protected]>