Skip to contentSkip to conversation

arm64: dts: qcom: hamoa/x1: fix idle exit latency

PATCH Superseded Daniel J Blueman 3 participants 3 messages Feb 20

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: hamoa/x1: fix idle exit latency

Designs based on the Qualcomm X1 Hamoa reference platform report:
driver: Idle state 1 target residency too low

This is because the declared X1 idle entry plus exit latency of 680us exceeds the declared minimum 600us residency time:
entry-latency-us = <180>;
exit-latency-us = <500>;
min-residency-us = <600>;

As 500us idle exit latency is overly conservative, fix this to be a more realistic 200us, in range of similar silicon. Tested on a Lenovo Yoga Slim 7x with Qualcomm X1E-80-100.

---
 arch/arm64/boot/dts/qcom/hamoa.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/hamoa.dtsi +1 -1
index a17900eacb20..b870f4dc9c42 100644
@@ -269,7 +269,7 @@ cluster_c4: cpu-sleep-0 {
 				idle-state-name = "ret";
 				arm,psci-suspend-param = <0x00000004>;
 				entry-latency-us = <180>;
-				exit-latency-us = <500>;
+				exit-latency-us = <200>;
 				min-residency-us = <600>;
 			};
 		};
Signature · 1 line
2.51.0
#1 lore raw
Quoted 23 lines · Daniel J Blueman

Designs based on the Qualcomm X1 Hamoa reference platform report:
driver: Idle state 1 target residency too low

This is because the declared X1 idle entry plus exit latency of 680us exceeds the declared minimum 600us residency time:
entry-latency-us = <180>;
exit-latency-us = <500>;
min-residency-us = <600>;

As 500us idle exit latency is overly conservative, fix this to be a more realistic 200us, in range of similar silicon. Tested on a Lenovo Yoga Slim 7x with Qualcomm X1E-80-100.

---
 arch/arm64/boot/dts/qcom/hamoa.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/hamoa.dtsi +0 -0
index a17900eacb20..b870f4dc9c42 100644

arch/arm64/boot/dts/qcom/hamoa.dtsi cluster_c4: cpu-sleep-0 { · line 273

Quoted 6 lines
arch/arm64/boot/dts/qcom/hamoa.dtsi +1 -1
@@ -269,7 +269,7 @@ cluster_c4: cpu-sleep-0 {
 				idle-state-name = "ret";
 				arm,psci-suspend-param = <0x00000004>;
 				entry-latency-us = <180>;
-				exit-latency-us = <500>;
+				exit-latency-us = <200>;
 				min-residency-us = <600>;

+Maulik?

Konrad

#2 lore raw
Quoted 33 lines · Konrad Dybcio
Quoted 23 lines · Daniel J Blueman

Designs based on the Qualcomm X1 Hamoa reference platform report:
driver: Idle state 1 target residency too low

This is because the declared X1 idle entry plus exit latency of 680us exceeds the declared minimum 600us residency time:
entry-latency-us = <180>;
exit-latency-us = <500>;
min-residency-us = <600>;

As 500us idle exit latency is overly conservative, fix this to be a more realistic 200us, in range of similar silicon. Tested on a Lenovo Yoga Slim 7x with Qualcomm X1E-80-100.

---
 arch/arm64/boot/dts/qcom/hamoa.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/hamoa.dtsi +0 -0
index a17900eacb20..b870f4dc9c42 100644

arch/arm64/boot/dts/qcom/hamoa.dtsi cluster_c4: cpu-sleep-0 { · line 273

Quoted 6 lines
arch/arm64/boot/dts/qcom/hamoa.dtsi +1 -1
@@ -269,7 +269,7 @@ cluster_c4: cpu-sleep-0 {
 				idle-state-name = "ret";
 				arm,psci-suspend-param = <0x00000004>;
 				entry-latency-us = <180>;
-				exit-latency-us = <500>;
+				exit-latency-us = <200>;
 				min-residency-us = <600>;

+Maulik?

Quoted 1 line

Konrad

Linux dt idle driver sums up entry & exit latency and displays final number as total exit latency at /sys/devices/system/cpu/cpu*/cpuidle/state1/latency

Can you please keep 320 usec as exit-latency-us to match with downstream 500usec total exit latency number from cluster_c4 state.

Thanks,
Maulik