Skip to contentSkip to conversation

ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC

PATCH Superseded Andy Shevchenko 2 participants 3 messages Feb 20 libata

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

---
 drivers/ata/Kconfig    |  1 -
 drivers/ata/ahci_dwc.c | 54 ------------------------------------------
 2 files changed, 55 deletions(-)
drivers/ata/Kconfig +0 -1
index 2349bca136e0..fff305ec1e78 100644
@@ -194,7 +194,6 @@ config AHCI_DM816
 config AHCI_DWC
 	tristate "Synopsys DWC AHCI SATA support"
 	select SATA_HOST
-	select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
 	help
 	  This option enables support for the Synopsys DWC AHCI SATA
 	  controller implementation.
drivers/ata/ahci_dwc.c +0 -54

81 lines not on this page · raw message

Signature · 1 line
2.50.1
maintainer
#1 lore raw
Quoted 27 lines · Andy Shevchenko

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

---
 drivers/ata/Kconfig    |  1 -
 drivers/ata/ahci_dwc.c | 54 ------------------------------------------
 2 files changed, 55 deletions(-)
drivers/ata/Kconfig +0 -1
index 2349bca136e0..fff305ec1e78 100644
@@ -194,7 +194,6 @@ config AHCI_DM816
 config AHCI_DWC
 	tristate "Synopsys DWC AHCI SATA support"
 	select SATA_HOST
-	select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
 	help
 	  This option enables support for the Synopsys DWC AHCI SATA
 	  controller implementation.
drivers/ata/ahci_dwc.c +0 -0
index 64abf865bb67..436041c57f73 100644

drivers/ata/ahci_dwc.c line 18

Quoted 7 lines
drivers/ata/ahci_dwc.c +0 -1
@@ -13,7 +13,6 @@
 #include <linux/kernel.h>
 #include <linux/libata.h>
 #include <linux/log2.h>
-#include <linux/mfd/syscon.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>

Since you are removing the, from what I can tell, unused syscon.h, I think we should remove the, from what I can tell, unused linux/regmap.h include as well.

(snip)

drivers/ata/ahci_dwc.c static struct ahci_dwc_plat_data ahci_dwc_plat = { · line 468

Quoted 4 lines

static const struct of_device_id ahci_dwc_of_match[] = {

drivers/ata/ahci_dwc.c +0 -1
 	{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
 	{ .compatible = "snps,spear-ahci", &ahci_dwc_plat },
-	{ .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },

If we are dropping support for baikal,bt1-ahci, then I think it makes sense to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml as well.

Kind regards,
Niklas

#2 lore raw
Quoted 3 lines · Niklas Cassel
Quoted 2 lines · Andy Shevchenko

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

...

Quoted 14 lines
Quoted 7 lines

#include <linux/kernel.h>
#include <linux/libata.h>
#include <linux/log2.h>
-#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>

Since you are removing the, from what I can tell, unused syscon.h, I think we should remove the, from what I can tell, unused linux/regmap.h include as well.

(snip)

Quoted 8 lines

drivers/ata/ahci_dwc.c static struct ahci_dwc_plat_data ahci_dwc_plat = { · line 468

Quoted 4 lines

static const struct of_device_id ahci_dwc_of_match[] = {

drivers/ata/ahci_dwc.c +0 -1
 	{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
 	{ .compatible = "snps,spear-ahci", &ahci_dwc_plat },
-	{ .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },

If we are dropping support for baikal,bt1-ahci, then I think it makes sense to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml as well.

Thanks, I have just sent a v2 with the suggested changes.

Signature · 2 lines
With Best Regards,
Andy Shevchenko