Skip to contentSkip to conversation

Add support for Allwinner PWM on D1/T113s/R329 SoCs

PATCH In review Aleksandr Shubin 4 participants 7 messages Feb 21 – Apr 24

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v13 cover Add support for Allwinner PWM on D1/T113s/R329 SoCs

v2:
- fix dt-bindings
- fix a remark in the driver

v3:
- fix dt-bindings
- fix sunxi-d1s-t113.dtsi

v4:
- fix a remark in the driver

v5:
- dropped unused varibale in the driver
- fix dt-bindings

v6:
- add apb0 clock

v7:
- fix a remark in the driver
- add maintainer

v8:
- fix compile driver for 6.8-rc

v9:
- fix a remark in the driver
- fix dt-bindings
- rename apb0 -> apb

v10:
- fix a remark in the driver
- fix compile driver for 6.12-rc2

v11:
- fix a remark in the driver
- fix compile driver for 6.14.0-rc2

v12:
- fix a remark in the driver
- fix a remark in the dt-bindings
- check driver build on 6.15.0-rc3

v13:
- rename driver sun20i -> sun8i to reflect wider SoC coverage
- drop the misleading APB > HOSC dev_info() warning
- require allwinner,npwms and validate it as 1..16 (remove default 8 and silent clamp)
- adjust clock-source selection comment/logic:
when sibling is disabled, pick the faster parent (APB vs HOSC); when sibling is enabled, keep existing shared settings

Aleksandr Shubin (3):
dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM
controller
pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support
riscv: dts: allwinner: d1: Add pwm node

 .../bindings/pwm/allwinner,sun20i-d1-pwm.yaml |  74 ++++
 .../boot/dts/allwinner/sunxi-d1s-t113.dtsi    |  13 +
 drivers/pwm/Kconfig                           |  10 +
 drivers/pwm/Makefile                          |   1 +
 drivers/pwm/pwm-sun8i.c                       | 393 ++++++++++++++++++
 5 files changed, 491 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-d1-pwm.yaml
 create mode 100644 drivers/pwm/pwm-sun8i.c
Signature · 1 line
2.25.1
#1 lore raw

PATCH v13 1/3 dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller

Allwinner's D1, T113-S3 and R329 SoCs have a new pwm controller which is different from the previous pwm-sun4i.

The D1 and T113 are identical in terms of peripherals, they differ only in the architecture of the CPU core, and even share the majority of their DT. Because of that, using the same compatible makes sense.
The R329 is a different SoC though, and should have a different compatible string added, especially as there is a difference in the number of channels.

D1 and T113s SoCs have one PWM controller with 8 channels. R329 SoC has two PWM controllers in both power domains, one of them has 9 channels (CPUX one) and the other has 6 (CPUS one).

Add a device tree binding for them.

---
 .../bindings/pwm/allwinner,sun20i-d1-pwm.yaml | 74 +++++++++++++++++++
 1 file changed, 74 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-d1-pwm.yaml
Documentation/devicetree/bindings/pwm/allwinner,sun20i-d1-pwm.yaml new file +74 -0
new file mode 100644
index 000000000000..306e14a9c4d5
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/allwinner,sun20i-d1-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner D1, T113-S3 and R329 PWM
+
+maintainers:
+  - Aleksandr Shubin <[email protected]>
+  - Brandon Cheo Fusi <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      - const: allwinner,sun20i-d1-pwm
+      - items:
+          - const: allwinner,sun50i-r329-pwm
+          - const: allwinner,sun20i-d1-pwm
+
+  reg:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 3
+
+  clocks:
+    items:
+      - description: Bus clock
+      - description: 24 MHz oscillator
+      - description: APB clock
+
+  clock-names:
+    items:
+      - const: bus
+      - const: hosc
+      - const: apb
+
+  resets:
+    maxItems: 1
+
+  allwinner,npwms:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: The number of PWM channels configured for this instance
+    minimum: 1
+    maximum: 16
+
+unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - "#pwm-cells"
+  - clocks
+  - clock-names
+  - resets
+  - allwinner,npwms
+
+examples:
+  - |
+    #include <dt-bindings/clock/sun20i-d1-ccu.h>
+    #include <dt-bindings/reset/sun20i-d1-ccu.h>
+
+    pwm: pwm@2000c00 {
+      compatible = "allwinner,sun20i-d1-pwm";
+      reg = <0x02000c00 0x400>;
+      clocks = <&ccu CLK_BUS_PWM>, <&dcxo>, <&ccu CLK_APB0>;
+      clock-names = "bus", "hosc", "apb";
+      resets = <&ccu RST_BUS_PWM>;
+      #pwm-cells = <0x3>;
+      allwinner,npwms = <8>;
+    };
+
+...
Signature · 1 line
2.25.1
maintainer Reviewed-by on v13 1/3
#2 lore raw

Re: [PATCH v13 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller

Quoted 15 lines · Aleksandr Shubin

Allwinner's D1, T113-S3 and R329 SoCs have a new pwm controller which is different from the previous pwm-sun4i.

The D1 and T113 are identical in terms of peripherals, they differ only in the architecture of the CPU core, and even share the majority of their DT. Because of that, using the same compatible makes sense.
The R329 is a different SoC though, and should have a different compatible string added, especially as there is a difference in the number of channels.

D1 and T113s SoCs have one PWM controller with 8 channels. R329 SoC has two PWM controllers in both power domains, one of them has 9 channels (CPUX one) and the other has 6 (CPUS one).

Quoted 8 lines

Add a device tree binding for them.

---
 .../bindings/pwm/allwinner,sun20i-d1-pwm.yaml | 74 +++++++++++++++++++
 1 file changed, 74 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-d1-pwm.yaml
#3 lore raw

PATCH v13 2/3 pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support

In reply to Aleksandr Shubin

Allwinner's D1, T113-S3 and R329 SoCs have a quite different PWM controllers with ones supported by pwm-sun4i driver.

This patch adds a PWM controller driver for Allwinner's D1, T113-S3 and R329 SoCs. The main difference between these SoCs is the number of channels defined by the DT property.

---
 drivers/pwm/Kconfig     |  10 +
 drivers/pwm/Makefile    |   1 +
 drivers/pwm/pwm-sun8i.c | 393 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 404 insertions(+)
 create mode 100644 drivers/pwm/pwm-sun8i.c
drivers/pwm/Kconfig +10 -0
index 6f3147518376..44d844eba589 100644
@@ -736,6 +736,16 @@ config PWM_SUN4I
 	  To compile this driver as a module, choose M here: the module
 	  will be called pwm-sun4i.
 
+config PWM_SUN8I
+	tristate "Allwinner D1/T113s/R329 PWM support"
+	depends on ARCH_SUNXI || COMPILE_TEST
+	depends on COMMON_CLK
+	help
+	  Generic PWM framework driver for Allwinner D1/T113s/R329 SoCs.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called pwm-sun8i.
+
 config PWM_SUNPLUS
 	tristate "Sunplus PWM support"
 	depends on ARCH_SUNPLUS || COMPILE_TEST
drivers/pwm/Makefile +1 -0
index 0dc0d2b69025..ba2e0ec7fc17 100644
@@ -67,6 +67,7 @@ obj-$(CONFIG_PWM_STM32)		+= pwm-stm32.o
 obj-$(CONFIG_PWM_STM32_LP)	+= pwm-stm32-lp.o
 obj-$(CONFIG_PWM_STMPE)		+= pwm-stmpe.o
 obj-$(CONFIG_PWM_SUN4I)		+= pwm-sun4i.o
+obj-$(CONFIG_PWM_SUN8I)		+= pwm-sun8i.o
 obj-$(CONFIG_PWM_SUNPLUS)	+= pwm-sunplus.o
 obj-$(CONFIG_PWM_TEGRA)		+= pwm-tegra.o
 obj-$(CONFIG_PWM_TH1520)	+= pwm_th1520.o
drivers/pwm/pwm-sun8i.c new file +393 -0

393 lines not on this page · raw message

Signature · 1 line
2.25.1
#4 lore raw

Re: [PATCH v13 2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support

Quoted 71 lines · Aleksandr Shubin

Allwinner's D1, T113-S3 and R329 SoCs have a quite different PWM controllers with ones supported by pwm-sun4i driver.

This patch adds a PWM controller driver for Allwinner's D1, T113-S3 and R329 SoCs. The main difference between these SoCs is the number of channels defined by the DT property.

---
 drivers/pwm/Kconfig     |  10 +
 drivers/pwm/Makefile    |   1 +
 drivers/pwm/pwm-sun8i.c | 393 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 404 insertions(+)
 create mode 100644 drivers/pwm/pwm-sun8i.c
drivers/pwm/Kconfig +10 -0
index 6f3147518376..44d844eba589 100644
@@ -736,6 +736,16 @@ config PWM_SUN4I
 	  To compile this driver as a module, choose M here: the module
 	  will be called pwm-sun4i.
 
+config PWM_SUN8I
+	tristate "Allwinner D1/T113s/R329 PWM support"
+	depends on ARCH_SUNXI || COMPILE_TEST
+	depends on COMMON_CLK
+	help
+	  Generic PWM framework driver for Allwinner D1/T113s/R329 SoCs.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called pwm-sun8i.
+
 config PWM_SUNPLUS
 	tristate "Sunplus PWM support"
 	depends on ARCH_SUNPLUS || COMPILE_TEST
drivers/pwm/Makefile +1 -0
index 0dc0d2b69025..ba2e0ec7fc17 100644
@@ -67,6 +67,7 @@ obj-$(CONFIG_PWM_STM32)		+= pwm-stm32.o
 obj-$(CONFIG_PWM_STM32_LP)	+= pwm-stm32-lp.o
 obj-$(CONFIG_PWM_STMPE)		+= pwm-stmpe.o
 obj-$(CONFIG_PWM_SUN4I)		+= pwm-sun4i.o
+obj-$(CONFIG_PWM_SUN8I)		+= pwm-sun8i.o
 obj-$(CONFIG_PWM_SUNPLUS)	+= pwm-sunplus.o
 obj-$(CONFIG_PWM_TEGRA)		+= pwm-tegra.o
 obj-$(CONFIG_PWM_TH1520)	+= pwm_th1520.o
drivers/pwm/pwm-sun8i.c new file +15 -0
new file mode 100644
index 000000000000..6e196f31314b
@@ -0,0 +1,393 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * PWM Controller Driver for sunxi platforms (D1, T113-S3 and R329)
+ *
+ * Limitations:
+ * - When the parameters change, the current running period is not completed
+ *   and new settings are applied immediately.
+ * - The PWM output goes to a HIGH-Z state when the channel is disabled.
+ * - Changing the clock configuration (SUN8I_PWM_CLK_CFG)
+ *   may cause a brief output glitch.
+ *
+ * Copyright (c) 2023 Aleksandr Shubin <[email protected]>
+ */
+
+#include <linux/bitfield.h>

drivers/pwm/pwm-sun8i.c line 25

Quoted 10 lines
drivers/pwm/pwm-sun8i.c new file +10 -0
+#include <linux/clk.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pwm.h>
+#include <linux/reset.h>
+
+#define SUN8I_PWM_CLK_CFG(pair)			(0x20 + ((pair) * 0x4))

A word about the range of pair would be good. Something like:

/*
* Shared clock register. SUN8I_PWM_CLK_CFG(pair) configures the settings
* for channels 2·pair and 2·pair+1. Maximal value for pair is hardware
* dependant, it cannot be bigger than 8.
*/

drivers/pwm/pwm-sun8i.c line 28

Quoted 3 lines
drivers/pwm/pwm-sun8i.c new file +3 -0
+#define SUN8I_PWM_CLK_CFG_SRC			GENMASK(8, 7)
+#define SUN8I_PWM_CLK_SRC_HOSC			0x0
+#define SUN8I_PWM_CLK_SRC_BUS			0x1

SUN8I_PWM_CLK_SRC_HOSC and SUN8I_PWM_CLK_SRC_BUS are values for SUN8I_PWM_CLK_CFG_SRC, right? It would be great if they were named SUN8I_PWM_CLK_CFG_SRC_HOSC and SUN8I_PWM_CLK_CFG_SRC_BUS then. And then it might be sensible to define it to

	FIELD_PREP(SUN8I_PWM_CLK_CFG_SRC, 1)

(and 0 respectively).

I hope there is no conflict with the reference manual.

Speaking of the reference manual: Is there a public one? If yes, adding a link to it would be awesome.

Quoted 10 lines
drivers/pwm/pwm-sun8i.c new file +10 -0
+#define SUN8I_PWM_CLK_CFG_DIV_M			GENMASK(3, 0)
+#define SUN8I_PWM_CLK_DIV_M_MAX			8
+
+#define SUN8I_PWM_CLK_GATE			0x40
+#define SUN8I_PWM_CLK_GATE_BYPASS(chan)		BIT((chan) + 16)
+#define SUN8I_PWM_CLK_GATE_GATING(chan)		BIT(chan)
+
+#define SUN8I_PWM_ENABLE			0x80
+#define SUN8I_PWM_ENABLE_EN(chan)		BIT(chan)
+

drivers/pwm/pwm-sun8i.c line 48

Quoted 10 lines
drivers/pwm/pwm-sun8i.c new file +10 -0
+#define SUN8I_PWM_CTL(chan)			(0x100 + (chan) * 0x20)
+#define SUN8I_PWM_CTL_ACT_STA			BIT(8)
+#define SUN8I_PWM_CTL_PRESCAL_K			GENMASK(7, 0)
+#define SUN8I_PWM_CTL_PRESCAL_K_MAX		field_max(SUN8I_PWM_CTL_PRESCAL_K)
+
+#define SUN8I_PWM_PERIOD(chan)			(0x104 + (chan) * 0x20)
+#define SUN8I_PWM_PERIOD_ENTIRE_CYCLE		GENMASK(31, 16)
+#define SUN8I_PWM_PERIOD_ACT_CYCLE		GENMASK(15, 0)
+
+#define SUN8I_PWM_PCNTR_SIZE			BIT(16)

This is unused (apart from the comment below). I'm unsure if this is a bit field, if so to which register? Does it need a comment? Or should it be dropped? From the discussion below, should this be field_max(SUN8I_PWM_PERIOD_ACT_CYCLE)? (The value is different then the calculations below needed some adaption if that is chosen.)

drivers/pwm/pwm-sun8i.c line 55

Quoted 6 lines
drivers/pwm/pwm-sun8i.c new file +6 -0
+/*
+ * SUN8I_PWM_MAGIC is used to quickly compute the values of the clock dividers
+ * div_m (SUN8I_PWM_CLK_CFG_DIV_M) & prescale_k (SUN8I_PWM_CTL_PRESCAL_K)
+ * without using a loop. These dividers limit the # of cycles in a period
+ * to SUN8I_PWM_PCNTR_SIZE (65536) by applying a scaling factor of
+ * 1 / (div_m * (prescale_k + 1)) to the clock source.

Here div_m is a plain divider, ...

drivers/pwm/pwm-sun8i.c line 68

Quoted 13 lines
drivers/pwm/pwm-sun8i.c new file +13 -0
+ *
+ * SUN8I_PWM_MAGIC is derived by solving for div_m and prescale_k
+ * such that for a given requested period,
+ *
+ * i) div_m is minimized for any prescale_k ≤ SUN8I_PWM_CTL_PRESCAL_K_MAX,
+ * ii) prescale_k is minimized.
+ *
+ * The derivation proceeds as follows, with val = # of cycles for requested
+ * period:
+ *
+ * for a given value of div_m we want the smallest prescale_k such that
+ *
+ * (val >> div_m) // (prescale_k + 1) ≤ 65536 (= SUN8I_PWM_PCNTR_SIZE)

... and here it is a shift. I assume that above 1 << div_m is actually meant, right?

Quoted 34 lines
drivers/pwm/pwm-sun8i.c new file +33 -0
+ * This is equivalent to:
+ *
+ * (val >> div_m) ≤ 65536 * (prescale_k + 1) + prescale_k
+ * ⟺ (val >> div_m) ≤ 65537 * prescale_k + 65536
+ * ⟺ (val >> div_m) - 65536 ≤ 65537 * prescale_k
+ * ⟺ ((val >> div_m) - 65536) / 65537 ≤ prescale_k
+ *
+ * As prescale_k is integer, this becomes
+ *
+ * ((val >> div_m) - 65536) // 65537 ≤ prescale_k
+ *
+ * And is minimized at
+ *
+ * ((val >> div_m) - 65536) // 65537
+ *
+ * Now we pick the smallest div_m that satifies prescale_k ≤ 255
+ * (i.e SUN8I_PWM_CTL_PRESCAL_K_MAX),
+ *
+ * ((val >> div_m) - 65536) // 65537 ≤ 255
+ * ⟺ (val >> div_m) - 65536 ≤ 255 * 65537 + 65536
+ * ⟺ val >> div_m ≤ 255 * 65537 + 2 * 65536
+ * ⟺ val >> div_m < (255 * 65537 + 2 * 65536 + 1)
+ * ⟺ div_m = fls((val) / (255 * 65537 + 2 * 65536 + 1))
+ *
+ * Suggested by Uwe Kleine-König
+ */
+#define SUN8I_PWM_MAGIC				(255 * 65537 + 2 * 65536 + 1)
+#define SUN8I_PWM_DIV_CONST			65537
[...]
+static int sun8i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
+			    const struct pwm_state *state)
+{
+	struct sun8i_pwm_chip *sun8i_chip = to_sun8i_pwm_chip(chip);
+	u64 bus_rate, hosc_rate, val, ent_cycle, act_cycle;

drivers/pwm/pwm-sun8i.c line 193

Quoted 10 lines
drivers/pwm/pwm-sun8i.c new file +10 -0
+	u32 clk_gate, clk_cfg, pwm_en, ctl, reg_period;
+	u32 prescale_k, div_m;
+	u64 clk_src_rate;
+	u8 clk_src;
+
+	pwm_en = sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_ENABLE);
+	clk_gate = sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_CLK_GATE);
+
+	if (!state->enabled) {
+		if (state->enabled != pwm->state.enabled) {

Can we make this

		if (pwm_en & SUN8I_PWM_ENABLE_EN(pwm->hwpwm)) {

? Then it depends on the hardware settings instead of cached state. Same for the other usage of pwm->state below.

Quoted 17 lines
drivers/pwm/pwm-sun8i.c new file +16 -0
+			clk_gate &= ~SUN8I_PWM_CLK_GATE_GATING(pwm->hwpwm);
+			pwm_en &= ~SUN8I_PWM_ENABLE_EN(pwm->hwpwm);
+			sun8i_pwm_writel(sun8i_chip, pwm_en, SUN8I_PWM_ENABLE);
+			sun8i_pwm_writel(sun8i_chip, clk_gate, SUN8I_PWM_CLK_GATE);
+		}
+		return 0;
+	}
+
+	ctl = sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_CTL(pwm->hwpwm));
+	clk_cfg = sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_CLK_CFG(pwm->hwpwm / 2));
+	hosc_rate = clk_get_rate(sun8i_chip->clk_hosc);
+	bus_rate = clk_get_rate(sun8i_chip->clk_apb);
+
[...]
+static int sun8i_pwm_probe(struct platform_device *pdev)
+{
+	struct pwm_chip *chip;

drivers/pwm/pwm-sun8i.c

Quoted 10 lines
drivers/pwm/pwm-sun8i.c new file +10 -0
+	struct sun8i_pwm_chip *sun8i_chip;
+	struct clk *clk_bus;
+	struct reset_control *rst;
+	u32 npwm;
+	int ret;
+
+	ret = of_property_read_u32(pdev->dev.of_node, "allwinner,npwms", &npwm);
+	if (ret < 0)
+		return dev_err_probe(&pdev->dev, ret,
+				     "Failed to get allwinner,npwms\n");

I failed to reply to your question about a non-vendored name for this in v10
(https://lore.kernel.org/linux-pwm/CAF4idNmDMQpFppUvCBbC1=SNMQBrTOqmFO60SMvKvaHvNJy=Bg@mail.gmail.com).

"npwms" would be good.

drivers/pwm/pwm-sun8i.c line 332

Quoted 3 lines
drivers/pwm/pwm-sun8i.c new file +3 -0
+	if (npwm < 1 || npwm > 16)
+		return dev_err_probe(&pdev->dev, -EINVAL,
+				     "Invalid allwinner,npwms\n");

I think there is a corner case if npwm is odd. In that case the last channel must not check for hwpwm ^ 1 being enabled in .apply(). So either .apply() should be more clever, or only even values for npwm should be supported.

drivers/pwm/pwm-sun8i.c line 341

Quoted 9 lines
drivers/pwm/pwm-sun8i.c new file +8 -0
+	chip = devm_pwmchip_alloc(&pdev->dev, npwm, sizeof(*sun8i_chip));
+	if (IS_ERR(chip))
+		return PTR_ERR(chip);
+	sun8i_chip = to_sun8i_pwm_chip(chip);
+
+	sun8i_chip->base = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(sun8i_chip->base))
+		return PTR_ERR(sun8i_chip->base);
[...]

Best regards
Uwe

#5 lore raw

PATCH v13 3/3 riscv: dts: allwinner: d1: Add pwm node

In reply to Aleksandr Shubin

D1 and T113s contain a pwm controller with 8 channels. This controller is supported by the sun8i-pwm driver.

Add a device tree node for it.

---
 arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +13 -0
index 63e252b44973..8e38a0d95f5a 100644
@@ -193,6 +193,19 @@ uart3_pb_pins: uart3-pb-pins {
 			};
 		};
 
+		pwm: pwm@2000c00 {
+			compatible = "allwinner,sun20i-d1-pwm";
+			reg = <0x02000c00 0x400>;
+			clocks = <&ccu CLK_BUS_PWM>,
+				 <&dcxo>,
+				 <&ccu CLK_APB0>;
+			clock-names = "bus", "hosc", "apb";
+			resets = <&ccu RST_BUS_PWM>;
+			status = "disabled";
+			#pwm-cells = <0x3>;
+			allwinner,npwms = <8>;
+		};
+
 		ccu: clock-controller@2001000 {
 			compatible = "allwinner,sun20i-d1-ccu";
 			reg = <0x2001000 0x1000>;
Signature · 1 line
2.25.1
maintainer
#6 lore raw

Re: [PATCH v13 3/3] riscv: dts: allwinner: d1: Add pwm node

Dne sobota, 21. februar 2026 ob 19:35:53 Srednjeevropski standardni čas je Aleksandr Shubin napisal(a):

Quoted 17 lines

D1 and T113s contain a pwm controller with 8 channels. This controller is supported by the sun8i-pwm driver.

Add a device tree node for it.

---
 arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +0 -0
index 63e252b44973..8e38a0d95f5a 100644
@@ -193,6 +193,19 @@ uart3_pb_pins: uart3-pb-pins {
 			};
 		};

arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi uart3_pb_pins: uart3-pb-pins { · line 204

Quoted 10 lines
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +9 -0
 
+		pwm: pwm@2000c00 {
+			compatible = "allwinner,sun20i-d1-pwm";
+			reg = <0x02000c00 0x400>;
+			clocks = <&ccu CLK_BUS_PWM>,
+				 <&dcxo>,
+				 <&ccu CLK_APB0>;
+			clock-names = "bus", "hosc", "apb";
+			resets = <&ccu RST_BUS_PWM>;
+			status = "disabled";

Move status at the bottom.

arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi uart3_pb_pins: uart3-pb-pins { · line 205

Quoted 1 line
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +1 -0
+			#pwm-cells = <0x3>;

Just use decimal format.

Best regards,
Jernej

Quoted 7 lines
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +3 -0
+			allwinner,npwms = <8>;
+		};
+
 		ccu: clock-controller@2001000 {
 			compatible = "allwinner,sun20i-d1-ccu";
 			reg = <0x2001000 0x1000>;