wifi: rtlwifi: usb: drop redundant device reference
PATCH RESEND 1/1 wifi: rtlwifi: usb: drop redundant device reference
Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect.
Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it.
---
This one fell out when sending v2 of the series:
https://lore.kernel.org/all/[email protected]/
so posting again separately.
Sorry for the mess.
Johan
drivers/net/wireless/realtek/rtlwifi/usb.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/net/wireless/realtek/rtlwifi/usb.c +0 -4
@@ -986,7 +986,6 @@ int rtl_usb_probe(struct usb_interface *intf,init_completion (&rtlpriv->firmware_loading_complete);SET_IEEE80211_DEV (hw, &intf->dev); udev =interface_to_usbdev (intf); -usb_get_dev (udev); usb_priv =rtl_usbpriv (hw);memset (usb_priv,0 ,sizeof (*usb_priv)); usb_priv->dev.intf = intf;
@@ -1038,7 +1037,6 @@ int rtl_usb_probe(struct usb_interface *intf,rtl_deinit_core (hw); error_out2:_rtl_usb_io_handler_release (hw); -usb_put_dev (udev);kfree (rtlpriv->usb_data);ieee80211_free_hw (hw);return -ENODEV ;
@@ -1050,7 +1048,6 @@ void rtl_usb_disconnect(struct usb_interface *intf)struct ieee80211_hw *hw =usb_get_intfdata (intf);struct rtl_priv *rtlpriv =rtl_priv (hw);struct rtl_mac *rtlmac =rtl_mac (rtl_priv (hw)); -struct rtl_usb *rtlusb =rtl_usbdev (rtl_usbpriv (hw));if (unlikely (!rtlpriv))return ;
@@ -1072,7 +1069,6 @@ void rtl_usb_disconnect(struct usb_interface *intf)kfree (rtlpriv->usb_data); rtlpriv->cfg->ops->deinit_sw_vars (hw);_rtl_usb_io_handler_release (hw); -usb_put_dev (rtlusb->udev);usb_set_intfdata (intf,NULL );ieee80211_free_hw (hw); }
Signature · 1 line
2.52.0
Ping-Ke Shih
maintainerQuoted 10 lines · Johan Hovold
Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect.
Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it.
Signed-off-by Johan Hovold <[email protected]>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
fc25b384fc0b wifi: rtlwifi: usb: drop redundant device reference