wifi: rtw89: drop redundant device reference
PATCH 1/1 wifi: rtw89: drop redundant device reference
Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect.
Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it.
---
Here's a follow-up to
https://lore.kernel.org/all/[email protected]/
which failed to include rtw89 despite Ping-Ke's explicit request (I thought I had grepped for usb_get_dev in wireless before sending out that series, but apparently not).
Johan
drivers/net/wireless/realtek/rtw89/usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/realtek/rtw89/usb.c +1 -2
@@ -935,7 +935,7 @@ static int rtw89_usb_intf_init(struct rtw89_dev *rtwdev,if (!rtwusb->vendor_req_buf)return -ENOMEM ; - rtwusb->udev =usb_get_dev (interface_to_usbdev (intf)); + rtwusb->udev =interface_to_usbdev (intf);usb_set_intfdata (intf, rtwdev->hw);
@@ -949,7 +949,6 @@ static void rtw89_usb_intf_deinit(struct rtw89_dev *rtwdev, {struct rtw89_usb *rtwusb =rtw89_usb_priv (rtwdev); -usb_put_dev (rtwusb->udev);kfree (rtwusb->vendor_req_buf);usb_set_intfdata (intf,NULL ); }
Signature · 1 line
2.52.0
Ping-Ke Shih
maintainerQuoted 10 lines · Johan Hovold
Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect.
Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it.
Signed-off-by Johan Hovold <[email protected]>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
c2a21f35cea4 wifi: rtw89: drop redundant device reference