Save Brightness on Macs
Subsystems (2)
v3 cover Save Brightness on Macs
We fix this by writing the brightness value to efivar 'backlight-level' at shutdown only, when it is changed since the last boot.
Changes in v3:
- Fixed a bug, in which apple_brightness_shutdown is still called on non-supported devices.
Changes in v2:
- Saved the brightness only when it is different than the previous boot.
Link to v2:
https://lore.kernel.org/all/[email protected]/
Link to v1:
https://lore.kernel.org/all/[email protected]/
Atharva Tiwari (2):
efi: Save Brightness using EFI on Macs platform/apple-gmux: use apple_brightness to save brightness to EFI
drivers/firmware/efi/Kconfig | 10 +++ drivers/firmware/efi/Makefile | 1 + drivers/firmware/efi/apple-brightness.c | 67 +++++++++++++++++++ drivers/platform/x86/apple-gmux.c | 21 ++++++ .../linux/platform_data/apple-brightness.h | 20 ++++++ 5 files changed, 119 insertions(+) create mode 100644 drivers/firmware/efi/apple-brightness.c create mode 100644 include/linux/platform_data/apple-brightness.h
Signature · 1 line
2.43.0
PATCH v3 1/2 efi: Save Brightness using EFI on Macs
Currently when a Mac reboots, the brightness is not the same as the previous boot instead its the same as the last time the Mac booted macOS.
We can fix this issue by saving the brightness level to the efivar backlight-level.
(tested on iMac20,1)
--- drivers/firmware/efi/Kconfig | 10 +++ drivers/firmware/efi/Makefile | 1 + drivers/firmware/efi/apple-brightness.c | 67 +++++++++++++++++++ .../linux/platform_data/apple-brightness.h | 20 ++++++ 4 files changed, 98 insertions(+) create mode 100644 drivers/firmware/efi/apple-brightness.c create mode 100644 include/linux/platform_data/apple-brightness.h
drivers/firmware/efi/Kconfig +10 -0
@@ -167,6 +167,16 @@ config APPLE_PROPERTIES If unsure, say Y if you have a Mac. Otherwise N. +config APPLE_BRIGHTNESS + bool "Apple Backlight control for EFI" + depends on X86 + help + This will save the brightness level to EFI, so brightness + level is preserved across reboots and shutdows. allowing + for improved support of Apple hardware. + + If unsure, say Y if you have a Mac, Otherwise N. + config RESET_ATTACK_MITIGATION bool "Reset memory attack mitigation" depends on EFI_STUB
drivers/firmware/efi/Makefile +1 -0
@@ -26,6 +26,7 @@ obj-$(CONFIG_EFI_BOOTLOADER_CONTROL) += efibc.o obj-$(CONFIG_EFI_TEST) += test/ obj-$(CONFIG_EFI_DEV_PATH_PARSER) += dev-path-parser.o obj-$(CONFIG_APPLE_PROPERTIES) += apple-properties.o +obj-$(CONFIG_APPLE_BRIGHTNESS) += apple-brightness.o obj-$(CONFIG_EFI_RCI2_TABLE) += rci2-table.o obj-$(CONFIG_EFI_EMBEDDED_FIRMWARE) += embedded-firmware.o obj-$(CONFIG_LOAD_UEFI_KEYS) += mokvar-table.o
drivers/firmware/efi/apple-brightness.c new file +67 -0
67 lines not on this page · raw message
include/linux/platform_data/apple-brightness.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ +/* +* apple-brightness.h - EFI brightness saver for Macs +* Copyright (C) 2026 Atharva Tiwari <[email protected]> +*/ + +#ifndef _APPLE_BL_H_ +#define _APPLE_BL_H_ + +#include <linux/backlight.h> +#include <linux/efi.h> + +#define APPLE_BRIGHTNESS_NAME L"backlight-level" +#define APPLE_BRIGHTNESS_GUID EFI_GUID(0x7c436110, 0xab2a, 0x4bbb, 0xa8, 0x80, 0xfe, 0x41, 0x99, 0x5c, 0x9f, 0x82) + +int apple_brightness_probe (struct backlight_device *bl, +int (*get_brightnessfn)(struct backlight_device *bl)); + +void apple_brightness_shutdown (void ); +#endif /* _APPLE_BL_H */
Signature · 1 line
2.43.0
Re: [PATCH v3 1/2] efi: Save Brightness using EFI on Macs
Quoted 5 lines · Atharva Tiwari
drivers/firmware/efi/Kconfig +0
-0
drivers/firmware/efi/Kconfig config APPLE_PROPERTIES · line 175
Quoted 9 lines
drivers/firmware/efi/Kconfig +6
-0@@ -167,6 +167,16 @@ config APPLE_PROPERTIES If unsure, say Y if you have a Mac. Otherwise N. +config APPLE_BRIGHTNESS + bool "Apple Backlight control for EFI" + depends on X86 + help + This will save the brightness level to EFI, so brightness + level is preserved across reboots and shutdows. allowing
shutdowns, allowing
drivers/firmware/efi/Kconfig config APPLE_PROPERTIES · line 178
Quoted 3 lines
drivers/firmware/efi/Kconfig +3
-0+ for improved support of Apple hardware. + + If unsure, say Y if you have a Mac, Otherwise N.
otherwise N.
Signature · 1 line
~Randy
PATCH v3 2/2 platform/apple-gmux: use apple_brightness to save brightness to EFI
In reply to Atharva Tiwariuse apple_brightness to save brightness to EFI.
(tested on iMac20,1)
--- drivers/platform/x86/apple-gmux.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
drivers/platform/x86/apple-gmux.c +21 -0
@@ -22,6 +22,7 @@#include <linux/pci.h> #include <linux/vga_switcheroo.h> #include <linux/debugfs.h> +#include <linux/platform_data/apple-brightness.h> #include <acpi/video.h> #include <asm/io.h>
@@ -78,6 +79,8 @@ struct apple_gmux_data {/* debugfs data */ u8 selected_port;struct dentry *debug_dentry; + +bool save_efi; };static struct apple_gmux_data *apple_gmux_data;
@@ -960,6 +963,13 @@ static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) }gmux_init_debugfs (gmux_data); +if (IS_ENABLED (CONFIG_APPLE_BRIGHTNESS )) { + ret =apple_brightness_probe (gmux_data->bdev, &gmux_get_brightness); +if (ret) +pr_warn ("Unable to Enable EFI brightness save: %d\n" , ret); +else + gmux_data->save_efi = true; + }return 0 ; err_register_handler:
@@ -1012,6 +1022,16 @@ static void gmux_remove(struct pnp_dev *pnp)kfree (gmux_data); } +static void gmux_shutdown (struct pnp_dev *pnp) +{ +struct apple_gmux_data *gmux_data =pnp_get_drvdata (pnp); + +if (gmux_data->save_efi) +apple_brightness_shutdown (); + +gmux_remove (pnp); +} +static const struct pnp_device_id gmux_device_ids[] = { {GMUX_ACPI_HID ,0 }, {"" ,0 }
@@ -1026,6 +1046,7 @@ static struct pnp_driver gmux_pnp_driver = { .name = "apple-gmux", .probe = gmux_probe, .remove = gmux_remove, + .shutdown = gmux_shutdown, .id_table = gmux_device_ids, .driver = { .pm = &gmux_dev_pm_ops,
Signature · 1 line
2.43.0
kernel test robot
build botRe: [PATCH v3 2/2] platform/apple-gmux: use apple_brightness to save brightness to EFI
kernel test robot noticed the following build errors:
Hi Atharva,
kernel test robot noticed the following build errors:
[auto build test ERROR on efi/next]
[also build test ERROR on linus/master v7.0-rc4 next-20260313] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Atharva-Tiwari/efi-Save-Brightness-using-EFI-on-Macs/20260316-084441 base: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next patch link: https://lore.kernel.org/r/20260315222020.24341-3-atharvatiwarilinuxdev%40gmail.com patch subject: [PATCH v3 2/2] platform/apple-gmux: use apple_brightness to save brightness to EFI config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260316/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260316/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "apple_brightness_shutdown" [drivers/platform/x86/apple-gmux.ko] undefined!
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki