bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS
Subsystems (4)
Ihor Solodrai
reviewerPATCH v2 1/2 bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS
The following kfuncs currently accept void *meta__ign argument:
* bpf_obj_new_impl
* bpf_obj_drop_impl
* bpf_percpu_obj_new_impl
* bpf_percpu_obj_drop_impl
* bpf_refcount_acquire_impl
* bpf_list_push_front_impl
* bpf_rbtree_add_impl
The __ign suffix is an indicator for the verifier to skip the argument in check_kfunc_args(). Then, in fixup_kfunc_call() the verifier may set the value of this argument to struct btf_struct_meta * kptr_struct_meta from insn_aux_data.
BPF programs must pass a dummy NULL value when caling these kfuncs.
Additionally, the list and rbtree _impl kfuncs also accept an implicit u64 argument, which doesn't require __ign suffix because it's a scalar, and BPF programs explicitly pass 0.
Add new kfuncs with KF_IMPLICIT_ARGS [1], that correspond to each _impl kfunc accepting meta__ign. The existing _impl kfuncs remain unchanged for backwards compatibility.
To support this, add "btf_struct_meta" to the list of recognized implicit argument types in resolve_btfids.
Implement is_kfunc_arg_implicit() in the verifier, that determines implicit args by inspecting both (_impl and non-_impl) BTF prototypes of the kfunc.
Update the special_kfunc_list in the verifier and relevant checks to support both the old _impl and the new KF_IMPLICIT_ARGS variants of btf_struct_meta users.
[1] https://lore.kernel.org/bpf/[email protected]/
--- kernel/bpf/helpers.c | 89 ++++++++++++---- kernel/bpf/verifier.c | 180 +++++++++++++++++++++++--------- tools/bpf/resolve_btfids/main.c | 1 + 3 files changed, 200 insertions(+), 70 deletions(-)
kernel/bpf/helpers.c +71 -18
@@ -2302,9 +2302,8 @@ void bpf_rb_root_free(const struct btf_field *field, void *rb_root,__bpf_kfunc_start_defs (); -__bpf_kfunc void *bpf_obj_new_impl(u64 local_type_id__k, void *meta__ign) +__bpf_kfunc void *bpf_obj_new(u64 local_type_id__k, struct btf_struct_meta *meta) { -struct btf_struct_meta *meta = meta__ign;u64 size = local_type_id__k;void *p;
@@ -2313,10 +2312,16 @@ __bpf_kfunc void *bpf_obj_new_impl(u64 local_type_id__k, void *meta__ign)return NULL ;if (meta)bpf_obj_init (meta->record, p); +return p; } -__bpf_kfunc void *bpf_percpu_obj_new_impl(u64 local_type_id__k, void *meta__ign) +__bpf_kfunc void *bpf_obj_new_impl(u64 local_type_id__k, void *meta__ign) +{ +return bpf_obj_new (local_type_id__k, meta__ign); +} + +__bpf_kfunc void *bpf_percpu_obj_new(u64 local_type_id__k, struct btf_struct_meta *meta) {u64 size = local_type_id__k;
@@ -2324,6 +2329,11 @@ __bpf_kfunc void *bpf_percpu_obj_new_impl(u64 local_type_id__k, void *meta__ign)return bpf_mem_alloc (&bpf_global_percpu_ma, size); } +__bpf_kfunc void *bpf_percpu_obj_new_impl(u64 local_type_id__k, void *meta__ign) +{ +return bpf_percpu_obj_new (local_type_id__k, meta__ign); +} +/* Must be called under migrate_disable(), as required by bpf_mem_free */ void __bpf_obj_drop_impl (void *p,const struct btf_record *rec,bool percpu) {
@@ -2347,23 +2357,31 @@ void __bpf_obj_drop_impl(void *p, const struct btf_record *rec, bool percpu)bpf_mem_free_rcu (ma, p); } -__bpf_kfunc void bpf_obj_drop_impl(void *p__alloc, void *meta__ign) +__bpf_kfunc void bpf_obj_drop(void *p__alloc, struct btf_struct_meta *meta) { -struct btf_struct_meta *meta = meta__ign;void *p = p__alloc;__bpf_obj_drop_impl (p, meta ? meta->record :NULL , false); } -__bpf_kfunc void bpf_percpu_obj_drop_impl(void *p__alloc, void *meta__ign) +__bpf_kfunc void bpf_obj_drop_impl(void *p__alloc, void *meta__ign) +{ +return bpf_obj_drop (p__alloc, meta__ign); +} + +__bpf_kfunc void bpf_percpu_obj_drop(void *p__alloc, struct btf_struct_meta *meta) {/* The verifier has ensured that meta__ign must be NULL */ bpf_mem_free_rcu (&bpf_global_percpu_ma, p__alloc); } -__bpf_kfunc void *bpf_refcount_acquire_impl(void *p__refcounted_kptr, void *meta__ign) +__bpf_kfunc void bpf_percpu_obj_drop_impl(void *p__alloc, void *meta__ign) +{ +bpf_percpu_obj_drop (p__alloc, meta__ign); +} + +__bpf_kfunc void *bpf_refcount_acquire(void *p__refcounted_kptr, struct btf_struct_meta *meta) { -struct btf_struct_meta *meta = meta__ign;struct bpf_refcount *ref;/* Could just cast directly to refcount_t *, but need some code using
@@ -2379,6 +2397,11 @@ __bpf_kfunc void *bpf_refcount_acquire_impl(void *p__refcounted_kptr, void *metareturn (void *)p__refcounted_kptr; } +__bpf_kfunc void *bpf_refcount_acquire_impl(void *p__refcounted_kptr, void *meta__ign) +{ +return bpf_refcount_acquire (p__refcounted_kptr, meta__ign); +} +static int __bpf_list_add (struct bpf_list_node_kern *node,struct bpf_list_head *head,bool tail,struct btf_record *rec,u64 off)
@@ -2406,24 +2429,38 @@ static int __bpf_list_add(struct bpf_list_node_kern *node,return 0 ; } +__bpf_kfunc int bpf_list_push_front(struct bpf_list_head *head, +struct bpf_list_node *node, +struct btf_struct_meta *meta, +u64 off) +{ +struct bpf_list_node_kern *n = (void *)node; + +return __bpf_list_add (n, head, false, meta ? meta->record :NULL , off); +} + __bpf_kfunc int bpf_list_push_front_impl(struct bpf_list_head *head,struct bpf_list_node *node,void *meta__ign,u64 off) +{ +return bpf_list_push_front (head, node, meta__ign, off); +} + +__bpf_kfunc int bpf_list_push_back(struct bpf_list_head *head, +struct bpf_list_node *node, +struct btf_struct_meta *meta, +u64 off) {struct bpf_list_node_kern *n = (void *)node; -struct btf_struct_meta *meta = meta__ign; -return __bpf_list_add (n, head, false, meta ? meta->record :NULL , off); +return __bpf_list_add (n, head, true, meta ? meta->record :NULL , off); } __bpf_kfunc int bpf_list_push_back_impl(struct bpf_list_head *head,struct bpf_list_node *node,void *meta__ign,u64 off) { -struct bpf_list_node_kern *n = (void *)node; -struct btf_struct_meta *meta = meta__ign; - -return __bpf_list_add (n, head, true, meta ? meta->record :NULL , off); +return bpf_list_push_back (head, node, meta__ign, off); }static struct bpf_list_node *__bpf_list_del (struct bpf_list_head *head,bool tail)
@@ -2535,16 +2572,24 @@ static int __bpf_rbtree_add(struct bpf_rb_root *root,return 0 ; } -__bpf_kfunc int bpf_rbtree_add_impl(struct bpf_rb_root *root, struct bpf_rb_node *node, -bool (less )(struct bpf_rb_node *a,const struct bpf_rb_node *b), -void *meta__ign,u64 off) +__bpf_kfunc int bpf_rbtree_add(struct bpf_rb_root *root, +struct bpf_rb_node *node, +bool (less )(struct bpf_rb_node *a,const struct bpf_rb_node *b), +struct btf_struct_meta *meta, +u64 off) { -struct btf_struct_meta *meta = meta__ign;struct bpf_rb_node_kern *n = (void *)node;return __bpf_rbtree_add (root, n, (void *)less, meta ? meta->record :NULL , off); } +__bpf_kfunc int bpf_rbtree_add_impl(struct bpf_rb_root *root, struct bpf_rb_node *node, +bool (less )(struct bpf_rb_node *a,const struct bpf_rb_node *b), +void *meta__ign,u64 off) +{ +return bpf_rbtree_add (root, node, less, meta__ign, off); +} + __bpf_kfunc struct bpf_rb_node *bpf_rbtree_first(struct bpf_rb_root *root) {struct rb_root_cached *r = (struct rb_root_cached *)root;
@@ -4536,12 +4581,19 @@ BTF_KFUNCS_START(generic_btf_ids)#ifdef CONFIG_CRASH_DUMP BTF_ID_FLAGS(func, crash_kexec, KF_DESTRUCTIVE)#endif +BTF_ID_FLAGS(func, bpf_obj_new, KF_ACQUIRE | KF_RET_NULL | KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_obj_new_impl, KF_ACQUIRE | KF_RET_NULL) +BTF_ID_FLAGS(func, bpf_percpu_obj_new, KF_ACQUIRE | KF_RET_NULL | KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_percpu_obj_new_impl, KF_ACQUIRE | KF_RET_NULL) +BTF_ID_FLAGS(func, bpf_obj_drop, KF_RELEASE | KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_obj_drop_impl, KF_RELEASE) +BTF_ID_FLAGS(func, bpf_percpu_obj_drop, KF_RELEASE | KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_percpu_obj_drop_impl, KF_RELEASE) +BTF_ID_FLAGS(func, bpf_refcount_acquire, KF_ACQUIRE | KF_RET_NULL | KF_RCU | KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_refcount_acquire_impl, KF_ACQUIRE | KF_RET_NULL | KF_RCU) +BTF_ID_FLAGS(func, bpf_list_push_front, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_list_push_front_impl) +BTF_ID_FLAGS(func, bpf_list_push_back, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_list_push_back_impl) BTF_ID_FLAGS(func, bpf_list_pop_front, KF_ACQUIRE | KF_RET_NULL)BTF_ID_FLAGS (func, bpf_list_pop_back,KF_ACQUIRE |KF_RET_NULL )
@@ -4550,6 +4602,7 @@ BTF_ID_FLAGS(func, bpf_list_back, KF_RET_NULL) BTF_ID_FLAGS(func, bpf_task_acquire, KF_ACQUIRE | KF_RCU | KF_RET_NULL) BTF_ID_FLAGS(func, bpf_task_release, KF_RELEASE) BTF_ID_FLAGS(func, bpf_rbtree_remove, KF_ACQUIRE | KF_RET_NULL) +BTF_ID_FLAGS(func, bpf_rbtree_add, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_rbtree_add_impl) BTF_ID_FLAGS(func, bpf_rbtree_first, KF_RET_NULL)BTF_ID_FLAGS (func, bpf_rbtree_root,KF_RET_NULL )
kernel/bpf/verifier.c +128 -52
369 lines not on this page · raw message
tools/bpf/resolve_btfids/main.c +1 -0
@@ -1065,6 +1065,7 @@ static bool is_kf_implicit_arg(const struct btf *btf, const struct btf_param *p) {static const char *const kf_implicit_arg_types[] = {"bpf_prog_aux" , +"btf_struct_meta" , };const struct btf_type *t;const char *name;
Signature · 1 line
2.53.0
Ihor Solodrai
reviewerPATCH v2 2/2 selftests/bpf: Update kfuncs using btf_struct_meta to new variants
Update selftests to use the new non-_impl kfuncs marked with KF_IMPLICIT_ARGS by removing redundant declarations and macros from bpf_experimental.h (the new kfuncs are present in the vmlinux.h) and updating relevant callsites.
Fix spin_lock verifier-log matching for lock_id_kptr_preserve by accepting variable instruction numbers. The calls to kfuncs with implicit arguments do not have register moves (e.g. r5 = 0) corresponding to dummy arguments anymore, so the order of instructions has shifted.
--- .../testing/selftests/bpf/bpf_experimental.h | 156 +----------------- .../selftests/bpf/prog_tests/spin_lock.c | 5 +- .../selftests/bpf/progs/kptr_xchg_inline.c | 4 +- 3 files changed, 9 insertions(+), 156 deletions(-)
tools/testing/selftests/bpf/bpf_experimental.h +4 -152
@@ -8,156 +8,11 @@#define __contains (name, node) __attribute__((btf_decl_tag("contains:" #name ":" #node))) -/* Description -* Allocates an object of the type represented by 'local_type_id' in -* program BTF. User may use the bpf_core_type_id_local macro to pass the -* type ID of a struct in program BTF. -* -* The 'local_type_id' parameter must be a known constant. -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* A pointer to an object of the type corresponding to the passed in -* 'local_type_id', or NULL on failure. -*/ -extern void *bpf_obj_new_impl (__u64 local_type_id,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_obj_new_impl */ -#define bpf_obj_new (type) ((type *)bpf_obj_new_impl(bpf_core_type_id_local(type), NULL)) - -/* Description -* Free an allocated object. All fields of the object that require -* destruction will be destructed before the storage is freed. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* Void. -*/ -extern void bpf_obj_drop_impl(void *kptr, void *meta) __ksym; - -/* Convenience macro to wrap over bpf_obj_drop_impl */ -#define bpf_obj_drop (kptr) bpf_obj_drop_impl(kptr, NULL) - -/* Description -* Increment the refcount on a refcounted local kptr, turning the -* non-owning reference input into an owning reference in the process. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* An owning reference to the object pointed to by 'kptr' -*/ -extern void *bpf_refcount_acquire_impl (void *kptr,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_refcount_acquire_impl */ -#define bpf_refcount_acquire (kptr) bpf_refcount_acquire_impl(kptr, NULL) - -/* Description -* Add a new entry to the beginning of the BPF linked list. -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a list -*/ -extern int bpf_list_push_front_impl(struct bpf_list_head *head, - struct bpf_list_node *node, - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_list_push_front_impl */ -#define bpf_list_push_front (head, node) bpf_list_push_front_impl(head, node, NULL, 0) - -/* Description -* Add a new entry to the end of the BPF linked list. -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a list -*/ -extern int bpf_list_push_back_impl(struct bpf_list_head *head, - struct bpf_list_node *node, - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_list_push_back_impl */ -#define bpf_list_push_back (head, node) bpf_list_push_back_impl(head, node, NULL, 0) - -/* Description -* Remove the entry at the beginning of the BPF linked list. -* Returns -* Pointer to bpf_list_node of deleted entry, or NULL if list is empty. -*/ -extern struct bpf_list_node *bpf_list_pop_front (struct bpf_list_head *head) __ksym; - -/* Description -* Remove the entry at the end of the BPF linked list. -* Returns -* Pointer to bpf_list_node of deleted entry, or NULL if list is empty. -*/ -extern struct bpf_list_node *bpf_list_pop_back (struct bpf_list_head *head) __ksym; - -/* Description -* Remove 'node' from rbtree with root 'root' -* Returns -* Pointer to the removed node, or NULL if 'root' didn't contain 'node' -*/ -extern struct bpf_rb_node *bpf_rbtree_remove (struct bpf_rb_root *root, -struct bpf_rb_node *node) __ksym; - -/* Description -* Add 'node' to rbtree with root 'root' using comparator 'less' -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a tree -*/ -extern int bpf_rbtree_add_impl(struct bpf_rb_root *root, struct bpf_rb_node *node, - bool (less)(struct bpf_rb_node *a, const struct bpf_rb_node *b), - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_rbtree_add_impl */ -#define bpf_rbtree_add (head, node, less) bpf_rbtree_add_impl(head, node, less, NULL, 0) +/* Convenience macro to wrap over bpf_obj_new */ +#define bpf_obj_new (type) ((type *)bpf_obj_new(bpf_core_type_id_local(type))) -/* Description -* Return the first (leftmost) node in input tree -* Returns -* Pointer to the node, which is _not_ removed from the tree. If the tree -* contains no nodes, returns NULL. -*/ -extern struct bpf_rb_node *bpf_rbtree_first (struct bpf_rb_root *root) __ksym; - -/* Description -* Allocates a percpu object of the type represented by 'local_type_id' in -* program BTF. User may use the bpf_core_type_id_local macro to pass the -* type ID of a struct in program BTF. -* -* The 'local_type_id' parameter must be a known constant. -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* A pointer to a percpu object of the type corresponding to the passed in -* 'local_type_id', or NULL on failure. -*/ -extern void *bpf_percpu_obj_new_impl (__u64 local_type_id,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_percpu_obj_new_impl */ -#define bpf_percpu_obj_new (type) ((type __percpu_kptr *)bpf_percpu_obj_new_impl(bpf_core_type_id_local(type), NULL)) - -/* Description -* Free an allocated percpu object. All fields of the object that require -* destruction will be destructed before the storage is freed. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* Void. -*/ -extern void bpf_percpu_obj_drop_impl(void *kptr, void *meta) __ksym; +/* Convenience macro to wrap over bpf_percpu_obj_new */ +#define bpf_percpu_obj_new (type) ((type __percpu_kptr *)bpf_percpu_obj_new(bpf_core_type_id_local(type)))struct bpf_iter_task_vma ;
@@ -167,9 +22,6 @@ extern int bpf_iter_task_vma_new(struct bpf_iter_task_vma *it,extern struct vm_area_struct *bpf_iter_task_vma_next (struct bpf_iter_task_vma *it) __ksym; extern void bpf_iter_task_vma_destroy(struct bpf_iter_task_vma *it) __ksym; -/* Convenience macro to wrap over bpf_obj_drop_impl */ -#define bpf_percpu_obj_drop (kptr) bpf_percpu_obj_drop_impl(kptr, NULL) -/* Description * Throw a BPF exception from the program, immediately terminating its * execution and unwinding the stack. The supplied 'cookie' parameter
tools/testing/selftests/bpf/prog_tests/spin_lock.c +3 -2
@@ -13,8 +13,9 @@ static struct {const char *err_msg; } spin_lock_fail_tests[] = { {"lock_id_kptr_preserve" , -"5: (bf) r1 = r0 ; R0=ptr_foo(id=2,ref_obj_id=2) " -"R1=ptr_foo(id=2,ref_obj_id=2) refs=2\n6: (85) call bpf_this_cpu_ptr#154\n" +"[0-9]\\+: (bf) r1 = r0 ; R0=ptr_foo(id=2,ref_obj_id=2)" +" R1=ptr_foo(id=2,ref_obj_id=2) refs=2\n" +"[0-9]\\+: (85) call bpf_this_cpu_ptr#154\n" "R1 type=ptr_ expected=percpu_ptr_" }, { "lock_id_global_zero","; R1=map_value(map=.data.A,ks=4,vs=4)\n2: (85) call bpf_this_cpu_ptr#154\n"
tools/testing/selftests/bpf/progs/kptr_xchg_inline.c +2 -2
@@ -25,14 +25,14 @@ __naked int kptr_xchg_inline(void) "if r0 == 0 goto 1f;" "r1 = r0;" "r2 = 0;" - "call %[bpf_obj_drop_impl];" + "call %[bpf_obj_drop];" "1:" "r0 = 0;" "exit;" : : __imm_addr(ptr), __imm(bpf_kptr_xchg), - __imm(bpf_obj_drop_impl) + __imm(bpf_obj_drop) : __clobber_all ); }
Signature · 1 line
2.53.0
[email protected]
AI reviewTypo: "caling" should be "calling".
Quoted 1 line
BPF programs must pass a dummy NULL value when caling these kfuncs.
Typo: "caling" should be "calling".
Quoted 4 lines
kernel/bpf/helpers.c +0
-0
[ ... ]
kernel/bpf/helpers.c
Quoted 7 lines
kernel/bpf/helpers.c +7
-0+__bpf_kfunc void *bpf_percpu_obj_new(u64 local_type_id__k, struct btf_struct_meta *meta) +{ +u64 size = local_type_id__k; + +/* The verifier has ensured that meta__ign must be NULL */ +return bpf_mem_alloc (&bpf_global_percpu_ma, size); +}
The parameter here is named "meta", not "meta__ign". Should the comment say "meta" instead?
[ ... ]
kernel/bpf/helpers.c void __bpf_obj_drop_impl(void *p, const struct btf_record *rec, bool percpu) · line 2381
Quoted 5 lines
kernel/bpf/helpers.c +5
-0+__bpf_kfunc void bpf_percpu_obj_drop(void *p__alloc, struct btf_struct_meta *meta) +{ +/* The verifier has ensured that meta__ign must be NULL */ +bpf_mem_free_rcu (&bpf_global_percpu_ma, p__alloc); +}
Same here -- the comment references "meta__ign" but the parameter is "meta".
Quoted 4 lines
kernel/bpf/verifier.c +0
-0
[ ... ]
Quoted 10 lines
case KF_ARG_PTR_TO_ALLOC_BTF_ID: if (reg->type == (PTR_TO_BTF_ID | MEM_ALLOC)) {kernel/bpf/verifier.c +1
-1-if (meta->func_id != special_kfunc_list[KF_bpf_obj_drop_impl]) { +if (!is_bpf_obj_drop_kfunc (meta->func_id)) {verbose(env, "arg#%d expected for bpf_obj_drop_impl()\n", i); return -EINVAL; } } else if (reg->type == (PTR_TO_BTF_ID | MEM_ALLOC | MEM_PERCPU)) {kernel/bpf/verifier.c +1
-1-if (meta->func_id != special_kfunc_list[KF_bpf_percpu_obj_drop_impl]) { +if (!is_bpf_percpu_obj_drop_kfunc (meta->func_id)) {
Quoted 3 lines
verbose(env, "arg#%d expected for bpf_percpu_obj_drop_impl()\n", i); return -EINVAL; }
The conditions now match both bpf_obj_drop and bpf_obj_drop_impl (and their percpu variants), but the error messages still reference only the _impl names. Would it make sense to update these to say "bpf_obj_drop" and "bpf_percpu_obj_drop" respectively, so that a developer calling the new variants sees the right function name in the error?
Andrii Nakryiko also had two unaddressed review comments on this patch:
https://lore.kernel.org/bpf/CAEf4BzbhBqrPxAtw2xE2aeO8nVaHggV2TVNrMrTJVQTg05X0tQ@mail.gmail.com/
1) Whether the special-casing in the verifier could be generalized by inspecting which implicit argument type is involved, rather than adding per-function helpers like is_bpf_obj_new_kfunc() etc.
2) Whether a typedef like bpf_implicit_offset_t should be added for the u64 offset argument, so resolve_btfids can identify it as an implicit arg by type rather than relying on positional ordering.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/23271098456
Dan Carpenter
build botBCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Ihor Solodrai…
BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Ihor Solodrai <[email protected]>
TO: Alexei Starovoitov <[email protected]>
TO: Andrii Nakryiko <[email protected]>
TO: Daniel Borkmann <[email protected]>
TO: Eduard Zingerman <[email protected]>
CC: [email protected]
CC: [email protected]
Hi Ihor,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Ihor-Solodrai/selftests-bpf-Update-kfuncs-using-btf_struct_meta-to-new-variants/20260319-070652 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20260318223544.1789748-1-ihor.solodrai%40linux.dev patch subject: [PATCH bpf-next v2 1/2] bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
config: x86_64-randconfig-161-20260319 (https://download.01.org/0day-ci/archive/20260320/[email protected]/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:kernel/bpf/verifier.c:12760 is_bpf_rbtree_add_kfunc() error: buffer overflow 'special_kfunc_list' 64 <= 64
vim +/special_kfunc_list +12760 kernel/bpf/verifier.c
3700d7c829341d Ihor Solodrai 2026-03-18 12757
3700d7c829341d Ihor Solodrai 2026-03-18 12758 static bool is_bpf_rbtree_add_kfunc(u32 func_id)
3700d7c829341d Ihor Solodrai 2026-03-18 12759 {
3700d7c829341d Ihor Solodrai 2026-03-18 @12760 return func_id == special_kfunc_list[KF_bpf_rbtree_add] ||
3700d7c829341d Ihor Solodrai 2026-03-18 12761 func_id == special_kfunc_list[KF_bpf_rbtree_add_impl];
3700d7c829341d Ihor Solodrai 2026-03-18 12762 }5c8fd7e2b5b0a5 Mykyta Yatsenko 2025-09-23 12763
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki