Skip to contentSkip to conversation

high_freq_hwp_cap_cppc.c: new test

PATCH Superseded Piotr Kubaj 2 participants 2 messages Mar 21 – Mar 23

v4 of 14 Superseded Latest is v14 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 high_freq_hwp_cap_cppc.c: new test

Verify for all online logical CPUs that their highest performance value are the same for HWP Capability MSR 0x771 and CPPC sysfs file.

---
Since SAFE_PREAD() already checks return code, remove the check.

 runtest/power_management_tests                |  1 +
 testcases/kernel/power_management/.gitignore  |  1 +
 .../power_management/high_freq_hwp_cap_cppc.c | 65 +++++++++++++++++++
 3 files changed, 67 insertions(+)
 create mode 100644 testcases/kernel/power_management/high_freq_hwp_cap_cppc.c
runtest/power_management_tests +1 -0
index 884e615cd..6d87dfb7f 100644
@@ -1,4 +1,5 @@
 #POWER_MANAGEMENT
+high_freq_hwp_cap_cppc high_freq_hwp_cap_cppc
 runpwtests01 runpwtests01.sh
 runpwtests02 runpwtests02.sh
 runpwtests03 runpwtests03.sh
testcases/kernel/power_management/.gitignore +1 -0
index 0c2a3ed4b..c13bca1c4 100644
@@ -1 +1,2 @@
+high_freq_hwp_cap_cppc
 pm_get_sched_values
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +65 -0

65 lines not on this page · raw message

Signature · 13 lines
2.47.3

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Piotr,

A few issues below.

testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 4

Quoted 4 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +4 -0
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+/*
+ * Copyright (C) 2026 Intel - http://www.intel.com/

The blank line between the SPDX identifier and the copyright block is non-standard. They should be adjacent (no blank line between them).

testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 19

Quoted 1 line
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +1 -0
+	nproc = tst_ncpus();

tst_ncpus() returns _SC_NPROCESSORS_ONLN — the *count* of online CPUs, not the highest CPU number. On a system where CPUs 0, 1, 3 are online and CPU 2 is offline, tst_ncpus() returns 3, and the loop below iterates over CPUs 0, 1, 2, accessing the wrong set of sysfs paths.

Use tst_ncpus_conf() as the upper bound and skip offline CPUs individually, or iterate over the actual online CPU numbers from /sys/devices/system/cpu/online.

testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 31

Quoted 2 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +2 -0
+		snprintf(path, sizeof(path), "/sys/devices/system/cpu/cpu%d/acpi_cppc/highest_perf", i);
+		SAFE_FILE_SCANF(path, "%llu", &sysfs_highest_perf);

CONFIG_ACPI_CPPC_LIB=y does not guarantee the acpi_cppc/ sysfs directory exists at runtime — it only appears when the CPU firmware exposes the CPPC _CPC ACPI method. If the path is absent, SAFE_FILE_SCANF aborts with TBROK. Check for existence and return TCONF instead:

  if (access(path, F_OK)) {
      tst_res(TCONF, "CPPC sysfs not available, skipping");
      return;
  }

testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 42

Quoted 8 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +8 -0
+		int fd = SAFE_OPEN(path, O_RDONLY);
+
+		SAFE_PREAD(1, fd, &msr_highest_perf, sizeof(msr_highest_perf), 0x771);
+		msr_highest_perf &= (1ULL << 8) - 1;
+		tst_res(TDEBUG, "%s: %llu", path, msr_highest_perf);
+
+		if (msr_highest_perf != sysfs_highest_perf)
+			status = false;

Two issues:

1. fd is never closed. Opening it once per CPU iteration leaks one file descriptor per CPU. Add SAFE_CLOSE(fd) at the end of the loop body.

2. When the values differ, status is set to false but there is no per-CPU message. The single TFAIL at the end gives no indication of which CPU triggered the failure. Add a TINFO or TFAIL per CPU:

     tst_res(TFAIL, "cpu%d: sysfs=%llu MSR=%llu",
             i, sysfs_highest_perf, msr_highest_perf);

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp