high_freq_hwp_cap_cppc.c: new test
PATCH v9 1/1 high_freq_hwp_cap_cppc.c: new test
Verify for all online logical CPUs that their highest performance value are the same for HWP Capability MSR 0x771 and CPPC sysfs file.
---
Checks for msr and CPPC are added to setup().
Useless snprintf() for CPU0 is dropped.
runtest/power_management_tests | 1 + testcases/kernel/power_management/.gitignore | 1 + .../power_management/high_freq_hwp_cap_cppc.c | 88 +++++++++++++++++++ 3 files changed, 90 insertions(+) create mode 100644 testcases/kernel/power_management/.gitignore create mode 100644 testcases/kernel/power_management/high_freq_hwp_cap_cppc.c
runtest/power_management_tests +1 -0
@@ -1,4 +1,5 @@ #POWER_MANAGEMENT +high_freq_hwp_cap_cppc high_freq_hwp_cap_cppc runpwtests03 runpwtests03.sh runpwtests04 runpwtests04.sh runpwtests06 runpwtests06.sh
testcases/kernel/power_management/.gitignore new file +1 -0
@@ -0,0 +1 @@ +high_freq_hwp_cap_cppc
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +88 -0
88 lines not on this page · raw message
Signature · 13 lines
2.47.3 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Piotr,
Quoted 4 lines · Piotr Kubaj
high_freq_hwp_cap_cppc.c: new testVerify for all online logical CPUs that their highest performance value are the same for HWP Capability MSR
0x771and CPPC sysfs file.
The body describes what the test does but not why it is needed. Please add at least one sentence explaining the motivation — e.g. a known inconsistency, a kernel regression, or a new interface being validated.
[...]
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 57
Quoted 5 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +5
-0+snprintf (path,sizeof (path),"/dev/cpu/%d/msr" , i); +int fd =SAFE_OPEN (path,O_RDONLY ); + +SAFE_PREAD (1 , fd, &msr_highest_perf,sizeof (msr_highest_perf),MSR_HWP_CAPABILITIES ); +SAFE_CLOSE (fd);
If SAFE_PREAD aborts via tst_brk(), cleanup() is called but fd is never closed because it is a loop-local variable with no cleanup handler. Promote fd to a static (initialized to -1) and add a cleanup() that guards with if (fd != -1) SAFE_CLOSE(fd);.
---
Note:
Our agent completed the review of the patch. The full review can be found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25317225258
The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp