Skip to contentSkip to conversation

ARM: dts: r9a06g032: Add #address-cells in the GIC node

PATCH In review Herve Codina (Schneider Electric) 2 participants 2 messages Mar 25

Subsystems (2)
Device tree bindings Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Herve Codina (Schneider Electric)

author
#0 lore raw

PATCH v2 1/1 ARM: dts: r9a06g032: Add #address-cells in the GIC node

When checking dts involving the r9a06g032.dtsi file, the following kind of warnings are reported:
Missing property '#address-cells' in node xxx, using 0 as fallback

Indeed, #address-cells is not present in the GIC interrupt controller node.

Fix it adding the missing property.

Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property in PCI node and in IRQ mux node consists of several components and the component related to "parent unit address", which size is defined by '#address-cells' of the node pointed to by the interrupt-parent component, is not used (=0)

No functional change.

Signed-off-by Herve Codina (Schneider Electric) <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>

---
Changes v1 -> v2
v1: https://lore.kernel.org/all/[email protected]/

Add details about value '0' in the commit log
Add 'Reviewed-by: Wolfram Sang'

---
 arch/arm/boot/dts/renesas/r9a06g032.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/renesas/r9a06g032.dtsi +1 -0
index f4f760aff28b..6acf524174c7 100644
@@ -507,6 +507,7 @@ gic: interrupt-controller@44101000 {
 			compatible = "arm,gic-400", "arm,cortex-a7-gic";
 			interrupt-controller;
 			#interrupt-cells = <3>;
+			#address-cells = <0>;
 			reg = <0x44101000 0x1000>, /* Distributer */
 			      <0x44102000 0x2000>, /* CPU interface */
 			      <0x44104000 0x2000>, /* Virt interface control */
Signature · 1 line
2.53.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 16 lines · Herve Codina (Schneider Electric)

When checking dts involving the r9a06g032.dtsi file, the following kind of warnings are reported:
Missing property '#address-cells' in node xxx, using 0 as fallback

Indeed, #address-cells is not present in the GIC interrupt controller node.

Fix it adding the missing property.

Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property in PCI node and in IRQ mux node consists of several components and the component related to "parent unit address", which size is defined by '#address-cells' of the node pointed to by the interrupt-parent component, is not used (=0)

Quoted 4 lines

No functional change.

Signed-off-by Herve Codina (Schneider Electric) <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

i.e. will queue in renesas-devel for v7.1.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds