Skip to contentSkip to conversation

s5p4418_nanopi2: Drop unnecessary BOARD_EARLY_INIT_F usage

PATCH In review Tom Rini 2 participants 4 messages Mar 25 – Apr 2

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 s5p4418_nanopi2: Drop unnecessary BOARD_EARLY_INIT_F usage

This platform enables CONFIG_BOARD_EARLY_INIT_F and then has a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function.

---
Cc: Stefan Bosch <[email protected]>

---
 board/friendlyarm/nanopi2/board.c | 5 -----
 1 file changed, 5 deletions(-)
board/friendlyarm/nanopi2/board.c +0 -5
index 4dff32e10d6b..ca8ae529ddf4 100644
@@ -406,11 +406,6 @@ __exit:
  * call from u-boot
  */
 
-int board_early_init_f(void)
-{
-	return 0;
-}
-
 int board_init(void)
 {
 	bd_hwrev_init();
Signature · 1 line
2.43.0
#1 lore raw

Hi Tom,

thank you for the patch. You are right, board_early_init_f can be removed. But where is CONFIG_BOARD_EARLY_INIT_F enabled, I didn't found it. Have I missed something?

Regards
Stefan

Quoted 26 lines · Tom Rini

This platform enables CONFIG_BOARD_EARLY_INIT_F and then has a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function. >

---
Cc: Stefan Bosch <[email protected]>

---
  board/friendlyarm/nanopi2/board.c | 5 -----
  1 file changed, 5 deletions(-)
board/friendlyarm/nanopi2/board.c +0 -5
index 4dff32e10d6b..ca8ae529ddf4 100644
@@ -406,11 +406,6 @@ __exit:
   * call from u-boot
   */
 
-int board_early_init_f(void)
-{
-	return 0;
-}
-
  int board_init(void)
  {
  	bd_hwrev_init();
author
#2 lore raw
Quoted 5 lines · Stefan Bosch

Hi Tom,

thank you for the patch. You are right, board_early_init_f can be removed. But where is CONFIG_BOARD_EARLY_INIT_F enabled, I didn't found it. Have I missed something?

This might be another case (since I sent out a dozen similar patches) where the platform wasn't actually enabling it either and so the commit message is wrong in that regard. I can fix that when applying if that's OK with you.

Quoted 30 lines

Regards
Stefan

Quoted 25 lines · Tom Rini

This platform enables CONFIG_BOARD_EARLY_INIT_F and then has a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function. >

---
Cc: Stefan Bosch <[email protected]>

---
  board/friendlyarm/nanopi2/board.c | 5 -----
  1 file changed, 5 deletions(-)
board/friendlyarm/nanopi2/board.c +0 -5
index 4dff32e10d6b..ca8ae529ddf4 100644
@@ -406,11 +406,6 @@ __exit:
   * call from u-boot
   */
-int board_early_init_f(void)
-{
-	return 0;
-}
-
  int board_init(void)
  {
  	bd_hwrev_init();
Signature · 1 line
Tom
Reviewed-by
#3 lore raw
Quoted 4 lines · Tom Rini
Quoted 2 lines · Stefan Bosch

Hi Tom,

Quoted 9 lines
Quoted 3 lines

thank you for the patch. You are right, board_early_init_f can be removed. But where is CONFIG_BOARD_EARLY_INIT_F enabled, I didn't found it. Have I missed something?

This might be another case (since I sent out a dozen similar patches) where the platform wasn't actually enabling it either and so the commit message is wrong in that regard. I can fix that when applying if that's OK with you.

That is OK for me, thank you.

Quoted 15 lines
Quoted 15 lines

Regards
Stefan

Quoted 10 lines · Tom Rini

This platform enables CONFIG_BOARD_EARLY_INIT_F and then has a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function. >

---
Cc: Stefan Bosch <[email protected]>

---
   board/friendlyarm/nanopi2/board.c | 5 -----
   1 file changed, 5 deletions(-)
Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
board/friendlyarm/nanopi2/board.c +0 -0
index 4dff32e10d6b..ca8ae529ddf4 100644
@@ -406,11 +406,6 @@ __exit:
    * call from u-boot
    */
Quoted 8 lines

board/friendlyarm/nanopi2/board.c __exit: · line 411

Quoted 8 lines
board/friendlyarm/nanopi2/board.c +0 -5
-int board_early_init_f(void)
-{
-	return 0;
-}
-
   int board_init(void)
   {
   	bd_hwrev_init();