s5p4418_nanopi2: Drop unnecessary BOARD_EARLY_INIT_F usage
PATCH 1/1 s5p4418_nanopi2: Drop unnecessary BOARD_EARLY_INIT_F usage
This platform enables CONFIG_BOARD_EARLY_INIT_F and then has a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function.
---
Cc: Stefan Bosch <[email protected]>
--- board/friendlyarm/nanopi2/board.c | 5 ----- 1 file changed, 5 deletions(-)
board/friendlyarm/nanopi2/board.c +0 -5
@@ -406,11 +406,6 @@ __exit:* call from u-boot */ -int board_early_init_f (void ) -{ -return 0 ; -} -int board_init (void ) {bd_hwrev_init ();
Signature · 1 line
2.43.0
Hi Tom,
thank you for the patch. You are right, board_early_init_f can be removed. But where is CONFIG_BOARD_EARLY_INIT_F enabled, I didn't found it. Have I missed something?
Regards
Stefan
Quoted 26 lines · Tom Rini
This platform enables
CONFIG_BOARD_EARLY_INIT_Fand then has a do-nothingboard_early_init_ffunction. Change to not enabling the option and so not needing an empty function. >Signed-off-by Tom Rini <[email protected]>---
Cc: Stefan Bosch <[email protected]>--- board/friendlyarm/nanopi2/board.c | 5 ----- 1 file changed, 5 deletions(-)board/friendlyarm/nanopi2/board.c +0
-5@@ -406,11 +406,6 @@ __exit:* call from u-boot */ -int board_early_init_f (void ) -{ -return 0 ; -} -int board_init (void ) {bd_hwrev_init ();
Quoted 5 lines · Stefan Bosch
Hi Tom,
thank you for the patch. You are right,
board_early_init_fcan be removed. But where isCONFIG_BOARD_EARLY_INIT_Fenabled, I didn't found it. Have I missed something?
This might be another case (since I sent out a dozen similar patches) where the platform wasn't actually enabling it either and so the commit message is wrong in that regard. I can fix that when applying if that's OK with you.
Quoted 30 lines
Regards
StefanQuoted 25 lines · Tom Rini
This platform enables
CONFIG_BOARD_EARLY_INIT_Fand then has a do-nothingboard_early_init_ffunction. Change to not enabling the option and so not needing an empty function. >Signed-off-by Tom Rini <[email protected]>---
Cc: Stefan Bosch <[email protected]>--- board/friendlyarm/nanopi2/board.c | 5 ----- 1 file changed, 5 deletions(-)board/friendlyarm/nanopi2/board.c +0
-5@@ -406,11 +406,6 @@ __exit:* call from u-boot */ -int board_early_init_f (void ) -{ -return 0 ; -} -int board_init (void ) {bd_hwrev_init ();
Signature · 1 line
Tom
Stefan Bosch
Reviewed-byQuoted 4 lines · Tom Rini
Quoted 2 lines · Stefan Bosch
Hi Tom,
Quoted 9 lines
Quoted 3 lines
thank you for the patch. You are right,
board_early_init_fcan be removed. But where isCONFIG_BOARD_EARLY_INIT_Fenabled, I didn't found it. Have I missed something?This might be another case (since I sent out a dozen similar patches) where the platform wasn't actually enabling it either and so the commit message is wrong in that regard. I can fix that when applying if that's OK with you.
That is OK for me, thank you.
Quoted 15 lines
Quoted 15 lines
Regards
StefanQuoted 10 lines · Tom Rini
This platform enables
CONFIG_BOARD_EARLY_INIT_Fand then has a do-nothingboard_early_init_ffunction. Change to not enabling the option and so not needing an empty function. >Signed-off-by Tom Rini <[email protected]>---
Cc: Stefan Bosch <[email protected]>--- board/friendlyarm/nanopi2/board.c | 5 ----- 1 file changed, 5 deletions(-)
Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
board/friendlyarm/nanopi2/board.c +0
-0@@ -406,11 +406,6 @@ __exit:* call from u-boot */ Quoted 8 lines
board/friendlyarm/nanopi2/board.c __exit: · line 411
Quoted 8 lines
board/friendlyarm/nanopi2/board.c +0
-5-int board_early_init_f (void ) -{ -return 0 ; -} -int board_init (void ) {bd_hwrev_init ();