Skip to contentSkip to conversation

staging: rtl8723bs: fix comparison to false

PATCH RESEND Superseded Akhil Boyapati 2 participants 4 messages Apr 8 – Apr 10 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: rtl8723bs: fix comparison to false

Replace '== false' with '!' operator for boolean test to adhere to Linux kernel coding style.

Reported by checkpatch:
CHECK: Using comparison to false is error prone

RESEND adding cc to [email protected]

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -2
index 864cd8b6d1f1..8f18175175ee 100644
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		rtw_ht_use_default_setting(padapter);
 
-		if (pmlmepriv->htpriv.sgi_20m == false)
+		if (!pmlmepriv->htpriv.sgi_20m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
-		if (pmlmepriv->htpriv.sgi_40m == false)
+		if (!pmlmepriv->htpriv.sgi_40m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
Signature · 1 line
2.53.0
#1 lore raw
Quoted 7 lines · Akhil Boyapati

Replace '== false' with '!' operator for boolean test to adhere to Linux kernel coding style.

Reported by checkpatch:
CHECK: Using comparison to false is error prone

RESEND adding cc to [email protected]

This should be resent as v2 if any change is present. You should only use RESEND if you don't edit context of email at all. Also such messages for changes should go under --- as everything above is commit message.

Quoted 13 lines
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +0 -0
index 864cd8b6d1f1..8f18175175ee 100644
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		rtw_ht_use_default_setting(padapter);

drivers/staging/rtl8723bs/core/rtw_ap.c int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) · line 1022

Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -2
 
-		if (pmlmepriv->htpriv.sgi_20m == false)
+		if (!pmlmepriv->htpriv.sgi_20m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
-		if (pmlmepriv->htpriv.sgi_40m == false)
+		if (!pmlmepriv->htpriv.sgi_40m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))

Hi Akhil,
I am also wondering why did you decide to resend the patch as it impplies it was sent somewhere else, but I don't see it anywhere on mailing list. Did you send it only to Greg?

author
#2 lore raw
Quoted 4 lines · Luka Gejak

Hi Akhil,
I am also wondering why did you decide to resend the patch as it impplies it was sent somewhere else, but I don't see it anywhere on mailing list. Did you send it only to Greg?

Yes, I accidentally only sent it to Greg, I realised this and resent it before I could get the response from Greg's bot. The content of the patch is exactly the same.

It took me some time for this reply as I was understanding the correct method to reply, let me know if anything can be improved.

#3 lore raw
Quoted 10 lines · Akhil
Quoted 4 lines · Luka Gejak

Hi Akhil,
I am also wondering why did you decide to resend the patch as it impplies it was sent somewhere else, but I don't see it anywhere on mailing list. Did you send it only to Greg?

Yes, I accidentally only sent it to Greg, I realised this and resent it before I could get the response from Greg's bot. The content of the patch is exactly the same.

It took me some time for this reply as I was understanding the correct method to reply, let me know if anything can be improved.

This should be resent as v2, because I'm sure you didn't include "RESEND adding cc to [email protected]" in original email. You should only use RESEND if you don't edit context of email at all. Also such messages for changes (as "RESEND adding cc to [email protected]") should go under --- as everything above is part of the commit message.