Skip to contentSkip to conversation

smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

PATCH Superseded Venkat Rao Bagalkote 3 participants 4 messages Apr 10

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

On the latest linux-next following modpost warning is reported:

WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/client/smb1maperror_test.o

Add MODULE_DESCRIPTION() to the test module to fix the warning.

---
Changes in v2:
- Fix typo in MODULE_DESCRIPTION

 fs/smb/client/smb1maperror_test.c | 1 +
 1 file changed, 1 insertion(+)
fs/smb/client/smb1maperror_test.c +1 -0
index 820c0dd3bcce..b93d3ac41f91 100644
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
 kunit_test_suite(maperror_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("SMB1 error mapping selftest module");
Signature · 1 line
2.45.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 27 lines · Venkat Rao Bagalkote

On the latest linux-next following modpost warning is reported:

WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/client/smb1maperror_test.o

Add MODULE_DESCRIPTION() to the test module to fix the warning.

---
Changes in v2:
- Fix typo in MODULE_DESCRIPTION

 fs/smb/client/smb1maperror_test.c | 1 +
 1 file changed, 1 insertion(+)
fs/smb/client/smb1maperror_test.c +1 -0
index 820c0dd3bcce..b93d3ac41f91 100644
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
 kunit_test_suite(maperror_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("SMB1 error mapping selftest module");
Signature · 1 line
2.45.2

LGTM, feel free to add below tag:

reviewer
#2 lore raw
In reply to Venkat Rao Bagalkote

Thanks for your patch. It is "KUnit test" rather than "selftest".

Perhaps the following description would be better: "KUnit tests of SMB1 maperror".

Quoted 1 line · Venkat Rao Bagalkote

+MODULE_DESCRIPTION("SMB1 error mapping selftest module");

#3 lore raw
Quoted 6 lines · ChenXiaoSong

Thanks for your patch. It is "KUnit test" rather than "selftest".

Perhaps the following description would be better: "KUnit tests of SMB1 maperror".

Quoted 1 line · Venkat Rao Bagalkote

+MODULE_DESCRIPTION("SMB1 error mapping selftest module");

Thank you for the review. I have sent v3, with proposed changes. Please review v3.

https://lore.kernel.org/all/[email protected]/

Regards,

Venkat.