Skip to contentSkip to conversation

smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

PATCH In review Venkat Rao Bagalkote 3 participants 3 messages Apr 10

Subsystems (3)
Linux-next tree SMB client (CIFS) Kernel SMB3 server (ksmbd)
lore
Share & tools
lore

Venkat Rao Bagalkote

author
#0 lore raw

PATCH v3 1/1 smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

On the latest linux-next following modpost warning is reported:

WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/client/smb1maperror_test.o

Add MODULE_DESCRIPTION() to the test module to fix the warning.

Signed-off-by Venkat Rao Bagalkote <[email protected]>

---
Changes in v3:
- Update MODULE_DESCRIPTION as suggested in review

 fs/smb/client/smb1maperror_test.c | 1 +
 1 file changed, 1 insertion(+)
fs/smb/client/smb1maperror_test.c +1 -0
index 820c0dd3bcce..2caaf11228ef 100644
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
 kunit_test_suite(maperror_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit tests of SMB1 maperror");
Signature · 1 line
2.45.2
reviewer Reviewed-by on v3 1/1
#1 lore raw

Looks good to me. Feel free to add:

Reviewed-by ChenXiaoSong <[email protected]>
Quoted 24 lines · Venkat Rao Bagalkote

On the latest linux-next following modpost warning is reported:

WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/client/smb1maperror_test.o

Add MODULE_DESCRIPTION() to the test module to fix the warning.

Signed-off-by Venkat Rao Bagalkote <[email protected]>

---
Changes in v3:
- Update MODULE_DESCRIPTION as suggested in review

  fs/smb/client/smb1maperror_test.c | 1 +
  1 file changed, 1 insertion(+)
fs/smb/client/smb1maperror_test.c +1 -0
index 820c0dd3bcce..2caaf11228ef 100644
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
  kunit_test_suite(maperror_suite);
 
  MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit tests of SMB1 maperror");
Signature · 3 lines
ChenXiaoSong <[email protected]>
Chinese Homepage: chenxiaosong.com
English Homepage: chenxiaosong.com/en
#2 lore raw

added to cifs-2.6.git for-next

Quoted 36 lines · ChenXiaoSong

Looks good to me. Feel free to add:

Reviewed-by ChenXiaoSong <[email protected]>
Quoted 20 lines · Venkat Rao Bagalkote

On the latest linux-next following modpost warning is reported:

WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/client/smb1maperror_test.o

Add MODULE_DESCRIPTION() to the test module to fix the warning.

Signed-off-by Venkat Rao Bagalkote <[email protected]>

---
Changes in v3:
- Update MODULE_DESCRIPTION as suggested in review

  fs/smb/client/smb1maperror_test.c | 1 +
  1 file changed, 1 insertion(+)
fs/smb/client/smb1maperror_test.c +0 -0
index 820c0dd3bcce..2caaf11228ef 100644

fs/smb/client/smb1maperror_test.c static struct kunit_suite maperror_suite = { · line 77

Quoted 4 lines
fs/smb/client/smb1maperror_test.c +1 -0
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
  kunit_test_suite(maperror_suite);
 
  MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit tests of SMB1 maperror");

--
ChenXiaoSong <[email protected]>
Chinese Homepage: chenxiaosong.com
English Homepage: chenxiaosong.com/en

Signature · 3 lines
Thanks,

Steve