netfilter: nft_set_rbtree: remove dead conditional
Subsystems (2)
Florian Westphal
maintainerPATCH v2 1/1 netfilter: nft_set_rbtree: remove dead conditional
net/netfilter/nft_set_rbtree.c:399 __nft_rbtree_insert()
warn: 'removed_end' is not an error pointer
Since commit : 087388278e0f ("netfilter: nf_tables: nft_set_rbtree: fix spurious insertion failure") __nft_rbtree_insert() can no longer fail and this condition is always false. Remove it.
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Florian Westphal <[email protected]>
---
v2: re-target to nf-next & fix commit message. There is no bug, the condition is never true anymore.
net/netfilter/nft_set_rbtree.c | 3 --- 1 file changed, 3 deletions(-)
net/netfilter/nft_set_rbtree.c +0 -3
@@ -396,9 +396,6 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set,const struct nft_rbtree_elem *removed_end; removed_end =nft_rbtree_gc_elem (set, priv, rbe); -if (IS_ERR (removed_end)) -return PTR_ERR (removed_end); -if (removed_end == rbe_le || removed_end == rbe_ge)return -EAGAIN ;
Signature · 1 line
2.53.0